)]}'
{"id":"openstack%2Fpython-saharaclient~417285","triplet_id":"openstack%2Fpython-saharaclient~master~Ie6c47b970b6dbb91ed07c56ac1b54f3448f2c481","project":"openstack/python-saharaclient","branch":"master","topic":"update-method-use-patch","hashtags":[],"change_id":"Ie6c47b970b6dbb91ed07c56ac1b54f3448f2c481","subject":"Convert update methods to use PATCH","status":"ABANDONED","created":"2017-01-06 04:47:29.000000000","updated":"2017-01-07 01:14:10.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"21de7923820fef3b98928ab7fefac4df5fbf59c9","_number":417285,"virtual_id_number":417285,"owner":{"_account_id":22689,"name":"Shu Yingya","email":"yingya.shu@easystack.cn","username":"ShuYingya"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":1,"date":"2017-01-06 08:15:44.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":8932,"name":"Telles Mota Vidal Nóbrega","email":"tellesnobrega@gmail.com","username":"tellesnobrega"},{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"rejected":{"_account_id":8932,"name":"Telles Mota Vidal Nóbrega","email":"tellesnobrega@gmail.com","username":"tellesnobrega"},"disliked":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":-2,"date":"2017-01-06 12:06:35.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":8932,"name":"Telles Mota Vidal Nóbrega","email":"tellesnobrega@gmail.com","username":"tellesnobrega"},{"value":-1,"date":"2017-01-06 12:14:39.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":8932,"name":"Telles Mota Vidal Nóbrega","email":"tellesnobrega@gmail.com","username":"tellesnobrega"},{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":8932,"name":"Telles Mota Vidal Nóbrega","email":"tellesnobrega@gmail.com","username":"tellesnobrega"},{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-01-06 08:15:44.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2017-01-06 12:06:35.000000000","updated_by":{"_account_id":8932,"name":"Telles Mota Vidal Nóbrega","email":"tellesnobrega@gmail.com","username":"tellesnobrega"},"reviewer":{"_account_id":8932,"name":"Telles Mota Vidal Nóbrega","email":"tellesnobrega@gmail.com","username":"tellesnobrega"},"state":"REVIEWER"},{"updated":"2017-01-06 12:14:39.000000000","updated_by":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"reviewer":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"state":"REVIEWER"}],"messages":[{"id":"788789b3485369cbf385c1335cc4af7e12186d48","author":{"_account_id":22689,"name":"Shu Yingya","email":"yingya.shu@easystack.cn","username":"ShuYingya"},"date":"2017-01-06 04:47:29.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"9ab0e5e9f9130dbd9483413d867473d4bd39871f","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-01-06 05:18:11.000000000","message":"Patch Set 1: Verified-1\n\nThis change depends on a change that failed to merge.","accounts_in_message":[],"_revision_number":1},{"id":"2166282b4e52fcb019e91b7297189470ddb015a7","author":{"_account_id":22689,"name":"Shu Yingya","email":"yingya.shu@easystack.cn","username":"ShuYingya"},"date":"2017-01-06 05:20:11.000000000","message":"Uploaded patch set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"237bc18c9abd6fec47de30cce83aa0e84342ad41","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-01-06 07:04:14.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-saharaclient-docs-ubuntu-xenial http://docs-draft.openstack.org/85/417285/2/check/gate-python-saharaclient-docs-ubuntu-xenial/2b6e4e2//doc/build/html/ : SUCCESS in 1m 52s\n- gate-python-saharaclient-pep8-ubuntu-xenial http://logs.openstack.org/85/417285/2/check/gate-python-saharaclient-pep8-ubuntu-xenial/ae1366f/ : FAILURE in 2m 00s\n- gate-python-saharaclient-python27-ubuntu-xenial http://logs.openstack.org/85/417285/2/check/gate-python-saharaclient-python27-ubuntu-xenial/7ea9efc/ : SUCCESS in 2m 00s\n- gate-python-saharaclient-python35 http://logs.openstack.org/85/417285/2/check/gate-python-saharaclient-python35/9454675/ : SUCCESS in 3m 32s\n- check-osc-plugins http://logs.openstack.org/85/417285/2/check/check-osc-plugins/8db5a98/ : SUCCESS in 5m 54s (non-voting)\n- gate-sahara-cli-ubuntu-xenial-nv http://logs.openstack.org/85/417285/2/check/gate-sahara-cli-ubuntu-xenial-nv/10f3b0d/ : FAILURE in 42m 35s (non-voting)\n- gate-python-saharaclient-dsvm-scenario-neutron-ubuntu-xenial http://logs.openstack.org/85/417285/2/check/gate-python-saharaclient-dsvm-scenario-neutron-ubuntu-xenial/9239f1f/ : SUCCESS in 54m 27s\n- gate-tempest-dsvm-neutron-src-python-saharaclient-ubuntu-xenial http://logs.openstack.org/85/417285/2/check/gate-tempest-dsvm-neutron-src-python-saharaclient-ubuntu-xenial/cca0cfc/ : SUCCESS in 1h 41m 55s","accounts_in_message":[],"_revision_number":2},{"id":"485688c26b9463d4c52f5c4aaf58aaf0af814b8e","author":{"_account_id":22689,"name":"Shu Yingya","email":"yingya.shu@easystack.cn","username":"ShuYingya"},"date":"2017-01-06 07:12:33.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"141e3ae5309e3899510f2814485030733a79009d","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-01-06 08:15:44.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-saharaclient-docs-ubuntu-xenial http://docs-draft.openstack.org/85/417285/3/check/gate-python-saharaclient-docs-ubuntu-xenial/2785ab1//doc/build/html/ : SUCCESS in 1m 58s\n- gate-python-saharaclient-pep8-ubuntu-xenial http://logs.openstack.org/85/417285/3/check/gate-python-saharaclient-pep8-ubuntu-xenial/eca47b9/ : SUCCESS in 2m 01s\n- gate-python-saharaclient-python27-ubuntu-xenial http://logs.openstack.org/85/417285/3/check/gate-python-saharaclient-python27-ubuntu-xenial/568c4d8/ : SUCCESS in 3m 26s\n- gate-python-saharaclient-python35 http://logs.openstack.org/85/417285/3/check/gate-python-saharaclient-python35/1eff385/ : SUCCESS in 2m 06s\n- check-osc-plugins http://logs.openstack.org/85/417285/3/check/check-osc-plugins/b14dc1f/ : SUCCESS in 5m 31s (non-voting)\n- gate-sahara-cli-ubuntu-xenial-nv http://logs.openstack.org/85/417285/3/check/gate-sahara-cli-ubuntu-xenial-nv/04eabc4/ : SUCCESS in 23m 11s (non-voting)\n- gate-python-saharaclient-dsvm-scenario-neutron-ubuntu-xenial http://logs.openstack.org/85/417285/3/check/gate-python-saharaclient-dsvm-scenario-neutron-ubuntu-xenial/8c77136/ : SUCCESS in 53m 17s\n- gate-tempest-dsvm-neutron-src-python-saharaclient-ubuntu-xenial http://logs.openstack.org/85/417285/3/check/gate-tempest-dsvm-neutron-src-python-saharaclient-ubuntu-xenial/6b1031c/ : SUCCESS in 1h 02m 59s","accounts_in_message":[],"_revision_number":3},{"id":"35a68f1574b378d6b68eea1bc856e1378cd92157","author":{"_account_id":8932,"name":"Telles Mota Vidal Nóbrega","email":"tellesnobrega@gmail.com","username":"tellesnobrega"},"date":"2017-01-06 12:06:35.000000000","message":"Patch Set 3: Code-Review-2\n\nSame as in the other comment, this will be changed on API v2.2","accounts_in_message":[],"_revision_number":3},{"id":"0baa4519eac7ce2b3b1ac1b7ce046df19616796e","author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"date":"2017-01-06 12:14:39.000000000","message":"Patch Set 3: Code-Review-1\n\nAgreed, it\u0027s an incompatible change, and 417279 can\u0027t be changed. This will be different when we will have a stable API v2.0 and python-saharaclient will switch to it (or maybe at that point we will have moved to openstacksdk), but anyway not now.","accounts_in_message":[],"_revision_number":3},{"id":"2b8ff27ddfbfc4f58e48c0467281a8fb63c89668","author":{"_account_id":22689,"name":"Shu Yingya","email":"yingya.shu@easystack.cn","username":"ShuYingya"},"date":"2017-01-07 01:14:10.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"c0ded00108867ca06fa4035db76c4b4309e0efe9","revisions":{"6a6d198d13ba4a84675fb5c0fbb4007121e5a263":{"kind":"REWORK","_number":1,"created":"2017-01-06 04:47:29.000000000","uploader":{"_account_id":22689,"name":"Shu Yingya","email":"yingya.shu@easystack.cn","username":"ShuYingya"},"ref":"refs/changes/85/417285/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-saharaclient","ref":"refs/changes/85/417285/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-saharaclient refs/changes/85/417285/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-saharaclient refs/changes/85/417285/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-saharaclient refs/changes/85/417285/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-saharaclient refs/changes/85/417285/1"}}},"commit":{"parents":[{"commit":"fb803225f3e7c48958acc86a9e9b747d598320ee","subject":"Add Constraints support","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-saharaclient/commit/fb803225f3e7c48958acc86a9e9b747d598320ee"}]}],"author":{"name":"Shu Yingya","email":"yingya.shu@easystack.cn","date":"2017-01-06 04:21:12.000000000","tz":0},"committer":{"name":"Shu Yingya","email":"yingya.shu@easystack.cn","date":"2017-01-06 04:46:48.000000000","tz":0},"subject":"Convert update methods to use PATCH in api v11","message":"Convert update methods to use PATCH in api v11\n\nAs the change in [1], the update method have been\nconverted to PATCH. We should also change the\nmethod in saharaclient.\n\n[1]: https://review.openstack.org/#/c/417279/\nDepends-On: Ie72ac627ca0182343c8604590674f0b722820ec8\n\nChange-Id: Ie6c47b970b6dbb91ed07c56ac1b54f3448f2c481\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-saharaclient/commit/6a6d198d13ba4a84675fb5c0fbb4007121e5a263"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-saharaclient/commit/6a6d198d13ba4a84675fb5c0fbb4007121e5a263"}]},"branch":"refs/heads/master"},"a0b33baf151745659792ba1622106b8ea018e569":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2017-01-06 05:20:11.000000000","uploader":{"_account_id":22689,"name":"Shu Yingya","email":"yingya.shu@easystack.cn","username":"ShuYingya"},"ref":"refs/changes/85/417285/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-saharaclient","ref":"refs/changes/85/417285/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-saharaclient refs/changes/85/417285/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-saharaclient refs/changes/85/417285/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-saharaclient refs/changes/85/417285/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-saharaclient refs/changes/85/417285/2"}}},"commit":{"parents":[{"commit":"fb803225f3e7c48958acc86a9e9b747d598320ee","subject":"Add Constraints support","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-saharaclient/commit/fb803225f3e7c48958acc86a9e9b747d598320ee"}]}],"author":{"name":"Shu Yingya","email":"yingya.shu@easystack.cn","date":"2017-01-06 04:21:12.000000000","tz":0},"committer":{"name":"Shu Yingya","email":"yingya.shu@easystack.cn","date":"2017-01-06 05:19:22.000000000","tz":0},"subject":"Convert update methods to use PATCH","message":"Convert update methods to use PATCH\n\nAs the change in [1], the update method have been\nconverted to PATCH. We should also change the\nmethod in saharaclient.\n\n[1]: https://review.openstack.org/#/c/417279/\nDepends-On: Ie72ac627ca0182343c8604590674f0b722820ec8\n\nChange-Id: Ie6c47b970b6dbb91ed07c56ac1b54f3448f2c481\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-saharaclient/commit/a0b33baf151745659792ba1622106b8ea018e569"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-saharaclient/commit/a0b33baf151745659792ba1622106b8ea018e569"}]},"branch":"refs/heads/master"},"c0ded00108867ca06fa4035db76c4b4309e0efe9":{"kind":"REWORK","_number":3,"created":"2017-01-06 07:12:33.000000000","uploader":{"_account_id":22689,"name":"Shu Yingya","email":"yingya.shu@easystack.cn","username":"ShuYingya"},"ref":"refs/changes/85/417285/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-saharaclient","ref":"refs/changes/85/417285/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-saharaclient refs/changes/85/417285/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-saharaclient refs/changes/85/417285/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-saharaclient refs/changes/85/417285/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-saharaclient refs/changes/85/417285/3"}}},"commit":{"parents":[{"commit":"fb803225f3e7c48958acc86a9e9b747d598320ee","subject":"Add Constraints support","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-saharaclient/commit/fb803225f3e7c48958acc86a9e9b747d598320ee"}]}],"author":{"name":"Shu Yingya","email":"yingya.shu@easystack.cn","date":"2017-01-06 04:21:12.000000000","tz":0},"committer":{"name":"Shu Yingya","email":"yingya.shu@easystack.cn","date":"2017-01-06 07:11:24.000000000","tz":0},"subject":"Convert update methods to use PATCH","message":"Convert update methods to use PATCH\n\nAs the change in [1], the update method have been\nconverted to PATCH. We should also change the\nmethod in saharaclient.\n\n[1]: https://review.openstack.org/#/c/417279/\n\nChange-Id: Ie6c47b970b6dbb91ed07c56ac1b54f3448f2c481\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-saharaclient/commit/c0ded00108867ca06fa4035db76c4b4309e0efe9"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-saharaclient/commit/c0ded00108867ca06fa4035db76c4b4309e0efe9"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}