)]}'
{"searchlightclient/osc/v1/facet.py":[{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"1258542d52a7c54e339eed0ca0186b870ef7f41b","unresolved":false,"context_lines":[{"line_number":60,"context_line":"            \"Resource\","},{"line_number":61,"context_line":"            \"Type\","},{"line_number":62,"context_line":"            \"Name\","},{"line_number":63,"context_line":"            \"Options\""},{"line_number":64,"context_line":"        )"},{"line_number":65,"context_line":"        params \u003d {"},{"line_number":66,"context_line":"            \"index\": parsed_args.index,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_06711c44","line":63,"updated":"2015-12-11 17:08:30.000000000","message":"I know the API calls this options; running it, i wonder if something else would be easier to read but I\u0027m not sure what. \u0027Values\u0027 perhaps? I\u0027m ok leaving it as \u0027options\u0027 if nobody else has an opinion","commit_id":"3c68d65395467ad71e63575548b527d989ca2b79"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"897e1fdf2539775d37d2c8cc99575616f426fa79","unresolved":false,"context_lines":[{"line_number":60,"context_line":"            \"Resource\","},{"line_number":61,"context_line":"            \"Type\","},{"line_number":62,"context_line":"            \"Name\","},{"line_number":63,"context_line":"            \"Options\""},{"line_number":64,"context_line":"        )"},{"line_number":65,"context_line":"        params \u003d {"},{"line_number":66,"context_line":"            \"index\": parsed_args.index,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_8a2163a0","line":63,"in_reply_to":"7a740942_06711c44","updated":"2015-12-14 01:42:47.000000000","message":"column name is also used to get the related values from result, so i don\u0027t think we can change to other name here, unless we change the result dict from \u0027options\u0027: {} to \u0027values\u0027: {}.","commit_id":"3c68d65395467ad71e63575548b527d989ca2b79"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"1258542d52a7c54e339eed0ca0186b870ef7f41b","unresolved":false,"context_lines":[{"line_number":73,"context_line":"        for resource, values in six.iteritems(data):"},{"line_number":74,"context_line":"            for s in values:"},{"line_number":75,"context_line":"                s[\"resource\"] \u003d resource"},{"line_number":76,"context_line":"                result.append(utils.get_dict_properties(s, columns))"},{"line_number":77,"context_line":"        return (columns, result)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_e69090ef","line":76,"updated":"2015-12-11 17:08:30.000000000","message":"Looking at the response, I think we could make \u0027options\u0027 a bit nicer to read from the CLI. Currently we get a string representation of the list SL gives back - [{u\u0027key\u0027: u\u0027ACTIVE\u0027, u\u0027doc_count\u0027: 2}]\n\nFrom a small sample it looks like other OSC plugins do some formatting; for instance, server list gives for \u0027Networks\u0027: public\u003d2001:db8::5, 172.25.0.4, although \u0027security_groups\u0027 is a dictionary.\n\nMy inclination would be to do:\n\nACTIVE (2), SUSPENDED (1)","commit_id":"3c68d65395467ad71e63575548b527d989ca2b79"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"897e1fdf2539775d37d2c8cc99575616f426fa79","unresolved":false,"context_lines":[{"line_number":73,"context_line":"        for resource, values in six.iteritems(data):"},{"line_number":74,"context_line":"            for s in values:"},{"line_number":75,"context_line":"                s[\"resource\"] \u003d resource"},{"line_number":76,"context_line":"                result.append(utils.get_dict_properties(s, columns))"},{"line_number":77,"context_line":"        return (columns, result)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_0a8a5364","line":76,"in_reply_to":"7a740942_e69090ef","updated":"2015-12-14 01:42:47.000000000","message":"Done","commit_id":"3c68d65395467ad71e63575548b527d989ca2b79"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"eece995a6ec0d26ba3d7888b39ac6e042c6ebc73","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    def get_parser(self, prog_name):"},{"line_number":29,"context_line":"        parser \u003d super(ListFacet, self).get_parser(prog_name)"},{"line_number":30,"context_line":"        parser.add_argument("},{"line_number":31,"context_line":"            \"--resource\","},{"line_number":32,"context_line":"            metavar\u003d\"\u003cresource\u003e\","},{"line_number":33,"context_line":"            help\u003d\"Get facets for a particular resource type\""},{"line_number":34,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":4,"id":"da6ed579_6ddb1f50","line":31,"updated":"2016-01-14 06:15:51.000000000","message":"I\u0027ve put some more discussion in the etherpad, but on looking again, i\u0027m wondering if we should by doing --type for less typing and to match API   or alternatively if we should be doing --resource-type to be consistent with resource type.","commit_id":"28b126a965ffc99f117239e50a3374805a562d6b"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"dbcefdc7e26e17cbb39ab01438f3fa38daf84787","unresolved":false,"context_lines":[{"line_number":32,"context_line":"            metavar\u003d\"\u003cresource-type\u003e\","},{"line_number":33,"context_line":"            help\u003d\"Get facets for a particular resource type\""},{"line_number":34,"context_line":"        )"},{"line_number":35,"context_line":"        parser.add_argument("},{"line_number":36,"context_line":"            \"--index\","},{"line_number":37,"context_line":"            metavar\u003d\"\u003cindex\u003e\","},{"line_number":38,"context_line":"            help\u003d\"Get facets for a particular index\""}],"source_content_type":"text/x-python","patch_set":6,"id":"ba63e191_f798781d","line":35,"updated":"2016-01-20 00:02:39.000000000","message":"I\u0027d probably also drop this in favor of the pure resource-type mapping.  Let\u0027s not add things we know we will delete shortly.","commit_id":"fe5ed250f236550814b6640f89b09740a427a345"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"9d4f587a2da196962b0dfffdb34d6842cb143059","unresolved":false,"context_lines":[{"line_number":32,"context_line":"            metavar\u003d\"\u003cresource-type\u003e\","},{"line_number":33,"context_line":"            help\u003d\"Get facets for a particular resource type\""},{"line_number":34,"context_line":"        )"},{"line_number":35,"context_line":"        parser.add_argument("},{"line_number":36,"context_line":"            \"--index\","},{"line_number":37,"context_line":"            metavar\u003d\"\u003cindex\u003e\","},{"line_number":38,"context_line":"            help\u003d\"Get facets for a particular index\""}],"source_content_type":"text/x-python","patch_set":6,"id":"ba63e191_3f1ee663","line":35,"in_reply_to":"ba63e191_f798781d","updated":"2016-01-20 00:50:51.000000000","message":"Done","commit_id":"fe5ed250f236550814b6640f89b09740a427a345"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"dbcefdc7e26e17cbb39ab01438f3fa38daf84787","unresolved":false,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        search_client \u003d self.app.client_manager.search"},{"line_number":59,"context_line":"        columns \u003d ("},{"line_number":60,"context_line":"            \"Resource\","},{"line_number":61,"context_line":"            \"Type\","},{"line_number":62,"context_line":"            \"Name\","},{"line_number":63,"context_line":"            \"Options\""}],"source_content_type":"text/x-python","patch_set":6,"id":"ba63e191_f734f8fb","line":60,"updated":"2016-01-20 00:02:39.000000000","message":"I think the column name of \"resource type\" would be better.","commit_id":"fe5ed250f236550814b6640f89b09740a427a345"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"9d4f587a2da196962b0dfffdb34d6842cb143059","unresolved":false,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        search_client \u003d self.app.client_manager.search"},{"line_number":59,"context_line":"        columns \u003d ("},{"line_number":60,"context_line":"            \"Resource\","},{"line_number":61,"context_line":"            \"Type\","},{"line_number":62,"context_line":"            \"Name\","},{"line_number":63,"context_line":"            \"Options\""}],"source_content_type":"text/x-python","patch_set":6,"id":"ba63e191_7fc53e8c","line":60,"in_reply_to":"ba63e191_f734f8fb","updated":"2016-01-20 00:50:51.000000000","message":"Done","commit_id":"fe5ed250f236550814b6640f89b09740a427a345"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"6758bc683c8a5b72ea02a5c6731856e0e2e222cf","unresolved":false,"context_lines":[{"line_number":75,"context_line":"                options \u003d []"},{"line_number":76,"context_line":"                for o in s.get(\u0027options\u0027, []):"},{"line_number":77,"context_line":"                    options.append("},{"line_number":78,"context_line":"                        str(o[\u0027key\u0027]) + \u0027(\u0027 + str(o[\u0027doc_count\u0027]) + \u0027)\u0027)"},{"line_number":79,"context_line":"                s[\"options\"] \u003d \u0027, \u0027.join(options)"},{"line_number":80,"context_line":"                s[\"resource\"] \u003d resource"},{"line_number":81,"context_line":"                result.append(utils.get_dict_properties(s, columns))"}],"source_content_type":"text/x-python","patch_set":6,"id":"da6ed579_daffcda8","line":78,"range":{"start_line":78,"start_character":40,"end_line":78,"end_character":43},"updated":"2016-01-17 18:03:14.000000000","message":"Tiny nit - it\u0027d be good to put a space before the parenthesis","commit_id":"fe5ed250f236550814b6640f89b09740a427a345"}]}