)]}'
{"id":"openstack%2Fpython-searchlightclient~366903","triplet_id":"openstack%2Fpython-searchlightclient~master~Icf0bdb72f790029e08be1150c4f7352446b1d8b2","project":"openstack/python-searchlightclient","branch":"master","topic":"bug/1621199","hashtags":[],"change_id":"Icf0bdb72f790029e08be1150c4f7352446b1d8b2","subject":"Use \u0027uuid\u0027 if \u0027id\u0027 is not found in \u0027_source\u0027","status":"ABANDONED","created":"2016-09-07 18:39:55.000000000","updated":"2016-10-13 09:18:45.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"0f8a4f3a5412ef48516fe115895a0320b5c3e4ca","_number":366903,"virtual_id_number":366903,"owner":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},{"value":1,"date":"2016-09-09 06:42:16.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},{"date":"2016-09-09 12:56:55.000000000","_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},{"date":"2016-09-09 06:41:50.000000000","_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":-1,"date":"2016-09-26 17:13:42.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-09-07 20:14:10.000000000","updated_by":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"reviewer":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"state":"REVIEWER"},{"updated":"2016-09-09 06:42:16.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2016-09-09 12:56:55.000000000","updated_by":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"reviewer":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"state":"REVIEWER"},{"updated":"2016-09-26 17:13:42.000000000","updated_by":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"reviewer":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"state":"REVIEWER"}],"messages":[{"id":"b81c5e1a0ab91dcb6968a976260bb107aed7e852","author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"date":"2016-09-07 18:39:55.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"b0b99e81df28e7372a4d63f9bef20a3c9ba9888a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-09-07 18:45:15.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-searchlightclient-docs-ubuntu-xenial http://docs-draft.openstack.org/03/366903/1/check/gate-python-searchlightclient-docs-ubuntu-xenial/fde9a1e//doc/build/html/ : SUCCESS in 2m 11s\n- gate-python-searchlightclient-pep8-ubuntu-xenial http://logs.openstack.org/03/366903/1/check/gate-python-searchlightclient-pep8-ubuntu-xenial/9ca530d/ : SUCCESS in 2m 15s\n- gate-python-searchlightclient-python27-searchlight http://logs.openstack.org/03/366903/1/check/gate-python-searchlightclient-python27-searchlight/6a8bfdc/ : SUCCESS in 3m 20s\n- gate-python-searchlightclient-python27-searchlight-es1 http://logs.openstack.org/03/366903/1/check/gate-python-searchlightclient-python27-searchlight-es1/90a3b18/ : SUCCESS in 2m 47s\n- gate-python-searchlightclient-python34-searchlight http://logs.openstack.org/03/366903/1/check/gate-python-searchlightclient-python34-searchlight/84c45ab/ : SUCCESS in 2m 31s\n- gate-python-searchlightclient-python35-searchlight-nv http://logs.openstack.org/03/366903/1/check/gate-python-searchlightclient-python35-searchlight-nv/719f306/ : SUCCESS in 3m 47s (non-voting)\n- gate-python-searchlightclient-pypy http://logs.openstack.org/03/366903/1/check/gate-python-searchlightclient-pypy/e99c57c/ : SUCCESS in 3m 47s (non-voting)\n- check-osc-plugins http://logs.openstack.org/03/366903/1/check/check-osc-plugins/3c6553d/ : SUCCESS in 3m 30s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"44665c247cf603589297dfbbd42cb6015f266136","author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"date":"2016-09-07 20:10:19.000000000","message":"Patch Set 1:\n\nWe have tried to enforce that \u0027id\u0027 always be present in results. _id is not a good field to use since it has implementation details embedded in it (some resources will have two copies of the same document with different _ids but the same id). It would be preferable to ensure that plugins map something to an id column","accounts_in_message":[],"_revision_number":1},{"id":"936ba1f0dabbd8b1e308a3a42077c9df1a192354","author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"date":"2016-09-07 20:10:42.000000000","message":"Patch Set 1: Code-Review-1\n\nGonna mark this -1 until i\u0027m satisfied there\u0027s a reason we need to allow id-less documents","accounts_in_message":[],"_revision_number":1},{"id":"ec0d310cd588cf3ca002331cae9c3e099f2f3762","author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"date":"2016-09-07 20:14:10.000000000","message":"Patch Set 1: Code-Review-1\n\nYes, there are a few fields (such as this and project_id) which we have an expectation of some data normalization where we may duplicate some fields.  It is required to do a couple of fields in order for use cases like the searchlight UI to have some common fields that it counts on being there.","accounts_in_message":[],"_revision_number":1},{"id":"5b3d61c5389a23b1facc511d9b0534278c5e9580","author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"date":"2016-09-09 06:37:00.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"88f1fb5f9511957e3783f5f94b7b8e131532600d","author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"date":"2016-09-09 06:41:50.000000000","message":"Patch Set 2:\n\nIronic does not have field with name \u0027id\u0027 in the external resources representation. I think searchlight should not modify schemas of incoming documents if possible.","accounts_in_message":[],"_revision_number":2},{"id":"da08bb467058a9516735854928679bfcf44e6bfa","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-09-09 06:42:16.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-searchlightclient-docs-ubuntu-xenial http://docs-draft.openstack.org/03/366903/2/check/gate-python-searchlightclient-docs-ubuntu-xenial/618a961//doc/build/html/ : SUCCESS in 4m 06s\n- gate-python-searchlightclient-pep8-ubuntu-xenial http://logs.openstack.org/03/366903/2/check/gate-python-searchlightclient-pep8-ubuntu-xenial/73be716/ : SUCCESS in 2m 55s\n- gate-python-searchlightclient-python27-searchlight http://logs.openstack.org/03/366903/2/check/gate-python-searchlightclient-python27-searchlight/48aaf5c/ : SUCCESS in 2m 25s\n- gate-python-searchlightclient-python27-searchlight-es1 http://logs.openstack.org/03/366903/2/check/gate-python-searchlightclient-python27-searchlight-es1/efefb7d/ : SUCCESS in 2m 15s\n- gate-python-searchlightclient-python34-searchlight http://logs.openstack.org/03/366903/2/check/gate-python-searchlightclient-python34-searchlight/c4195d9/ : SUCCESS in 2m 25s\n- gate-python-searchlightclient-python35-searchlight-nv http://logs.openstack.org/03/366903/2/check/gate-python-searchlightclient-python35-searchlight-nv/da2fa56/ : SUCCESS in 2m 27s (non-voting)\n- gate-python-searchlightclient-pypy http://logs.openstack.org/03/366903/2/check/gate-python-searchlightclient-pypy/83919bf/ : SUCCESS in 2m 24s (non-voting)\n- check-osc-plugins http://logs.openstack.org/03/366903/2/check/check-osc-plugins/56ca51f/ : SUCCESS in 4m 54s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"310da08cc75d4b97f24ab4e074dddc101756487e","author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"date":"2016-09-09 12:56:55.000000000","message":"Patch Set 2:\n\nUnderstood, but for the sake of the client and the UI (and other consumers) we\u0027ve always tried to at least define id, name and updated_id (see https://github.com/openstack/searchlight/blob/master/doc/source/authoring-plugins.rst#L313). With schema mappings we\u0027ve tried to maintain compatibility with the source data but not be restricted by it .","accounts_in_message":[],"_revision_number":2},{"id":"956f0a80c48ee9a3fa563590362a32ccc0b53252","author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"date":"2016-09-20 03:56:17.000000000","message":"Patch Set 2:\n\nI override id in the plugin https://github.com/openstack/searchlight/blob/master/doc/source/authoring-plugins.rst#L317","accounts_in_message":[],"_revision_number":2},{"id":"044d911c0b44e301acd0ff7e403b88d13d3e8d80","author":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"date":"2016-09-26 17:13:42.000000000","message":"Patch Set 2: Code-Review-1\n\nMaybe we could fall back to using hit._id ?","accounts_in_message":[],"_revision_number":2},{"id":"dbb7eca553c7b9be32531f599817db349f066c30","author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"date":"2016-09-26 17:25:24.000000000","message":"Patch Set 2:\n\nhit._id will work in some cases, but in some cases it\u0027s modified server-side (we store multiple copies of some documents where there are admin-only fields).\n\nIt\u0027s not really sustainable to add specific cases for individual plugins. The same problem will exist on the UI which assumes the presence of id, name and updated_at fields as a minimum. It would be vastly preferable to duplicate UUID into \u0027id\u0027.","accounts_in_message":[],"_revision_number":2},{"id":"bb3fac89cb8a3558df459c5e502cec5e89a3e1f1","author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"date":"2016-09-26 17:34:23.000000000","message":"Patch Set 2:\n\nThe \u0027get_document_id_field\u0027 is used to get the id from the openstack resource; it\u0027s not intended as a substitute for an \u0027id\u0027 field in hte plugin. The beginning of that paragraph states that an \u0027id\u0027 field should be mapped in the plugin.","accounts_in_message":[],"_revision_number":2},{"id":"4847d2c86e3931071625f2c17087973b8c7a5ad6","author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"date":"2016-10-13 09:18:45.000000000","message":"Abandoned\n\nAgree with \u0027id\u0027 mapping in the plugin.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"ba6ff711b698c234957bf4c1b5bc8069695f45eb","revisions":{"8ea265e41e498f39d97abf7aa6bad74f9581eb6f":{"kind":"REWORK","_number":1,"created":"2016-09-07 18:39:55.000000000","uploader":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"ref":"refs/changes/03/366903/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-searchlightclient","ref":"refs/changes/03/366903/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-searchlightclient refs/changes/03/366903/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-searchlightclient refs/changes/03/366903/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-searchlightclient refs/changes/03/366903/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-searchlightclient refs/changes/03/366903/1"}}},"commit":{"parents":[{"commit":"3cf93f7f640ef04a1be31d515c19cffec19cec45","subject":"TrivialFix: Remove logging import unused","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-searchlightclient/commit/3cf93f7f640ef04a1be31d515c19cffec19cec45"}]}],"author":{"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","date":"2016-09-07 18:14:17.000000000","tz":180},"committer":{"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","date":"2016-09-07 18:31:07.000000000","tz":180},"subject":"Fall back to \u0027_id\u0027 value if \u0027id\u0027 is not found in \u0027_source\u0027","message":"Fall back to \u0027_id\u0027 value if \u0027id\u0027 is not found in \u0027_source\u0027\n\nSearchlight plugin API allows to use any name for document id field,\nit\u0027s \u0027uuid\u0027 in ironic for example. But due to limitation in client\ncode only \u0027id\u0027 can be used. This patch proposes leave \u0027_id\u0027 field\nas is if \u0027id\u0027 is not found in \u0027_source\u0027.\n\nCloses-Bug: #1621199\nChange-Id: Icf0bdb72f790029e08be1150c4f7352446b1d8b2\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-searchlightclient/commit/8ea265e41e498f39d97abf7aa6bad74f9581eb6f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-searchlightclient/commit/8ea265e41e498f39d97abf7aa6bad74f9581eb6f"}]},"branch":"refs/heads/master"},"ba6ff711b698c234957bf4c1b5bc8069695f45eb":{"kind":"REWORK","_number":2,"created":"2016-09-09 06:37:00.000000000","uploader":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"ref":"refs/changes/03/366903/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-searchlightclient","ref":"refs/changes/03/366903/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-searchlightclient refs/changes/03/366903/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-searchlightclient refs/changes/03/366903/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-searchlightclient refs/changes/03/366903/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-searchlightclient refs/changes/03/366903/2"}}},"commit":{"parents":[{"commit":"3cf93f7f640ef04a1be31d515c19cffec19cec45","subject":"TrivialFix: Remove logging import unused","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-searchlightclient/commit/3cf93f7f640ef04a1be31d515c19cffec19cec45"}]}],"author":{"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","date":"2016-09-07 18:14:17.000000000","tz":180},"committer":{"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","date":"2016-09-09 06:30:47.000000000","tz":180},"subject":"Use \u0027uuid\u0027 if \u0027id\u0027 is not found in \u0027_source\u0027","message":"Use \u0027uuid\u0027 if \u0027id\u0027 is not found in \u0027_source\u0027\n\nOpenStack ironic service does not have \u0027id\u0027 field in the external\nrepresentation of resources. If \u0027id\u0027 is not present try to use\n\u0027uuid\u0027.\n\nPartial-Bug: #1621199\nChange-Id: Icf0bdb72f790029e08be1150c4f7352446b1d8b2\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-searchlightclient/commit/ba6ff711b698c234957bf4c1b5bc8069695f45eb"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-searchlightclient/commit/ba6ff711b698c234957bf4c1b5bc8069695f45eb"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}