)]}'
{"id":"openstack%2Fpython-searchlightclient~388209","triplet_id":"openstack%2Fpython-searchlightclient~master~I8a312d8a17dcf1b09ca507aad97bba7bbb2d8a2b","project":"openstack/python-searchlightclient","branch":"master","topic":"mock","hashtags":[],"change_id":"I8a312d8a17dcf1b09ca507aad97bba7bbb2d8a2b","subject":"Replace \u0027MagicMock\u0027 with \u0027Mock\u0027","status":"MERGED","created":"2016-10-18 20:47:14.000000000","updated":"2016-11-07 01:36:08.000000000","submitted":"2016-11-07 01:36:08.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"edb873d2cb36e87b12b69789b4caf2d352626a9a","_number":388209,"virtual_id_number":388209,"owner":{"_account_id":17130,"name":"melissaml","email":"ma.lei@99cloud.net","username":"malei"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2016-11-07 01:36:08.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},{"value":0,"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2016-11-07 01:33:43.000000000","_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},{"value":2,"date":"2016-10-25 18:19:18.000000000","_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2016-11-07 01:33:43.000000000","_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},{"value":0,"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-10-25 18:19:18.000000000","updated_by":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"reviewer":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"state":"REVIEWER"},{"updated":"2016-11-07 01:33:43.000000000","updated_by":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"reviewer":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"state":"REVIEWER"},{"updated":"2016-11-07 01:36:08.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"39ede7f74e91d1c6a8be21cde27709db00dbc849","author":{"_account_id":17130,"name":"melissaml","email":"ma.lei@99cloud.net","username":"malei"},"date":"2016-10-18 20:47:14.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"029e20d3bf6f678218af8ae9e7fb0fdee8167581","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-10-18 20:53:57.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-searchlightclient-docs-ubuntu-xenial http://docs-draft.openstack.org/09/388209/1/check/gate-python-searchlightclient-docs-ubuntu-xenial/4321266//doc/build/html/ : SUCCESS in 2m 01s\n- gate-python-searchlightclient-pep8-ubuntu-xenial http://logs.openstack.org/09/388209/1/check/gate-python-searchlightclient-pep8-ubuntu-xenial/65163bf/ : SUCCESS in 2m 01s\n- gate-python-searchlightclient-python27-searchlight http://logs.openstack.org/09/388209/1/check/gate-python-searchlightclient-python27-searchlight/7349233/ : SUCCESS in 2m 14s\n- gate-python-searchlightclient-python27-searchlight-es1 http://logs.openstack.org/09/388209/1/check/gate-python-searchlightclient-python27-searchlight-es1/e91a832/ : SUCCESS in 6m 31s\n- gate-python-searchlightclient-python34-searchlight http://logs.openstack.org/09/388209/1/check/gate-python-searchlightclient-python34-searchlight/eed0c37/ : SUCCESS in 2m 14s\n- gate-python-searchlightclient-python35-searchlight-nv http://logs.openstack.org/09/388209/1/check/gate-python-searchlightclient-python35-searchlight-nv/946bad2/ : SUCCESS in 3m 30s (non-voting)\n- gate-python-searchlightclient-pypy http://logs.openstack.org/09/388209/1/check/gate-python-searchlightclient-pypy/0afcde9/ : SUCCESS in 2m 32s (non-voting)\n- check-osc-plugins http://logs.openstack.org/09/388209/1/check/check-osc-plugins/a00ade8/ : SUCCESS in 3m 28s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"1ea0d64b9922faecd5d57e4e957f5613e39d87e2","author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"date":"2016-10-25 18:19:18.000000000","message":"Patch Set 1: Code-Review+2\n\nAgreed; MagicMock can lead to more problems than it solves.","accounts_in_message":[],"_revision_number":1},{"id":"5e1514baec707a9cfdbb878852c1215dedb442d8","author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"date":"2016-11-07 01:33:43.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"1a3ba1f4600d3d04707abeefd1ece37556cdee7b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-11-07 01:33:53.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"0ff72e80cf3ba2a475a74c32b7442717380eb52a","date":"2016-11-07 01:36:08.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":1},{"id":"685d5dcd64074d1652603281412c01d1563dc217","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-11-07 01:36:08.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-searchlightclient-docs-ubuntu-xenial http://docs-draft.openstack.org/09/388209/1/gate/gate-python-searchlightclient-docs-ubuntu-xenial/459e984//doc/build/html/ : SUCCESS in 2m 14s\n- gate-python-searchlightclient-pep8-ubuntu-xenial http://logs.openstack.org/09/388209/1/gate/gate-python-searchlightclient-pep8-ubuntu-xenial/31abdb4/ : SUCCESS in 1m 42s\n- gate-python-searchlightclient-python27-searchlight http://logs.openstack.org/09/388209/1/gate/gate-python-searchlightclient-python27-searchlight/56be2ff/ : SUCCESS in 1m 49s\n- gate-python-searchlightclient-python27-searchlight-es1 http://logs.openstack.org/09/388209/1/gate/gate-python-searchlightclient-python27-searchlight-es1/f4200a5/ : SUCCESS in 1m 46s\n- gate-python-searchlightclient-python34-searchlight http://logs.openstack.org/09/388209/1/gate/gate-python-searchlightclient-python34-searchlight/0aedd33/ : SUCCESS in 1m 50s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"bdf3095b5dd8046217ff2666f2b4662ae4dbfca3","revisions":{"bdf3095b5dd8046217ff2666f2b4662ae4dbfca3":{"kind":"REWORK","_number":1,"created":"2016-10-18 20:47:14.000000000","uploader":{"_account_id":17130,"name":"melissaml","email":"ma.lei@99cloud.net","username":"malei"},"ref":"refs/changes/09/388209/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-searchlightclient","ref":"refs/changes/09/388209/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-searchlightclient refs/changes/09/388209/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-searchlightclient refs/changes/09/388209/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-searchlightclient refs/changes/09/388209/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-searchlightclient refs/changes/09/388209/1"}}},"commit":{"parents":[{"commit":"c3cf67f5e5c837d8f0cb46d46441c487be5af324","subject":"Remove circular TOC reference","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-searchlightclient/commit/c3cf67f5e5c837d8f0cb46d46441c487be5af324"}]}],"author":{"name":"melissaml","email":"ma.lei@99cloud.net","date":"2016-10-18 20:46:23.000000000","tz":480},"committer":{"name":"melissaml","email":"ma.lei@99cloud.net","date":"2016-10-18 20:47:12.000000000","tz":480},"subject":"Replace \u0027MagicMock\u0027 with \u0027Mock\u0027","message":"Replace \u0027MagicMock\u0027 with \u0027Mock\u0027\n\nMagicMock magically allow things to pass. Any usage should\nbe replaced with the Mock class and explicit attributes\nshould be set on it. [1]\n[1] http://stackoverflow.com/questions/17181687/mock-vs-magicmock\n\nChange-Id: I8a312d8a17dcf1b09ca507aad97bba7bbb2d8a2b\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-searchlightclient/commit/bdf3095b5dd8046217ff2666f2b4662ae4dbfca3"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-searchlightclient/commit/bdf3095b5dd8046217ff2666f2b4662ae4dbfca3"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}