)]}'
{"id":"openstack%2Fpython-searchlightclient~404000","triplet_id":"openstack%2Fpython-searchlightclient~master~Idb02425dbefb6ea9038b625d6286e377988b2c03","project":"openstack/python-searchlightclient","branch":"master","topic":"six-iteritems","hashtags":[],"change_id":"Idb02425dbefb6ea9038b625d6286e377988b2c03","subject":"Replace six.iteritems() with .items()","status":"MERGED","created":"2016-11-29 03:23:59.000000000","updated":"2016-12-03 00:16:46.000000000","submitted":"2016-12-03 00:16:46.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"e061b8a57ebb54129ad6b022526357af78bf8634","_number":404000,"virtual_id_number":404000,"owner":{"_account_id":17130,"name":"melissaml","email":"ma.lei@99cloud.net","username":"malei"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},{"value":2,"date":"2016-12-03 00:16:46.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"all":[{"value":2,"date":"2016-12-03 00:14:21.000000000","_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2016-11-29 15:21:43.000000000","_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"all":[{"value":1,"date":"2016-12-03 00:14:21.000000000","_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-11-29 15:21:43.000000000","updated_by":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"reviewer":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"state":"REVIEWER"},{"updated":"2016-12-03 00:14:21.000000000","updated_by":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"reviewer":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"state":"REVIEWER"},{"updated":"2016-12-03 00:16:46.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"de724e49ac45b3922c59dbedb6647f9d57eef5a0","author":{"_account_id":17130,"name":"melissaml","email":"ma.lei@99cloud.net","username":"malei"},"date":"2016-11-29 03:23:59.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"a697d4be4517ed4879ce8c5a09f8c605ddbc40b4","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-11-29 03:27:31.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-searchlightclient-docs-ubuntu-xenial http://docs-draft.openstack.org/00/404000/1/check/gate-python-searchlightclient-docs-ubuntu-xenial/29ca472//doc/build/html/ : SUCCESS in 1m 44s\n- gate-python-searchlightclient-pep8-ubuntu-xenial http://logs.openstack.org/00/404000/1/check/gate-python-searchlightclient-pep8-ubuntu-xenial/7373c04/ : FAILURE in 1m 51s\n- gate-python-searchlightclient-python27-searchlight http://logs.openstack.org/00/404000/1/check/gate-python-searchlightclient-python27-searchlight/ca2b95c/ : FAILURE in 1m 47s\n- gate-python-searchlightclient-python27-searchlight-es1 http://logs.openstack.org/00/404000/1/check/gate-python-searchlightclient-python27-searchlight-es1/7feced6/ : FAILURE in 2m 20s\n- gate-python-searchlightclient-python34-searchlight http://logs.openstack.org/00/404000/1/check/gate-python-searchlightclient-python34-searchlight/228692d/ : FAILURE in 1m 51s\n- gate-python-searchlightclient-python35-searchlight-nv http://logs.openstack.org/00/404000/1/check/gate-python-searchlightclient-python35-searchlight-nv/593b971/ : FAILURE in 1m 48s (non-voting)\n- gate-python-searchlightclient-pypy http://logs.openstack.org/00/404000/1/check/gate-python-searchlightclient-pypy/ae9873d/ : FAILURE in 2m 28s (non-voting)\n- check-osc-plugins http://logs.openstack.org/00/404000/1/check/check-osc-plugins/e649e1a/ : SUCCESS in 3m 18s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"66471b6478b78ff7909dab498d8fc5416ac13ceb","author":{"_account_id":17130,"name":"melissaml","email":"ma.lei@99cloud.net","username":"malei"},"date":"2016-11-29 03:43:20.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"99ba1f314cb9ec6232a0c59fa8dd2bcfd13fc862","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-11-29 03:48:40.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-searchlightclient-docs-ubuntu-xenial http://docs-draft.openstack.org/00/404000/2/check/gate-python-searchlightclient-docs-ubuntu-xenial/bafac25//doc/build/html/ : SUCCESS in 2m 33s\n- gate-python-searchlightclient-pep8-ubuntu-xenial http://logs.openstack.org/00/404000/2/check/gate-python-searchlightclient-pep8-ubuntu-xenial/08c9e7a/ : SUCCESS in 3m 48s\n- gate-python-searchlightclient-python27-searchlight http://logs.openstack.org/00/404000/2/check/gate-python-searchlightclient-python27-searchlight/526aa2b/ : SUCCESS in 1m 50s\n- gate-python-searchlightclient-python27-searchlight-es1 http://logs.openstack.org/00/404000/2/check/gate-python-searchlightclient-python27-searchlight-es1/e39a826/ : SUCCESS in 2m 20s\n- gate-python-searchlightclient-python34-searchlight http://logs.openstack.org/00/404000/2/check/gate-python-searchlightclient-python34-searchlight/02e04aa/ : SUCCESS in 1m 54s\n- gate-python-searchlightclient-python35-searchlight-nv http://logs.openstack.org/00/404000/2/check/gate-python-searchlightclient-python35-searchlight-nv/8a95adb/ : SUCCESS in 2m 44s (non-voting)\n- gate-python-searchlightclient-pypy http://logs.openstack.org/00/404000/2/check/gate-python-searchlightclient-pypy/6b41730/ : SUCCESS in 2m 00s (non-voting)\n- check-osc-plugins http://logs.openstack.org/00/404000/2/check/check-osc-plugins/5f6281f/ : SUCCESS in 3m 18s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"4cf1d8e08a4d0a9ff56011f08994210d1f621553","author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"date":"2016-11-29 15:21:43.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"984726b1df3b4075cf93f7abc3a989ce8ad4d683","author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"date":"2016-12-03 00:14:21.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"fd9c9f365af17ab51bcdce64f222dc44431e5c23","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-12-03 00:14:31.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"ae46a02e29977b11130111862917fc596a4a2898","date":"2016-12-03 00:16:46.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":2},{"id":"e5a0ee63603f925d55662176e0d86051513ecfdf","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-12-03 00:16:46.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-searchlightclient-docs-ubuntu-xenial http://docs-draft.openstack.org/00/404000/2/gate/gate-python-searchlightclient-docs-ubuntu-xenial/b46ab8e//doc/build/html/ : SUCCESS in 1m 42s\n- gate-python-searchlightclient-pep8-ubuntu-xenial http://logs.openstack.org/00/404000/2/gate/gate-python-searchlightclient-pep8-ubuntu-xenial/0a002fb/ : SUCCESS in 1m 53s\n- gate-python-searchlightclient-python27-ubuntu-xenial http://logs.openstack.org/00/404000/2/gate/gate-python-searchlightclient-python27-ubuntu-xenial/2816c05/ : SUCCESS in 1m 45s\n- gate-python-searchlightclient-python34 http://logs.openstack.org/00/404000/2/gate/gate-python-searchlightclient-python34/5775857/ : SUCCESS in 1m 51s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"fb3e26044d0fbb52c0b266017c8920576f3f160b","revisions":{"6076b88754121e83580fba30da9d362b38b74541":{"kind":"REWORK","_number":1,"created":"2016-11-29 03:23:59.000000000","uploader":{"_account_id":17130,"name":"melissaml","email":"ma.lei@99cloud.net","username":"malei"},"ref":"refs/changes/00/404000/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-searchlightclient","ref":"refs/changes/00/404000/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-searchlightclient refs/changes/00/404000/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-searchlightclient refs/changes/00/404000/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-searchlightclient refs/changes/00/404000/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-searchlightclient refs/changes/00/404000/1"}}},"commit":{"parents":[{"commit":"5e94996791dec45682b99e6c72aae5c56d0e556a","subject":"Merge \"Don\u0027t include openstack/common in flake8 exclude list\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-searchlightclient/commit/5e94996791dec45682b99e6c72aae5c56d0e556a"}]}],"author":{"name":"melissaml","email":"ma.lei@99cloud.net","date":"2016-11-29 03:23:16.000000000","tz":480},"committer":{"name":"melissaml","email":"ma.lei@99cloud.net","date":"2016-11-29 03:23:16.000000000","tz":480},"subject":"Replace six.iteritems() with .items()","message":"Replace six.iteritems() with .items()\n\n1.As mentioned in [1], we should avoid using six.iteritems to achieve iterators.\nWe can use dict.items instead, as it will return iterators in PY3 as well.\nAnd dict.items/keys will more readable. 2.In py2, the performance about\nlist should be negligible, see the link [2].\n[1] https://wiki.openstack.org/wiki/Python3\n[2] http://lists.openstack.org/pipermail/openstack-dev/2015-June/066391.html\n\nChange-Id: Idb02425dbefb6ea9038b625d6286e377988b2c03\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-searchlightclient/commit/6076b88754121e83580fba30da9d362b38b74541"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-searchlightclient/commit/6076b88754121e83580fba30da9d362b38b74541"}]},"branch":"refs/heads/master"},"fb3e26044d0fbb52c0b266017c8920576f3f160b":{"kind":"REWORK","_number":2,"created":"2016-11-29 03:43:20.000000000","uploader":{"_account_id":17130,"name":"melissaml","email":"ma.lei@99cloud.net","username":"malei"},"ref":"refs/changes/00/404000/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-searchlightclient","ref":"refs/changes/00/404000/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-searchlightclient refs/changes/00/404000/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-searchlightclient refs/changes/00/404000/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-searchlightclient refs/changes/00/404000/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-searchlightclient refs/changes/00/404000/2"}}},"commit":{"parents":[{"commit":"5e94996791dec45682b99e6c72aae5c56d0e556a","subject":"Merge \"Don\u0027t include openstack/common in flake8 exclude list\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-searchlightclient/commit/5e94996791dec45682b99e6c72aae5c56d0e556a"}]}],"author":{"name":"melissaml","email":"ma.lei@99cloud.net","date":"2016-11-29 03:23:16.000000000","tz":480},"committer":{"name":"melissaml","email":"ma.lei@99cloud.net","date":"2016-11-29 03:42:40.000000000","tz":480},"subject":"Replace six.iteritems() with .items()","message":"Replace six.iteritems() with .items()\n\n1.As mentioned in [1], we should avoid using six.iteritems to achieve iterators.\nWe can use dict.items instead, as it will return iterators in PY3 as well.\nAnd dict.items/keys will more readable. 2.In py2, the performance about\nlist should be negligible, see the link [2].\n[1] https://wiki.openstack.org/wiki/Python3\n[2] http://lists.openstack.org/pipermail/openstack-dev/2015-June/066391.html\n\nChange-Id: Idb02425dbefb6ea9038b625d6286e377988b2c03\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-searchlightclient/commit/fb3e26044d0fbb52c0b266017c8920576f3f160b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-searchlightclient/commit/fb3e26044d0fbb52c0b266017c8920576f3f160b"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}