)]}'
{"id":"openstack%2Fpython-senlinclient~434117","triplet_id":"openstack%2Fpython-senlinclient~master~I1b19c848b7b264a2968546ae8f46e87475d527da","project":"openstack/python-senlinclient","branch":"master","topic":"avoid-import-sdk-classes-1","hashtags":[],"change_id":"I1b19c848b7b264a2968546ae8f46e87475d527da","subject":"Avoid import internal classes from SDK","status":"MERGED","created":"2017-02-15 07:48:38.000000000","updated":"2017-02-15 09:11:22.000000000","submitted":"2017-02-15 09:11:22.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"9262fc9cba3aa3f1569388bfc351811cdad28ead","_number":434117,"virtual_id_number":434117,"owner":{"_account_id":8246,"name":"Qiming Teng","email":"tengqm@outlook.com","username":"tengqm"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2017-02-15 09:11:22.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":8246,"name":"Qiming Teng","email":"tengqm@outlook.com","username":"tengqm"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":8246,"name":"Qiming Teng","email":"tengqm@outlook.com","username":"tengqm"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2017-02-15 09:07:21.000000000","_account_id":8246,"name":"Qiming Teng","email":"tengqm@outlook.com","username":"tengqm"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":8246,"name":"Qiming Teng","email":"tengqm@outlook.com","username":"tengqm"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2017-02-15 09:07:21.000000000","_account_id":8246,"name":"Qiming Teng","email":"tengqm@outlook.com","username":"tengqm"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":8246,"name":"Qiming Teng","email":"tengqm@outlook.com","username":"tengqm"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-02-15 09:11:22.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"afccf5c32d1c939c785ca33d2f9d2b292ef98abb","author":{"_account_id":8246,"name":"Qiming Teng","email":"tengqm@outlook.com","username":"tengqm"},"date":"2017-02-15 07:48:38.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"1593493178b9d04f755146c1c8fc479eb4f0b0c6","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-02-15 07:53:01.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-senlinclient-docs-ubuntu-xenial http://docs-draft.openstack.org/17/434117/1/check/gate-python-senlinclient-docs-ubuntu-xenial/b1cb719//doc/build/html/ : SUCCESS in 3m 24s\n- gate-python-senlinclient-pep8-ubuntu-xenial http://logs.openstack.org/17/434117/1/check/gate-python-senlinclient-pep8-ubuntu-xenial/dafd965/ : SUCCESS in 3m 10s\n- gate-python-senlinclient-python27-ubuntu-xenial http://logs.openstack.org/17/434117/1/check/gate-python-senlinclient-python27-ubuntu-xenial/64747a3/ : SUCCESS in 2m 03s\n- gate-python-senlinclient-python35 http://logs.openstack.org/17/434117/1/check/gate-python-senlinclient-python35/5e8bc07/ : SUCCESS in 1m 59s\n- check-osc-plugins http://logs.openstack.org/17/434117/1/check/check-osc-plugins/0a3c548/ : SUCCESS in 3m 13s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"d1473cf0cc587d7083cca5f0df9aa55f1cca4ba0","author":{"_account_id":8246,"name":"Qiming Teng","email":"tengqm@outlook.com","username":"tengqm"},"date":"2017-02-15 09:07:21.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"fe985af68b42d222cc158906a0cb9baa45bbe09a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-02-15 09:07:31.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"d66ab7d62cea6204d0a568f4d07d83f8c71e92a8","date":"2017-02-15 09:11:22.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":1},{"id":"092d24112784e3352d4c0e4a246bcb3514f97b59","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-02-15 09:11:22.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-senlinclient-docs-ubuntu-xenial http://docs-draft.openstack.org/17/434117/1/gate/gate-python-senlinclient-docs-ubuntu-xenial/c37303c//doc/build/html/ : SUCCESS in 1m 56s\n- gate-python-senlinclient-pep8-ubuntu-xenial http://logs.openstack.org/17/434117/1/gate/gate-python-senlinclient-pep8-ubuntu-xenial/c058404/ : SUCCESS in 2m 10s\n- gate-python-senlinclient-python27-ubuntu-xenial http://logs.openstack.org/17/434117/1/gate/gate-python-senlinclient-python27-ubuntu-xenial/a2477bf/ : SUCCESS in 2m 39s\n- gate-python-senlinclient-python35 http://logs.openstack.org/17/434117/1/gate/gate-python-senlinclient-python35/d05104d/ : SUCCESS in 3m 28s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"f3cead5d1ce704e4697c502768f894ad457e3faa","revisions":{"f3cead5d1ce704e4697c502768f894ad457e3faa":{"kind":"REWORK","_number":1,"created":"2017-02-15 07:48:38.000000000","uploader":{"_account_id":8246,"name":"Qiming Teng","email":"tengqm@outlook.com","username":"tengqm"},"ref":"refs/changes/17/434117/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-senlinclient","ref":"refs/changes/17/434117/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-senlinclient refs/changes/17/434117/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-senlinclient refs/changes/17/434117/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-senlinclient refs/changes/17/434117/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-senlinclient refs/changes/17/434117/1"}}},"commit":{"parents":[{"commit":"4273feb35b5f1b94e4b1ab5fd9732c2ae2d6e592","subject":"Update imoprt order","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-senlinclient/commit/4273feb35b5f1b94e4b1ab5fd9732c2ae2d6e592"}]}],"author":{"name":"tengqm","email":"tengqim@cn.ibm.com","date":"2017-02-15 07:46:44.000000000","tz":-300},"committer":{"name":"tengqm","email":"tengqim@cn.ibm.com","date":"2017-02-15 07:46:44.000000000","tz":-300},"subject":"Avoid import internal classes from SDK","message":"Avoid import internal classes from SDK\n\nThis is part of a series of changes related to the usage of SDK. In some\ntest cases, we are importing the resource classes from SDK directly and\neven instantiate them. This is bad for unit tests. We should instead\nmock those resources for unit tests. When functional tests are added,\nthe real resource list/dump will be tested instead.\n\nChange-Id: I1b19c848b7b264a2968546ae8f46e87475d527da\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-senlinclient/commit/f3cead5d1ce704e4697c502768f894ad457e3faa"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-senlinclient/commit/f3cead5d1ce704e4697c502768f894ad457e3faa"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}