)]}'
{"id":"openstack%2Fpython-swiftclient~12055","triplet_id":"openstack%2Fpython-swiftclient~master~I36b3807b2f3234c778316f1e743d27304755aed8","project":"openstack/python-swiftclient","branch":"master","topic":"bug/1037690","hashtags":[],"change_id":"I36b3807b2f3234c778316f1e743d27304755aed8","subject":"Allow endpoint type to be specified.","status":"MERGED","created":"2012-08-28 14:26:55.000000000","updated":"2012-09-05 07:51:32.000000000","submitted":"2012-09-05 07:51:32.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"9c8aa94d368533e626e283916ceceb0fb7ad06f8","_number":12055,"virtual_id_number":12055,"owner":{"_account_id":1192,"name":"David Kranz","email":"dkranz@redhat.com","username":"david-kranz"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},{"value":2,"date":"2012-09-05 07:51:32.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1192,"name":"David Kranz","email":"dkranz@redhat.com","username":"david-kranz"},{"value":0,"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"all":[{"value":2,"date":"2012-09-05 07:50:00.000000000","_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1192,"name":"David Kranz","email":"dkranz@redhat.com","username":"david-kranz"},{"value":0,"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"all":[{"value":1,"date":"2012-09-05 07:50:00.000000000","_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1192,"name":"David Kranz","email":"dkranz@redhat.com","username":"david-kranz"},{"value":0,"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},{"_account_id":1192,"name":"David Kranz","email":"dkranz@redhat.com","username":"david-kranz"},{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2012-08-30 16:15:31.000000000","updated_by":{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},"reviewer":{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},"state":"REVIEWER"},{"updated":"2012-09-05 07:50:00.000000000","updated_by":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"reviewer":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"state":"REVIEWER"},{"updated":"2012-09-05 07:51:32.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"1efbdb251138d5d44414b941ace294c34f3cc194","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-08-28 14:28:37.000000000","message":"Patch Set 1: Works for me\n\nBuild successful\n\n- http://logs.openstack.org/12055/1/check/gate-python-swiftclient-merge/85 : SUCCESS\n- http://logs.openstack.org/12055/1/check/gate-python-swiftclient-docs/35 : SUCCESS\n- http://logs.openstack.org/12055/1/check/gate-python-swiftclient-pep8/84 : SUCCESS\n- http://logs.openstack.org/12055/1/check/gate-python-swiftclient-python26/83 : SUCCESS\n- http://logs.openstack.org/12055/1/check/gate-python-swiftclient-python27/83 : SUCCESS\n","accounts_in_message":[],"_revision_number":1},{"id":"440dd904d2f89ee1628c8de466e0331d469914e1","author":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"date":"2012-08-29 11:35:32.000000000","message":"Patch Set 1: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":1},{"id":"1577a588b84895dc7e1b66d206b94455ec2d536e","author":{"_account_id":1192,"name":"David Kranz","email":"dkranz@redhat.com","username":"david-kranz"},"date":"2012-08-30 16:05:23.000000000","message":"Patch Set 1:\n\nThanks, Chmouel! Can some one please give this another review and approve it? It already has a Core approved.","accounts_in_message":[],"_revision_number":1},{"id":"22776aabf1c0057d0a824d55a237f1e228383990","author":{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},"date":"2012-08-30 17:56:22.000000000","message":"Patch Set 1: Looks good to me, but someone else must approve\n\n(1 inline comment)\n\nOne minor nitpick (in an inline comment), but it\u0027s not the end of the world. Fix or not.\n\nSince I don\u0027t have a Keystone install set up anywhere, I can\u0027t really test this out (unless I misunderstand how things work), so I can\u0027t give it a +2. However, the code looks sane and the tests look good, so I\u0027m happy to give a +1.","accounts_in_message":[],"_revision_number":1},{"id":"91be5f04fd851145ee7bf184b1ed5ce8f00bdc7e","author":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"date":"2012-08-30 18:03:33.000000000","message":"Patch Set 1:\n\nYou right Sam thanks for checking, we need to have the hyphens one now unless for Essex which was the underscores one.","accounts_in_message":[],"_revision_number":1},{"id":"36b8402dec917547e68afb65e32b9293345c6cdb","author":{"_account_id":1192,"name":"David Kranz","email":"dkranz@redhat.com","username":"david-kranz"},"date":"2012-08-30 18:39:33.000000000","message":"Patch Set 1:\n\nI did think about this but figured it was trivial to add and if I didn\u0027t, the resulting inconsistency of the two patterns  of arguments could only cause pain to existing users with no possible benefit. I think we should leave it as is but can remove it if you really care about this.","accounts_in_message":[],"_revision_number":1},{"id":"795be29003ac84d644cb09dc272893223c69134e","author":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"date":"2012-08-30 18:56:03.000000000","message":"Patch Set 1:\n\nAFAIK it\u0027s only for old option that we keep compat for post grizzly we will be able to remove all those underscores...","accounts_in_message":[],"_revision_number":1},{"id":"cf9919b99f39fe4ccf0d267d153dae2e6890974a","author":{"_account_id":1192,"name":"David Kranz","email":"dkranz@redhat.com","username":"david-kranz"},"date":"2012-09-04 16:53:19.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"873b56ffc31dcaa74e81682e70c22d0f86be7ac7","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-09-04 16:58:30.000000000","message":"Patch Set 2: Works for me\n\nBuild successful\n\n- http://logs.openstack.org/12055/2/check/gate-python-swiftclient-merge/94 : SUCCESS\n- http://logs.openstack.org/12055/2/check/gate-python-swiftclient-docs/44 : SUCCESS\n- http://logs.openstack.org/12055/2/check/gate-python-swiftclient-pep8/93 : SUCCESS\n- http://logs.openstack.org/12055/2/check/gate-python-swiftclient-python26/92 : SUCCESS\n- http://logs.openstack.org/12055/2/check/gate-python-swiftclient-python27/92 : SUCCESS\n","accounts_in_message":[],"_revision_number":2},{"id":"a1eeed0b0ae9900f62d0f478ca1b97532c21264d","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-09-05 07:50:00.000000000","message":"Patch Set 2: No score\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"f1b3efb421f6d622cf884991f53ae18741c9ad4d","author":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"date":"2012-09-05 07:50:00.000000000","message":"Patch Set 2: Looks good to me (core reviewer); Approved\n\nApproved based on Sam\u0027s and my other review.","accounts_in_message":[],"_revision_number":2},{"id":"b6870976e6490b5633976ffdbe696179c1dafba2","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-09-05 07:51:32.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":2},{"id":"abac6d08cfc5ce6aabe68316e3b3bf9676d47192","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-09-05 07:51:32.000000000","message":"Patch Set 2: Verified\n\nBuild successful\n\n- http://logs.openstack.org/12055/2/gate/gate-python-swiftclient-merge/95 : SUCCESS\n- http://logs.openstack.org/12055/2/gate/gate-python-swiftclient-docs/45 : SUCCESS\n- http://logs.openstack.org/12055/2/gate/gate-python-swiftclient-pep8/94 : SUCCESS\n- http://logs.openstack.org/12055/2/gate/gate-python-swiftclient-python26/93 : SUCCESS\n- http://logs.openstack.org/12055/2/gate/gate-python-swiftclient-python27/93 : SUCCESS\n","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"4b4fbf0dc0d2e918b88c1e387f462faca7e98ffd","revisions":{"e295914c53512d697c3b321d11fb6c586064d5bb":{"kind":"REWORK","_number":1,"created":"2012-08-28 14:26:55.000000000","uploader":{"_account_id":1192,"name":"David Kranz","email":"dkranz@redhat.com","username":"david-kranz"},"ref":"refs/changes/55/12055/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-swiftclient","ref":"refs/changes/55/12055/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/55/12055/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/55/12055/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/55/12055/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-swiftclient refs/changes/55/12055/1"}}},"commit":{"parents":[{"commit":"58baa42075754c1a3d44a4dbe5e4546bb5689d46","subject":"Merge \"Add nosehtmloutput as a test dependency.\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/58baa42075754c1a3d44a4dbe5e4546bb5689d46"}]}],"author":{"name":"David Kranz","email":"david.kranz@qrclab.com","date":"2012-08-28 14:25:42.000000000","tz":-240},"committer":{"name":"David Kranz","email":"david.kranz@qrclab.com","date":"2012-08-28 14:25:42.000000000","tz":-240},"subject":"Allow endpoint type to be specified.","message":"Allow endpoint type to be specified.\n\nFixes bug 1037690.\n\nChange-Id: I36b3807b2f3234c778316f1e743d27304755aed8\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/e295914c53512d697c3b321d11fb6c586064d5bb"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/e295914c53512d697c3b321d11fb6c586064d5bb"}]},"branch":"refs/heads/master"},"4b4fbf0dc0d2e918b88c1e387f462faca7e98ffd":{"kind":"REWORK","_number":2,"created":"2012-09-04 16:53:19.000000000","uploader":{"_account_id":1192,"name":"David Kranz","email":"dkranz@redhat.com","username":"david-kranz"},"ref":"refs/changes/55/12055/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-swiftclient","ref":"refs/changes/55/12055/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/55/12055/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/55/12055/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/55/12055/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-swiftclient refs/changes/55/12055/2"}}},"commit":{"parents":[{"commit":"c97a90c847f8811e5eb766dd26ff8373675514ac","subject":"Merge \"PEP8 issues fixed\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/c97a90c847f8811e5eb766dd26ff8373675514ac"}]}],"author":{"name":"David Kranz","email":"david.kranz@qrclab.com","date":"2012-08-28 14:25:42.000000000","tz":-240},"committer":{"name":"David Kranz","email":"david.kranz@qrclab.com","date":"2012-09-04 16:53:18.000000000","tz":-240},"subject":"Allow endpoint type to be specified.","message":"Allow endpoint type to be specified.\n\nFixes bug 1037690.\n\nChange-Id: I36b3807b2f3234c778316f1e743d27304755aed8\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/4b4fbf0dc0d2e918b88c1e387f462faca7e98ffd"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/4b4fbf0dc0d2e918b88c1e387f462faca7e98ffd"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}