)]}'
{"id":"openstack%2Fpython-swiftclient~123168","triplet_id":"openstack%2Fpython-swiftclient~master~I4fed013cdb8936509609d06093337cc147ade0d6","project":"openstack/python-swiftclient","branch":"master","topic":"p-bug1372465","hashtags":[],"change_id":"I4fed013cdb8936509609d06093337cc147ade0d6","subject":"Fix bug with some OS options not being passed to client","status":"MERGED","created":"2014-09-22 16:07:05.000000000","updated":"2014-09-25 09:15:22.000000000","submitted":"2014-09-25 09:15:22.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"0d02acdb01e27e1ab0120087ab19cb9fa22750e7","_number":123168,"virtual_id_number":123168,"owner":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":9216,"name":"Joel Wright","email":"joel.wright@gmail.com","username":"jjw-sohonet"},{"value":0,"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},{"value":2,"date":"2014-09-25 09:15:22.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},{"value":0,"_account_id":330,"name":"John Dickinson","email":"me@not.mn","username":"notmyname"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"all":[{"value":0,"_account_id":9216,"name":"Joel Wright","email":"joel.wright@gmail.com","username":"jjw-sohonet"},{"value":2,"date":"2014-09-24 17:32:46.000000000","_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},{"value":2,"date":"2014-09-24 17:28:35.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":330,"name":"John Dickinson","email":"me@not.mn","username":"notmyname"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"all":[{"value":0,"_account_id":9216,"name":"Joel Wright","email":"joel.wright@gmail.com","username":"jjw-sohonet"},{"value":1,"date":"2014-09-24 17:32:46.000000000","_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},{"value":0,"_account_id":330,"name":"John Dickinson","email":"me@not.mn","username":"notmyname"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":330,"name":"John Dickinson","email":"me@not.mn","username":"notmyname"},{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},{"_account_id":9216,"name":"Joel Wright","email":"joel.wright@gmail.com","username":"jjw-sohonet"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2014-09-24 16:12:08.000000000","updated_by":{"_account_id":9216,"name":"Joel Wright","email":"joel.wright@gmail.com","username":"jjw-sohonet"},"reviewer":{"_account_id":9216,"name":"Joel Wright","email":"joel.wright@gmail.com","username":"jjw-sohonet"},"state":"REVIEWER"},{"updated":"2014-09-24 17:28:35.000000000","updated_by":{"_account_id":330,"name":"John Dickinson","email":"me@not.mn","username":"notmyname"},"reviewer":{"_account_id":330,"name":"John Dickinson","email":"me@not.mn","username":"notmyname"},"state":"REVIEWER"},{"updated":"2014-09-24 17:32:46.000000000","updated_by":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"reviewer":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"state":"REVIEWER"},{"updated":"2014-09-25 09:15:22.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"7e002b63e27bd7c74f90a7a0717adffc441d17fc","author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"date":"2014-09-22 16:07:05.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"f49e091527ccc21f678ccdd43327ae70e913071c","author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"date":"2014-09-22 16:21:12.000000000","message":"Patch Set 1:\n\nI\u0027ve asked Joel Wright to review because I have removed process_options() from SwiftService in favour of the existing code in shell.py, but there may have been a good reason for it being in SwiftService.","accounts_in_message":[],"_revision_number":1},{"id":"8140c53b6bc47b21fda9c644a2d5e34e15635679","author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"date":"2014-09-22 18:05:02.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"72e86934dc68d5ac33821e26174b3fff7bd2bd7f","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-09-22 20:02:57.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded.\n\n- gate-python-swiftclient-pep8 http://logs.openstack.org/68/123168/2/check/gate-python-swiftclient-pep8/40a1864 : SUCCESS in 1m 09s\n- gate-python-swiftclient-docs http://docs-draft.openstack.org/68/123168/2/check/gate-python-swiftclient-docs/ab51490/doc/build/html/ : SUCCESS in 1m 14s\n- gate-python-swiftclient-python26 http://logs.openstack.org/68/123168/2/check/gate-python-swiftclient-python26/a4fb8ce : SUCCESS in 2m 03s\n- gate-python-swiftclient-python27 http://logs.openstack.org/68/123168/2/check/gate-python-swiftclient-python27/5863163 : SUCCESS in 1m 07s\n- gate-python-swiftclient-python33 http://logs.openstack.org/68/123168/2/check/gate-python-swiftclient-python33/137a3a9 : SUCCESS in 3m 11s\n- check-tempest-dsvm-full http://logs.openstack.org/68/123168/2/check/check-tempest-dsvm-full/b5333e9 : SUCCESS in 53m 14s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/68/123168/2/check/check-tempest-dsvm-postgres-full/49a3791 : SUCCESS in 56m 10s\n- check-tempest-dsvm-neutron-full http://logs.openstack.org/68/123168/2/check/check-tempest-dsvm-neutron-full/2fa9ef6 : SUCCESS in 1h 06m 22s\n- check-tempest-dsvm-neutron-heat-slow http://logs.openstack.org/68/123168/2/check/check-tempest-dsvm-neutron-heat-slow/d1fb120 : SUCCESS in 25m 23s\n- check-grenade-dsvm http://logs.openstack.org/68/123168/2/check/check-grenade-dsvm/83a95f4 : SUCCESS in 47m 31s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/68/123168/2/check/gate-tempest-dsvm-large-ops/6ced752 : SUCCESS in 24m 45s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/68/123168/2/check/gate-tempest-dsvm-neutron-large-ops/b947d9f : SUCCESS in 27m 34s\n- check-tempest-dsvm-full-havana http://logs.openstack.org/68/123168/2/check/check-tempest-dsvm-full-havana/7a9b3af : FAILURE in 12m 53s (non-voting)\n- check-tempest-dsvm-neutron-havana http://logs.openstack.org/68/123168/2/check/check-tempest-dsvm-neutron-havana/9397c03 : FAILURE in 13m 57s (non-voting)\n- check-tempest-dsvm-full-icehouse http://logs.openstack.org/68/123168/2/check/check-tempest-dsvm-full-icehouse/ec611ba : SUCCESS in 50m 39s\n- check-tempest-dsvm-neutron-icehouse http://logs.openstack.org/68/123168/2/check/check-tempest-dsvm-neutron-icehouse/8521eec : SUCCESS in 52m 50s\n- gate-python-swiftclient-pypy http://logs.openstack.org/68/123168/2/check/gate-python-swiftclient-pypy/92af2ea : SUCCESS in 1m 43s\n- check-swift-dsvm-functional http://logs.openstack.org/68/123168/2/check/check-swift-dsvm-functional/d70b041 : SUCCESS in 22m 47s","accounts_in_message":[],"_revision_number":2},{"id":"e918071a70becf983c9de6ac058d401c66ac95ba","author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"date":"2014-09-23 08:01:25.000000000","message":"Patch Set 2: Workflow-1\n\nWIP - looking at retaining process_options in service.py","accounts_in_message":[],"_revision_number":2},{"id":"f51fc97ecc4f4a203aaad6cd627d5e0ea94dcb61","author":{"_account_id":9216,"name":"Joel Wright","email":"joel.wright@gmail.com","username":"jjw-sohonet"},"date":"2014-09-23 08:08:56.000000000","message":"Patch Set 2:\n\nJust wanted to record the reasoning behind process_options() in this comment thread.\n\nprocess_options() was added in order to allow the SwiftService object to make use of the Openstack auth environment variables in a similar way to the shell code. I believe that the conflicting auth v2/v3 processing crept back in during a rebase onto master. I would prefer to see the code for modifying the keystone options moved to service.py where it can also be used by external projects. I believe that all the exit conditions for enforce_requires in parse_args could be retained by raising a service.SwiftError with an appropriate error message.","accounts_in_message":[],"_revision_number":2},{"id":"5bf85f85e193dabc9df146d74b6400a956184e5c","author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"date":"2014-09-23 13:37:10.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"592e8b2a1f39e8b238e8622949f320ed268daef9","author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"date":"2014-09-23 13:40:42.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"8303c79c7fdd4c54e95a2cf1f49c8261d4feba3f","author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"date":"2014-09-23 13:53:24.000000000","message":"Patch Set 4:\n\nLatest patch set leaves option processing in service.py and fixes the bug there, so as not to break other clients.\n\nHave discussed this with Joel and agreed that there is scope for further rationalisation/de-deduplication of the code in shell.parse_args and service.process_options. However, I am reluctant to rush into stripping code out of shell.parse_args() and moving it into service.py without checking through all the subsequent code paths for unforeseen consequences, so for the time being the option processing is duplicated in shell and service, which fixes the immediate bug.\n\nIn the longer term I\u0027d like to discuss whether *all* the option mangling is needed in SwiftService - e.g. handling \u0027old-style\u0027 -A -U -K options - or whether SwiftService should expect (and enforce) a \u0027clean\u0027 set of options. In which case shell.py would continue to handle old/new style options - some code would disappear from shell.parse_args and some code would disappear from service.process_opts.","accounts_in_message":[],"_revision_number":4},{"id":"ba78ed46268d97aefd02e3c22acdc9a7e4ecc07b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-09-23 17:43:25.000000000","message":"Patch Set 4: Verified-1\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGit#Test_Failures\n\n- gate-python-swiftclient-pep8 http://logs.openstack.org/68/123168/4/check/gate-python-swiftclient-pep8/e3c72f4 : SUCCESS in 1m 09s\n- gate-python-swiftclient-docs http://docs-draft.openstack.org/68/123168/4/check/gate-python-swiftclient-docs/470f50a/doc/build/html/ : SUCCESS in 1m 56s\n- gate-python-swiftclient-python26 http://logs.openstack.org/68/123168/4/check/gate-python-swiftclient-python26/4b594af : SUCCESS in 1m 28s\n- gate-python-swiftclient-python27 http://logs.openstack.org/68/123168/4/check/gate-python-swiftclient-python27/cc9116f : SUCCESS in 1m 12s\n- gate-python-swiftclient-python33 http://logs.openstack.org/68/123168/4/check/gate-python-swiftclient-python33/1a0e6d9 : SUCCESS in 3m 19s\n- check-tempest-dsvm-full http://logs.openstack.org/68/123168/4/check/check-tempest-dsvm-full/57b4dce : SUCCESS in 46m 36s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/68/123168/4/check/check-tempest-dsvm-postgres-full/22c438b : FAILURE in 1h 04m 10s\n- check-tempest-dsvm-neutron-full http://logs.openstack.org/68/123168/4/check/check-tempest-dsvm-neutron-full/31c3dda : SUCCESS in 1h 10m 43s\n- check-tempest-dsvm-neutron-heat-slow http://logs.openstack.org/68/123168/4/check/check-tempest-dsvm-neutron-heat-slow/5711f04 : SUCCESS in 25m 05s\n- check-grenade-dsvm http://logs.openstack.org/68/123168/4/check/check-grenade-dsvm/2a8e36e : SUCCESS in 44m 33s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/68/123168/4/check/gate-tempest-dsvm-large-ops/8fcf99f : SUCCESS in 26m 40s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/68/123168/4/check/gate-tempest-dsvm-neutron-large-ops/352d8f5 : SUCCESS in 19m 27s\n- check-tempest-dsvm-full-havana http://logs.openstack.org/68/123168/4/check/check-tempest-dsvm-full-havana/ebdf493 : SUCCESS in 32m 39s (non-voting)\n- check-tempest-dsvm-neutron-havana http://logs.openstack.org/68/123168/4/check/check-tempest-dsvm-neutron-havana/72084db : FAILURE in 7m 07s (non-voting)\n- check-tempest-dsvm-full-icehouse http://logs.openstack.org/68/123168/4/check/check-tempest-dsvm-full-icehouse/92f955c : FAILURE in 6m 25s\n- check-tempest-dsvm-neutron-icehouse http://logs.openstack.org/68/123168/4/check/check-tempest-dsvm-neutron-icehouse/5cfe8cf : SUCCESS in 54m 54s\n- gate-python-swiftclient-pypy http://logs.openstack.org/68/123168/4/check/gate-python-swiftclient-pypy/8cd0ed8 : SUCCESS in 1m 17s\n- check-swift-dsvm-functional http://logs.openstack.org/68/123168/4/check/check-swift-dsvm-functional/e07b0ea : SUCCESS in 20m 25s","accounts_in_message":[],"_revision_number":4},{"id":"3005bcbdae5b1f58877c40d54b3cd834e652cb87","author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"date":"2014-09-23 17:46:51.000000000","message":"Patch Set 4:\n\nrecheck no bug","accounts_in_message":[],"_revision_number":4},{"id":"9c28c7c6c654d756d6313dfd927961e59b0a227a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-09-24 01:33:05.000000000","message":"Patch Set 4: Verified+1\n\nBuild succeeded.\n\n- gate-python-swiftclient-pep8 http://logs.openstack.org/68/123168/4/check/gate-python-swiftclient-pep8/4ab5f0c : SUCCESS in 55s\n- gate-python-swiftclient-docs http://docs-draft.openstack.org/68/123168/4/check/gate-python-swiftclient-docs/fe52c6f/doc/build/html/ : SUCCESS in 41s\n- gate-python-swiftclient-python26 http://logs.openstack.org/68/123168/4/check/gate-python-swiftclient-python26/a117b9a : SUCCESS in 1m 16s\n- gate-python-swiftclient-python27 http://logs.openstack.org/68/123168/4/check/gate-python-swiftclient-python27/11b2da0 : SUCCESS in 41s\n- gate-python-swiftclient-python33 http://logs.openstack.org/68/123168/4/check/gate-python-swiftclient-python33/ec9fadb : SUCCESS in 4m 31s\n- check-tempest-dsvm-full http://logs.openstack.org/68/123168/4/check/check-tempest-dsvm-full/852d2c5 : SUCCESS in 54m 14s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/68/123168/4/check/check-tempest-dsvm-postgres-full/31590d4 : SUCCESS in 59m 52s\n- check-tempest-dsvm-neutron-full http://logs.openstack.org/68/123168/4/check/check-tempest-dsvm-neutron-full/3662246 : SUCCESS in 54m 45s\n- check-tempest-dsvm-neutron-heat-slow http://logs.openstack.org/68/123168/4/check/check-tempest-dsvm-neutron-heat-slow/60a1d0b : SUCCESS in 25m 22s\n- check-grenade-dsvm http://logs.openstack.org/68/123168/4/check/check-grenade-dsvm/fd28616 : SUCCESS in 49m 11s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/68/123168/4/check/gate-tempest-dsvm-large-ops/4495252 : SUCCESS in 25m 18s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/68/123168/4/check/gate-tempest-dsvm-neutron-large-ops/19aa308 : SUCCESS in 26m 58s\n- check-tempest-dsvm-full-havana http://logs.openstack.org/68/123168/4/check/check-tempest-dsvm-full-havana/962adec : SUCCESS in 36m 43s (non-voting)\n- check-tempest-dsvm-neutron-havana http://logs.openstack.org/68/123168/4/check/check-tempest-dsvm-neutron-havana/9b88149 : SUCCESS in 37m 24s (non-voting)\n- check-tempest-dsvm-full-icehouse http://logs.openstack.org/68/123168/4/check/check-tempest-dsvm-full-icehouse/5835281 : SUCCESS in 49m 40s\n- check-tempest-dsvm-neutron-icehouse http://logs.openstack.org/68/123168/4/check/check-tempest-dsvm-neutron-icehouse/4e701fa : SUCCESS in 57m 54s\n- gate-python-swiftclient-pypy http://logs.openstack.org/68/123168/4/check/gate-python-swiftclient-pypy/c178772 : SUCCESS in 2m 09s\n- check-swift-dsvm-functional http://logs.openstack.org/68/123168/4/check/check-swift-dsvm-functional/ae728d6 : SUCCESS in 21m 09s","accounts_in_message":[],"_revision_number":4},{"id":"2f7ca51e6e792f2a348bd1252f6997812564eeaa","author":{"_account_id":9216,"name":"Joel Wright","email":"joel.wright@gmail.com","username":"jjw-sohonet"},"date":"2014-09-24 16:12:08.000000000","message":"Patch Set 4: Code-Review+1\n\nThis all looks good to me and quickly fixes the regression whilst giving us the chance to discuss the amount of legacy option support we want for the SwiftService code later.","accounts_in_message":[],"_revision_number":4},{"id":"4545a23aa381ce7da540a7d57e0cfe4eaebdc8ff","author":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"date":"2014-09-24 16:26:17.000000000","message":"Patch Set 4:\n\n(1 comment)\n\nmanaging 3 version of API is going to be painful and more painful, I am getting those errors when running the tests :\n\nhttp://sprunge.us/XMPK\n\nit\u0027s cause i have some OS_* options in my own environement defined which should probably cleared/mocked out before running, i.e: if i do :\n\nfor x in $(env|grep OS_);do unset ${x%\u003d*};done\n\nbefore running the tests they all pass","accounts_in_message":[],"_revision_number":4},{"id":"3e9b0556558eecdb99b921629bdfa611dda3ef33","author":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"date":"2014-09-24 16:28:41.000000000","message":"Patch Set 4: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":4},{"id":"c948e565d3809bfb54dc07991331e8e8c2820432","author":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"date":"2014-09-24 16:36:09.000000000","message":"Patch Set 4: Code-Review+2\n\nafter chatting on irc i am fine with a quick followup patch fixing those unittests (with OS_ variable already set)","accounts_in_message":[],"_revision_number":4},{"id":"7aecc0891a13ec3a516d977e8c406a5c486c8d32","author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"date":"2014-09-24 17:19:50.000000000","message":"Uploaded patch set 5.","accounts_in_message":[],"_revision_number":5},{"id":"07e4b369271026764e9495e2702e226c2c5dd321","author":{"_account_id":330,"name":"John Dickinson","email":"me@not.mn","username":"notmyname"},"date":"2014-09-24 17:28:35.000000000","message":"Patch Set 5: Code-Review+2","accounts_in_message":[],"_revision_number":5},{"id":"aa50aabb272bdb095a8a28c5ddb04456b2b30f49","author":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"date":"2014-09-24 17:32:46.000000000","message":"Patch Set 5: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":5},{"id":"32f2ab9b7346fbe4c6025923a18f91e1ead024b1","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-09-24 19:24:09.000000000","message":"Patch Set 5: Verified-1\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGit#Test_Failures\n\n- gate-python-swiftclient-pep8 http://logs.openstack.org/68/123168/5/check/gate-python-swiftclient-pep8/120be64 : SUCCESS in 56s\n- gate-python-swiftclient-docs http://docs-draft.openstack.org/68/123168/5/check/gate-python-swiftclient-docs/6601559/doc/build/html/ : SUCCESS in 1m 01s\n- gate-python-swiftclient-python26 http://logs.openstack.org/68/123168/5/check/gate-python-swiftclient-python26/c7b5e6e : SUCCESS in 1m 05s\n- gate-python-swiftclient-python27 http://logs.openstack.org/68/123168/5/check/gate-python-swiftclient-python27/94f6b58 : SUCCESS in 1m 03s\n- gate-python-swiftclient-python33 http://logs.openstack.org/68/123168/5/check/gate-python-swiftclient-python33/97cd90e : SUCCESS in 3m 06s\n- check-tempest-dsvm-full http://logs.openstack.org/68/123168/5/check/check-tempest-dsvm-full/1c97f2e : SUCCESS in 53m 48s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/68/123168/5/check/check-tempest-dsvm-postgres-full/b98b7c6 : FAILURE in 48m 17s\n- check-tempest-dsvm-neutron-full http://logs.openstack.org/68/123168/5/check/check-tempest-dsvm-neutron-full/a2140d4 : SUCCESS in 1h 14m 43s\n- check-tempest-dsvm-neutron-heat-slow http://logs.openstack.org/68/123168/5/check/check-tempest-dsvm-neutron-heat-slow/c48058c : SUCCESS in 21m 35s\n- check-grenade-dsvm http://logs.openstack.org/68/123168/5/check/check-grenade-dsvm/e561164 : SUCCESS in 47m 10s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/68/123168/5/check/gate-tempest-dsvm-large-ops/090aca6 : SUCCESS in 25m 07s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/68/123168/5/check/gate-tempest-dsvm-neutron-large-ops/5ff62f8 : SUCCESS in 23m 50s\n- check-tempest-dsvm-full-havana http://logs.openstack.org/68/123168/5/check/check-tempest-dsvm-full-havana/6a61257 : SUCCESS in 37m 04s (non-voting)\n- check-tempest-dsvm-neutron-havana http://logs.openstack.org/68/123168/5/check/check-tempest-dsvm-neutron-havana/ebeb4f5 : SUCCESS in 53m 09s (non-voting)\n- check-tempest-dsvm-full-icehouse http://logs.openstack.org/68/123168/5/check/check-tempest-dsvm-full-icehouse/215a990 : SUCCESS in 48m 51s\n- check-tempest-dsvm-neutron-icehouse http://logs.openstack.org/68/123168/5/check/check-tempest-dsvm-neutron-icehouse/2a25dd7 : SUCCESS in 52m 34s\n- gate-python-swiftclient-pypy http://logs.openstack.org/68/123168/5/check/gate-python-swiftclient-pypy/cc3930a : SUCCESS in 1m 46s\n- check-swift-dsvm-functional http://logs.openstack.org/68/123168/5/check/check-swift-dsvm-functional/2c6eb20 : SUCCESS in 21m 07s","accounts_in_message":[],"_revision_number":5},{"id":"e530b87e6d131d59c534a362b6002f939058ce7c","author":{"_account_id":330,"name":"John Dickinson","email":"me@not.mn","username":"notmyname"},"date":"2014-09-24 19:35:32.000000000","message":"Patch Set 5:\n\nrecheck no bug","accounts_in_message":[],"_revision_number":5},{"id":"5eb6f5a86bbf5d772c86e48cb6376db21995fefc","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-09-24 21:12:43.000000000","message":"Patch Set 5: Verified+1\n\nBuild succeeded.\n\n- gate-python-swiftclient-pep8 http://logs.openstack.org/68/123168/5/check/gate-python-swiftclient-pep8/eacbbc6 : SUCCESS in 53s\n- gate-python-swiftclient-docs http://docs-draft.openstack.org/68/123168/5/check/gate-python-swiftclient-docs/918e058/doc/build/html/ : SUCCESS in 59s\n- gate-python-swiftclient-python26 http://logs.openstack.org/68/123168/5/check/gate-python-swiftclient-python26/e82f6b4 : SUCCESS in 1m 41s\n- gate-python-swiftclient-python27 http://logs.openstack.org/68/123168/5/check/gate-python-swiftclient-python27/528e5cb : SUCCESS in 58s\n- gate-python-swiftclient-python33 http://logs.openstack.org/68/123168/5/check/gate-python-swiftclient-python33/05e6c19 : SUCCESS in 3m 13s\n- check-tempest-dsvm-full http://logs.openstack.org/68/123168/5/check/check-tempest-dsvm-full/0af9249 : SUCCESS in 44m 58s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/68/123168/5/check/check-tempest-dsvm-postgres-full/6c6f537 : SUCCESS in 49m 17s\n- check-tempest-dsvm-neutron-full http://logs.openstack.org/68/123168/5/check/check-tempest-dsvm-neutron-full/d4656de : SUCCESS in 1h 03m 12s\n- check-tempest-dsvm-neutron-heat-slow http://logs.openstack.org/68/123168/5/check/check-tempest-dsvm-neutron-heat-slow/e77073c : SUCCESS in 26m 01s\n- check-grenade-dsvm http://logs.openstack.org/68/123168/5/check/check-grenade-dsvm/2a90d3a : SUCCESS in 46m 36s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/68/123168/5/check/gate-tempest-dsvm-large-ops/20559c9 : SUCCESS in 25m 17s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/68/123168/5/check/gate-tempest-dsvm-neutron-large-ops/fc3abe5 : SUCCESS in 24m 12s\n- check-tempest-dsvm-full-havana http://logs.openstack.org/68/123168/5/check/check-tempest-dsvm-full-havana/d1bbac8 : SUCCESS in 38m 29s (non-voting)\n- check-tempest-dsvm-neutron-havana http://logs.openstack.org/68/123168/5/check/check-tempest-dsvm-neutron-havana/9a9581c : SUCCESS in 36m 35s (non-voting)\n- check-tempest-dsvm-full-icehouse http://logs.openstack.org/68/123168/5/check/check-tempest-dsvm-full-icehouse/0e90412 : SUCCESS in 52m 49s\n- check-tempest-dsvm-neutron-icehouse http://logs.openstack.org/68/123168/5/check/check-tempest-dsvm-neutron-icehouse/4a57a47 : SUCCESS in 59m 55s\n- gate-python-swiftclient-pypy http://logs.openstack.org/68/123168/5/check/gate-python-swiftclient-pypy/bc7b2de : SUCCESS in 1m 15s\n- check-swift-dsvm-functional http://logs.openstack.org/68/123168/5/check/check-swift-dsvm-functional/5361d84 : SUCCESS in 17m 23s","accounts_in_message":[],"_revision_number":5},{"id":"ada924e76449fa93dc8fd6a3a652fee3bcd43481","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-09-24 21:12:45.000000000","message":"Patch Set 5: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":5},{"id":"f8363c394112001a5a63bf841771a2af8abfa536","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-09-25 09:15:22.000000000","message":"Patch Set 5: Verified+2\n\nBuild succeeded.\n\n- gate-python-swiftclient-docs http://docs-draft.openstack.org/68/123168/5/gate/gate-python-swiftclient-docs/9a3f10b/doc/build/html/ : SUCCESS in 1m 01s\n- gate-python-swiftclient-pep8 http://logs.openstack.org/68/123168/5/gate/gate-python-swiftclient-pep8/83174d0 : SUCCESS in 1m 00s\n- gate-python-swiftclient-python26 http://logs.openstack.org/68/123168/5/gate/gate-python-swiftclient-python26/fd4ae22 : SUCCESS in 56s\n- gate-python-swiftclient-python27 http://logs.openstack.org/68/123168/5/gate/gate-python-swiftclient-python27/5c4b9d7 : SUCCESS in 1m 23s\n- gate-python-swiftclient-python33 http://logs.openstack.org/68/123168/5/gate/gate-python-swiftclient-python33/e5f6c8b : SUCCESS in 3m 02s\n- gate-tempest-dsvm-full http://logs.openstack.org/68/123168/5/gate/gate-tempest-dsvm-full/95b07a4 : SUCCESS in 1h 02m 56s\n- gate-tempest-dsvm-postgres-full http://logs.openstack.org/68/123168/5/gate/gate-tempest-dsvm-postgres-full/14719c6 : SUCCESS in 1h 05m 11s\n- gate-tempest-dsvm-neutron-full http://logs.openstack.org/68/123168/5/gate/gate-tempest-dsvm-neutron-full/726e09c : SUCCESS in 1h 20m 23s\n- gate-tempest-dsvm-neutron-heat-slow http://logs.openstack.org/68/123168/5/gate/gate-tempest-dsvm-neutron-heat-slow/74e7633 : SUCCESS in 19m 52s\n- gate-grenade-dsvm http://logs.openstack.org/68/123168/5/gate/gate-grenade-dsvm/c7decea : SUCCESS in 48m 50s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/68/123168/5/gate/gate-tempest-dsvm-large-ops/18f2e49 : SUCCESS in 27m 43s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/68/123168/5/gate/gate-tempest-dsvm-neutron-large-ops/c6f5b8e : SUCCESS in 24m 25s\n- gate-python-swiftclient-pypy http://logs.openstack.org/68/123168/5/gate/gate-python-swiftclient-pypy/836f9ab : SUCCESS in 6m 53s\n- gate-swift-dsvm-functional http://logs.openstack.org/68/123168/5/gate/gate-swift-dsvm-functional/7f4003e : SUCCESS in 21m 01s","accounts_in_message":[],"_revision_number":5},{"id":"7f1e766ca2f2bc7d71c048604c23e6575982f5c3","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-09-25 09:15:22.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":5}],"current_revision_number":5,"current_revision":"f90d7f28e504be045e59b395aee0abc057417f8f","revisions":{"a073e23567b51e9ea99205fa43c55c5863006fc5":{"kind":"REWORK","_number":1,"created":"2014-09-22 16:07:05.000000000","uploader":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"ref":"refs/changes/68/123168/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-swiftclient","ref":"refs/changes/68/123168/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/68/123168/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/68/123168/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/68/123168/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-swiftclient refs/changes/68/123168/1"}}},"commit":{"parents":[{"commit":"8f1b394325804c23ac18e7f9da6cb56a3b95eed2","subject":"Stop creating extraneous directories","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/8f1b394325804c23ac18e7f9da6cb56a3b95eed2"}]}],"author":{"name":"Alistair Coles","email":"alistair.coles@hp.com","date":"2014-09-22 10:52:44.000000000","tz":60},"committer":{"name":"Alistair Coles","email":"alistair.coles@hp.com","date":"2014-09-22 16:06:32.000000000","tz":60},"subject":"Fix bug with some OS options not being passed to client","message":"Fix bug with some OS options not being passed to client\n\nFixes a regression that is preventing swiftclient from\nauthenticating using keystone v3 options.\n\nswiftclient/shell.py processes the dict of command\nline options to set up a child dict (\u0027os_options\u0027)\nof keystone auth specific options (line 960). The\nprocessing includes stripping --os- prefixes from\nthe command line options before adding keys to\nos_options.\n\nA recent patch https://review.openstack.org/#/c/85453/\nintroduced a duplication of this option processing\nin service.py (line 79) which replaces the already\ncreated os_options, but omits keystone v3 related\noptions. Consequently the keystone v3 options are\nnot being passed to the client get_auth() method.\n\nThis patch removes the duplicate processing and adds\nunit tests in test_shell.py to verify that command\nline options are correctly passed to the client\nget_auth method.\n\nThe MockHttpTest class is re-used in test_shell.py,\nso it is moved from test_swiftclient.py\nto tests/unit/utils.py\n\nCloses-bug: #1372465\n\nChange-Id: I4fed013cdb8936509609d06093337cc147ade0d6\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/a073e23567b51e9ea99205fa43c55c5863006fc5"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/a073e23567b51e9ea99205fa43c55c5863006fc5"}]},"branch":"refs/heads/master"},"c79cb5a325317a074afb0715f408b17660e619b1":{"kind":"REWORK","_number":2,"created":"2014-09-22 18:05:02.000000000","uploader":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"ref":"refs/changes/68/123168/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-swiftclient","ref":"refs/changes/68/123168/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/68/123168/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/68/123168/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/68/123168/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-swiftclient refs/changes/68/123168/2"}}},"commit":{"parents":[{"commit":"8f1b394325804c23ac18e7f9da6cb56a3b95eed2","subject":"Stop creating extraneous directories","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/8f1b394325804c23ac18e7f9da6cb56a3b95eed2"}]}],"author":{"name":"Alistair Coles","email":"alistair.coles@hp.com","date":"2014-09-22 10:52:44.000000000","tz":60},"committer":{"name":"Alistair Coles","email":"alistair.coles@hp.com","date":"2014-09-22 18:04:29.000000000","tz":60},"subject":"Fix bug with some OS options not being passed to client","message":"Fix bug with some OS options not being passed to client\n\nFixes a regression that is preventing swiftclient from\nauthenticating using keystone v3 options.\n\nswiftclient/shell.py processes the dict of command\nline options to set up a child dict (\u0027os_options\u0027)\nof keystone auth specific options (line 960). The\nprocessing includes stripping --os- prefixes from\nthe command line options before adding keys to\nos_options.\n\nA recent patch https://review.openstack.org/#/c/85453/\nintroduced a duplication of this option processing\nin service.py (line 79) which replaces the already\ncreated os_options, but omits keystone v3 related\noptions. Consequently the keystone v3 options are\nnot being passed to the client get_auth() method.\n\nThis patch removes the duplicate processing and adds\nunit tests in test_shell.py to verify that command\nline options are correctly passed to the client\nget_auth method.\n\nThe MockHttpTest class is re-used in test_shell.py,\nso it is moved from test_swiftclient.py\nto tests/unit/utils.py\n\nCloses-bug: #1372465\n\nChange-Id: I4fed013cdb8936509609d06093337cc147ade0d6\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/c79cb5a325317a074afb0715f408b17660e619b1"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/c79cb5a325317a074afb0715f408b17660e619b1"}]},"branch":"refs/heads/master"},"4797edc360a92853e59842e60dfe903ddd4911c6":{"kind":"REWORK","_number":3,"created":"2014-09-23 13:37:10.000000000","uploader":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"ref":"refs/changes/68/123168/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-swiftclient","ref":"refs/changes/68/123168/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/68/123168/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/68/123168/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/68/123168/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-swiftclient refs/changes/68/123168/3"}}},"commit":{"parents":[{"commit":"8f1b394325804c23ac18e7f9da6cb56a3b95eed2","subject":"Stop creating extraneous directories","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/8f1b394325804c23ac18e7f9da6cb56a3b95eed2"}]}],"author":{"name":"Alistair Coles","email":"alistair.coles@hp.com","date":"2014-09-22 10:52:44.000000000","tz":60},"committer":{"name":"Alistair Coles","email":"alistair.coles@hp.com","date":"2014-09-23 13:36:24.000000000","tz":60},"subject":"Fix bug with some OS options not being passed to client","message":"Fix bug with some OS options not being passed to client\n\nFixes a regression that is preventing swiftclient from\nauthenticating using keystone v3 options.\n\nswiftclient/shell.py processes the dict of command\nline options to set up a child dict (\u0027os_options\u0027)\nof keystone auth specific options (line 960). The\nprocessing includes stripping --os- prefixes from\nthe command line options before adding keys to\nos_options.\n\nA recent patch https://review.openstack.org/#/c/85453/\nintroduced a duplication of this option processing\nin service.py (line 79) which replaces the os_options\ncreated in shell.py, but omits keystone v3 related\noptions. Consequently the keystone v3 options are\nnot being passed to the client get_auth() method.\n\nThis patch adds the keystone v3 related options to\nthe option processing in service.py.\n\nFor pragmatic reasons (i.e. fixing the bug quickly)\nthe option processing code has not been removed from\nparse_args in shell.py. It is likely that the code in\nparse_args is now redundant, but all code paths between\nparse_args and process_options should be inspected and\ntest coverage added before removing that code.\n\nUnit tests have been added in test_shell.py to verify\nthat command line options are correctly passed to the\nclient get_auth method.\n\nThe MockHttpTest class is re-used in test_shell.py,\nso it is moved from test_swiftclient.py\nto tests/unit/utils.py\n\nCloses-bug: #1372465\n\nChange-Id: I4fed013cdb8936509609d06093337cc147ade0d6\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/4797edc360a92853e59842e60dfe903ddd4911c6"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/4797edc360a92853e59842e60dfe903ddd4911c6"}]},"branch":"refs/heads/master"},"0e1b47a5ae8457a3fe227fc9c6f693bef725d1b3":{"kind":"REWORK","_number":4,"created":"2014-09-23 13:40:42.000000000","uploader":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"ref":"refs/changes/68/123168/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-swiftclient","ref":"refs/changes/68/123168/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/68/123168/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/68/123168/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/68/123168/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-swiftclient refs/changes/68/123168/4"}}},"commit":{"parents":[{"commit":"8f1b394325804c23ac18e7f9da6cb56a3b95eed2","subject":"Stop creating extraneous directories","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/8f1b394325804c23ac18e7f9da6cb56a3b95eed2"}]}],"author":{"name":"Alistair Coles","email":"alistair.coles@hp.com","date":"2014-09-22 10:52:44.000000000","tz":60},"committer":{"name":"Alistair Coles","email":"alistair.coles@hp.com","date":"2014-09-23 13:40:16.000000000","tz":60},"subject":"Fix bug with some OS options not being passed to client","message":"Fix bug with some OS options not being passed to client\n\nFixes a regression that is preventing swiftclient from\nauthenticating using keystone v3 options.\n\nswiftclient/shell.py processes the dict of command\nline options to set up a child dict (\u0027os_options\u0027)\nof keystone auth specific options (line 960). The\nprocessing includes stripping --os- prefixes from\nthe command line options before adding keys to\nos_options.\n\nA recent patch https://review.openstack.org/#/c/85453/\nintroduced a duplication of this option processing\nin service.py (line 79) which replaces the os_options\ncreated in shell.py, but omits keystone v3 related\noptions. Consequently the keystone v3 options are\nnot being passed to the client get_auth() method.\n\nThis patch adds the keystone v3 related options to\nthe option processing in service.py.\n\nFor pragmatic reasons (i.e. fixing the bug quickly)\nthe option processing code has not been removed from\nparse_args in shell.py. It is likely that the code in\nparse_args is now redundant, but all code paths between\nparse_args and process_options should be inspected and\ntest coverage added before removing that code.\n\nUnit tests have been added in test_shell.py to verify\nthat command line options are correctly passed to the\nclient get_auth method.\n\nThe MockHttpTest class is re-used in test_shell.py,\nso it is moved from test_swiftclient.py\nto tests/unit/utils.py\n\nCloses-bug: #1372465\n\nChange-Id: I4fed013cdb8936509609d06093337cc147ade0d6\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/0e1b47a5ae8457a3fe227fc9c6f693bef725d1b3"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/0e1b47a5ae8457a3fe227fc9c6f693bef725d1b3"}]},"branch":"refs/heads/master"},"f90d7f28e504be045e59b395aee0abc057417f8f":{"kind":"REWORK","_number":5,"created":"2014-09-24 17:19:50.000000000","uploader":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"ref":"refs/changes/68/123168/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-swiftclient","ref":"refs/changes/68/123168/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/68/123168/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/68/123168/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/68/123168/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-swiftclient refs/changes/68/123168/5"}}},"commit":{"parents":[{"commit":"8f1b394325804c23ac18e7f9da6cb56a3b95eed2","subject":"Stop creating extraneous directories","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/8f1b394325804c23ac18e7f9da6cb56a3b95eed2"}]}],"author":{"name":"Alistair Coles","email":"alistair.coles@hp.com","date":"2014-09-22 10:52:44.000000000","tz":60},"committer":{"name":"Alistair Coles","email":"alistair.coles@hp.com","date":"2014-09-24 17:19:12.000000000","tz":60},"subject":"Fix bug with some OS options not being passed to client","message":"Fix bug with some OS options not being passed to client\n\nFixes a regression that is preventing swiftclient from\nauthenticating using keystone v3 options.\n\nswiftclient/shell.py processes the dict of command\nline options to set up a child dict (\u0027os_options\u0027)\nof keystone auth specific options (line 960). The\nprocessing includes stripping --os- prefixes from\nthe command line options before adding keys to\nos_options.\n\nA recent patch https://review.openstack.org/#/c/85453/\nintroduced a duplication of this option processing\nin service.py (line 79) which replaces the os_options\ncreated in shell.py, but omits keystone v3 related\noptions. Consequently the keystone v3 options are\nnot being passed to the client get_auth() method.\n\nThis patch adds the keystone v3 related options to\nthe option processing in service.py.\n\nFor pragmatic reasons (i.e. fixing the bug quickly)\nthe option processing code has not been removed from\nparse_args in shell.py. It is likely that the code in\nparse_args is now redundant, but all code paths between\nparse_args and process_options should be inspected and\ntest coverage added before removing that code.\n\nUnit tests have been added in test_shell.py to verify\nthat command line options are correctly passed to the\nclient get_auth method.\n\nThe MockHttpTest class is re-used in test_shell.py,\nso it is moved from test_swiftclient.py\nto tests/unit/utils.py\n\nCloses-bug: #1372465\n\nChange-Id: I4fed013cdb8936509609d06093337cc147ade0d6\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/f90d7f28e504be045e59b395aee0abc057417f8f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/f90d7f28e504be045e59b395aee0abc057417f8f"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}