)]}'
{"id":"openstack%2Fpython-swiftclient~124009","triplet_id":"openstack%2Fpython-swiftclient~master~I5d100f81115e74878d510326acb5777e6a3626c8","project":"openstack/python-swiftclient","branch":"master","topic":"p-os-env-test-setup","hashtags":[],"change_id":"I5d100f81115e74878d510326acb5777e6a3626c8","subject":"Fix unit tests failing when OS_ env vars are set","status":"MERGED","created":"2014-09-25 11:00:01.000000000","updated":"2014-09-26 15:48:49.000000000","submitted":"2014-09-26 15:48:49.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"a4bc786172e31440afa8cd99cbb3dcce41b431a9","_number":124009,"virtual_id_number":124009,"owner":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2014-09-26 15:48:49.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":7479,"name":"paul luse","email":"paul.e.luse@intel.com","username":"peluse"},{"value":0,"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":7479,"name":"paul luse","email":"paul.e.luse@intel.com","username":"peluse"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2014-09-25 19:51:12.000000000","_account_id":7479,"name":"paul luse","email":"paul.e.luse@intel.com","username":"peluse"},{"value":2,"date":"2014-09-25 17:59:33.000000000","_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":7479,"name":"paul luse","email":"paul.e.luse@intel.com","username":"peluse"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2014-09-25 19:51:12.000000000","_account_id":7479,"name":"paul luse","email":"paul.e.luse@intel.com","username":"peluse"},{"value":0,"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},{"_account_id":7479,"name":"paul luse","email":"paul.e.luse@intel.com","username":"peluse"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2014-09-25 17:59:33.000000000","updated_by":{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},"reviewer":{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},"state":"REVIEWER"},{"updated":"2014-09-25 19:51:12.000000000","updated_by":{"_account_id":7479,"name":"paul luse","email":"paul.e.luse@intel.com","username":"peluse"},"reviewer":{"_account_id":7479,"name":"paul luse","email":"paul.e.luse@intel.com","username":"peluse"},"state":"REVIEWER"},{"updated":"2014-09-26 15:48:49.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"f220b79de753124caf3aa8b111b5a3cb4ab3bdcc","author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"date":"2014-09-25 11:00:01.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"de25499bb7cc02f99c83931409462c5e6c0f62c8","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-09-25 12:49:27.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded.\n\n- gate-python-swiftclient-pep8 http://logs.openstack.org/09/124009/1/check/gate-python-swiftclient-pep8/7d2dcec : SUCCESS in 43s\n- gate-python-swiftclient-docs http://docs-draft.openstack.org/09/124009/1/check/gate-python-swiftclient-docs/401c57d/doc/build/html/ : SUCCESS in 1m 01s\n- gate-python-swiftclient-python26 http://logs.openstack.org/09/124009/1/check/gate-python-swiftclient-python26/57a9f28 : SUCCESS in 56s\n- gate-python-swiftclient-python27 http://logs.openstack.org/09/124009/1/check/gate-python-swiftclient-python27/78997bc : SUCCESS in 1m 00s\n- gate-python-swiftclient-python33 http://logs.openstack.org/09/124009/1/check/gate-python-swiftclient-python33/5092793 : SUCCESS in 3m 05s\n- check-tempest-dsvm-full http://logs.openstack.org/09/124009/1/check/check-tempest-dsvm-full/83bee7e : SUCCESS in 54m 49s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/09/124009/1/check/check-tempest-dsvm-postgres-full/636ef14 : SUCCESS in 54m 22s\n- check-tempest-dsvm-neutron-full http://logs.openstack.org/09/124009/1/check/check-tempest-dsvm-neutron-full/917d19a : SUCCESS in 51m 16s\n- check-tempest-dsvm-neutron-heat-slow http://logs.openstack.org/09/124009/1/check/check-tempest-dsvm-neutron-heat-slow/bb1cec8 : SUCCESS in 24m 02s\n- check-grenade-dsvm http://logs.openstack.org/09/124009/1/check/check-grenade-dsvm/6f49042 : SUCCESS in 47m 18s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/09/124009/1/check/gate-tempest-dsvm-large-ops/1cc0ea7 : SUCCESS in 24m 20s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/09/124009/1/check/gate-tempest-dsvm-neutron-large-ops/f6ad7a7 : SUCCESS in 19m 20s\n- check-tempest-dsvm-full-havana http://logs.openstack.org/09/124009/1/check/check-tempest-dsvm-full-havana/42d2e26 : SUCCESS in 35m 54s (non-voting)\n- check-tempest-dsvm-neutron-havana http://logs.openstack.org/09/124009/1/check/check-tempest-dsvm-neutron-havana/ee076b8 : SUCCESS in 35m 22s (non-voting)\n- check-tempest-dsvm-full-icehouse http://logs.openstack.org/09/124009/1/check/check-tempest-dsvm-full-icehouse/308b482 : SUCCESS in 48m 24s\n- check-tempest-dsvm-neutron-icehouse http://logs.openstack.org/09/124009/1/check/check-tempest-dsvm-neutron-icehouse/7002eb6 : SUCCESS in 55m 26s\n- gate-python-swiftclient-pypy http://logs.openstack.org/09/124009/1/check/gate-python-swiftclient-pypy/5aa2ee2 : SUCCESS in 1m 26s\n- check-swift-dsvm-functional http://logs.openstack.org/09/124009/1/check/check-swift-dsvm-functional/a30ecbc : SUCCESS in 20m 51s","accounts_in_message":[],"_revision_number":1},{"id":"359b142a40dd7e7413a54f3c93cef8e78fe67fde","author":{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},"date":"2014-09-25 17:59:33.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"d322dac62316b17811bb0c6253cb3afe38b166ac","author":{"_account_id":7479,"name":"paul luse","email":"paul.e.luse@intel.com","username":"peluse"},"date":"2014-09-25 19:51:12.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"a44599367a304bd577bec8d1259c95cef593448f","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-09-25 19:51:13.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"5fdd123d59f7bdb8668c13499f5bcd7adabe0c4d","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-09-26 01:11:59.000000000","message":"Patch Set 1:\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"c06b1f71296634e40fa963b3f5b9aaa964cfb7cf","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-09-26 15:48:49.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded.\n\n- gate-python-swiftclient-docs http://docs-draft.openstack.org/09/124009/1/gate/gate-python-swiftclient-docs/732ddb6/doc/build/html/ : SUCCESS in 1m 44s\n- gate-python-swiftclient-pep8 http://logs.openstack.org/09/124009/1/gate/gate-python-swiftclient-pep8/eba2d52 : SUCCESS in 1m 41s\n- gate-python-swiftclient-python26 http://logs.openstack.org/09/124009/1/gate/gate-python-swiftclient-python26/a07d250 : SUCCESS in 2m 33s\n- gate-python-swiftclient-python27 http://logs.openstack.org/09/124009/1/gate/gate-python-swiftclient-python27/9907628 : SUCCESS in 56s\n- gate-python-swiftclient-python33 http://logs.openstack.org/09/124009/1/gate/gate-python-swiftclient-python33/f802225 : SUCCESS in 3m 39s\n- gate-tempest-dsvm-full http://logs.openstack.org/09/124009/1/gate/gate-tempest-dsvm-full/7170de8 : SUCCESS in 52m 47s\n- gate-tempest-dsvm-postgres-full http://logs.openstack.org/09/124009/1/gate/gate-tempest-dsvm-postgres-full/9000f9a : SUCCESS in 1h 01m 21s\n- gate-tempest-dsvm-neutron-full http://logs.openstack.org/09/124009/1/gate/gate-tempest-dsvm-neutron-full/51ed568 : SUCCESS in 1h 07m 34s\n- gate-tempest-dsvm-neutron-heat-slow http://logs.openstack.org/09/124009/1/gate/gate-tempest-dsvm-neutron-heat-slow/c752642 : SUCCESS in 28m 30s\n- gate-grenade-dsvm http://logs.openstack.org/09/124009/1/gate/gate-grenade-dsvm/752a3f6 : SUCCESS in 54m 26s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/09/124009/1/gate/gate-tempest-dsvm-large-ops/50c6252 : SUCCESS in 29m 54s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/09/124009/1/gate/gate-tempest-dsvm-neutron-large-ops/be89866 : SUCCESS in 21m 34s\n- gate-python-swiftclient-pypy http://logs.openstack.org/09/124009/1/gate/gate-python-swiftclient-pypy/a6d72e7 : SUCCESS in 2m 33s\n- gate-swift-dsvm-functional http://logs.openstack.org/09/124009/1/gate/gate-swift-dsvm-functional/f710ccd : SUCCESS in 17m 53s","accounts_in_message":[],"_revision_number":1},{"id":"1238741d9052a4db67f4ac9815489663d823b37a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-09-26 15:48:49.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"b13c84b2ef8a7fee31de2a77b66b50370e6968e5","revisions":{"b13c84b2ef8a7fee31de2a77b66b50370e6968e5":{"kind":"REWORK","_number":1,"created":"2014-09-25 11:00:01.000000000","uploader":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"ref":"refs/changes/09/124009/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-swiftclient","ref":"refs/changes/09/124009/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/09/124009/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/09/124009/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/09/124009/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-swiftclient refs/changes/09/124009/1"}}},"commit":{"parents":[{"commit":"8f1b394325804c23ac18e7f9da6cb56a3b95eed2","subject":"Stop creating extraneous directories","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/8f1b394325804c23ac18e7f9da6cb56a3b95eed2"}]}],"author":{"name":"Alistair Coles","email":"alistair.coles@hp.com","date":"2014-09-25 10:34:48.000000000","tz":60},"committer":{"name":"Alistair Coles","email":"alistair.coles@hp.com","date":"2014-09-25 10:44:39.000000000","tz":60},"subject":"Fix unit tests failing when OS_ env vars are set","message":"Fix unit tests failing when OS_ env vars are set\n\ntests/unit/test_shell.py:TestParsing tests can fail if\nthere are OS_* variables set in the environment. There\nis already code in the test setUp to remove ST_* variables,\nso we should do the same for OS_* variables.\n\nThis patch also changes the mechanism used to remove and\nthen restore any unwanted variables found in os.environ.\n\nThe existing setUp() takes a copy of os.environ and then\ndeletes any ST_* variables in the original. In tearDown() it\nsets os.environ as the copy. However, the environ imported\ninto shell.py remains pointing to the original os.environ\nobject. So after the first call to tearDown, subsequent\nmocking of os.environ has no effect on shell.environ.\nThis renders some of the tests ineffective e.g.\ntest_insufficient_env_vars_v3 is not actually setting any\nvars in shell.environ.\n\nThe issue can be provoked by repeating a test:\nnosetests -w tests/unit/ test_shell.py:TestParsing.test_args_v3 \\\n test_shell.py:TestParsing.test_args_v3\n\nThe test will pass first time and fail second time.\n\nChange-Id: I5d100f81115e74878d510326acb5777e6a3626c8\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/b13c84b2ef8a7fee31de2a77b66b50370e6968e5"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/b13c84b2ef8a7fee31de2a77b66b50370e6968e5"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}