)]}'
{"bin/swift":[{"author":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"change_message_id":"c0d3de296458ebdc434d3b272ad3da7de8e53d27","unresolved":false,"context_lines":[{"line_number":1131,"context_line":"    parser.add_option(\u0027--os-region-name\u0027,"},{"line_number":1132,"context_line":"                      metavar\u003d\u0027\u003cregion-name\u003e\u0027,"},{"line_number":1133,"context_line":"                      default\u003denviron.get(\u0027OS_REGION_NAME\u0027),"},{"line_number":1134,"context_line":"                      help\u003d\u0027Openstack region name.\u0027"},{"line_number":1135,"context_line":"                           \u0027Defaults to env[OS_REGION_NAME]\u0027)"},{"line_number":1136,"context_line":"    parser.add_option(\u0027--os_region_name\u0027,"},{"line_number":1137,"context_line":"                      help\u003dSUPPRESS_HELP)"}],"source_content_type":"text/x-swift","patch_set":4,"id":"AAAALH%2F%2FdJs%3D","line":1134,"updated":"2012-09-10 09:38:30.000000000","message":"Any chances to add a space after the dot here, (there is other that may be need to be fixed with an other patch).","commit_id":"a3f0fbb2fb4155eed2cb56a7232c0ca5d61aa966"}],"swiftclient/client.py":[{"author":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"change_message_id":"08e335b7e18e87b80fdb80c666396ced9dc11624","unresolved":false,"context_lines":[{"line_number":243,"context_line":"            tenant_name\u003dos_options.get(\u0027tenant_name\u0027),"},{"line_number":244,"context_line":"            tenant_id\u003dos_options.get(\u0027tenant_id\u0027),"},{"line_number":245,"context_line":"            auth_url\u003dauth_url)"},{"line_number":246,"context_line":"    except exceptions.Unauthorized, err:"},{"line_number":247,"context_line":"        raise ClientException(\u0027Unauthorised. Check username, password,\u0027"},{"line_number":248,"context_line":"            \u0027and tenant name/id\u0027)"},{"line_number":249,"context_line":"    service_type \u003d os_options.get(\u0027service_type\u0027) or \u0027object-store\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAALH%2F%2FgB8%3D","line":246,"updated":"2012-09-05 21:41:27.000000000","message":"Nice but technically this should be another commits.","commit_id":"c16bd8955f05e528a600438adf94f151a57214b3"},{"author":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"change_message_id":"08e335b7e18e87b80fdb80c666396ced9dc11624","unresolved":false,"context_lines":[{"line_number":253,"context_line":"            attr\u003d\u0027region\u0027, filter_value\u003dos_options.get(\u0027region_name\u0027),"},{"line_number":254,"context_line":"            service_type\u003dservice_type,"},{"line_number":255,"context_line":"            endpoint_type\u003dendpoint_type)"},{"line_number":256,"context_line":"    except exceptions.EndpointNotFound:"},{"line_number":257,"context_line":"        raise ClientException(\u0027Endpoint for %s not found - \u0027"},{"line_number":258,"context_line":"            \u0027have you specified a region?\u0027 % service_type)"},{"line_number":259,"context_line":"    return (endpoint, _ksclient.auth_token)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAALH%2F%2FgBw%3D","line":256,"updated":"2012-09-05 21:41:27.000000000","message":"There is not tests for this (and the other Unauthorized).","commit_id":"c16bd8955f05e528a600438adf94f151a57214b3"},{"author":{"_account_id":616,"name":"Mark Washenberger","email":"mark.washenberger@markwash.net","username":"markwash"},"change_message_id":"8f69479e7a9671607ee10035d70257f698955f17","unresolved":false,"context_lines":[{"line_number":247,"context_line":"    try:"},{"line_number":248,"context_line":"        endpoint \u003d _ksclient.service_catalog.url_for("},{"line_number":249,"context_line":"            attr\u003d\u0027region\u0027,"},{"line_number":250,"context_line":"            filter_value\u003dos_options.get(\u0027region_name\u0027),"},{"line_number":251,"context_line":"            service_type\u003dservice_type,"},{"line_number":252,"context_line":"            endpoint_type\u003dendpoint_type)"},{"line_number":253,"context_line":"    except exceptions.EndpointNotFound:"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAALH%2F%2Fbnk%3D","line":250,"updated":"2012-09-11 20:57:12.000000000","message":"if region_name is not specified, the filter_value will be None. However, service_catalog is going to do this check:\n\n endpoints \u003d service[\u0027endpoints\u0027]\n for endpoint in endpoints:\n      if not filter_value or endpoint.get(attr) \u003d\u003d filter_value:\n          return endpoint[endpoint_type]\n\nThis implies that if os_region is not specified and the region attribute is set on an endpoint, it will not find any match. Is that okay?\n\nWould it be better to say\n\n filter_key \u003d None\n region_name \u003d os_options.get(\u0027region_name\u0027)\n if region_name:\n     filter_key \u003d \u0027region\u0027\n\n endpoint \u003d _ksclient.service_catalog.url_for(\n     attr\u003dfilter_key,\n     filter_value\u003dregion_name,\n     ...\n\n\n?","commit_id":"68d1550f15a6ec6f51973af2e27f3a6943b6305f"},{"author":{"_account_id":616,"name":"Mark Washenberger","email":"mark.washenberger@markwash.net","username":"markwash"},"change_message_id":"065baa32926e0bbb597eae18495387633ceaa7c6","unresolved":false,"context_lines":[{"line_number":247,"context_line":"    try:"},{"line_number":248,"context_line":"        endpoint \u003d _ksclient.service_catalog.url_for("},{"line_number":249,"context_line":"            attr\u003d\u0027region\u0027,"},{"line_number":250,"context_line":"            filter_value\u003dos_options.get(\u0027region_name\u0027),"},{"line_number":251,"context_line":"            service_type\u003dservice_type,"},{"line_number":252,"context_line":"            endpoint_type\u003dendpoint_type)"},{"line_number":253,"context_line":"    except exceptions.EndpointNotFound:"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAALH%2F%2FbYg%3D","line":250,"in_reply_to":"AAAALH%2F%2Fbnk%3D","updated":"2012-09-12 04:46:08.000000000","message":"Apparently I did not get enough sleep today!\n\nRereading my comment, I see the current code will work nicely.","commit_id":"68d1550f15a6ec6f51973af2e27f3a6943b6305f"}],"tests/test_swiftclient.py":[{"author":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"change_message_id":"08e335b7e18e87b80fdb80c666396ced9dc11624","unresolved":false,"context_lines":[{"line_number":213,"context_line":"        os_options\u003d{\u0027service_type\u0027: \u0027object-store\u0027,"},{"line_number":214,"context_line":"                    \u0027endpoint_type\u0027: \u0027internalURL\u0027,"},{"line_number":215,"context_line":"                    \u0027tenant_name\u0027: \u0027asdf\u0027,"},{"line_number":216,"context_line":"                    \u0027regin_name\u0027: \u0027region-a\u0027}"},{"line_number":217,"context_line":"        c.get_keystoneclient_2_0 \u003d fake_get_keystoneclient_2_0(os_options)"},{"line_number":218,"context_line":"        url, token \u003d c.get_auth(\u0027http://www.test.com\u0027, \u0027asdf\u0027, \u0027asdf\u0027,"},{"line_number":219,"context_line":"                                os_options\u003dos_options,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAALH%2F%2FgCA%3D","line":216,"updated":"2012-09-05 21:41:27.000000000","message":"typo..","commit_id":"c16bd8955f05e528a600438adf94f151a57214b3"}],"tests/utils.py":[{"author":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"change_message_id":"c0d3de296458ebdc434d3b272ad3da7de8e53d27","unresolved":false,"context_lines":[{"line_number":21,"context_line":"                                    user,"},{"line_number":22,"context_line":"                                    key,"},{"line_number":23,"context_line":"                                    actual_os_options):"},{"line_number":24,"context_line":"        if exc is not None:"},{"line_number":25,"context_line":"            raise exc(\u0027test\u0027)"},{"line_number":26,"context_line":"        if actual_os_options !\u003d os_options:"},{"line_number":27,"context_line":"            return \"\", None"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAALH%2F%2FdJk%3D","line":24,"updated":"2012-09-10 09:38:30.000000000","message":"why not just? (except if that could ever be a 0)\n\nif exc:","commit_id":"a3f0fbb2fb4155eed2cb56a7232c0ca5d61aa966"}]}