)]}'
{"swiftclient/service.py":[{"author":{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},"change_message_id":"25c8eec729a1aa78e366fac4bb09fcf7b96100f4","unresolved":false,"context_lines":[{"line_number":1202,"context_line":"        # to HEAD the first container"},{"line_number":1203,"context_line":"        for r in interruptable_as_completed(create_containers):"},{"line_number":1204,"context_line":"            res \u003d r.result()"},{"line_number":1205,"context_line":"            yield res"},{"line_number":1206,"context_line":""},{"line_number":1207,"context_line":"        if options[\u0027segment_size\u0027] is not None:"},{"line_number":1208,"context_line":"            seg_container \u003d container + \u0027_segments\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"baa201ad_8730d1e9","line":1205,"updated":"2014-10-10 18:22:08.000000000","message":"Do we need to clear create_containers out now that we\u0027ve done the job?\n\nLooking at line 1230, it looks like we might end up making a second request to create the container if we don\u0027t, though since this is some futures-backed thingy, maybe that\u0027s not the case.","commit_id":"9f857e3967009c99010fd997cfe127a78eed6867"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"e1ba3a824a93bd097dc520e150203f811297e3cc","unresolved":false,"context_lines":[{"line_number":1202,"context_line":"        # to HEAD the first container"},{"line_number":1203,"context_line":"        for r in interruptable_as_completed(create_containers):"},{"line_number":1204,"context_line":"            res \u003d r.result()"},{"line_number":1205,"context_line":"            yield res"},{"line_number":1206,"context_line":""},{"line_number":1207,"context_line":"        if options[\u0027segment_size\u0027] is not None:"},{"line_number":1208,"context_line":"            seg_container \u003d container + \u0027_segments\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"baa201ad_efc95a5b","line":1205,"in_reply_to":"baa201ad_8730d1e9","updated":"2014-10-13 09:21:26.000000000","message":"Good question. At line 201 it looks like create_containers gets emptied as jobs complete. However, I\u0027d prefer it to be more obvious here, and taking Matt\u0027s suggestion at line 1232 will achieve that.","commit_id":"9f857e3967009c99010fd997cfe127a78eed6867"},{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"3cb6a2d0fe80c322f7695466b3ee5a2a63b035e2","unresolved":false,"context_lines":[{"line_number":1202,"context_line":"        # to HEAD the first container"},{"line_number":1203,"context_line":"        for r in interruptable_as_completed(create_containers):"},{"line_number":1204,"context_line":"            res \u003d r.result()"},{"line_number":1205,"context_line":"            yield res"},{"line_number":1206,"context_line":""},{"line_number":1207,"context_line":"        if options[\u0027segment_size\u0027] is not None:"},{"line_number":1208,"context_line":"            seg_container \u003d container + \u0027_segments\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"baa201ad_9c6d6d07","line":1205,"in_reply_to":"baa201ad_8730d1e9","updated":"2014-10-13 06:21:42.000000000","message":"create_containers doesn\u0027t need to be cleaned out, as create_containers are recreated rather then appended to below.","commit_id":"9f857e3967009c99010fd997cfe127a78eed6867"},{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"3cb6a2d0fe80c322f7695466b3ee5a2a63b035e2","unresolved":false,"context_lines":[{"line_number":1229,"context_line":""},{"line_number":1230,"context_line":"        for r in interruptable_as_completed(create_containers):"},{"line_number":1231,"context_line":"            res \u003d r.result()"},{"line_number":1232,"context_line":"            yield res"},{"line_number":1233,"context_line":""},{"line_number":1234,"context_line":"        # We maintain a results queue here and a separate thread to monitor"},{"line_number":1235,"context_line":"        # the futures because we want to get results back from potential"}],"source_content_type":"text/x-python","patch_set":3,"id":"baa201ad_fc583959","line":1232,"updated":"2014-10-13 06:21:42.000000000","message":"But now that you are waiting for the original container to be created (line 1203), waiting here is only required when (according to the code) when segment_size has been defined. So this wait can now be apart of the segment_size if statement (indented in).","commit_id":"9f857e3967009c99010fd997cfe127a78eed6867"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"e1ba3a824a93bd097dc520e150203f811297e3cc","unresolved":false,"context_lines":[{"line_number":1229,"context_line":""},{"line_number":1230,"context_line":"        for r in interruptable_as_completed(create_containers):"},{"line_number":1231,"context_line":"            res \u003d r.result()"},{"line_number":1232,"context_line":"            yield res"},{"line_number":1233,"context_line":""},{"line_number":1234,"context_line":"        # We maintain a results queue here and a separate thread to monitor"},{"line_number":1235,"context_line":"        # the futures because we want to get results back from potential"}],"source_content_type":"text/x-python","patch_set":3,"id":"baa201ad_2ff1a2cd","line":1232,"in_reply_to":"baa201ad_fc583959","updated":"2014-10-13 09:21:26.000000000","message":"Done","commit_id":"9f857e3967009c99010fd997cfe127a78eed6867"}]}