)]}'
{"swiftclient/service.py":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"92e589830426e85d924bad0aed0c349d42116f47","unresolved":false,"context_lines":[{"line_number":599,"context_line":"            res[\"action\"] \u003d \"post_container\""},{"line_number":600,"context_line":"            response_dict \u003d {}"},{"line_number":601,"context_line":"            headers \u003d split_headers("},{"line_number":602,"context_line":"                options[\u0027meta\u0027], \u0027X-Container-Meta-\u0027)"},{"line_number":603,"context_line":"            headers.update("},{"line_number":604,"context_line":"                split_headers(options[\u0027header\u0027], \u0027\u0027))"},{"line_number":605,"context_line":"            if options[\u0027read_acl\u0027] is not None:"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a8c0949_5cb6dfdd","line":602,"updated":"2014-10-30 13:10:15.000000000","message":"Maybe here we don\u0027t need character \u0027-\u0027 at the end of string? Otherwise what is it means?","commit_id":"95056d1ef49730d98eda1fc246b7e4bb1070a311"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"c3d900426b3cdf6cfe42a0cea5889f636055c042","unresolved":false,"context_lines":[{"line_number":599,"context_line":"            res[\"action\"] \u003d \"post_container\""},{"line_number":600,"context_line":"            response_dict \u003d {}"},{"line_number":601,"context_line":"            headers \u003d split_headers("},{"line_number":602,"context_line":"                options[\u0027meta\u0027], \u0027X-Container-Meta-\u0027)"},{"line_number":603,"context_line":"            headers.update("},{"line_number":604,"context_line":"                split_headers(options[\u0027header\u0027], \u0027\u0027))"},{"line_number":605,"context_line":"            if options[\u0027read_acl\u0027] is not None:"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a8c0949_7c68fbf5","line":602,"in_reply_to":"7a8c0949_5cb6dfdd","updated":"2014-10-30 13:20:35.000000000","message":"The \u0027-\u0027 is needed. Whats happening here is that items in options[\u0027meta\u0027] such as \u0027foo:bar\u0027 get transformed to headers X-Container-Meta-foo: bar which is a valid user metadata header. Without the \u0027-\u0027 you get X-Container-Metafoo which is not valid user metadata.","commit_id":"95056d1ef49730d98eda1fc246b7e4bb1070a311"}],"swiftclient/shell.py":[{"author":{"_account_id":13470,"name":"Daniel Wakefield","email":"dan@danw.eu","username":"danw"},"change_message_id":"0f6eb0e07ba9c25237ffd3eaf77dbc09096599d3","unresolved":false,"context_lines":[{"line_number":614,"context_line":"                        results_iterator \u003d swift.post("},{"line_number":615,"context_line":"                            container\u003dcontainer, objects\u003dobjects"},{"line_number":616,"context_line":"                        )"},{"line_number":617,"context_line":"                        for result in results_iterator:  # only 1 result"},{"line_number":618,"context_line":"                            if not result[\"success\"]:"},{"line_number":619,"context_line":"                                raise(result[\"error\"])"},{"line_number":620,"context_line":"                    else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9aa7fdbe_b5b744f4","line":617,"updated":"2014-10-24 13:45:31.000000000","message":"this could be changed to result \u003d next(results_iterator) since we know that only one result is returned. It would allow you to remove the success check here and rely on one at the end of the try block","commit_id":"8b34413d472e86fb404640378c51f5046e91144b"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"d30e3f26ae7f25eb028d8862959918f39974e39c","unresolved":false,"context_lines":[{"line_number":614,"context_line":"                        results_iterator \u003d swift.post("},{"line_number":615,"context_line":"                            container\u003dcontainer, objects\u003dobjects"},{"line_number":616,"context_line":"                        )"},{"line_number":617,"context_line":"                        for result in results_iterator:  # only 1 result"},{"line_number":618,"context_line":"                            if not result[\"success\"]:"},{"line_number":619,"context_line":"                                raise(result[\"error\"])"},{"line_number":620,"context_line":"                    else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9aa7fdbe_53e46be0","line":617,"in_reply_to":"9aa7fdbe_b5b744f4","updated":"2014-10-24 17:20:17.000000000","message":"Done","commit_id":"8b34413d472e86fb404640378c51f5046e91144b"},{"author":{"_account_id":13470,"name":"Daniel Wakefield","email":"dan@danw.eu","username":"danw"},"change_message_id":"0f6eb0e07ba9c25237ffd3eaf77dbc09096599d3","unresolved":false,"context_lines":[{"line_number":624,"context_line":"                else:"},{"line_number":625,"context_line":"                    result \u003d swift.post(container\u003dcontainer)"},{"line_number":626,"context_line":"                    if result and not result[\"success\"]:"},{"line_number":627,"context_line":"                        raise(result[\"error\"])"},{"line_number":628,"context_line":""},{"line_number":629,"context_line":"        except SwiftError as e:"},{"line_number":630,"context_line":"            output_manager.error(e.value)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9aa7fdbe_b5e024fb","line":627,"updated":"2014-10-24 13:45:31.000000000","message":"you could outdent the check here one level which would remove the slight code duplication.","commit_id":"8b34413d472e86fb404640378c51f5046e91144b"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"d30e3f26ae7f25eb028d8862959918f39974e39c","unresolved":false,"context_lines":[{"line_number":624,"context_line":"                else:"},{"line_number":625,"context_line":"                    result \u003d swift.post(container\u003dcontainer)"},{"line_number":626,"context_line":"                    if result and not result[\"success\"]:"},{"line_number":627,"context_line":"                        raise(result[\"error\"])"},{"line_number":628,"context_line":""},{"line_number":629,"context_line":"        except SwiftError as e:"},{"line_number":630,"context_line":"            output_manager.error(e.value)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9aa7fdbe_93ea53aa","line":627,"in_reply_to":"9aa7fdbe_b5e024fb","updated":"2014-10-24 17:20:17.000000000","message":"Done","commit_id":"8b34413d472e86fb404640378c51f5046e91144b"}]}