)]}'
{"id":"openstack%2Fpython-swiftclient~129572","triplet_id":"openstack%2Fpython-swiftclient~master~I111150eb3d026c8d01c2cac13d3613ca7304e5b9","project":"openstack/python-swiftclient","branch":"master","topic":"bug/1383243","hashtags":[],"change_id":"I111150eb3d026c8d01c2cac13d3613ca7304e5b9","subject":"Make swift post output an error message when failing","status":"MERGED","created":"2014-10-20 11:08:48.000000000","updated":"2014-11-13 03:30:02.000000000","submitted":"2014-11-13 03:30:01.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":6,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"15024a64cc6421fa01e7c56695ee9492a1a248bf","_number":129572,"virtual_id_number":129572,"owner":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2014-11-13 03:30:01.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"date":"2014-10-30 13:20:35.000000000","_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},{"value":0,"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"value":0,"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},{"value":0,"_account_id":13470,"name":"Daniel Wakefield","email":"dan@danw.eu","username":"danw"},{"value":0,"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},{"value":2,"date":"2014-10-29 22:15:53.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"value":1,"date":"2014-10-30 13:10:15.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},{"value":1,"date":"2014-10-28 11:27:56.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":13470,"name":"Daniel Wakefield","email":"dan@danw.eu","username":"danw"},{"value":2,"date":"2014-11-13 01:27:27.000000000","_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},{"value":0,"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"value":0,"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},{"value":0,"_account_id":13470,"name":"Daniel Wakefield","email":"dan@danw.eu","username":"danw"},{"value":1,"date":"2014-11-13 01:27:27.000000000","_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},{"_account_id":13470,"name":"Daniel Wakefield","email":"dan@danw.eu","username":"danw"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2014-10-28 11:27:56.000000000","updated_by":{"_account_id":13470,"name":"Daniel Wakefield","email":"dan@danw.eu","username":"danw"},"reviewer":{"_account_id":13470,"name":"Daniel Wakefield","email":"dan@danw.eu","username":"danw"},"state":"REVIEWER"},{"updated":"2014-10-29 22:15:53.000000000","updated_by":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"reviewer":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"state":"REVIEWER"},{"updated":"2014-10-30 13:10:15.000000000","updated_by":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"reviewer":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"state":"REVIEWER"},{"updated":"2014-11-13 01:27:27.000000000","updated_by":{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},"reviewer":{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},"state":"REVIEWER"},{"updated":"2014-11-13 03:30:01.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"0aa21c35d1c1b3ccdc340cf46edcb64a25f6ca2a","author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"date":"2014-10-20 11:08:48.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"e31f53b6a0ccc650575aa029df8cdfe42571eec4","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-10-20 12:32:34.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-swiftclient-pep8 http://logs.openstack.org/72/129572/1/check/gate-python-swiftclient-pep8/4dc77b7 : SUCCESS in 33s\n- gate-python-swiftclient-docs http://docs-draft.openstack.org/72/129572/1/check/gate-python-swiftclient-docs/10ff5a5/doc/build/html/ : SUCCESS in 44s\n- gate-python-swiftclient-python26 http://logs.openstack.org/72/129572/1/check/gate-python-swiftclient-python26/ad5e1b8 : SUCCESS in 43s\n- gate-python-swiftclient-python27 http://logs.openstack.org/72/129572/1/check/gate-python-swiftclient-python27/ac10e5b : SUCCESS in 35s\n- gate-python-swiftclient-python33 http://logs.openstack.org/72/129572/1/check/gate-python-swiftclient-python33/2ee29db : SUCCESS in 3m 05s\n- check-tempest-dsvm-full http://logs.openstack.org/72/129572/1/check/check-tempest-dsvm-full/b424cac : SUCCESS in 59m 30s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/72/129572/1/check/check-tempest-dsvm-postgres-full/96ca36a : SUCCESS in 52m 05s\n- check-tempest-dsvm-neutron-full http://logs.openstack.org/72/129572/1/check/check-tempest-dsvm-neutron-full/b30d82a : SUCCESS in 1h 03m 09s\n- check-tempest-dsvm-neutron-heat-slow http://logs.openstack.org/72/129572/1/check/check-tempest-dsvm-neutron-heat-slow/62440d3 : SUCCESS in 22m 54s\n- check-grenade-dsvm http://logs.openstack.org/72/129572/1/check/check-grenade-dsvm/76a1a91 : SUCCESS in 58m 38s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/72/129572/1/check/gate-tempest-dsvm-large-ops/9e319b2 : SUCCESS in 23m 47s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/72/129572/1/check/gate-tempest-dsvm-neutron-large-ops/081b06b : SUCCESS in 22m 05s\n- check-tempest-dsvm-full-icehouse http://logs.openstack.org/72/129572/1/check/check-tempest-dsvm-full-icehouse/8bf8f98 : SUCCESS in 49m 33s\n- check-tempest-dsvm-neutron-icehouse http://logs.openstack.org/72/129572/1/check/check-tempest-dsvm-neutron-icehouse/6a65fd4 : SUCCESS in 54m 48s\n- gate-python-swiftclient-pypy http://logs.openstack.org/72/129572/1/check/gate-python-swiftclient-pypy/bcb4d5e : SUCCESS in 1m 28s\n- check-swift-dsvm-functional http://logs.openstack.org/72/129572/1/check/check-swift-dsvm-functional/3730614 : SUCCESS in 15m 51s\n- check-swiftclient-dsvm-functional http://logs.openstack.org/72/129572/1/check/check-swiftclient-dsvm-functional/e8c97c3 : FAILURE in 14m 20s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"0f6eb0e07ba9c25237ffd3eaf77dbc09096599d3","author":{"_account_id":13470,"name":"Daniel Wakefield","email":"dan@danw.eu","username":"danw"},"date":"2014-10-24 13:45:31.000000000","message":"Patch Set 1: Code-Review+1\n\n(2 comments)","accounts_in_message":[],"_revision_number":1},{"id":"afa0b19a571fa3f346931536f8b17f2db639df1f","author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"date":"2014-10-24 17:15:24.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"d30e3f26ae7f25eb028d8862959918f39974e39c","author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"date":"2014-10-24 17:20:17.000000000","message":"Patch Set 1:\n\n(2 comments)\n\n@Dan nice idea, thanks. Unfortunately it led to discovering that the SwiftService wasn\u0027t returning a result dict on success, so needed to fix that.\n\nThe side-by-side of service.py looks worse than it is - I just added some returns and dropped the else\u0027s.","accounts_in_message":[],"_revision_number":1},{"id":"0911b5b70f4b51aa9421de8465c44bb5acaa9e67","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-10-24 18:18:54.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-swiftclient-pep8 http://logs.openstack.org/72/129572/2/check/gate-python-swiftclient-pep8/2366644 : SUCCESS in 42s\n- gate-python-swiftclient-docs http://docs-draft.openstack.org/72/129572/2/check/gate-python-swiftclient-docs/590e40f/doc/build/html/ : SUCCESS in 49s\n- gate-python-swiftclient-python27 http://logs.openstack.org/72/129572/2/check/gate-python-swiftclient-python27/166f6de : SUCCESS in 41s\n- gate-python-swiftclient-python33 http://logs.openstack.org/72/129572/2/check/gate-python-swiftclient-python33/2038a35 : SUCCESS in 3m 00s\n- check-tempest-dsvm-full http://logs.openstack.org/72/129572/2/check/check-tempest-dsvm-full/1539619 : SUCCESS in 41m 26s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/72/129572/2/check/check-tempest-dsvm-postgres-full/5fc7fd6 : SUCCESS in 52m 06s\n- check-tempest-dsvm-neutron-full http://logs.openstack.org/72/129572/2/check/check-tempest-dsvm-neutron-full/4fea666 : SUCCESS in 48m 53s\n- check-tempest-dsvm-neutron-heat-slow http://logs.openstack.org/72/129572/2/check/check-tempest-dsvm-neutron-heat-slow/3735798 : SUCCESS in 18m 21s\n- check-grenade-dsvm http://logs.openstack.org/72/129572/2/check/check-grenade-dsvm/514001d : SUCCESS in 47m 01s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/72/129572/2/check/gate-tempest-dsvm-large-ops/fcf0f6c : SUCCESS in 19m 17s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/72/129572/2/check/gate-tempest-dsvm-neutron-large-ops/8a87ebd : SUCCESS in 18m 12s\n- check-tempest-dsvm-full-icehouse http://logs.openstack.org/72/129572/2/check/check-tempest-dsvm-full-icehouse/76315d6 : SUCCESS in 48m 37s\n- check-tempest-dsvm-neutron-icehouse http://logs.openstack.org/72/129572/2/check/check-tempest-dsvm-neutron-icehouse/b592953 : SUCCESS in 58m 53s\n- check-tempest-dsvm-full-juno http://logs.openstack.org/72/129572/2/check/check-tempest-dsvm-full-juno/c3a0f5e : SUCCESS in 44m 11s\n- check-tempest-dsvm-neutron-juno http://logs.openstack.org/72/129572/2/check/check-tempest-dsvm-neutron-juno/13f1b50 : SUCCESS in 58m 21s\n- gate-python-swiftclient-pypy http://logs.openstack.org/72/129572/2/check/gate-python-swiftclient-pypy/65acd36 : SUCCESS in 1m 12s\n- gate-python-swiftclient-python26 http://logs.openstack.org/72/129572/2/check/gate-python-swiftclient-python26/805bf7c : SUCCESS in 36s\n- check-swift-dsvm-functional http://logs.openstack.org/72/129572/2/check/check-swift-dsvm-functional/20a0e69 : SUCCESS in 17m 47s\n- check-swiftclient-dsvm-functional http://logs.openstack.org/72/129572/2/check/check-swiftclient-dsvm-functional/00dc625 : FAILURE in 14m 28s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"cae65e6b9b4e3d0a841c51c2f7f9a34c8f3c2d01","author":{"_account_id":13470,"name":"Daniel Wakefield","email":"dan@danw.eu","username":"danw"},"date":"2014-10-28 11:27:56.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"56e5d2c978fd311bc64ec726f2e2e330ca1cd582","author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"date":"2014-10-29 22:15:53.000000000","message":"Patch Set 2: Code-Review+2\n\nbah, there\u0027s probably some stuff that could get cleaned up in this but the existing behavior is so f\u0027ing annoying I\u0027ll stick my +2 on it.\n\nIf you\u0027re core and have the option to either approve or nit, please approve and just tell me whatever you want cleaned up in a follow on patch.","accounts_in_message":[],"_revision_number":2},{"id":"92e589830426e85d924bad0aed0c349d42116f47","author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"date":"2014-10-30 13:10:15.000000000","message":"Patch Set 2: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"c3d900426b3cdf6cfe42a0cea5889f636055c042","author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"date":"2014-10-30 13:20:35.000000000","message":"Patch Set 2:\n\n(1 comment)\n\n@Roman thanks for reviewing, replied to your question inline","accounts_in_message":[],"_revision_number":2},{"id":"47da9c92990fdad1b317af4290f79878aec79860","author":{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},"date":"2014-11-13 01:27:27.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"cc854c029b55631956dd0571fc416f5e5ea38c6e","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-11-13 01:27:28.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"2f4e012203619202a1f26f00e52877166ad192c9","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-11-13 03:30:01.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-swiftclient-docs http://docs-draft.openstack.org/72/129572/2/gate/gate-python-swiftclient-docs/e5f0acb/doc/build/html/ : SUCCESS in 41s\n- gate-python-swiftclient-pep8 http://logs.openstack.org/72/129572/2/gate/gate-python-swiftclient-pep8/e1cb68b : SUCCESS in 31s\n- gate-python-swiftclient-python27 http://logs.openstack.org/72/129572/2/gate/gate-python-swiftclient-python27/0737be5 : SUCCESS in 38s\n- gate-python-swiftclient-python33 http://logs.openstack.org/72/129572/2/gate/gate-python-swiftclient-python33/9c24719 : SUCCESS in 2m 31s\n- gate-python-swiftclient-pypy http://logs.openstack.org/72/129572/2/gate/gate-python-swiftclient-pypy/fc141d6 : SUCCESS in 1m 20s\n- gate-tempest-dsvm-src-python-swiftclient http://logs.openstack.org/72/129572/2/gate/gate-tempest-dsvm-src-python-swiftclient/ce0426c : SUCCESS in 51m 33s\n- gate-tempest-dsvm-neutron-src-python-swiftclient http://logs.openstack.org/72/129572/2/gate/gate-tempest-dsvm-neutron-src-python-swiftclient/9538d69 : SUCCESS in 1h 15m 27s\n- gate-python-swiftclient-python26 http://logs.openstack.org/72/129572/2/gate/gate-python-swiftclient-python26/8777fe2 : SUCCESS in 39s\n- gate-swift-dsvm-functional http://logs.openstack.org/72/129572/2/gate/gate-swift-dsvm-functional/78751d1 : SUCCESS in 25m 44s","accounts_in_message":[],"_revision_number":2},{"id":"b2951d4523bfb314cda9786872cf210d1242f7b7","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-11-13 03:30:02.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"95056d1ef49730d98eda1fc246b7e4bb1070a311","revisions":{"8b34413d472e86fb404640378c51f5046e91144b":{"kind":"REWORK","_number":1,"created":"2014-10-20 11:08:48.000000000","uploader":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"ref":"refs/changes/72/129572/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-swiftclient","ref":"refs/changes/72/129572/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/72/129572/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/72/129572/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/72/129572/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-swiftclient refs/changes/72/129572/1"}}},"commit":{"parents":[{"commit":"871a3e40f306f1bff056a86edcd644a82ab29c67","subject":"Fix KeyError raised from client Connection","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/871a3e40f306f1bff056a86edcd644a82ab29c67"}]}],"author":{"name":"Alistair Coles","email":"alistair.coles@hp.com","date":"2014-10-20 09:41:34.000000000","tz":60},"committer":{"name":"Alistair Coles","email":"alistair.coles@hp.com","date":"2014-10-20 11:00:54.000000000","tz":60},"subject":"Make swift post output an error message when failing","message":"Make swift post output an error message when failing\n\nswiftclient.shell.st_post was ignoring the result dict\nreturned from SwiftService.post and therefore giving no\nindication when posts failed e.g. due to invalid auth\ncredentials.\n\nThis patch checks the result dict and on failure outputs\nthe ClientException message and exits with error code 1.\n\nAlso adds unit tests and cleans up some unnecessary mocked\nreturn values in existing tests.\n\nCloses-Bug: 1383243\n\nChange-Id: I111150eb3d026c8d01c2cac13d3613ca7304e5b9\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/8b34413d472e86fb404640378c51f5046e91144b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/8b34413d472e86fb404640378c51f5046e91144b"}]},"branch":"refs/heads/master"},"95056d1ef49730d98eda1fc246b7e4bb1070a311":{"kind":"REWORK","_number":2,"created":"2014-10-24 17:15:24.000000000","uploader":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"ref":"refs/changes/72/129572/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-swiftclient","ref":"refs/changes/72/129572/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/72/129572/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/72/129572/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/72/129572/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-swiftclient refs/changes/72/129572/2"}}},"commit":{"parents":[{"commit":"871a3e40f306f1bff056a86edcd644a82ab29c67","subject":"Fix KeyError raised from client Connection","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/871a3e40f306f1bff056a86edcd644a82ab29c67"}]}],"author":{"name":"Alistair Coles","email":"alistair.coles@hp.com","date":"2014-10-20 09:41:34.000000000","tz":60},"committer":{"name":"Alistair Coles","email":"alistair.coles@hp.com","date":"2014-10-24 17:13:37.000000000","tz":60},"subject":"Make swift post output an error message when failing","message":"Make swift post output an error message when failing\n\nswiftclient.shell.st_post was ignoring the result dict\nreturned from SwiftService.post and therefore giving no\nindication when posts failed e.g. due to invalid auth\ncredentials.\n\nThis patch ensures that SwiftService always returns a\nresult_dict from post() and then checks the result dict.\nOn failure the shell now outputs the ClientException\nmessage and exits with error code 1.\n\nAlso adds unit tests and cleans up some unnecessary mocked\nreturn values in existing tests.\n\nCloses-Bug: 1383243\n\nChange-Id: I111150eb3d026c8d01c2cac13d3613ca7304e5b9\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/95056d1ef49730d98eda1fc246b7e4bb1070a311"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/95056d1ef49730d98eda1fc246b7e4bb1070a311"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}