)]}'
{"id":"openstack%2Fpython-swiftclient~133224","triplet_id":"openstack%2Fpython-swiftclient~master~Iaf1e21324ce592049d02cd5be123604b99833e86","project":"openstack/python-swiftclient","branch":"master","topic":"test_coverage_swift_reader","hashtags":[],"change_id":"Iaf1e21324ce592049d02cd5be123604b99833e86","subject":"Fix misnamed variable in SwiftReader.","status":"MERGED","created":"2014-11-07 12:58:32.000000000","updated":"2014-11-17 11:12:14.000000000","submitted":"2014-11-17 11:12:13.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"4b9e8cf3ccc43ff61aafeb28c4a2d19e0c1a0a10","_number":133224,"virtual_id_number":133224,"owner":{"_account_id":13470,"name":"Daniel Wakefield","email":"dan@danw.eu","username":"danw"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2014-11-17 11:12:13.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},{"value":0,"_account_id":6968,"name":"Christian Schwede","email":"cschwede@nvidia.com","username":"cschwede"},{"value":0,"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2014-11-17 10:10:49.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},{"value":0,"_account_id":6968,"name":"Christian Schwede","email":"cschwede@nvidia.com","username":"cschwede"},{"value":2,"date":"2014-11-12 02:47:57.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2014-11-17 10:10:49.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},{"value":0,"date":"2014-11-09 14:33:00.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":6968,"name":"Christian Schwede","email":"cschwede@nvidia.com","username":"cschwede"},{"value":0,"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"_account_id":6968,"name":"Christian Schwede","email":"cschwede@nvidia.com","username":"cschwede"},{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2014-11-09 14:33:00.000000000","updated_by":{"_account_id":6968,"name":"Christian Schwede","email":"cschwede@nvidia.com","username":"cschwede"},"reviewer":{"_account_id":6968,"name":"Christian Schwede","email":"cschwede@nvidia.com","username":"cschwede"},"state":"REVIEWER"},{"updated":"2014-11-12 02:47:57.000000000","updated_by":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"reviewer":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"state":"REVIEWER"},{"updated":"2014-11-17 10:10:49.000000000","updated_by":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"reviewer":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"state":"REVIEWER"},{"updated":"2014-11-17 11:12:13.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"2b5dd53f216e1642cdd3c24bb5d23594882117a5","author":{"_account_id":13470,"name":"Daniel Wakefield","email":"dan@danw.eu","username":"danw"},"date":"2014-11-07 12:58:32.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"44be1107346f2b06f6feb9a9e7656a41446ab62e","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-11-07 14:24:26.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-swiftclient-pep8 http://logs.openstack.org/24/133224/1/check/gate-python-swiftclient-pep8/1d34072 : SUCCESS in 42s\n- gate-python-swiftclient-docs http://docs-draft.openstack.org/24/133224/1/check/gate-python-swiftclient-docs/b472ed4/doc/build/html/ : SUCCESS in 39s\n- gate-python-swiftclient-python27 http://logs.openstack.org/24/133224/1/check/gate-python-swiftclient-python27/ae674ee : SUCCESS in 38s\n- gate-python-swiftclient-python33 http://logs.openstack.org/24/133224/1/check/gate-python-swiftclient-python33/85c738f : SUCCESS in 2m 49s\n- check-tempest-dsvm-full http://logs.openstack.org/24/133224/1/check/check-tempest-dsvm-full/b67082c : SUCCESS in 45m 06s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/24/133224/1/check/check-tempest-dsvm-postgres-full/3bc8129 : SUCCESS in 46m 10s\n- check-tempest-dsvm-neutron-full http://logs.openstack.org/24/133224/1/check/check-tempest-dsvm-neutron-full/6c068bf : SUCCESS in 1h 05m 34s\n- check-tempest-dsvm-neutron-heat-slow http://logs.openstack.org/24/133224/1/check/check-tempest-dsvm-neutron-heat-slow/143cf5b : SUCCESS in 18m 35s\n- check-grenade-dsvm http://logs.openstack.org/24/133224/1/check/check-grenade-dsvm/18cc7c1 : SUCCESS in 43m 10s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/24/133224/1/check/gate-tempest-dsvm-large-ops/290bcb3 : SUCCESS in 24m 07s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/24/133224/1/check/gate-tempest-dsvm-neutron-large-ops/049f87c : SUCCESS in 26m 05s\n- check-tempest-dsvm-full-icehouse http://logs.openstack.org/24/133224/1/check/check-tempest-dsvm-full-icehouse/43c98e0 : SUCCESS in 49m 49s\n- check-tempest-dsvm-neutron-icehouse http://logs.openstack.org/24/133224/1/check/check-tempest-dsvm-neutron-icehouse/9f815c6 : SUCCESS in 54m 31s\n- check-tempest-dsvm-full-juno http://logs.openstack.org/24/133224/1/check/check-tempest-dsvm-full-juno/360ffbd : SUCCESS in 57m 27s\n- check-tempest-dsvm-neutron-juno http://logs.openstack.org/24/133224/1/check/check-tempest-dsvm-neutron-juno/3eae069 : SUCCESS in 57m 59s\n- gate-python-swiftclient-pypy http://logs.openstack.org/24/133224/1/check/gate-python-swiftclient-pypy/cc396e3 : SUCCESS in 1m 24s\n- gate-python-swiftclient-python26 http://logs.openstack.org/24/133224/1/check/gate-python-swiftclient-python26/720cf64 : SUCCESS in 40s\n- check-swift-dsvm-functional http://logs.openstack.org/24/133224/1/check/check-swift-dsvm-functional/e016e7e : SUCCESS in 18m 51s\n- check-swiftclient-dsvm-functional http://logs.openstack.org/24/133224/1/check/check-swiftclient-dsvm-functional/c05aae1 : FAILURE in 14m 46s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"fb41d1c7f833a5867f692c9a295116b70d6c7494","author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"date":"2014-11-12 02:47:57.000000000","message":"Patch Set 1: Code-Review+2\n\nso I think the code is fine, but I find these tests a little hard to follow.\n\nI\u0027ve been working on some better http response faking tooling in another change [1] that let me create some tests that demonstrated the issue in a way that was a little clearer to me:\n\nhttps://gist.github.com/clayg/18578ce41f69a122a45f\n\nBasically you just setup a stub response that returns a body with an etag that doesn\u0027t match what the client will calculate and when you turn the crank you can see the SwiftError filled in the response and success set to False.  Simplicity itself.\n\nCurrently the valid etag and no etag tests pass, and when I apply your change to the service class of course the invalid etag test correctly shows success False with the expected error response.\n\nMaybe after this lands I can add these tests as a dependency on my other change.\n\n1. https://review.openstack.org/#/c/130711/","accounts_in_message":[],"_revision_number":1},{"id":"e6acc6a8319d9fc59073a99d67a24e44d1d59f8e","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-11-17 10:10:49.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"a83942c3097c0666c2702c54e4478f4b29ab1932","author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"date":"2014-11-17 10:10:49.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\nNice catch!","accounts_in_message":[],"_revision_number":1},{"id":"23fdb06a64251480a84aa5fab0e4819019599fac","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-11-17 11:12:13.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-swiftclient-docs http://docs-draft.openstack.org/24/133224/1/gate/gate-python-swiftclient-docs/817cbda/doc/build/html/ : SUCCESS in 42s\n- gate-python-swiftclient-pep8 http://logs.openstack.org/24/133224/1/gate/gate-python-swiftclient-pep8/f07af5c : SUCCESS in 32s\n- gate-python-swiftclient-python27 http://logs.openstack.org/24/133224/1/gate/gate-python-swiftclient-python27/35460e7 : SUCCESS in 39s\n- gate-python-swiftclient-python33 http://logs.openstack.org/24/133224/1/gate/gate-python-swiftclient-python33/4dd93a0 : SUCCESS in 2m 31s\n- gate-python-swiftclient-pypy http://logs.openstack.org/24/133224/1/gate/gate-python-swiftclient-pypy/5dd6e88 : SUCCESS in 1m 19s\n- gate-tempest-dsvm-src-python-swiftclient http://logs.openstack.org/24/133224/1/gate/gate-tempest-dsvm-src-python-swiftclient/bb14012 : SUCCESS in 45m 30s\n- gate-tempest-dsvm-neutron-src-python-swiftclient http://logs.openstack.org/24/133224/1/gate/gate-tempest-dsvm-neutron-src-python-swiftclient/4257d3b : SUCCESS in 1h 01m 22s\n- gate-python-swiftclient-python26 http://logs.openstack.org/24/133224/1/gate/gate-python-swiftclient-python26/c018566 : SUCCESS in 40s\n- gate-swift-dsvm-functional http://logs.openstack.org/24/133224/1/gate/gate-swift-dsvm-functional/b62cf32 : SUCCESS in 17m 06s","accounts_in_message":[],"_revision_number":1},{"id":"e2f5cfeec8903057929c659f6338a18f2c059686","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-11-17 11:12:14.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"93cc42b21d213079285fcd09f1cf07168b803018","revisions":{"93cc42b21d213079285fcd09f1cf07168b803018":{"kind":"REWORK","_number":1,"created":"2014-11-07 12:58:32.000000000","uploader":{"_account_id":13470,"name":"Daniel Wakefield","email":"dan@danw.eu","username":"danw"},"ref":"refs/changes/24/133224/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-swiftclient","ref":"refs/changes/24/133224/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/24/133224/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/24/133224/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/24/133224/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-swiftclient refs/changes/24/133224/1"}}},"commit":{"parents":[{"commit":"19b427eacbbbb94199551766149472f26fa08698","subject":"Merge \"Adds user friendly message when --segment-size is a non-integer\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/19b427eacbbbb94199551766149472f26fa08698"}]}],"author":{"name":"Daniel Wakefield","email":"daniel.wakefield@hp.com","date":"2014-11-07 12:46:23.000000000","tz":0},"committer":{"name":"Daniel Wakefield","email":"daniel.wakefield@hp.com","date":"2014-11-07 12:55:51.000000000","tz":0},"subject":"Fix misnamed variable in SwiftReader.","message":"Fix misnamed variable in SwiftReader.\n\nactual_md5 was being used instead of _actual_md5 only when assigning\nthe md5 object. This resulted in all checks and updates of the md5\nto be skipped.\n\nWhen fixed it revealed another bug that the md5 of the read content\nis always checked even if there is no _expected_etag.\n\nAdded tests\n\nChange-Id: Iaf1e21324ce592049d02cd5be123604b99833e86\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/93cc42b21d213079285fcd09f1cf07168b803018"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/93cc42b21d213079285fcd09f1cf07168b803018"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}