)]}'
{"id":"openstack%2Fpython-swiftclient~14330","triplet_id":"openstack%2Fpython-swiftclient~master~Ice2aa29024429d3e6f569a88d5cf8b4202537827","project":"openstack/python-swiftclient","branch":"master","topic":"bug/1008940","hashtags":[],"change_id":"Ice2aa29024429d3e6f569a88d5cf8b4202537827","subject":"Force utf-8 encode of HTTPConnection params","status":"MERGED","created":"2012-10-11 12:20:03.000000000","updated":"2012-11-16 23:13:09.000000000","submitted":"2012-11-16 23:13:09.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"979187bad1e2559d1b872a45b1af0cf775e1a389","_number":14330,"virtual_id_number":14330,"owner":{"_account_id":2455,"name":"Tihomir Trifonov","email":"t.trifonov@gmail.com","username":"ttrifonov"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2012-11-16 23:13:09.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":2455,"name":"Tihomir Trifonov","email":"t.trifonov@gmail.com","username":"ttrifonov"},{"value":0,"_account_id":330,"name":"John Dickinson","email":"me@not.mn","username":"notmyname"},{"value":0,"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":330,"name":"John Dickinson","email":"me@not.mn","username":"notmyname"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":2455,"name":"Tihomir Trifonov","email":"t.trifonov@gmail.com","username":"ttrifonov"},{"value":2,"date":"2012-11-16 22:28:26.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":330,"name":"John Dickinson","email":"me@not.mn","username":"notmyname"},{"value":2,"date":"2012-11-16 23:11:29.000000000","_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":2455,"name":"Tihomir Trifonov","email":"t.trifonov@gmail.com","username":"ttrifonov"},{"value":0,"date":"2012-11-16 22:28:26.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":330,"name":"John Dickinson","email":"me@not.mn","username":"notmyname"},{"value":1,"date":"2012-11-16 23:11:29.000000000","_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":330,"name":"John Dickinson","email":"me@not.mn","username":"notmyname"},{"_account_id":2455,"name":"Tihomir Trifonov","email":"t.trifonov@gmail.com","username":"ttrifonov"},{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2012-11-16 22:28:26.000000000","updated_by":{"_account_id":330,"name":"John Dickinson","email":"me@not.mn","username":"notmyname"},"reviewer":{"_account_id":330,"name":"John Dickinson","email":"me@not.mn","username":"notmyname"},"state":"REVIEWER"},{"updated":"2012-11-16 23:11:29.000000000","updated_by":{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},"reviewer":{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},"state":"REVIEWER"},{"updated":"2012-11-16 23:13:09.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"93e14bce14c6f9268192648944166c03a18ee046","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-10-11 12:21:46.000000000","message":"Patch Set 1: Works for me\n\nBuild successful\n\n- http://logs.openstack.org/14330/1/check/gate-python-swiftclient-merge/114 : SUCCESS\n- http://logs.openstack.org/14330/1/check/gate-python-swiftclient-docs/63 : SUCCESS\n- http://logs.openstack.org/14330/1/check/gate-python-swiftclient-pep8/112 : SUCCESS\n- http://logs.openstack.org/14330/1/check/gate-python-swiftclient-python26/111 : SUCCESS\n- http://logs.openstack.org/14330/1/check/gate-python-swiftclient-python27/111 : SUCCESS\n","accounts_in_message":[],"_revision_number":1},{"id":"d3ce7c8cfde85b138d90d58e10ae7aff6f2caedf","author":{"_account_id":330,"name":"John Dickinson","email":"me@not.mn","username":"notmyname"},"date":"2012-10-23 18:00:54.000000000","message":"Patch Set 1: I would prefer that you didn\u0027t merge this\n\nThis seems to break existing functionality. For example, using a \u0027:\u0027 in a header now gets escaped. This breaks auth requests to clusters using tempauth and swauth.","accounts_in_message":[],"_revision_number":1},{"id":"1a8a5b78bfb02fc6a3231ec0af654bcab4f7a20a","author":{"_account_id":2455,"name":"Tihomir Trifonov","email":"t.trifonov@gmail.com","username":"ttrifonov"},"date":"2012-10-23 19:13:42.000000000","message":"Patch Set 1:\n\nJohn,\n\nnice catch. Assuming that the allowed separators for HTTP headers according to RFC-2616 are \u0027()\u003c\u003e@,;:\\\\\"/[]?\u003d{} \\t\u0027, his will not escape unwanted symbols:\n\n    allowed_separators \u003d \u0027()\u003c\u003e@,;:\\\\\"/[]?\u003d{} \\t\u0027\n\n    def putheader_escaped(key, value):\n        func(quote(key, allowed_separators),\n             quote(value, allowed_separators))\n\nand will probably work as expected. Any thoughts on that?","accounts_in_message":[],"_revision_number":1},{"id":"2b1cf393c78dc86ffcf5f2ec30e2ac8632ab9d34","author":{"_account_id":330,"name":"John Dickinson","email":"me@not.mn","username":"notmyname"},"date":"2012-10-23 19:58:02.000000000","message":"Patch Set 1:\n\nya, that seems to work","accounts_in_message":[],"_revision_number":1},{"id":"c81569b806b742d0450f02c0651688fd9a8f1765","author":{"_account_id":2455,"name":"Tihomir Trifonov","email":"t.trifonov@gmail.com","username":"ttrifonov"},"date":"2012-10-24 09:15:27.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"2423c6032a4202f06780caadef0032319cd84241","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-10-24 09:16:58.000000000","message":"Patch Set 2: Doesn\u0027t seem to work\n\nBuild failed\n\n- http://logs.openstack.org/14330/2/check/gate-python-swiftclient-merge/118 : SUCCESS\n- http://logs.openstack.org/14330/2/check/gate-python-swiftclient-docs/67 : SUCCESS\n- http://logs.openstack.org/14330/2/check/gate-python-swiftclient-pep8/116 : SUCCESS\n- http://logs.openstack.org/14330/2/check/gate-python-swiftclient-python26/115 : FAILURE\n- http://logs.openstack.org/14330/2/check/gate-python-swiftclient-python27/115 : SUCCESS\n","accounts_in_message":[],"_revision_number":2},{"id":"e7f4dd3b07d5dc1888d9c60b5d48645fd08859bf","author":{"_account_id":2455,"name":"Tihomir Trifonov","email":"t.trifonov@gmail.com","username":"ttrifonov"},"date":"2012-10-24 09:22:46.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"7807c7de8c8d9808097edff769cfba9947e84f85","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-10-24 09:24:13.000000000","message":"Patch Set 3: Works for me\n\nBuild successful\n\n- http://logs.openstack.org/14330/3/check/gate-python-swiftclient-merge/119 : SUCCESS\n- http://logs.openstack.org/14330/3/check/gate-python-swiftclient-docs/68 : SUCCESS\n- http://logs.openstack.org/14330/3/check/gate-python-swiftclient-pep8/117 : SUCCESS\n- http://logs.openstack.org/14330/3/check/gate-python-swiftclient-python26/116 : SUCCESS\n- http://logs.openstack.org/14330/3/check/gate-python-swiftclient-python27/116 : SUCCESS\n","accounts_in_message":[],"_revision_number":3},{"id":"1bc0f32c6dcdabf3780a73c86774fbff7a4191b3","author":{"_account_id":330,"name":"John Dickinson","email":"me@not.mn","username":"notmyname"},"date":"2012-10-24 23:42:37.000000000","message":"Patch Set 3: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":3},{"id":"0b64dc7c085ed584709fc9d2542e7764f61fea5c","author":{"_account_id":330,"name":"John Dickinson","email":"me@not.mn","username":"notmyname"},"date":"2012-10-25 22:52:16.000000000","message":"Patch Set 3: I would prefer that you didn\u0027t merge this\n\nThis breaks ACL parsing. Specifically, w.r.t. header values containing a *. You can duplicate this bug by using this version of the client and running swift\u0027s functional tests (./.functests in the swift source dir).","accounts_in_message":[],"_revision_number":3},{"id":"2cd6048d81c429399bda7a80dcdf3dd3bf24caa9","author":{"_account_id":9,"name":"LaunchpadSync","username":"launchpadsync"},"date":"2012-11-02 06:03:03.000000000","message":"Patch Set 3:\n\ncode review expired after 1 week of no activity after a negative review, it can be restored using the `Restore Change` button under the Patch Set on the web interface","accounts_in_message":[],"_revision_number":3},{"id":"e3732fa9f98d0676b3bff679db1401aaf6f852de","author":{"_account_id":9,"name":"LaunchpadSync","username":"launchpadsync"},"date":"2012-11-02 06:03:03.000000000","message":"Patch Set 3: Abandoned\n\ncode review expired after 1 week of no activity after a negative review, it can be restored using the `Restore Change` button under the Patch Set on the web interface","accounts_in_message":[],"_revision_number":3},{"id":"2f8db5a74018d6552af39894f9700fbfeccd5421","author":{"_account_id":2455,"name":"Tihomir Trifonov","email":"t.trifonov@gmail.com","username":"ttrifonov"},"date":"2012-11-02 13:22:25.000000000","message":"Patch Set 3: Restored","accounts_in_message":[],"_revision_number":3},{"id":"7f361f3c05b3bc22686dd82901e41ef3a0afde29","author":{"_account_id":2455,"name":"Tihomir Trifonov","email":"t.trifonov@gmail.com","username":"ttrifonov"},"date":"2012-11-02 13:23:27.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"a56c5d8d4d67512219eb1aaa100ff75f8abde67b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-11-02 13:24:59.000000000","message":"Patch Set 4: Works for me\n\nBuild successful\n\n- http://logs.openstack.org/14330/4/check/gate-python-swiftclient-merge/122 : SUCCESS\n- http://logs.openstack.org/14330/4/check/gate-python-swiftclient-docs/71 : SUCCESS\n- http://logs.openstack.org/14330/4/check/gate-python-swiftclient-pep8/120 : SUCCESS\n- http://logs.openstack.org/14330/4/check/gate-python-swiftclient-python26/119 : SUCCESS\n- http://logs.openstack.org/14330/4/check/gate-python-swiftclient-python27/119 : SUCCESS\n","accounts_in_message":[],"_revision_number":4},{"id":"5c8ef02fb333d667ef01088f4dd6580cd24d564d","author":{"_account_id":2455,"name":"Tihomir Trifonov","email":"t.trifonov@gmail.com","username":"ttrifonov"},"date":"2012-11-02 13:25:08.000000000","message":"Patch Set 4:\n\nOk, it seems quoting is not applicable for http headers. I\u0027ve removed the quoting, and only utf8 encoding is left, to prevent concatenation of unicode and utf8 strings. The escaping however will be responsibility of the software, that uses python-swiftclient.","accounts_in_message":[],"_revision_number":4},{"id":"0a1a19620e0bfba5ccef00e1f1b881503b94636c","author":{"_account_id":330,"name":"John Dickinson","email":"me@not.mn","username":"notmyname"},"date":"2012-11-02 17:57:10.000000000","message":"Patch Set 4: I would prefer that you didn\u0027t merge this\n\n(1 inline comment)\n\nThere is one small thing I didn\u0027t catch earlier.","accounts_in_message":[],"_revision_number":4},{"id":"af7e6a77c391061b6c87e5b4af64fbcc4f7d8f98","author":{"_account_id":2455,"name":"Tihomir Trifonov","email":"t.trifonov@gmail.com","username":"ttrifonov"},"date":"2012-11-02 19:34:18.000000000","message":"Uploaded patch set 5.","accounts_in_message":[],"_revision_number":5},{"id":"fd64f57fc85d085ab9fd0412024271d377dfec6e","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-11-02 19:37:11.000000000","message":"Patch Set 5: Works for me\n\nBuild successful\n\n- http://logs.openstack.org/14330/5/check/gate-python-swiftclient-merge/123 : SUCCESS\n- http://logs.openstack.org/14330/5/check/gate-python-swiftclient-docs/72 : SUCCESS\n- http://logs.openstack.org/14330/5/check/gate-python-swiftclient-pep8/121 : SUCCESS\n- http://logs.openstack.org/14330/5/check/gate-python-swiftclient-python26/120 : SUCCESS\n- http://logs.openstack.org/14330/5/check/gate-python-swiftclient-python27/120 : SUCCESS\n","accounts_in_message":[],"_revision_number":5},{"id":"349298183d5dc8ec62a60465467b42b482c3f622","author":{"_account_id":330,"name":"John Dickinson","email":"me@not.mn","username":"notmyname"},"date":"2012-11-16 22:28:26.000000000","message":"Patch Set 5: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":5},{"id":"a76a8dab7da20375ba1ad32e75415e1b570cb990","author":{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},"date":"2012-11-16 23:11:29.000000000","message":"Patch Set 5: Looks good to me (core reviewer); Approved\n\n","accounts_in_message":[],"_revision_number":5},{"id":"c4b24cad4b23af95c048f7f3b0523f9ea4c517cc","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-11-16 23:11:41.000000000","message":"Patch Set 5: No score\n\nStarting gate jobs.\nhttps://jenkins.openstack.org/zuul/status","accounts_in_message":[],"_revision_number":5},{"id":"99f8e7eb8cfb80c2e3209ea0679beb3d85ab061b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-11-16 23:13:09.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":5},{"id":"f4d0eb58fe0b0fb5284497fc6d7f8eca13b6ae62","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-11-16 23:13:09.000000000","message":"Patch Set 5: Verified\n\nBuild successful\n\n- http://logs.openstack.org/14330/5/gate/gate-python-swiftclient-merge/134 : SUCCESS\n- http://logs.openstack.org/14330/5/gate/gate-python-swiftclient-docs/83 : SUCCESS\n- http://logs.openstack.org/14330/5/gate/gate-python-swiftclient-pep8/132 : SUCCESS\n- http://logs.openstack.org/14330/5/gate/gate-python-swiftclient-python26/131 : SUCCESS\n- http://logs.openstack.org/14330/5/gate/gate-python-swiftclient-python27/131 : SUCCESS\n","accounts_in_message":[],"_revision_number":5}],"current_revision_number":5,"current_revision":"8b42f8a40c9a48f85b8d4d859afb4e28a510c036","revisions":{"4429558e4f842cce0349b621be9372a61e4cc5c6":{"kind":"REWORK","_number":1,"created":"2012-10-11 12:20:03.000000000","uploader":{"_account_id":2455,"name":"Tihomir Trifonov","email":"t.trifonov@gmail.com","username":"ttrifonov"},"ref":"refs/changes/30/14330/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-swiftclient","ref":"refs/changes/30/14330/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/30/14330/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/30/14330/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/30/14330/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-swiftclient refs/changes/30/14330/1"}}},"commit":{"parents":[{"commit":"a99a37f7f6d905f4c305e68f8f5bd58e37683213","subject":"Merge \"\tFix swiftclient 400 error when OS_AUTH_URL is set.\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/a99a37f7f6d905f4c305e68f8f5bd58e37683213"}]}],"author":{"name":"Tihomir Trifonov","email":"t.trifonov@gmail.com","date":"2012-10-11 12:04:00.000000000","tz":180},"committer":{"name":"Tihomir Trifonov","email":"t.trifonov@gmail.com","date":"2012-10-11 12:19:47.000000000","tz":180},"subject":"Force utf-8 encode of HTTPConnection params","message":"Force utf-8 encode of HTTPConnection params\n\nThis patch forces swiftclient to encode to utf-8\nall url and headers arguments, to avoid the\nUnicodeDecodeError which is raised by \u0027\\r\\n\u0027.join([])\ninvoked in htplib.py.\n\nCurrently the affected projects are Horizon(upload file\nwith unicode name) and swiftclient CLI(\u0027swift post\u0027 with\nunicode filename as header)\n\nThis is also a follow-up of this review:\n    https://review.openstack.org/#/c/14216/\n\nI\u0027d still want to hear what the Swift core devs\nthink of it. Is it better to create a new\nAutoEncodingHTTPConnection? Or to handle the connection\ncreation and make sure there are no unicode and utf-8\nstring at the same time. If these unicode checks have to\nbe added in the calling code(Dashboard, CLI), there are\nso many places to be added, and also in all new commands\nthat might be exposed from the API.\n\nFixes bug 1008940\n\nChange-Id: Ice2aa29024429d3e6f569a88d5cf8b4202537827\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/4429558e4f842cce0349b621be9372a61e4cc5c6"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/4429558e4f842cce0349b621be9372a61e4cc5c6"}]},"branch":"refs/heads/master"},"2916b81e559bd353f1340d6d950386d5edcf7725":{"kind":"REWORK","_number":2,"created":"2012-10-24 09:15:27.000000000","uploader":{"_account_id":2455,"name":"Tihomir Trifonov","email":"t.trifonov@gmail.com","username":"ttrifonov"},"ref":"refs/changes/30/14330/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-swiftclient","ref":"refs/changes/30/14330/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/30/14330/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/30/14330/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/30/14330/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-swiftclient refs/changes/30/14330/2"}}},"commit":{"parents":[{"commit":"a99a37f7f6d905f4c305e68f8f5bd58e37683213","subject":"Merge \"\tFix swiftclient 400 error when OS_AUTH_URL is set.\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/a99a37f7f6d905f4c305e68f8f5bd58e37683213"}]}],"author":{"name":"Tihomir Trifonov","email":"t.trifonov@gmail.com","date":"2012-10-11 12:04:00.000000000","tz":180},"committer":{"name":"Tihomir Trifonov","email":"t.trifonov@gmail.com","date":"2012-10-24 09:11:50.000000000","tz":180},"subject":"Force utf-8 encode of HTTPConnection params","message":"Force utf-8 encode of HTTPConnection params\n\nThis patch forces swiftclient to encode to utf-8\nall url and headers arguments, to avoid the\nUnicodeDecodeError which is raised by \u0027\\r\\n\u0027.join([])\ninvoked in htplib.py.\n\nCurrently the affected projects are Horizon(upload file\nwith unicode name) and swiftclient CLI(\u0027swift post\u0027 with\nunicode filename as header)\n\nThis is also a follow-up of this review:\n    https://review.openstack.org/#/c/14216/\n\nI\u0027d still want to hear what the Swift core devs\nthink of it. Is it better to create a new\nAutoEncodingHTTPConnection? Or to handle the connection\ncreation and make sure there are no unicode and utf-8\nstring at the same time. If these unicode checks have to\nbe added in the calling code(Dashboard, CLI), there are\nso many places to be added, and also in all new commands\nthat might be exposed from the API.\n\nFixes bug 1008940\n\nPatch Set 2: marking some symbols as safe for escaping\nin HTTP headers as specified by RFC-2616.\n\nChange-Id: Ice2aa29024429d3e6f569a88d5cf8b4202537827\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/2916b81e559bd353f1340d6d950386d5edcf7725"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/2916b81e559bd353f1340d6d950386d5edcf7725"}]},"branch":"refs/heads/master"},"2ed16e07c6b6de1f17620a310f6b569014bba37c":{"kind":"REWORK","_number":3,"created":"2012-10-24 09:22:46.000000000","uploader":{"_account_id":2455,"name":"Tihomir Trifonov","email":"t.trifonov@gmail.com","username":"ttrifonov"},"ref":"refs/changes/30/14330/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-swiftclient","ref":"refs/changes/30/14330/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/30/14330/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/30/14330/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/30/14330/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-swiftclient refs/changes/30/14330/3"}}},"commit":{"parents":[{"commit":"a99a37f7f6d905f4c305e68f8f5bd58e37683213","subject":"Merge \"\tFix swiftclient 400 error when OS_AUTH_URL is set.\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/a99a37f7f6d905f4c305e68f8f5bd58e37683213"}]}],"author":{"name":"Tihomir Trifonov","email":"t.trifonov@gmail.com","date":"2012-10-11 12:04:00.000000000","tz":180},"committer":{"name":"Tihomir Trifonov","email":"t.trifonov@gmail.com","date":"2012-10-24 09:22:30.000000000","tz":180},"subject":"Force utf-8 encode of HTTPConnection params","message":"Force utf-8 encode of HTTPConnection params\n\nThis patch forces swiftclient to encode to utf-8\nall url and headers arguments, to avoid the\nUnicodeDecodeError which is raised by \u0027\\r\\n\u0027.join([])\ninvoked in htplib.py.\n\nCurrently the affected projects are Horizon(upload file\nwith unicode name) and swiftclient CLI(\u0027swift post\u0027 with\nunicode filename as header)\n\nThis is also a follow-up of this review:\n    https://review.openstack.org/#/c/14216/\n\nI\u0027d still want to hear what the Swift core devs\nthink of it. Is it better to create a new\nAutoEncodingHTTPConnection? Or to handle the connection\ncreation and make sure there are no unicode and utf-8\nstring at the same time. If these unicode checks have to\nbe added in the calling code(Dashboard, CLI), there are\nso many places to be added, and also in all new commands\nthat might be exposed from the API.\n\nFixes bug 1008940\n\nPatch Set 3: marking some symbols as safe for escaping\nin HTTP headers as specified by RFC-2616.\n\nChange-Id: Ice2aa29024429d3e6f569a88d5cf8b4202537827\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/2ed16e07c6b6de1f17620a310f6b569014bba37c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/2ed16e07c6b6de1f17620a310f6b569014bba37c"}]},"branch":"refs/heads/master"},"42f0cc83fe67809c41253403c94c428d7f0e0d3e":{"kind":"REWORK","_number":4,"created":"2012-11-02 13:23:27.000000000","uploader":{"_account_id":2455,"name":"Tihomir Trifonov","email":"t.trifonov@gmail.com","username":"ttrifonov"},"ref":"refs/changes/30/14330/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-swiftclient","ref":"refs/changes/30/14330/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/30/14330/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/30/14330/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/30/14330/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-swiftclient refs/changes/30/14330/4"}}},"commit":{"parents":[{"commit":"656b80bef38db8eda148288a4cb5c9fbd3a0da4b","subject":"swiftclient Connection : default optional arguments to None","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/656b80bef38db8eda148288a4cb5c9fbd3a0da4b"}]}],"author":{"name":"Tihomir Trifonov","email":"t.trifonov@gmail.com","date":"2012-10-11 12:04:00.000000000","tz":180},"committer":{"name":"Tihomir Trifonov","email":"t.trifonov@gmail.com","date":"2012-11-02 13:20:48.000000000","tz":120},"subject":"Force utf-8 encode of HTTPConnection params","message":"Force utf-8 encode of HTTPConnection params\n\nThis patch forces swiftclient to encode to utf-8\nall url and headers arguments, to avoid the\nUnicodeDecodeError which is raised by \u0027\\r\\n\u0027.join([])\ninvoked in htplib.py.\n\nCurrently the affected projects are Horizon(upload file\nwith unicode name) and swiftclient CLI(\u0027swift post\u0027 with\nunicode filename as header)\n\nThis is also a follow-up of this review:\n    https://review.openstack.org/#/c/14216/\n\nI\u0027d still want to hear what the Swift core devs\nthink of it. Is it better to create a new\nAutoEncodingHTTPConnection? Or to handle the connection\ncreation and make sure there are no unicode and utf-8\nstring at the same time. If these unicode checks have to\nbe added in the calling code(Dashboard, CLI), there are\nso many places to be added, and also in all new commands\nthat might be exposed from the API.\n\nFixes bug 1008940\n\nChange-Id: Ice2aa29024429d3e6f569a88d5cf8b4202537827\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/42f0cc83fe67809c41253403c94c428d7f0e0d3e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/42f0cc83fe67809c41253403c94c428d7f0e0d3e"}]},"branch":"refs/heads/master"},"8b42f8a40c9a48f85b8d4d859afb4e28a510c036":{"kind":"REWORK","_number":5,"created":"2012-11-02 19:34:18.000000000","uploader":{"_account_id":2455,"name":"Tihomir Trifonov","email":"t.trifonov@gmail.com","username":"ttrifonov"},"ref":"refs/changes/30/14330/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-swiftclient","ref":"refs/changes/30/14330/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/30/14330/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/30/14330/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/30/14330/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-swiftclient refs/changes/30/14330/5"}}},"commit":{"parents":[{"commit":"656b80bef38db8eda148288a4cb5c9fbd3a0da4b","subject":"swiftclient Connection : default optional arguments to None","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/656b80bef38db8eda148288a4cb5c9fbd3a0da4b"}]}],"author":{"name":"Tihomir Trifonov","email":"t.trifonov@gmail.com","date":"2012-10-11 12:04:00.000000000","tz":180},"committer":{"name":"Tihomir Trifonov","email":"t.trifonov@gmail.com","date":"2012-11-02 19:33:32.000000000","tz":120},"subject":"Force utf-8 encode of HTTPConnection params","message":"Force utf-8 encode of HTTPConnection params\n\nThis patch forces swiftclient to encode to utf-8\nall url and headers arguments, to avoid the\nUnicodeDecodeError which is raised by \u0027\\r\\n\u0027.join([])\ninvoked in htplib.py.\n\nCurrently the affected projects are Horizon(upload file\nwith unicode name) and swiftclient CLI(\u0027swift post\u0027 with\nunicode filename as header)\n\nThis is also a follow-up of this review:\n    https://review.openstack.org/#/c/14216/\n\nI\u0027d still want to hear what the Swift core devs\nthink of it. Is it better to create a new\nAutoEncodingHTTPConnection? Or to handle the connection\ncreation and make sure there are no unicode and utf-8\nstring at the same time. If these unicode checks have to\nbe added in the calling code(Dashboard, CLI), there are\nso many places to be added, and also in all new commands\nthat might be exposed from the API.\n\nFixes bug 1008940\n\nChange-Id: Ice2aa29024429d3e6f569a88d5cf8b4202537827\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/8b42f8a40c9a48f85b8d4d859afb4e28a510c036"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/8b42f8a40c9a48f85b8d4d859afb4e28a510c036"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}