)]}'
{"id":"openstack%2Fpython-swiftclient~149043","triplet_id":"openstack%2Fpython-swiftclient~master~Id1c72ad86135a49d4b985992d788736b65f7dbda","project":"openstack/python-swiftclient","branch":"master","topic":"test_connection_release","hashtags":[],"change_id":"Id1c72ad86135a49d4b985992d788736b65f7dbda","subject":"Release connection after consuming the content","status":"MERGED","created":"2015-01-21 20:39:51.000000000","updated":"2015-02-25 13:54:16.000000000","submitted":"2015-02-25 13:54:14.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"7c60d864ba6392d5269e0ebf9f3a685410fc1c40","_number":149043,"virtual_id_number":149043,"owner":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},{"value":0,"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},{"value":0,"_account_id":15090,"name":"Elvis Teixeira","email":"elvis.teixeira@lsbd.ufc.br","username":"ElvisTeixeira"},{"value":2,"date":"2015-02-25 13:54:14.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":13635,"name":"Cory Benfield","email":"cory.benfield@hpe.com","username":"Lukasa"},{"value":0,"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},{"value":0,"_account_id":6968,"name":"Christian Schwede","email":"cschwede@nvidia.com","username":"cschwede"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"value":0,"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"all":[{"value":0,"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},{"value":0,"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},{"value":0,"_account_id":15090,"name":"Elvis Teixeira","email":"elvis.teixeira@lsbd.ufc.br","username":"ElvisTeixeira"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":13635,"name":"Cory Benfield","email":"cory.benfield@hpe.com","username":"Lukasa"},{"value":2,"date":"2015-02-25 11:03:17.000000000","_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},{"value":2,"date":"2015-02-25 11:06:50.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":6968,"name":"Christian Schwede","email":"cschwede@nvidia.com","username":"cschwede"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"value":0,"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":6968,"name":"Christian Schwede","email":"cschwede@nvidia.com","username":"cschwede"},"all":[{"value":0,"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},{"value":0,"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},{"value":0,"_account_id":15090,"name":"Elvis Teixeira","email":"elvis.teixeira@lsbd.ufc.br","username":"ElvisTeixeira"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":13635,"name":"Cory Benfield","email":"cory.benfield@hpe.com","username":"Lukasa"},{"value":0,"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},{"value":1,"date":"2015-02-25 11:06:50.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":6968,"name":"Christian Schwede","email":"cschwede@nvidia.com","username":"cschwede"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"value":0,"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"_account_id":6968,"name":"Christian Schwede","email":"cschwede@nvidia.com","username":"cschwede"},{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},{"_account_id":13635,"name":"Cory Benfield","email":"cory.benfield@hpe.com","username":"Lukasa"},{"_account_id":15090,"name":"Elvis Teixeira","email":"elvis.teixeira@lsbd.ufc.br","username":"ElvisTeixeira"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-01-21 20:40:48.000000000","updated_by":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"reviewer":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"state":"REVIEWER"},{"updated":"2015-01-22 01:50:36.000000000","updated_by":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"reviewer":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"state":"REVIEWER"},{"updated":"2015-02-24 17:34:06.000000000","updated_by":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"reviewer":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"state":"REVIEWER"},{"updated":"2015-02-24 17:36:09.000000000","updated_by":{"_account_id":13635,"name":"Cory Benfield","email":"cory.benfield@hpe.com","username":"Lukasa"},"reviewer":{"_account_id":13635,"name":"Cory Benfield","email":"cory.benfield@hpe.com","username":"Lukasa"},"state":"REVIEWER"},{"updated":"2015-02-24 19:10:56.000000000","updated_by":{"_account_id":15090,"name":"Elvis Teixeira","email":"elvis.teixeira@lsbd.ufc.br","username":"ElvisTeixeira"},"reviewer":{"_account_id":15090,"name":"Elvis Teixeira","email":"elvis.teixeira@lsbd.ufc.br","username":"ElvisTeixeira"},"state":"REVIEWER"},{"updated":"2015-02-24 22:34:34.000000000","updated_by":{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},"reviewer":{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},"state":"REVIEWER"},{"updated":"2015-02-25 01:10:31.000000000","updated_by":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"reviewer":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"state":"REVIEWER"},{"updated":"2015-02-25 11:06:50.000000000","updated_by":{"_account_id":6968,"name":"Christian Schwede","email":"cschwede@nvidia.com","username":"cschwede"},"reviewer":{"_account_id":6968,"name":"Christian Schwede","email":"cschwede@nvidia.com","username":"cschwede"},"state":"REVIEWER"},{"updated":"2015-02-25 13:54:14.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"4a1a35b54d26d25d76dd5a7ed71178907b6f3420","author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"date":"2015-01-21 20:39:51.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"8765da5aaebe74e0644390f0d6d6988c7550e78b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-01-21 21:09:22.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-swiftclient-python26 http://logs.openstack.org/43/149043/1/check/gate-python-swiftclient-python26/e079f6e/ : SUCCESS in 47s\n- gate-python-swiftclient-pep8 http://logs.openstack.org/43/149043/1/check/gate-python-swiftclient-pep8/76efe9c/ : FAILURE in 40s\n- gate-python-swiftclient-docs http://docs-draft.openstack.org/43/149043/1/check/gate-python-swiftclient-docs/05457d8//doc/build/html/ : SUCCESS in 47s\n- gate-python-swiftclient-python27 http://logs.openstack.org/43/149043/1/check/gate-python-swiftclient-python27/6300577/ : SUCCESS in 52s\n- gate-python-swiftclient-python33 http://logs.openstack.org/43/149043/1/check/gate-python-swiftclient-python33/c56d004/ : SUCCESS in 2m 35s\n- gate-tempest-dsvm-neutron-src-python-swiftclient-icehouse http://logs.openstack.org/43/149043/1/check/gate-tempest-dsvm-neutron-src-python-swiftclient-icehouse/48a4bce/ : SUCCESS in 27m 58s\n- gate-tempest-dsvm-neutron-src-python-swiftclient-juno http://logs.openstack.org/43/149043/1/check/gate-tempest-dsvm-neutron-src-python-swiftclient-juno/44093ec/ : SUCCESS in 28m 13s\n- gate-python-swiftclient-pypy http://logs.openstack.org/43/149043/1/check/gate-python-swiftclient-pypy/2095317/ : SUCCESS in 1m 32s\n- gate-tempest-dsvm-neutron-src-python-swiftclient http://logs.openstack.org/43/149043/1/check/gate-tempest-dsvm-neutron-src-python-swiftclient/ecff200/ : SUCCESS in 29m 26s\n- check-swift-dsvm-functional http://logs.openstack.org/43/149043/1/check/check-swift-dsvm-functional/7db51e3/ : SUCCESS in 23m 02s\n- check-swiftclient-dsvm-functional http://logs.openstack.org/43/149043/1/check/check-swiftclient-dsvm-functional/ab47467/ : FAILURE in 12m 21s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"9062e64333ad3ead3c64771b3b082a7d46c7db1f","author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"date":"2015-01-21 21:39:21.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"0ba61be898c545daa9fc6c2d5e8796623ecb39e1","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-01-21 22:21:05.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-swiftclient-python26 http://logs.openstack.org/43/149043/2/check/gate-python-swiftclient-python26/5f48c43/ : SUCCESS in 45s\n- gate-python-swiftclient-pep8 http://logs.openstack.org/43/149043/2/check/gate-python-swiftclient-pep8/2edbe09/ : SUCCESS in 34s\n- gate-python-swiftclient-docs http://docs-draft.openstack.org/43/149043/2/check/gate-python-swiftclient-docs/dd9f50e//doc/build/html/ : SUCCESS in 40s\n- gate-python-swiftclient-python27 http://logs.openstack.org/43/149043/2/check/gate-python-swiftclient-python27/c5cb171/ : SUCCESS in 54s\n- gate-python-swiftclient-python33 http://logs.openstack.org/43/149043/2/check/gate-python-swiftclient-python33/f848a91/ : SUCCESS in 2m 46s\n- gate-tempest-dsvm-neutron-src-python-swiftclient-icehouse http://logs.openstack.org/43/149043/2/check/gate-tempest-dsvm-neutron-src-python-swiftclient-icehouse/6eff59f/ : SUCCESS in 27m 35s\n- gate-tempest-dsvm-neutron-src-python-swiftclient-juno http://logs.openstack.org/43/149043/2/check/gate-tempest-dsvm-neutron-src-python-swiftclient-juno/c29a672/ : SUCCESS in 32m 41s\n- gate-python-swiftclient-pypy http://logs.openstack.org/43/149043/2/check/gate-python-swiftclient-pypy/8ca3360/ : SUCCESS in 1m 22s\n- gate-tempest-dsvm-neutron-src-python-swiftclient http://logs.openstack.org/43/149043/2/check/gate-tempest-dsvm-neutron-src-python-swiftclient/d1c7270/ : SUCCESS in 40m 10s\n- check-swift-dsvm-functional http://logs.openstack.org/43/149043/2/check/check-swift-dsvm-functional/d0913ca/ : SUCCESS in 23m 14s\n- check-swiftclient-dsvm-functional http://logs.openstack.org/43/149043/2/check/check-swiftclient-dsvm-functional/e0ee83c/ : FAILURE in 14m 43s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"e2f5d7791a411db13ce082c41d449837e1d3ba00","author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"date":"2015-01-22 01:50:36.000000000","message":"Patch Set 2:\n\nyeah so I find 0 test infrastructure that will exercise this code path (insert NameError, all tests still pass).  So unfortunately you have options:\n\n1) write some new test infrastructure that will exercise this code with minimal mocking in such a way that reviewers can still run it on the old code and get a reasonable failure then run it again with this patch and verify that a reasonable assertion about the expected behavior passes.\n\n2) explain how you observed the problem and how to reproduce the undesirable behavior functionally and validate the fix (e.g. an example script using swiftclient with stream\u003dTrue).  If the script can isolate the bad behavior in-process it may be a good candidate to extend swiftclient\u0027s anemic functional test suite.","accounts_in_message":[],"_revision_number":2},{"id":"bfb4dc08752bae71e06af659bb7353db51a69c2c","author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"date":"2015-01-24 20:48:16.000000000","message":"Patch Set 2:\n\nHey Clay,\n\nThere really isn\u0027t a \"bug\" per-se that this is fixing just an annoying log message that it will reduce the frequency of. If you look at the linked bug in the commit message then you\u0027ll see that this is (in part) triggered by glance\u0027s use of swiftclient. I can write a test that may need some heavy mocking so we can assert that `close` is in fact called after a response has been streamed. Would that be sufficient in your opinion?","accounts_in_message":[],"_revision_number":2},{"id":"3d1b6a161a92593e21a70a25ac5870be8818f040","author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"date":"2015-02-24 17:28:12.000000000","message":"Patch Set 2:\n\nThis perfectly normal log message also has proven to be a red herring to people trying to debug issues in the past. Pete Zaitcev only just recently opened an issue because glance broke the python-swiftclient gate and they titled their issue with this log message assuming that requests/urllib3 was to blame because of the locality of the message. Eliminating this message will be helpful in general. It\u0027ll certainly still pop up occasionally but this should significantly reduce the frequency.","accounts_in_message":[],"_revision_number":2},{"id":"590f0cb9397c38bd4a6b31dff9fbff9a72a5ff10","author":{"_account_id":13635,"name":"Cory Benfield","email":"cory.benfield@hpe.com","username":"Lukasa"},"date":"2015-02-24 17:36:09.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"25cacfea53ff5c0550a31fc0dd379bc1a5575ca8","author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"date":"2015-02-24 18:25:08.000000000","message":"Patch Set 2: Code-Review+1\n\n(1 comment)\n\nI think this is good, I\u0027m going to put +1 on it for now, and think how this could be tested.","accounts_in_message":[],"_revision_number":2},{"id":"b627c588d7de640c0a6b13c823eb605dc630f733","author":{"_account_id":15090,"name":"Elvis Teixeira","email":"elvis.teixeira@lsbd.ufc.br","username":"ElvisTeixeira"},"date":"2015-02-24 19:10:56.000000000","message":"Patch Set 2: Code-Review+1\n\nFine","accounts_in_message":[],"_revision_number":2},{"id":"67ef8d5696523e4e445fcaad6e0d2e331341ecc7","author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"date":"2015-02-24 20:43:23.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"54ae9c867903d8a8c53c4037da3cece1ee3ea862","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-02-24 22:00:53.000000000","message":"Patch Set 3: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-swiftclient-python26 http://logs.openstack.org/43/149043/3/check/gate-python-swiftclient-python26/4c739a7/ : SUCCESS in 55s\n- gate-python-swiftclient-pep8 http://logs.openstack.org/43/149043/3/check/gate-python-swiftclient-pep8/c169828/ : SUCCESS in 47s\n- gate-python-swiftclient-docs http://docs-draft.openstack.org/43/149043/3/check/gate-python-swiftclient-docs/8bfba48//doc/build/html/ : SUCCESS in 1m 00s\n- gate-python-swiftclient-python27 http://logs.openstack.org/43/149043/3/check/gate-python-swiftclient-python27/1033c27/ : SUCCESS in 1m 10s\n- gate-python-swiftclient-python34 http://logs.openstack.org/43/149043/3/check/gate-python-swiftclient-python34/ae29931/ : SUCCESS in 3m 00s\n- gate-tempest-dsvm-neutron-src-python-swiftclient-icehouse http://logs.openstack.org/43/149043/3/check/gate-tempest-dsvm-neutron-src-python-swiftclient-icehouse/3bc481e/ : FAILURE in 13m 55s\n- gate-tempest-dsvm-neutron-src-python-swiftclient-juno http://logs.openstack.org/43/149043/3/check/gate-tempest-dsvm-neutron-src-python-swiftclient-juno/88b21f3/ : SUCCESS in 39m 41s\n- gate-python-swiftclient-pypy http://logs.openstack.org/43/149043/3/check/gate-python-swiftclient-pypy/aa823f9/ : SUCCESS in 1m 19s\n- gate-tempest-dsvm-neutron-src-python-swiftclient http://logs.openstack.org/43/149043/3/check/gate-tempest-dsvm-neutron-src-python-swiftclient/0982994/ : SUCCESS in 1h 07m 31s\n- check-swift-dsvm-functional http://logs.openstack.org/43/149043/3/check/check-swift-dsvm-functional/99fbfde/ : SUCCESS in 24m 24s\n- check-swiftclient-dsvm-functional http://logs.openstack.org/43/149043/3/check/check-swiftclient-dsvm-functional/e578c6f/ : SUCCESS in 24m 40s (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"35c1ca81e74c5dfb2b1171a3cbaa2b0540fc8acc","author":{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},"date":"2015-02-24 22:34:34.000000000","message":"Patch Set 3:\n\nrecheck no bug","accounts_in_message":[],"_revision_number":3},{"id":"283f23d4306a0aabaac608e882171e14f1d76359","author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"date":"2015-02-24 23:06:47.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"dd993150e85b73e187bb815243ef9adc4a18f854","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-02-24 23:32:17.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-swiftclient-python26 http://logs.openstack.org/43/149043/3/check/gate-python-swiftclient-python26/400974d/ : SUCCESS in 50s\n- gate-python-swiftclient-pep8 http://logs.openstack.org/43/149043/3/check/gate-python-swiftclient-pep8/3f2bae6/ : SUCCESS in 36s\n- gate-python-swiftclient-docs http://docs-draft.openstack.org/43/149043/3/check/gate-python-swiftclient-docs/7e9044a//doc/build/html/ : SUCCESS in 47s\n- gate-python-swiftclient-python27 http://logs.openstack.org/43/149043/3/check/gate-python-swiftclient-python27/7e5111a/ : SUCCESS in 58s\n- gate-python-swiftclient-python34 http://logs.openstack.org/43/149043/3/check/gate-python-swiftclient-python34/ce91e48/ : SUCCESS in 2m 48s\n- gate-tempest-dsvm-neutron-src-python-swiftclient-icehouse http://logs.openstack.org/43/149043/3/check/gate-tempest-dsvm-neutron-src-python-swiftclient-icehouse/9983fd4/ : SUCCESS in 29m 42s\n- gate-tempest-dsvm-neutron-src-python-swiftclient-juno http://logs.openstack.org/43/149043/3/check/gate-tempest-dsvm-neutron-src-python-swiftclient-juno/63c6291/ : SUCCESS in 40m 15s\n- gate-python-swiftclient-pypy http://logs.openstack.org/43/149043/3/check/gate-python-swiftclient-pypy/a80c02c/ : SUCCESS in 1m 08s\n- gate-tempest-dsvm-neutron-src-python-swiftclient http://logs.openstack.org/43/149043/3/check/gate-tempest-dsvm-neutron-src-python-swiftclient/6cdc633/ : SUCCESS in 54m 32s\n- check-swift-dsvm-functional http://logs.openstack.org/43/149043/3/check/check-swift-dsvm-functional/d360242/ : SUCCESS in 26m 57s\n- check-swiftclient-dsvm-functional http://logs.openstack.org/43/149043/3/check/check-swiftclient-dsvm-functional/ecae705/ : SUCCESS in 21m 15s (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"d4309ab91b74e1d123dc2e3784de8776c7282391","author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"date":"2015-02-25 01:10:31.000000000","message":"Patch Set 3: Code-Review+2\n\nOkay. I think the code looks good, although of course the lack of pointed testing is a little disconcerning.","accounts_in_message":[],"_revision_number":3},{"id":"4a2cccaba28b5e7d32ee7d7923a1c51fcf19f0c5","author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"date":"2015-02-25 01:15:46.000000000","message":"Patch Set 3:\n\nI\u0027m happy to circle back around when there is testing for this section. I\u0027m just not comfortable adding testing for this for all of you being a drive-by contributor and whatnot.","accounts_in_message":[],"_revision_number":3},{"id":"df4e756de15a48cb8bd3bf26c2ebf04c6cae2c88","author":{"_account_id":6968,"name":"Christian Schwede","email":"cschwede@nvidia.com","username":"cschwede"},"date":"2015-02-25 11:03:17.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"f207068637cdbbf22f8e84ba40b522fa7e2c5fcc","author":{"_account_id":6968,"name":"Christian Schwede","email":"cschwede@nvidia.com","username":"cschwede"},"date":"2015-02-25 11:06:50.000000000","message":"Patch Set 4: Code-Review+2 Workflow+1\n\nThis code looks good to me, thanks for the fix!\n\nI added a simple follow up patch with a test to avoid regression, thus the rebase. The test only ensures that resp.close() has been called after all chunks are consumed.","accounts_in_message":[],"_revision_number":4},{"id":"1c11358d0b00e7534fa6ebeb7623f415bf5a5beb","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-02-25 12:32:02.000000000","message":"Patch Set 4: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-swiftclient-python26 http://logs.openstack.org/43/149043/4/check/gate-python-swiftclient-python26/b3dc498/ : SUCCESS in 1m 05s\n- gate-python-swiftclient-pep8 http://logs.openstack.org/43/149043/4/check/gate-python-swiftclient-pep8/e19964d/ : SUCCESS in 54s\n- gate-python-swiftclient-docs http://docs-draft.openstack.org/43/149043/4/check/gate-python-swiftclient-docs/b6c2f01//doc/build/html/ : SUCCESS in 47s\n- gate-python-swiftclient-python27 http://logs.openstack.org/43/149043/4/check/gate-python-swiftclient-python27/aa65072/ : SUCCESS in 51s\n- gate-python-swiftclient-python34 http://logs.openstack.org/43/149043/4/check/gate-python-swiftclient-python34/8a2fbff/ : SUCCESS in 3m 25s\n- gate-tempest-dsvm-neutron-src-python-swiftclient-icehouse http://logs.openstack.org/43/149043/4/check/gate-tempest-dsvm-neutron-src-python-swiftclient-icehouse/63f9ed9/ : SUCCESS in 33m 41s\n- gate-tempest-dsvm-neutron-src-python-swiftclient-juno http://logs.openstack.org/43/149043/4/check/gate-tempest-dsvm-neutron-src-python-swiftclient-juno/eb78d5a/ : SUCCESS in 48m 46s\n- gate-python-swiftclient-pypy http://logs.openstack.org/43/149043/4/check/gate-python-swiftclient-pypy/252c1c9/ : SUCCESS in 1m 23s\n- gate-tempest-dsvm-neutron-src-python-swiftclient http://logs.openstack.org/43/149043/4/check/gate-tempest-dsvm-neutron-src-python-swiftclient/768d391/ : SUCCESS in 1h 13m 14s\n- check-swift-dsvm-functional http://logs.openstack.org/43/149043/4/check/check-swift-dsvm-functional/7479bd0/ : SUCCESS in 33m 41s\n- check-swiftclient-dsvm-functional http://logs.openstack.org/43/149043/4/check/check-swiftclient-dsvm-functional/f646408/ : SUCCESS in 26m 26s (non-voting)","accounts_in_message":[],"_revision_number":4},{"id":"8280e56a219f58d897851e36b47a4797c8c7ece4","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-02-25 12:32:05.000000000","message":"Patch Set 4: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":4},{"id":"cab9723dbe6c077a71d0ea8995f1bfea1de09177","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-02-25 13:54:14.000000000","message":"Patch Set 4: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-swiftclient-python26 http://logs.openstack.org/43/149043/4/gate/gate-python-swiftclient-python26/cfa8e31/ : SUCCESS in 57s\n- gate-python-swiftclient-docs http://docs-draft.openstack.org/43/149043/4/gate/gate-python-swiftclient-docs/1e2dcb0//doc/build/html/ : SUCCESS in 50s\n- gate-python-swiftclient-pep8 http://logs.openstack.org/43/149043/4/gate/gate-python-swiftclient-pep8/e3be26e/ : SUCCESS in 35s\n- gate-python-swiftclient-python27 http://logs.openstack.org/43/149043/4/gate/gate-python-swiftclient-python27/e6b449a/ : SUCCESS in 56s\n- gate-python-swiftclient-python34 http://logs.openstack.org/43/149043/4/gate/gate-python-swiftclient-python34/690aa28/ : SUCCESS in 3m 40s\n- gate-python-swiftclient-pypy http://logs.openstack.org/43/149043/4/gate/gate-python-swiftclient-pypy/111df1f/ : SUCCESS in 1m 23s\n- gate-tempest-dsvm-neutron-src-python-swiftclient http://logs.openstack.org/43/149043/4/gate/gate-tempest-dsvm-neutron-src-python-swiftclient/2aed994/ : SUCCESS in 1h 22m 01s\n- gate-swift-dsvm-functional http://logs.openstack.org/43/149043/4/gate/gate-swift-dsvm-functional/81daf1a/ : SUCCESS in 28m 40s","accounts_in_message":[],"_revision_number":4},{"id":"31a6cdb1e6c147d71b6193be32c6133d1bed012f","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-02-25 13:54:16.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"8756591b0ad24320a0b6fa3b2f7513e17ec46b6c","revisions":{"a5f09e82aab1481ae5aac7b54e2d3f2ea8ea3dd7":{"kind":"REWORK","_number":1,"created":"2015-01-21 20:39:51.000000000","uploader":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"ref":"refs/changes/43/149043/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-swiftclient","ref":"refs/changes/43/149043/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/43/149043/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/43/149043/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/43/149043/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-swiftclient refs/changes/43/149043/1"}}},"commit":{"parents":[{"commit":"7709fea51e71084163cf56c4d11a280ca4388357","subject":"Merge \"Check that content_type header exists before using\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/7709fea51e71084163cf56c4d11a280ca4388357"}]}],"author":{"name":"Ian Cordasco","email":"ian.cordasco@rackspace.com","date":"2015-01-21 20:38:02.000000000","tz":-360},"committer":{"name":"Ian Cordasco","email":"ian.cordasco@rackspace.com","date":"2015-01-21 20:38:02.000000000","tz":-360},"subject":"Release connection after consuming the content","message":"Release connection after consuming the content\n\nWhen using stream\u003dTrue, we need to make sure we release a connection\nback to the connection pool to avoid warnings clogging up the logs. We\ncan do this by releasing the connection once we\u0027ve read all the content\nfrom the response. In situations where stream\u003dFalse, requests already\ndoes this for us.\n\nChange-Id: Id1c72ad86135a49d4b985992d788736b65f7dbda\nCloses-bug: 1341777\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/a5f09e82aab1481ae5aac7b54e2d3f2ea8ea3dd7"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/a5f09e82aab1481ae5aac7b54e2d3f2ea8ea3dd7"}]},"branch":"refs/heads/master"},"129e7b52a778212e18b5576ff7b6ed41c86fa6b1":{"kind":"REWORK","_number":2,"created":"2015-01-21 21:39:21.000000000","uploader":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"ref":"refs/changes/43/149043/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-swiftclient","ref":"refs/changes/43/149043/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/43/149043/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/43/149043/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/43/149043/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-swiftclient refs/changes/43/149043/2"}}},"commit":{"parents":[{"commit":"7709fea51e71084163cf56c4d11a280ca4388357","subject":"Merge \"Check that content_type header exists before using\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/7709fea51e71084163cf56c4d11a280ca4388357"}]}],"author":{"name":"Ian Cordasco","email":"ian.cordasco@rackspace.com","date":"2015-01-21 20:38:02.000000000","tz":-360},"committer":{"name":"Ian Cordasco","email":"ian.cordasco@rackspace.com","date":"2015-01-21 21:39:17.000000000","tz":-360},"subject":"Release connection after consuming the content","message":"Release connection after consuming the content\n\nWhen using stream\u003dTrue, we need to make sure we release a connection\nback to the connection pool to avoid warnings clogging up the logs. We\ncan do this by releasing the connection once we\u0027ve read all the content\nfrom the response. In situations where stream\u003dFalse, requests already\ndoes this for us.\n\nChange-Id: Id1c72ad86135a49d4b985992d788736b65f7dbda\nCloses-bug: 1341777\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/129e7b52a778212e18b5576ff7b6ed41c86fa6b1"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/129e7b52a778212e18b5576ff7b6ed41c86fa6b1"}]},"branch":"refs/heads/master"},"b0f1cba0011b1b86175745bb2a2ba48d38a237dc":{"kind":"REWORK","_number":3,"created":"2015-02-24 20:43:23.000000000","uploader":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"ref":"refs/changes/43/149043/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-swiftclient","ref":"refs/changes/43/149043/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/43/149043/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/43/149043/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/43/149043/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-swiftclient refs/changes/43/149043/3"}}},"commit":{"parents":[{"commit":"7709fea51e71084163cf56c4d11a280ca4388357","subject":"Merge \"Check that content_type header exists before using\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/7709fea51e71084163cf56c4d11a280ca4388357"}]}],"author":{"name":"Ian Cordasco","email":"ian.cordasco@rackspace.com","date":"2015-01-21 20:38:02.000000000","tz":-360},"committer":{"name":"Ian Cordasco","email":"ian.cordasco@rackspace.com","date":"2015-02-24 20:42:58.000000000","tz":-360},"subject":"Release connection after consuming the content","message":"Release connection after consuming the content\n\nWhen using stream\u003dTrue, we need to make sure we release a connection\nback to the connection pool to avoid warnings clogging up the logs. We\ncan do this by releasing the connection once we\u0027ve read all the content\nfrom the response. In situations where stream\u003dFalse, requests already\ndoes this for us.\n\nRelated-bug: 1424732\nCloses-bug: 1341777\nChange-Id: Id1c72ad86135a49d4b985992d788736b65f7dbda\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/b0f1cba0011b1b86175745bb2a2ba48d38a237dc"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/b0f1cba0011b1b86175745bb2a2ba48d38a237dc"}]},"branch":"refs/heads/master"},"8756591b0ad24320a0b6fa3b2f7513e17ec46b6c":{"kind":"TRIVIAL_REBASE","_number":4,"created":"2015-02-25 11:03:17.000000000","uploader":{"_account_id":6968,"name":"Christian Schwede","email":"cschwede@nvidia.com","username":"cschwede"},"ref":"refs/changes/43/149043/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-swiftclient","ref":"refs/changes/43/149043/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/43/149043/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/43/149043/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/43/149043/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-swiftclient refs/changes/43/149043/4"}}},"commit":{"parents":[{"commit":"731707f06da899fa8fb2d521e35f850a2e1652ab","subject":"Merge \"Fix crash with -l, -d /, and pseudo folders\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/731707f06da899fa8fb2d521e35f850a2e1652ab"}]}],"author":{"name":"Ian Cordasco","email":"ian.cordasco@rackspace.com","date":"2015-01-21 20:38:02.000000000","tz":-360},"committer":{"name":"Christian Schwede","email":"christian.schwede@enovance.com","date":"2015-02-25 11:00:56.000000000","tz":0},"subject":"Release connection after consuming the content","message":"Release connection after consuming the content\n\nWhen using stream\u003dTrue, we need to make sure we release a connection\nback to the connection pool to avoid warnings clogging up the logs. We\ncan do this by releasing the connection once we\u0027ve read all the content\nfrom the response. In situations where stream\u003dFalse, requests already\ndoes this for us.\n\nRelated-bug: 1424732\nCloses-bug: 1341777\nChange-Id: Id1c72ad86135a49d4b985992d788736b65f7dbda\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/8756591b0ad24320a0b6fa3b2f7513e17ec46b6c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/8756591b0ad24320a0b6fa3b2f7513e17ec46b6c"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
