)]}'
{"id":"openstack%2Fpython-swiftclient~149108","triplet_id":"openstack%2Fpython-swiftclient~master~Id68590d6af16040a2877e719bc38d1e126603e42","project":"openstack/python-swiftclient","branch":"master","topic":"clean-environ-defaults","hashtags":[],"change_id":"Id68590d6af16040a2877e719bc38d1e126603e42","subject":"Fix environment sanitization for TestServiceUtils","status":"MERGED","created":"2015-01-22 01:25:04.000000000","updated":"2015-01-30 04:15:55.000000000","submitted":"2015-01-30 04:15:55.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"8a34c3d54de8f361816d3691a89c1ba9f99a0070","_number":149108,"virtual_id_number":149108,"owner":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2015-01-30 04:15:55.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},{"value":0,"_account_id":7479,"name":"paul luse","email":"paul.e.luse@intel.com","username":"peluse"},{"value":0,"date":"2015-01-22 03:25:22.000000000","_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2015-01-27 16:54:25.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},{"value":2,"date":"2015-01-30 03:33:56.000000000","_account_id":7479,"name":"paul luse","email":"paul.e.luse@intel.com","username":"peluse"},{"value":0,"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":7479,"name":"paul luse","email":"paul.e.luse@intel.com","username":"peluse"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},{"value":1,"date":"2015-01-30 03:33:56.000000000","_account_id":7479,"name":"paul luse","email":"paul.e.luse@intel.com","username":"peluse"},{"value":0,"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"_account_id":7479,"name":"paul luse","email":"paul.e.luse@intel.com","username":"peluse"},{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-01-27 16:54:25.000000000","updated_by":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"reviewer":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"state":"REVIEWER"},{"updated":"2015-01-30 03:33:56.000000000","updated_by":{"_account_id":7479,"name":"paul luse","email":"paul.e.luse@intel.com","username":"peluse"},"reviewer":{"_account_id":7479,"name":"paul luse","email":"paul.e.luse@intel.com","username":"peluse"},"state":"REVIEWER"},{"updated":"2015-01-30 04:15:55.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"40ee0385b57da2d02dc3fdf734da0b2396d6e634","author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"date":"2015-01-22 01:25:04.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"68e8b18dbf32d4dab62cd083178541dc9e993d60","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-01-22 02:18:55.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-swiftclient-python26 http://logs.openstack.org/08/149108/1/check/gate-python-swiftclient-python26/18ea216/ : SUCCESS in 49s\n- gate-python-swiftclient-pep8 http://logs.openstack.org/08/149108/1/check/gate-python-swiftclient-pep8/76e67d5/ : SUCCESS in 1m 18s\n- gate-python-swiftclient-docs http://docs-draft.openstack.org/08/149108/1/check/gate-python-swiftclient-docs/c2e48f1//doc/build/html/ : SUCCESS in 47s\n- gate-python-swiftclient-python27 http://logs.openstack.org/08/149108/1/check/gate-python-swiftclient-python27/b28d700/ : SUCCESS in 1m 29s\n- gate-python-swiftclient-python33 http://logs.openstack.org/08/149108/1/check/gate-python-swiftclient-python33/401918f/ : SUCCESS in 2m 32s\n- gate-tempest-dsvm-neutron-src-python-swiftclient-icehouse http://logs.openstack.org/08/149108/1/check/gate-tempest-dsvm-neutron-src-python-swiftclient-icehouse/396d68e/ : SUCCESS in 28m 23s\n- gate-tempest-dsvm-neutron-src-python-swiftclient-juno http://logs.openstack.org/08/149108/1/check/gate-tempest-dsvm-neutron-src-python-swiftclient-juno/00342da/ : SUCCESS in 33m 57s\n- gate-python-swiftclient-pypy http://logs.openstack.org/08/149108/1/check/gate-python-swiftclient-pypy/90f19f5/ : SUCCESS in 2m 12s\n- gate-tempest-dsvm-neutron-src-python-swiftclient http://logs.openstack.org/08/149108/1/check/gate-tempest-dsvm-neutron-src-python-swiftclient/8e1b07d/ : SUCCESS in 37m 59s\n- check-swift-dsvm-functional http://logs.openstack.org/08/149108/1/check/check-swift-dsvm-functional/15a67bf/ : SUCCESS in 24m 32s\n- check-swiftclient-dsvm-functional http://logs.openstack.org/08/149108/1/check/check-swiftclient-dsvm-functional/a69b98f/ : FAILURE in 14m 40s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"476c84ce1c89fcc0d06f882b70589fa1d26fa608","author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"date":"2015-01-22 03:25:22.000000000","message":"Patch Set 1:\n\n(1 comment)\n\nI run that one failing test with:\n\n    python -m testtools.run tests.unit.test_service.TestServiceUtils.test_process_options_defaults","accounts_in_message":[],"_revision_number":1},{"id":"d5466bb61d65ab5f6fd5224b9e73f865ef0e8709","author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"date":"2015-01-27 16:54:25.000000000","message":"Patch Set 1: Code-Review+2\n\nThat test breaks for me too when I set env variables in test environment, this fixes it.\n\nI\u0027m wondering why all those defaults are loaded from os.environ in the service module (shell.py already does that during parsing) but thats a separate issue.","accounts_in_message":[],"_revision_number":1},{"id":"b33ae513fbaede4f99bb94854afe795b99e369fc","author":{"_account_id":7479,"name":"paul luse","email":"paul.e.luse@intel.com","username":"peluse"},"date":"2015-01-30 03:33:56.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"4a45425abcfb071ce644c832a9a3966c80f8c9cb","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-01-30 03:33:57.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"6a743164db2dae7b4274060d7b4f8bcfafbc4e97","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-01-30 04:15:55.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":1},{"id":"18bd9d31643debfdcfa5c5bd47c8d68815a00bd6","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-01-30 04:15:55.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-swiftclient-python26 http://logs.openstack.org/08/149108/1/gate/gate-python-swiftclient-python26/c700963/ : SUCCESS in 39s\n- gate-python-swiftclient-docs http://docs-draft.openstack.org/08/149108/1/gate/gate-python-swiftclient-docs/cdf4b5f//doc/build/html/ : SUCCESS in 46s\n- gate-python-swiftclient-pep8 http://logs.openstack.org/08/149108/1/gate/gate-python-swiftclient-pep8/cf15410/ : SUCCESS in 39s\n- gate-python-swiftclient-python27 http://logs.openstack.org/08/149108/1/gate/gate-python-swiftclient-python27/2468c2b/ : SUCCESS in 43s\n- gate-python-swiftclient-python33 http://logs.openstack.org/08/149108/1/gate/gate-python-swiftclient-python33/465549f/ : SUCCESS in 2m 28s\n- gate-python-swiftclient-pypy http://logs.openstack.org/08/149108/1/gate/gate-python-swiftclient-pypy/26ca0ec/ : SUCCESS in 1m 41s\n- gate-tempest-dsvm-neutron-src-python-swiftclient http://logs.openstack.org/08/149108/1/gate/gate-tempest-dsvm-neutron-src-python-swiftclient/855b631/ : SUCCESS in 37m 09s\n- gate-swift-dsvm-functional http://logs.openstack.org/08/149108/1/gate/gate-swift-dsvm-functional/95ce65d/ : SUCCESS in 24m 02s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"eef91b35139411fcef31855ce0ebe4407a2de70b","revisions":{"eef91b35139411fcef31855ce0ebe4407a2de70b":{"kind":"REWORK","_number":1,"created":"2015-01-22 01:25:04.000000000","uploader":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"ref":"refs/changes/08/149108/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-swiftclient","ref":"refs/changes/08/149108/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/08/149108/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/08/149108/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/08/149108/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-swiftclient refs/changes/08/149108/1"}}},"commit":{"parents":[{"commit":"7709fea51e71084163cf56c4d11a280ca4388357","subject":"Merge \"Check that content_type header exists before using\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/7709fea51e71084163cf56c4d11a280ca4388357"}]}],"author":{"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","date":"2015-01-22 01:20:53.000000000","tz":-480},"committer":{"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","date":"2015-01-22 01:20:53.000000000","tz":-480},"subject":"Fix environment sanitization for TestServiceUtils","message":"Fix environment sanitization for TestServiceUtils\n\nI\u0027m not sure how test_process_options_defaults ever passed for anyone that had\nall the ST_(AUTH|USER|KEY) set in their environment when they ran it.  Despite\nour efforts to patch os.environ swiftclient.servce was acctually importing\nenviron from os and then sticking the results into some global state.  The\ntests seemed to work fine on infra, but for me locally until I `unset ST_AUTH`\nthe test would always fail.  Seems to work now and looks fairly reasonable on\nthe surface.\n\nChange-Id: Id68590d6af16040a2877e719bc38d1e126603e42\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/eef91b35139411fcef31855ce0ebe4407a2de70b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/eef91b35139411fcef31855ce0ebe4407a2de70b"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
