)]}'
{"id":"openstack%2Fpython-swiftclient~150494","triplet_id":"openstack%2Fpython-swiftclient~master~I02a28168d4820a1948c40a9894d2bd4da41be24c","project":"openstack/python-swiftclient","branch":"master","topic":"clean-environ-defaults","hashtags":[],"change_id":"I02a28168d4820a1948c40a9894d2bd4da41be24c","subject":"Set bogus ST_ env variables in tox.ini","status":"ABANDONED","created":"2015-01-27 17:11:35.000000000","updated":"2015-01-28 17:44:01.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"47ad07907f7857cd575c9e868b55d62b9842a551","_number":150494,"virtual_id_number":150494,"owner":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":1,"date":"2015-01-27 18:09:09.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":-1,"date":"2015-01-27 19:21:29.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},{"value":0,"date":"2015-01-27 17:12:37.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-01-27 17:12:37.000000000","updated_by":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"reviewer":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"state":"REVIEWER"},{"updated":"2015-01-27 18:09:09.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"ec7681359722623fe99f9416500372c4101f614b","author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"date":"2015-01-27 17:11:35.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"ad5c339e49058d92b456df50b70af4bf60f520c9","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-01-27 18:09:09.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-swiftclient-python26 http://logs.openstack.org/94/150494/1/check/gate-python-swiftclient-python26/a87c0ac/ : SUCCESS in 56s\n- gate-python-swiftclient-pep8 http://logs.openstack.org/94/150494/1/check/gate-python-swiftclient-pep8/2bd5ed9/ : SUCCESS in 30s\n- gate-python-swiftclient-docs http://docs-draft.openstack.org/94/150494/1/check/gate-python-swiftclient-docs/facb493//doc/build/html/ : SUCCESS in 50s\n- gate-python-swiftclient-python27 http://logs.openstack.org/94/150494/1/check/gate-python-swiftclient-python27/a33b98a/ : SUCCESS in 48s\n- gate-python-swiftclient-python33 http://logs.openstack.org/94/150494/1/check/gate-python-swiftclient-python33/d4aebe0/ : SUCCESS in 2m 34s\n- gate-tempest-dsvm-neutron-src-python-swiftclient-icehouse http://logs.openstack.org/94/150494/1/check/gate-tempest-dsvm-neutron-src-python-swiftclient-icehouse/f328538/ : SUCCESS in 29m 29s\n- gate-tempest-dsvm-neutron-src-python-swiftclient-juno http://logs.openstack.org/94/150494/1/check/gate-tempest-dsvm-neutron-src-python-swiftclient-juno/fe9e1c7/ : SUCCESS in 30m 59s\n- gate-python-swiftclient-pypy http://logs.openstack.org/94/150494/1/check/gate-python-swiftclient-pypy/61f9883/ : SUCCESS in 1m 47s\n- gate-tempest-dsvm-neutron-src-python-swiftclient http://logs.openstack.org/94/150494/1/check/gate-tempest-dsvm-neutron-src-python-swiftclient/d47677e/ : SUCCESS in 32m 43s\n- check-swift-dsvm-functional http://logs.openstack.org/94/150494/1/check/check-swift-dsvm-functional/7a53389/ : SUCCESS in 22m 38s\n- check-swiftclient-dsvm-functional http://logs.openstack.org/94/150494/1/check/check-swiftclient-dsvm-functional/0c24a40/ : FAILURE in 15m 12s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"3571de989c7e80b26c4a7121fbb9a783a15779c1","author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"date":"2015-01-27 19:21:29.000000000","message":"Patch Set 1: Code-Review-1\n\nSo this is most likely half-baked - the idea is to make the gate tox jobs fail if a test doesn\u0027t mock the environ properly, but the risk is still that some test could actually _rely_ (!) on these bogus env vars and pass in the gate, but then fail when run outside of tox where the bogus vars would not be set.\n\nI guess the tox job could run with and without the bogus env vars to try to defeat that scenario, but feels like this isn\u0027t water-tight.","accounts_in_message":[],"_revision_number":1},{"id":"2ff594cb5c21f8b152f6fb6cde6c85e95056ac6b","author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"date":"2015-01-28 17:44:01.000000000","message":"Abandoned\n\nmaybe not","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"9f396058c0070cb4f2e721c569fdc30a528df27a","revisions":{"9f396058c0070cb4f2e721c569fdc30a528df27a":{"kind":"REWORK","_number":1,"created":"2015-01-27 17:11:35.000000000","uploader":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"ref":"refs/changes/94/150494/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-swiftclient","ref":"refs/changes/94/150494/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/94/150494/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/94/150494/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/94/150494/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-swiftclient refs/changes/94/150494/1"}}},"commit":{"parents":[{"commit":"eef91b35139411fcef31855ce0ebe4407a2de70b","subject":"Fix environment sanitization for TestServiceUtils","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/eef91b35139411fcef31855ce0ebe4407a2de70b"}]}],"author":{"name":"Alistair Coles","email":"alistair.coles@hp.com","date":"2015-01-27 17:05:03.000000000","tz":0},"committer":{"name":"Alistair Coles","email":"alistair.coles@hp.com","date":"2015-01-27 17:07:17.000000000","tz":0},"subject":"Set bogus ST_ env variables in tox.ini","message":"Set bogus ST_ env variables in tox.ini\n\nWe want to be able to run tests without manually cleaning\nswift options from the environment, so this patch sets\nsome bogus environment variables in tox.ini. That should\ncause any tests that are not correctly mocking os.environ\nto fail when run with tox.\n\nChange-Id: I02a28168d4820a1948c40a9894d2bd4da41be24c\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/9f396058c0070cb4f2e721c569fdc30a528df27a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/9f396058c0070cb4f2e721c569fdc30a528df27a"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
