)]}'
{"tests/unit/test_shell.py":[{"author":{"_account_id":6968,"name":"Christian Schwede","email":"cschwede@nvidia.com","username":"cschwede"},"change_message_id":"3189900533e423680b18478089d297e31c5f69f5","unresolved":false,"context_lines":[{"line_number":523,"context_line":"            content_length\u003d0,"},{"line_number":524,"context_line":"            headers\u003d{\u0027x-object-meta-mtime\u0027: mock.ANY},"},{"line_number":525,"context_line":"            response_dict\u003d{})"},{"line_number":526,"context_line":"        self.assertEqual([], connection.return_value.delete_object.mock_calls)"},{"line_number":527,"context_line":""},{"line_number":528,"context_line":"    @mock.patch(\u0027swiftclient.service.Connection\u0027)"},{"line_number":529,"context_line":"    def test_upload_delete_dlo_segments(self, connection):"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba7be1f8_8dc0dee1","line":526,"updated":"2015-02-23 08:03:21.000000000","message":"Maybe just use \n\n self.assertFalse(connection.return_value.delete_object.mock_calls)?\n\nIt\u0027s just a nitpick, but might improve readability a bit and makes it more clear that this should not have been called at all.","commit_id":"03ce4e2d52be946a26375d89d8fbf6080350bf2e"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"c53d9130125e2a25a8f9a8becef6f486e96ef34e","unresolved":false,"context_lines":[{"line_number":523,"context_line":"            content_length\u003d0,"},{"line_number":524,"context_line":"            headers\u003d{\u0027x-object-meta-mtime\u0027: mock.ANY},"},{"line_number":525,"context_line":"            response_dict\u003d{})"},{"line_number":526,"context_line":"        self.assertEqual([], connection.return_value.delete_object.mock_calls)"},{"line_number":527,"context_line":""},{"line_number":528,"context_line":"    @mock.patch(\u0027swiftclient.service.Connection\u0027)"},{"line_number":529,"context_line":"    def test_upload_delete_dlo_segments(self, connection):"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba7be1f8_e4892f76","line":526,"in_reply_to":"ba7be1f8_8dc0dee1","updated":"2015-02-24 16:58:13.000000000","message":"Done","commit_id":"03ce4e2d52be946a26375d89d8fbf6080350bf2e"},{"author":{"_account_id":6968,"name":"Christian Schwede","email":"cschwede@nvidia.com","username":"cschwede"},"change_message_id":"3189900533e423680b18478089d297e31c5f69f5","unresolved":false,"context_lines":[{"line_number":594,"context_line":"            content_length\u003d0,"},{"line_number":595,"context_line":"            headers\u003d{\u0027x-object-meta-mtime\u0027: mock.ANY},"},{"line_number":596,"context_line":"            response_dict\u003d{})"},{"line_number":597,"context_line":"        self.assertEqual([], connection.return_value.delete_object.mock_calls)"},{"line_number":598,"context_line":""},{"line_number":599,"context_line":"    @mock.patch(\u0027swiftclient.service.Connection\u0027)"},{"line_number":600,"context_line":"    def test_upload_segments_to_same_container(self, connection):"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba7be1f8_8d4e1e95","line":597,"updated":"2015-02-23 08:03:21.000000000","message":"Same as above","commit_id":"03ce4e2d52be946a26375d89d8fbf6080350bf2e"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"c53d9130125e2a25a8f9a8becef6f486e96ef34e","unresolved":false,"context_lines":[{"line_number":594,"context_line":"            content_length\u003d0,"},{"line_number":595,"context_line":"            headers\u003d{\u0027x-object-meta-mtime\u0027: mock.ANY},"},{"line_number":596,"context_line":"            response_dict\u003d{})"},{"line_number":597,"context_line":"        self.assertEqual([], connection.return_value.delete_object.mock_calls)"},{"line_number":598,"context_line":""},{"line_number":599,"context_line":"    @mock.patch(\u0027swiftclient.service.Connection\u0027)"},{"line_number":600,"context_line":"    def test_upload_segments_to_same_container(self, connection):"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba7be1f8_047ba37b","line":597,"in_reply_to":"ba7be1f8_8d4e1e95","updated":"2015-02-24 16:58:13.000000000","message":"Done","commit_id":"03ce4e2d52be946a26375d89d8fbf6080350bf2e"},{"author":{"_account_id":9216,"name":"Joel Wright","email":"joel.wright@gmail.com","username":"jjw-sohonet"},"change_message_id":"0d04fdb83543c301faa4df10005091b7d263a3b3","unresolved":false,"context_lines":[{"line_number":518,"context_line":"        ]"},{"line_number":519,"context_line":"        connection.return_value.get_object.return_value \u003d ({}, json.dumps("},{"line_number":520,"context_line":"            [{\u0027name\u0027: \u0027container1/old_seg1\u0027}, {\u0027name\u0027: \u0027container2/old_seg2\u0027}]"},{"line_number":521,"context_line":"        ))"},{"line_number":522,"context_line":"        connection.return_value.put_object.return_value \u003d ("},{"line_number":523,"context_line":"            \u0027d41d8cd98f00b204e9800998ecf8427e\u0027)"},{"line_number":524,"context_line":"        swiftclient.shell.main(argv)"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba7be1f8_6a6a69b4","line":521,"updated":"2015-02-24 17:23:15.000000000","message":"Are the 2nd and 3rd returns from head_object and the get_object return values required here? I was under the impression those would only be required in the event that --leave-segments is False.","commit_id":"bfa166bbc5f9ba1981f0639c5121d8e1ce87a91e"},{"author":{"_account_id":9216,"name":"Joel Wright","email":"joel.wright@gmail.com","username":"jjw-sohonet"},"change_message_id":"0d04fdb83543c301faa4df10005091b7d263a3b3","unresolved":false,"context_lines":[{"line_number":593,"context_line":"                     \u0027last_modified\u0027: \u0027123T456\u0027},"},{"line_number":594,"context_line":"                    {\u0027name\u0027: \u0027prefix_b\u0027, \u0027bytes\u0027: 0,"},{"line_number":595,"context_line":"                     \u0027last_modified\u0027: \u0027123T456\u0027}]]"},{"line_number":596,"context_line":"        ]"},{"line_number":597,"context_line":"        connection.return_value.put_object.return_value \u003d ("},{"line_number":598,"context_line":"            \u0027d41d8cd98f00b204e9800998ecf8427e\u0027)"},{"line_number":599,"context_line":"        swiftclient.shell.main(argv)"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba7be1f8_ead5791c","line":596,"updated":"2015-02-24 17:23:15.000000000","message":"Similar to my comments above, are the 2nd and 3rd head return values, and the get_container return value required here?","commit_id":"bfa166bbc5f9ba1981f0639c5121d8e1ce87a91e"}]}
