)]}'
{"id":"openstack%2Fpython-swiftclient~16650","triplet_id":"openstack%2Fpython-swiftclient~master~I49db5410e650cb97d0d573c58d2cde104ec12732","project":"openstack/python-swiftclient","branch":"master","topic":"bug/1062274","hashtags":[],"change_id":"I49db5410e650cb97d0d573c58d2cde104ec12732","subject":"Add confirmation before swift delete --all.","status":"ABANDONED","created":"2012-11-21 16:47:11.000000000","updated":"2013-01-09 06:03:14.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"6d23901c1dc61e5490d07fdb96a94a578e03e5bc","_number":16650,"virtual_id_number":16650,"owner":{"_account_id":6215,"name":"Michael Eckert","email":"eckert@b1-systems.de","username":"eckert"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},{"_account_id":5652,"name":"David Ripton","email":"dripton@redhat.com","username":"dripton"},{"_account_id":6215,"name":"Michael Eckert","email":"eckert@b1-systems.de","username":"eckert"},{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},{"value":1,"date":"2012-11-21 16:51:12.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"value":1,"default_value":0,"optional":true},"Code-Review":{"recommended":{"_account_id":5652,"name":"David Ripton","email":"dripton@redhat.com","username":"dripton"},"disliked":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"all":[{"value":-1,"date":"2012-11-26 19:23:55.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},{"value":1,"date":"2012-11-21 17:00:04.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":5652,"name":"David Ripton","email":"dripton@redhat.com","username":"dripton"},{"value":0,"date":"2012-11-26 20:00:48.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":6215,"name":"Michael Eckert","email":"eckert@b1-systems.de","username":"eckert"},{"value":-1,"date":"2012-12-10 06:44:57.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"date":"2012-11-26 19:23:55.000000000","_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},{"_account_id":5652,"name":"David Ripton","email":"dripton@redhat.com","username":"dripton"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":6215,"name":"Michael Eckert","email":"eckert@b1-systems.de","username":"eckert"},{"date":"2012-12-10 06:44:57.000000000","_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},{"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},{"_account_id":5652,"name":"David Ripton","email":"dripton@redhat.com","username":"dripton"},{"_account_id":6215,"name":"Michael Eckert","email":"eckert@b1-systems.de","username":"eckert"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2012-11-21 16:51:12.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2012-11-21 17:00:04.000000000","updated_by":{"_account_id":5652,"name":"David Ripton","email":"dripton@redhat.com","username":"dripton"},"reviewer":{"_account_id":5652,"name":"David Ripton","email":"dripton@redhat.com","username":"dripton"},"state":"REVIEWER"},{"updated":"2012-11-26 19:23:55.000000000","updated_by":{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},"reviewer":{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},"state":"REVIEWER"},{"updated":"2012-12-10 06:44:57.000000000","updated_by":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"reviewer":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"state":"REVIEWER"}],"messages":[{"id":"bac3ec954151d458488d72ca4f9f5a02d7f0faeb","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-11-21 16:51:12.000000000","message":"Patch Set 1: Works for me\n\nBuild successful\n\n- http://logs.openstack.org/16650/1/check/gate-python-swiftclient-merge/139 : SUCCESS\n- http://logs.openstack.org/16650/1/check/gate-python-swiftclient-docs/88 : SUCCESS\n- http://logs.openstack.org/16650/1/check/gate-python-swiftclient-pep8/137 : SUCCESS\n- http://logs.openstack.org/16650/1/check/gate-python-swiftclient-python26/136 : SUCCESS\n- http://logs.openstack.org/16650/1/check/gate-python-swiftclient-python27/136 : SUCCESS\n","accounts_in_message":[],"_revision_number":1},{"id":"1bc46fe982f8a7f03797422eef2864f4998c6168","author":{"_account_id":5652,"name":"David Ripton","email":"dripton@redhat.com","username":"dripton"},"date":"2012-11-21 17:00:04.000000000","message":"Patch Set 1: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":1},{"id":"d2ba90893ff212c31cf3565820b2488074555ff5","author":{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},"date":"2012-11-26 19:23:55.000000000","message":"Patch Set 1: I would prefer that you didn\u0027t merge this\n\nThis will break every script that uses \"delete --all\".","accounts_in_message":[],"_revision_number":1},{"id":"62244a1b61c5a89e37e7111d1833620b6034036e","author":{"_account_id":6215,"name":"Michael Eckert","email":"eckert@b1-systems.de","username":"eckert"},"date":"2012-11-26 20:00:48.000000000","message":"Patch Set 1:\n\nI know, that it will break it, but it does make sense, that you are going to be asked, if you want to delete everything. It is a major change and shouldn\u0027t be released till a major release. It doesn\u0027t make any sense imo, if someone have to give another parameter to be asked. To be honest, would you add a \"interactive\" parameter, to be asked if you really want this? I\u0027ll guess not. But it makes sense, if that is the default and if you don\u0027t want to be asked (e.g. in scripts) you have to give another parameter (like here \"-n\", \"--non-interactive\").","accounts_in_message":[],"_revision_number":1},{"id":"384e4ca04a7360da3d1a211ad7bea15018f86040","author":{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},"date":"2012-11-29 20:08:44.000000000","message":"Patch Set 1:\n\nI don\u0027t think it\u0027s worth the breakage. To me, \"swift delete --all\" is like \"rm -f\" or \"fsck -y\": you\u0027re saying \"do it and damn the consequences\". It\u0027s not like a simple \"swift delete\" defaults to deleting everything.\n\nThis is just my opinion, though, so I\u0027ll leave my vote at -1. If enough other reviewers think it\u0027s a good idea to merge this, I\u0027m fine with being outvoted.","accounts_in_message":[],"_revision_number":1},{"id":"3d2d2d0c5e90c32abda62cb35c265ac98fc98a73","author":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"date":"2012-12-10 06:44:57.000000000","message":"Patch Set 1: I would prefer that you didn\u0027t merge this\n\nI agree with Sam, IMHO swift CLI is no mean to be interactive expecting a PTY and as said by Sam --all is already an acknowledgement by the user to delete everything","accounts_in_message":[],"_revision_number":1},{"id":"2bbc3f9cc24c88f321881cd82a15fcd9ca691565","author":{"_account_id":9,"name":"LaunchpadSync","username":"launchpadsync"},"date":"2013-01-09 06:03:14.000000000","message":"Patch Set 1:\n\ncode review expired after 2 weeks of no activity, it can be restored using the `Restore Change` button  under the Patch Set on the web interface","accounts_in_message":[],"_revision_number":1},{"id":"1f95b6e77183128edbe05ee2f6a6d93e5b8b0a4d","author":{"_account_id":9,"name":"LaunchpadSync","username":"launchpadsync"},"date":"2013-01-09 06:03:14.000000000","message":"Patch Set 1: Abandoned\n\ncode review expired after 2 weeks of no activity, it can be restored using the `Restore Change` button  under the Patch Set on the web interface","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"296b3cc36497687d65154337049869af3e2d6bc7","revisions":{"296b3cc36497687d65154337049869af3e2d6bc7":{"kind":"REWORK","_number":1,"created":"2012-11-21 16:47:11.000000000","uploader":{"_account_id":6215,"name":"Michael Eckert","email":"eckert@b1-systems.de","username":"eckert"},"ref":"refs/changes/50/16650/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-swiftclient","ref":"refs/changes/50/16650/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/50/16650/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/50/16650/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/50/16650/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-swiftclient refs/changes/50/16650/1"}}},"commit":{"parents":[{"commit":"0053b4cf0ee8a57d9a1db51aa2c08c50ccb104e9","subject":"Merge \"Remove unused json_request.\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/0053b4cf0ee8a57d9a1db51aa2c08c50ccb104e9"}]}],"author":{"name":"Michael Eckert","email":"eckert@b1-systems.de","date":"2012-11-21 16:46:00.000000000","tz":60},"committer":{"name":"Michael Eckert","email":"eckert@b1-systems.de","date":"2012-11-21 16:46:00.000000000","tz":60},"subject":"Add confirmation before swift delete --all.","message":"Add confirmation before swift delete --all.\n\nChange-Id: I49db5410e650cb97d0d573c58d2cde104ec12732\nFixes: Bug #1062274\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/296b3cc36497687d65154337049869af3e2d6bc7"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/296b3cc36497687d65154337049869af3e2d6bc7"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
