)]}'
{"swiftclient/service.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"d6efbcd9403f5e2eb7ce428b0686eb3252b86253","unresolved":false,"context_lines":[{"line_number":1590,"context_line":"                    old_manifest \u003d headers.get(\u0027x-object-manifest\u0027)"},{"line_number":1591,"context_line":"                    is_slo \u003d config_true_value("},{"line_number":1592,"context_line":"                        headers.get(\u0027x-static-large-object\u0027))"},{"line_number":1593,"context_line":"                    skip_identical \u003d ((bool(old_manifest) or is_slo)"},{"line_number":1594,"context_line":"                                      \u003d\u003d bool(segment_size)"},{"line_number":1595,"context_line":"                                      and options[\u0027skip_identical\u0027])"},{"line_number":1596,"context_line":"                    if skip_identical or ("}],"source_content_type":"text/x-python","patch_set":2,"id":"9a0c5dc1_a2f2cf98","line":1593,"updated":"2015-05-12 21:57:08.000000000","message":"So our user cares about whether the final object is segmented or not, but doesn\u0027t care about whether it\u0027s as SLO (which will have integrity checks) or DLO (which won\u0027t)? That feels...odd.","commit_id":"8d1a969ca869dd224318c64c91119f1a3612b1bc"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"d6efbcd9403f5e2eb7ce428b0686eb3252b86253","unresolved":false,"context_lines":[{"line_number":1591,"context_line":"                    is_slo \u003d config_true_value("},{"line_number":1592,"context_line":"                        headers.get(\u0027x-static-large-object\u0027))"},{"line_number":1593,"context_line":"                    skip_identical \u003d ((bool(old_manifest) or is_slo)"},{"line_number":1594,"context_line":"                                      \u003d\u003d bool(segment_size)"},{"line_number":1595,"context_line":"                                      and options[\u0027skip_identical\u0027])"},{"line_number":1596,"context_line":"                    if skip_identical or ("},{"line_number":1597,"context_line":"                            is_slo and not options[\u0027leave_segments\u0027]):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a0c5dc1_1878edc3","line":1594,"updated":"2015-05-12 21:57:08.000000000","message":"bool(segment_size) is insufficient here; we don\u0027t create an xLO if the object is coming from a stream or is smaller than the segment size. As a result, if you\u0027re uploading a mix of large and small objects, this won\u0027t skip identical small objects.","commit_id":"8d1a969ca869dd224318c64c91119f1a3612b1bc"}]}
