)]}'
{"id":"openstack%2Fpython-swiftclient~18458","triplet_id":"openstack%2Fpython-swiftclient~master~I322674eba9c07e6def97bce339815fa15191a92d","project":"openstack/python-swiftclient","branch":"master","topic":"add_insecure_env2","hashtags":[],"change_id":"I322674eba9c07e6def97bce339815fa15191a92d","subject":"Add env[SWIFTCLIENT_INSECURE]","status":"MERGED","created":"2012-12-20 04:24:38.000000000","updated":"2013-01-10 20:10:30.000000000","submitted":"2013-01-10 20:10:30.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"941ccb115714bb3a49d84e68e6a02c1dc79aabf2","_number":18458,"virtual_id_number":18458,"owner":{"_account_id":4234,"name":"You Yamagata","email":"bi.yamagata@gmail.com","username":"y-yamagata"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},{"value":2,"date":"2013-01-10 20:10:30.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":917,"name":"Chuck Thier","email":"cthier@gmail.com","username":"cthier"},{"value":0,"_account_id":4234,"name":"You Yamagata","email":"bi.yamagata@gmail.com","username":"y-yamagata"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"all":[{"value":2,"date":"2013-01-10 17:00:20.000000000","_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2013-01-10 19:35:49.000000000","_account_id":917,"name":"Chuck Thier","email":"cthier@gmail.com","username":"cthier"},{"value":0,"_account_id":4234,"name":"You Yamagata","email":"bi.yamagata@gmail.com","username":"y-yamagata"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":917,"name":"Chuck Thier","email":"cthier@gmail.com","username":"cthier"},"all":[{"value":0,"date":"2013-01-10 17:00:20.000000000","_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2013-01-10 19:35:49.000000000","_account_id":917,"name":"Chuck Thier","email":"cthier@gmail.com","username":"cthier"},{"value":0,"_account_id":4234,"name":"You Yamagata","email":"bi.yamagata@gmail.com","username":"y-yamagata"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},{"_account_id":917,"name":"Chuck Thier","email":"cthier@gmail.com","username":"cthier"},{"_account_id":4234,"name":"You Yamagata","email":"bi.yamagata@gmail.com","username":"y-yamagata"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2013-01-10 17:00:20.000000000","updated_by":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"reviewer":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"state":"REVIEWER"},{"updated":"2013-01-10 19:35:49.000000000","updated_by":{"_account_id":917,"name":"Chuck Thier","email":"cthier@gmail.com","username":"cthier"},"reviewer":{"_account_id":917,"name":"Chuck Thier","email":"cthier@gmail.com","username":"cthier"},"state":"REVIEWER"},{"updated":"2013-01-10 20:10:30.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"5473d56cea84a32617aee6f43bea4c9f77398b2f","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-12-20 04:26:16.000000000","message":"Patch Set 1: Works for me\n\nBuild successful\n\n- http://logs.openstack.org/18458/1/check/gate-python-swiftclient-docs/101 : SUCCESS\n- http://logs.openstack.org/18458/1/check/gate-python-swiftclient-pep8/150 : SUCCESS\n- http://logs.openstack.org/18458/1/check/gate-python-swiftclient-python26/149 : SUCCESS\n- http://logs.openstack.org/18458/1/check/gate-python-swiftclient-python27/149 : SUCCESS\n","accounts_in_message":[],"_revision_number":1},{"id":"5bda0d2981c2c161c92840bf8b94f871601048cb","author":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"date":"2013-01-08 13:39:42.000000000","message":"Patch Set 1: I would prefer that you didn\u0027t merge this\n\nexcept adding a config_true_value function this patch does not seem to implement the SWIFTCLIENT_INSECURE feature.","accounts_in_message":[],"_revision_number":1},{"id":"2990fcd45e07bb171ce251cdecbfa6f59a88e0c9","author":{"_account_id":4234,"name":"You Yamagata","email":"bi.yamagata@gmail.com","username":"y-yamagata"},"date":"2013-01-09 02:41:10.000000000","message":"Patch Set 1:\n\nHi\n\nThank you for your review and comment.\n\nI checked my patch. But I guess env[SWIFTCLIENT_INSECURE] feature is implemented as follows.\n\nhttps://review.openstack.org/#/c/18458/1/bin/swift\n\nIn this code, I use config_true_value function.\n\nI am sorry if I misunderstand your comment.","accounts_in_message":[],"_revision_number":1},{"id":"3a26e60c0a8ad5c1632ad0db40f658cf7d5ccbfd","author":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"date":"2013-01-09 10:24:12.000000000","message":"Patch Set 1:\n\nHi you, apologies if I misunderstand you but I could not see where is the feature implemented, you are adding a env variable and a switch but for what?","accounts_in_message":[],"_revision_number":1},{"id":"d3549fc1290d1b110dd5d09bed417117f07c1f25","author":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"date":"2013-01-09 10:32:40.000000000","message":"Patch Set 1: No score\n\nOh apologies I read the commit message differently and I thought you were trying to add that feature but it was already there.\n\nI think it would be nicer to move the config_true_value to its own file as for example utils.py and you probably want to remove client.py:254 and just use insecure\u003dkwargs.get(\u0027insecure\u0027) later on.\n\nThanks.","accounts_in_message":[],"_revision_number":1},{"id":"7553efcfa57bd8a8a86d55f01219307b901e4447","author":{"_account_id":4234,"name":"You Yamagata","email":"bi.yamagata@gmail.com","username":"y-yamagata"},"date":"2013-01-10 04:24:54.000000000","message":"Patch Set 1:\n\nThank you for your advice.\nI will fix and submit the patch again.","accounts_in_message":[],"_revision_number":1},{"id":"a83b6bb4e867bccaf1a3980ad999b9a96d33d7ea","author":{"_account_id":4234,"name":"You Yamagata","email":"bi.yamagata@gmail.com","username":"y-yamagata"},"date":"2013-01-10 04:28:23.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"27c28d4c55b7136e4ec05708b5cd864436ca9c1e","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-01-10 04:30:07.000000000","message":"Patch Set 2: Works for me\n\nBuild successful\n\n- http://logs.openstack.org/18458/2/check/gate-python-swiftclient-docs/112 : SUCCESS\n- http://logs.openstack.org/18458/2/check/gate-python-swiftclient-pep8/161 : SUCCESS\n- http://logs.openstack.org/18458/2/check/gate-python-swiftclient-python26/160 : SUCCESS\n- http://logs.openstack.org/18458/2/check/gate-python-swiftclient-python27/160 : SUCCESS\n","accounts_in_message":[],"_revision_number":2},{"id":"e1bc96309d3b154f52ac1a34fcdae0d10f20c31e","author":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"date":"2013-01-10 17:00:20.000000000","message":"Patch Set 2: Looks good to me (core reviewer)\n\nI don\u0027t like much the name of the env variable when it should be an  OS_ prefixed variable but since this is already there unless we change novaclient we can\u0027t really do otherwise.","accounts_in_message":[],"_revision_number":2},{"id":"c0e5276a699038c0efe44c077b05870dc088d2f5","author":{"_account_id":917,"name":"Chuck Thier","email":"cthier@gmail.com","username":"cthier"},"date":"2013-01-10 19:35:49.000000000","message":"Patch Set 2: Looks good to me (core reviewer); Approved\n\n","accounts_in_message":[],"_revision_number":2},{"id":"b6788c663912ca6a5ed2f85e4f228fbefcb498c9","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-01-10 19:57:48.000000000","message":"Patch Set 2: No score\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"2f1d8467a36479c7786d51eccb9e5db6f7f9dd9a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-01-10 20:10:30.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":2},{"id":"c21c6f9212812faacad38b5366431b423350b9ad","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-01-10 20:10:30.000000000","message":"Patch Set 2: Verified\n\nBuild successful\n\n- http://logs.openstack.org/18458/2/gate/gate-python-swiftclient-docs/114 : SUCCESS\n- http://logs.openstack.org/18458/2/gate/gate-python-swiftclient-pep8/163 : SUCCESS\n- http://logs.openstack.org/18458/2/gate/gate-python-swiftclient-python26/162 : SUCCESS\n- http://logs.openstack.org/18458/2/gate/gate-python-swiftclient-python27/162 : SUCCESS\n","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"5edb40b44227a8a615a95bd565dd92ffbb3165c0","revisions":{"1b21c5a67f64bd2095747c52c66afc6f14551ae3":{"kind":"REWORK","_number":1,"created":"2012-12-20 04:24:38.000000000","uploader":{"_account_id":4234,"name":"You Yamagata","email":"bi.yamagata@gmail.com","username":"y-yamagata"},"ref":"refs/changes/58/18458/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-swiftclient","ref":"refs/changes/58/18458/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/58/18458/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/58/18458/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/58/18458/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-swiftclient refs/changes/58/18458/1"}}},"commit":{"parents":[{"commit":"7df9cadbf006624192c48b81d1c9f1b4ed679a37","subject":"Merge \"Add --insecure option to fix bug #1077869\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/7df9cadbf006624192c48b81d1c9f1b4ed679a37"}]}],"author":{"name":"You Yamagata","email":"bi.yamagata@gmail.com","date":"2012-12-20 04:14:09.000000000","tz":540},"committer":{"name":"You Yamagata","email":"bi.yamagata@gmail.com","date":"2012-12-20 04:14:09.000000000","tz":540},"subject":"Add env[SWIFTCLIENT_INSECURE]","message":"Add env[SWIFTCLIENT_INSECURE]\n\nAdd env[SWIFTCLIENT_INSECURE] as default of --insecure option.\nThe name follows \u0027NOVACLIENT_INSECURE\u0027 in novaclient.\n\nChange-Id: I322674eba9c07e6def97bce339815fa15191a92d\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/1b21c5a67f64bd2095747c52c66afc6f14551ae3"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/1b21c5a67f64bd2095747c52c66afc6f14551ae3"}]},"branch":"refs/heads/master"},"5edb40b44227a8a615a95bd565dd92ffbb3165c0":{"kind":"REWORK","_number":2,"created":"2013-01-10 04:28:23.000000000","uploader":{"_account_id":4234,"name":"You Yamagata","email":"bi.yamagata@gmail.com","username":"y-yamagata"},"ref":"refs/changes/58/18458/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-swiftclient","ref":"refs/changes/58/18458/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/58/18458/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/58/18458/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/58/18458/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-swiftclient refs/changes/58/18458/2"}}},"commit":{"parents":[{"commit":"e93d47a930f6079547c668070665a85f731d332f","subject":"Use testtools as base class for test cases.","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/e93d47a930f6079547c668070665a85f731d332f"}]}],"author":{"name":"You Yamagata","email":"bi.yamagata@gmail.com","date":"2013-01-10 03:59:57.000000000","tz":540},"committer":{"name":"You Yamagata","email":"bi.yamagata@gmail.com","date":"2013-01-10 04:26:53.000000000","tz":540},"subject":"Add env[SWIFTCLIENT_INSECURE]","message":"Add env[SWIFTCLIENT_INSECURE]\n\nAdd env[SWIFTCLIENT_INSECURE] as default of --insecure option.\nIf set to \u0027true\u0027, allow to access insecure keystone server.\nThe name follows \u0027NOVACLIENT_INSECURE\u0027 in novaclient.\n\nChange-Id: I322674eba9c07e6def97bce339815fa15191a92d\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/5edb40b44227a8a615a95bd565dd92ffbb3165c0"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/5edb40b44227a8a615a95bd565dd92ffbb3165c0"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}