)]}'
{"id":"openstack%2Fpython-swiftclient~184659","triplet_id":"openstack%2Fpython-swiftclient~master~I6cc30a5c12e37de06d7322533a3c36ad15397cc8","project":"openstack/python-swiftclient","branch":"master","topic":"bug/1338464","hashtags":[],"change_id":"I6cc30a5c12e37de06d7322533a3c36ad15397cc8","subject":"Stop decoding object content","status":"MERGED","created":"2015-05-21 00:41:49.000000000","updated":"2015-05-29 08:13:18.000000000","submitted":"2015-05-29 08:13:16.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"9bd17fdbf3e3eac0cca2716db3072e849736c856","_number":184659,"virtual_id_number":184659,"owner":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2015-05-29 08:13:16.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":6968,"name":"Christian Schwede","email":"cschwede@nvidia.com","username":"cschwede"},{"value":0,"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"value":0,"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},{"value":0,"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":6968,"name":"Christian Schwede","email":"cschwede@nvidia.com","username":"cschwede"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2015-05-29 07:25:44.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":6968,"name":"Christian Schwede","email":"cschwede@nvidia.com","username":"cschwede"},{"value":0,"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"value":2,"date":"2015-05-22 21:16:04.000000000","_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},{"value":0,"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":6968,"name":"Christian Schwede","email":"cschwede@nvidia.com","username":"cschwede"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2015-05-29 07:25:44.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":6968,"name":"Christian Schwede","email":"cschwede@nvidia.com","username":"cschwede"},{"value":0,"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"value":0,"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},{"value":0,"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},{"_account_id":6968,"name":"Christian Schwede","email":"cschwede@nvidia.com","username":"cschwede"},{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-05-22 06:44:14.000000000","updated_by":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"reviewer":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"state":"REVIEWER"},{"updated":"2015-05-22 21:16:04.000000000","updated_by":{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},"reviewer":{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},"state":"REVIEWER"},{"updated":"2015-05-29 07:25:44.000000000","updated_by":{"_account_id":6968,"name":"Christian Schwede","email":"cschwede@nvidia.com","username":"cschwede"},"reviewer":{"_account_id":6968,"name":"Christian Schwede","email":"cschwede@nvidia.com","username":"cschwede"},"state":"REVIEWER"},{"updated":"2015-05-29 08:13:16.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"8c20dd0a174462dd5974957619e69033c4dc6c8f","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2015-05-21 00:41:49.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"b495a0282b88ba7d2fe8abea0ce2cbe44ca35a27","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2015-05-21 00:43:18.000000000","message":"Patch Set 1:\n\nI wrote a bit of middleware[1] to help functionally test this, though you\u0027ll need to configure it to use Content-Encoding instead of Transfer-Encoding. If there\u0027s interest, I\u0027d be happy to submit it upstream whenever I get around to writing tests for it.\n\nNote that this is a change from existing behavior: Despite the error in the linked bug, the object *is* downloaded, decompressed, and written to disk (or stdout, with `--output -`). I\u0027m considering adding a --decode-content flag for downloads that would preserve existing behavior, minus the error, but that will likely be a separate patch.\n\n[1] https://gist.github.com/tipabu/7c8ed7a713a7f51f20c2","accounts_in_message":[],"_revision_number":1},{"id":"fab5fcc4dd709d4f7236c1f83d9f9f8e2ffd076f","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2015-05-21 01:15:27.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"24233112e222c473bbaf05b0d464e6d8e5ca49a2","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-05-21 02:01:05.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-swiftclient-python26 http://logs.openstack.org/59/184659/2/check/gate-python-swiftclient-python26/267b407/ : SUCCESS in 50s\n- gate-python-swiftclient-pep8 http://logs.openstack.org/59/184659/2/check/gate-python-swiftclient-pep8/f6708dd/ : SUCCESS in 43s\n- gate-python-swiftclient-docs http://docs-draft.openstack.org/59/184659/2/check/gate-python-swiftclient-docs/dc9d0f2//doc/build/html/ : SUCCESS in 37s\n- gate-python-swiftclient-python27 http://logs.openstack.org/59/184659/2/check/gate-python-swiftclient-python27/95026a6/ : SUCCESS in 1m 00s\n- gate-python-swiftclient-python34 http://logs.openstack.org/59/184659/2/check/gate-python-swiftclient-python34/9cf895f/ : SUCCESS in 1m 48s\n- gate-python-swiftclient-pypy http://logs.openstack.org/59/184659/2/check/gate-python-swiftclient-pypy/2ca3ae0/ : SUCCESS in 1m 39s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-swiftclient http://logs.openstack.org/59/184659/2/check/gate-tempest-dsvm-neutron-src-python-swiftclient/e2b3b0c/ : SUCCESS in 44m 55s\n- check-swift-dsvm-functional http://logs.openstack.org/59/184659/2/check/check-swift-dsvm-functional/bb116d8/ : SUCCESS in 15m 43s\n- check-swiftclient-dsvm-functional http://logs.openstack.org/59/184659/2/check/check-swiftclient-dsvm-functional/b7c0b97/ : SUCCESS in 17m 26s","accounts_in_message":[],"_revision_number":2},{"id":"6f8a43e7762ef9ad77acc0f738bb9bd8837ffa9e","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2015-05-22 06:38:35.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"f4fb778791cc93b4f6c58831866e1f2635053d19","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2015-05-22 06:43:41.000000000","message":"Patch Set 3:\n\nBroke out this bug-fix (python-swiftclient sends accept-encoding headers by default) from the feature (let python-swiftclient accept and decode gzipped responses). This will let us debate about the utility/maintainability of that feature separately.","accounts_in_message":[],"_revision_number":3},{"id":"f5371d63e51f79805fe028552f6423474b085191","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-05-22 07:33:56.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-swiftclient-python26 http://logs.openstack.org/59/184659/3/check/gate-python-swiftclient-python26/9db73ce/ : SUCCESS in 1m 02s\n- gate-python-swiftclient-pep8 http://logs.openstack.org/59/184659/3/check/gate-python-swiftclient-pep8/896a992/ : SUCCESS in 36s\n- gate-python-swiftclient-docs http://docs-draft.openstack.org/59/184659/3/check/gate-python-swiftclient-docs/5b2376a//doc/build/html/ : SUCCESS in 52s\n- gate-python-swiftclient-python27 http://logs.openstack.org/59/184659/3/check/gate-python-swiftclient-python27/db48413/ : SUCCESS in 57s\n- gate-python-swiftclient-python34 http://logs.openstack.org/59/184659/3/check/gate-python-swiftclient-python34/e67c849/ : SUCCESS in 1m 33s\n- gate-python-swiftclient-pypy http://logs.openstack.org/59/184659/3/check/gate-python-swiftclient-pypy/15b5a8d/ : SUCCESS in 1m 24s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-swiftclient http://logs.openstack.org/59/184659/3/check/gate-tempest-dsvm-neutron-src-python-swiftclient/f345fba/ : SUCCESS in 54m 34s\n- check-swift-dsvm-functional http://logs.openstack.org/59/184659/3/check/check-swift-dsvm-functional/06189ea/ : SUCCESS in 18m 56s\n- check-swiftclient-dsvm-functional http://logs.openstack.org/59/184659/3/check/check-swiftclient-dsvm-functional/dacc247/ : SUCCESS in 18m 58s","accounts_in_message":[],"_revision_number":3},{"id":"4a6f27ee0a0d9758e74361ab26d5deb8c5a52b67","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2015-05-22 20:25:47.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"129008f0233e7abc179b75c898f75e5d1feb31d3","author":{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},"date":"2015-05-22 21:16:04.000000000","message":"Patch Set 4: Code-Review+2\n\nConfirmed via tcpdump that swiftclient was sending \"Accept-Encoding: gzip, deflate, compress\" and now sends \"Accept-Encoding: identity\".","accounts_in_message":[],"_revision_number":4},{"id":"ae25093a78abd708ce74b9b5107e8e3a234c9cd9","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-05-22 21:23:05.000000000","message":"Patch Set 4: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-swiftclient-python26 http://logs.openstack.org/59/184659/4/check/gate-python-swiftclient-python26/c994c15/ : SUCCESS in 58s\n- gate-python-swiftclient-pep8 http://logs.openstack.org/59/184659/4/check/gate-python-swiftclient-pep8/403ef17/ : SUCCESS in 45s\n- gate-python-swiftclient-docs http://docs-draft.openstack.org/59/184659/4/check/gate-python-swiftclient-docs/5e60231//doc/build/html/ : SUCCESS in 58s\n- gate-python-swiftclient-python27 http://logs.openstack.org/59/184659/4/check/gate-python-swiftclient-python27/c6e97f2/ : SUCCESS in 59s\n- gate-python-swiftclient-python34 http://logs.openstack.org/59/184659/4/check/gate-python-swiftclient-python34/69702ed/ : SUCCESS in 2m 15s\n- gate-python-swiftclient-pypy http://logs.openstack.org/59/184659/4/check/gate-python-swiftclient-pypy/3b48b90/ : SUCCESS in 1m 59s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-swiftclient http://logs.openstack.org/59/184659/4/check/gate-tempest-dsvm-neutron-src-python-swiftclient/d2e0892/ : SUCCESS in 57m 08s\n- check-swift-dsvm-functional http://logs.openstack.org/59/184659/4/check/check-swift-dsvm-functional/cb2e180/ : SUCCESS in 22m 37s\n- check-swiftclient-dsvm-functional http://logs.openstack.org/59/184659/4/check/check-swiftclient-dsvm-functional/219cc27/ : SUCCESS in 21m 31s","accounts_in_message":[],"_revision_number":4},{"id":"6b7ec191f79d42b9e2a0504ef9250ee028a8a425","author":{"_account_id":6968,"name":"Christian Schwede","email":"cschwede@nvidia.com","username":"cschwede"},"date":"2015-05-29 07:25:44.000000000","message":"Patch Set 4: Code-Review+2 Workflow+1\n\nNice, also confirmed this with:\n\n tcpdump -i lo -vvvs 1024 -l -A port 8080 | grep Accept-Encoding\n\nWorks as expected.","accounts_in_message":[],"_revision_number":4},{"id":"887ddce515682d11ce5213023ca59bd941e148b2","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-05-29 07:25:49.000000000","message":"Patch Set 4: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":4},{"id":"5cc68e5560651b394f1dc86b8319809199d82760","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-05-29 08:13:16.000000000","message":"Patch Set 4: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-swiftclient-python26 http://logs.openstack.org/59/184659/4/gate/gate-python-swiftclient-python26/860ad3c/ : SUCCESS in 52s\n- gate-python-swiftclient-docs http://docs-draft.openstack.org/59/184659/4/gate/gate-python-swiftclient-docs/c1d6fd8//doc/build/html/ : SUCCESS in 36s\n- gate-python-swiftclient-pep8 http://logs.openstack.org/59/184659/4/gate/gate-python-swiftclient-pep8/2ab03f9/ : SUCCESS in 40s\n- gate-python-swiftclient-python27 http://logs.openstack.org/59/184659/4/gate/gate-python-swiftclient-python27/438e361/ : SUCCESS in 1m 03s\n- gate-python-swiftclient-python34 http://logs.openstack.org/59/184659/4/gate/gate-python-swiftclient-python34/0344c49/ : SUCCESS in 2m 05s\n- gate-python-swiftclient-pypy http://logs.openstack.org/59/184659/4/gate/gate-python-swiftclient-pypy/bd3403e/ : SUCCESS in 1m 11s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-swiftclient http://logs.openstack.org/59/184659/4/gate/gate-tempest-dsvm-neutron-src-python-swiftclient/7b76fc1/ : SUCCESS in 46m 58s\n- gate-swift-dsvm-functional http://logs.openstack.org/59/184659/4/gate/gate-swift-dsvm-functional/8366de7/ : SUCCESS in 17m 13s\n- gate-swiftclient-dsvm-functional http://logs.openstack.org/59/184659/4/gate/gate-swiftclient-dsvm-functional/a9a4b1b/ : SUCCESS in 18m 11s","accounts_in_message":[],"_revision_number":4},{"id":"c324d5de96be94345b6bca473faa4ba7d3a2f9d7","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-05-29 08:13:18.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"7d5c85ad1013185bd3aa7f0d384f2e0e68e3b484","revisions":{"e8043ab05309e8808f3b7326f85582947313364c":{"kind":"REWORK","_number":1,"created":"2015-05-21 00:41:49.000000000","uploader":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"ref":"refs/changes/59/184659/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-swiftclient","ref":"refs/changes/59/184659/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/59/184659/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/59/184659/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/59/184659/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-swiftclient refs/changes/59/184659/1"}}},"commit":{"parents":[{"commit":"925cb1c59ca2df015d9073a8e46a8aec7ac39cf3","subject":"Remove simplejson dependency","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/925cb1c59ca2df015d9073a8e46a8aec7ac39cf3"}]}],"author":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2015-05-20 23:07:04.000000000","tz":-420},"committer":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2015-05-21 00:15:46.000000000","tz":-420},"subject":"Stop decoding object content","message":"Stop decoding object content\n\nPreviously, we had urllib3 (via requests) automatically decode all\nresponses with a Content-Encoding of deflate or gzip. This included\nobject downloads, which would in turn cause etag or content-length\nmismatch errors. (See bug 1338464)\n\nThis was apparently added in response to a third-party proxy sitting\nbetween the client and server which, having observed that the client\nwould accept gzip-encoded content while the server sent an unencoded\nresponse, would perform the compression. (See bug 1282861)\n\nNow, rather than having urllib3 perform the decoding, we\u0027ll do it\nourselves, and only for API requests where we want Python objects out\ninstead of raw bytes. Delfate support is dropped, as there are\napparently conflicting implementations.\n\nIn addition, a Cache-Control: no-transform header is added for object\ndownloads to discourage proxies from encoding otherwise unencoded\ncontent. (See RFC 7230, Section 5.7.2)\n\nChange-Id: I6cc30a5c12e37de06d7322533a3c36ad15397cc8\nCloses-Bug: 1338464\nRelated-Bug: 1282861\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/e8043ab05309e8808f3b7326f85582947313364c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/e8043ab05309e8808f3b7326f85582947313364c"}]},"branch":"refs/heads/master"},"ab66df0241f7c48762a95ba616a6fc8547cdd280":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2015-05-21 01:15:27.000000000","uploader":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"ref":"refs/changes/59/184659/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-swiftclient","ref":"refs/changes/59/184659/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/59/184659/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/59/184659/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/59/184659/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-swiftclient refs/changes/59/184659/2"}}},"commit":{"parents":[{"commit":"317df7e527c174695e184f8250f5f743ac91f0f2","subject":"Remove simplejson dependency","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/317df7e527c174695e184f8250f5f743ac91f0f2"}]}],"author":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2015-05-20 23:07:04.000000000","tz":-420},"committer":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2015-05-21 01:14:53.000000000","tz":-420},"subject":"Stop decoding object content","message":"Stop decoding object content\n\nPreviously, we had urllib3 (via requests) automatically decode all\nresponses with a Content-Encoding of deflate or gzip. This included\nobject downloads, which would in turn cause etag or content-length\nmismatch errors. (See bug 1338464)\n\nThis was apparently added in response to a third-party proxy sitting\nbetween the client and server which, having observed that the client\nwould accept gzip-encoded content while the server sent an unencoded\nresponse, would perform the compression. (See bug 1282861)\n\nNow, rather than having urllib3 perform the decoding, we\u0027ll do it\nourselves, and only for API requests where we want Python objects out\ninstead of raw bytes. Delfate support is dropped, as there are\napparently conflicting implementations.\n\nIn addition, a Cache-Control: no-transform header is added for object\ndownloads to discourage proxies from encoding otherwise unencoded\ncontent. (See RFC 7230, Section 5.7.2)\n\nChange-Id: I6cc30a5c12e37de06d7322533a3c36ad15397cc8\nCloses-Bug: 1338464\nRelated-Bug: 1282861\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/ab66df0241f7c48762a95ba616a6fc8547cdd280"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/ab66df0241f7c48762a95ba616a6fc8547cdd280"}]},"branch":"refs/heads/master"},"863afe76a84c8c362ebb499c3e454446e066b859":{"kind":"REWORK","_number":3,"created":"2015-05-22 06:38:35.000000000","uploader":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"ref":"refs/changes/59/184659/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-swiftclient","ref":"refs/changes/59/184659/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/59/184659/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/59/184659/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/59/184659/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-swiftclient refs/changes/59/184659/3"}}},"commit":{"parents":[{"commit":"317df7e527c174695e184f8250f5f743ac91f0f2","subject":"Remove simplejson dependency","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/317df7e527c174695e184f8250f5f743ac91f0f2"}]}],"author":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2015-05-20 23:07:04.000000000","tz":-420},"committer":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2015-05-22 05:33:25.000000000","tz":-420},"subject":"Stop decoding object content","message":"Stop decoding object content\n\nPreviously, we had urllib3 (via requests) automatically decode all\nresponses with a Content-Encoding of deflate or gzip. This included\nobject downloads, which would in turn cause etag or content-length\nmismatch errors. (See bug 1338464)\n\nThis was apparently added in response to a third-party proxy sitting\nbetween the client and server which, having observed that the client\nwould accept gzip-encoded content while the server sent an unencoded\nresponse, would perform the compression. (See bug 1282861)\n\nNow, we\u0027ll no longer let requests send any default headers, nor do any\ndecoding. In addition, a Cache-Control: no-transform header is added for\nobject downloads (provided the caller did not already include one) to\nfurther discourage proxies from encoding otherwise unencoded content.\n(See RFC 7230, Section 5.7.2)\n\nChange-Id: I6cc30a5c12e37de06d7322533a3c36ad15397cc8\nCloses-Bug: 1338464\nRelated-Bug: 1282861\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/863afe76a84c8c362ebb499c3e454446e066b859"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/863afe76a84c8c362ebb499c3e454446e066b859"}]},"branch":"refs/heads/master"},"7d5c85ad1013185bd3aa7f0d384f2e0e68e3b484":{"kind":"REWORK","_number":4,"created":"2015-05-22 20:25:47.000000000","uploader":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"ref":"refs/changes/59/184659/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-swiftclient","ref":"refs/changes/59/184659/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/59/184659/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/59/184659/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/59/184659/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-swiftclient refs/changes/59/184659/4"}}},"commit":{"parents":[{"commit":"52b849217f22b6185b7f6dc0b9ad6ab5a10ce132","subject":"Merge \"Add tests for uploads deleting DLO segments\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/52b849217f22b6185b7f6dc0b9ad6ab5a10ce132"}]}],"author":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2015-05-20 23:07:04.000000000","tz":-420},"committer":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2015-05-22 20:24:46.000000000","tz":-420},"subject":"Stop decoding object content","message":"Stop decoding object content\n\nPreviously, we had urllib3 (via requests) automatically decode all\nresponses with a Content-Encoding of deflate or gzip. This included\nobject downloads, which would in turn cause etag or content-length\nmismatch errors. (See bug 1338464)\n\nThis was apparently added in response to a third-party proxy sitting\nbetween the client and server which, having observed that the client\nwould accept gzip-encoded content while the server sent an unencoded\nresponse, would perform the compression. (See bug 1282861)\n\nNow, we\u0027ll no longer let requests send any default headers, nor do any\ndecoding.\n\nChange-Id: I6cc30a5c12e37de06d7322533a3c36ad15397cc8\nCloses-Bug: 1338464\nRelated-Bug: 1282861\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/7d5c85ad1013185bd3aa7f0d384f2e0e68e3b484"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/7d5c85ad1013185bd3aa7f0d384f2e0e68e3b484"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
