)]}'
{"id":"openstack%2Fpython-swiftclient~189815","triplet_id":"openstack%2Fpython-swiftclient~master~I355ad2827a2f7c14526db6bbb691cc2d2a880b2a","project":"openstack/python-swiftclient","branch":"master","hashtags":[],"change_id":"I355ad2827a2f7c14526db6bbb691cc2d2a880b2a","subject":"Rename `obj` to `name` in *_object wrappers","status":"NEW","created":"2015-06-09 17:07:22.000000000","updated":"2017-12-18 12:12:20.000000000","submit_type":"MERGE_IF_NECESSARY","mergeable":false,"submittable":false,"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"b24004f56a6dd86fd13ac60a91f4b18b446d52ad","_number":189815,"virtual_id_number":189815,"owner":{"_account_id":11356,"name":"Louis Taylor","email":"louis@kragniz.eu","username":"kragniz"},"actions":{},"labels":{"Verified":{"all":[{"_account_id":9216,"name":"Joel Wright","email":"joel.wright@gmail.com","username":"jjw-sohonet"},{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},{"_account_id":6968,"name":"Christian Schwede","email":"cschwede@nvidia.com","username":"cschwede"},{"_account_id":11356,"name":"Louis Taylor","email":"louis@kragniz.eu","username":"kragniz"},{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"rejected":{"_account_id":9216,"name":"Joel Wright","email":"joel.wright@gmail.com","username":"jjw-sohonet"},"all":[{"value":-2,"date":"2015-06-25 14:01:11.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":9216,"name":"Joel Wright","email":"joel.wright@gmail.com","username":"jjw-sohonet"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},{"value":-2,"date":"2015-06-25 10:56:30.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":6968,"name":"Christian Schwede","email":"cschwede@nvidia.com","username":"cschwede"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":11356,"name":"Louis Taylor","email":"louis@kragniz.eu","username":"kragniz"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":9216,"name":"Joel Wright","email":"joel.wright@gmail.com","username":"jjw-sohonet"},{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":6968,"name":"Christian Schwede","email":"cschwede@nvidia.com","username":"cschwede"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":11356,"name":"Louis Taylor","email":"louis@kragniz.eu","username":"kragniz"},{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},{"_account_id":6968,"name":"Christian Schwede","email":"cschwede@nvidia.com","username":"cschwede"},{"_account_id":9216,"name":"Joel Wright","email":"joel.wright@gmail.com","username":"jjw-sohonet"},{"_account_id":11356,"name":"Louis Taylor","email":"louis@kragniz.eu","username":"kragniz"},{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-06-10 00:11:32.000000000","updated_by":{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},"reviewer":{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},"state":"REVIEWER"},{"updated":"2015-06-24 23:28:26.000000000","updated_by":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"reviewer":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"state":"REVIEWER"},{"updated":"2015-06-25 10:56:30.000000000","updated_by":{"_account_id":6968,"name":"Christian Schwede","email":"cschwede@nvidia.com","username":"cschwede"},"reviewer":{"_account_id":6968,"name":"Christian Schwede","email":"cschwede@nvidia.com","username":"cschwede"},"state":"REVIEWER"},{"updated":"2015-06-25 14:01:11.000000000","updated_by":{"_account_id":9216,"name":"Joel Wright","email":"joel.wright@gmail.com","username":"jjw-sohonet"},"reviewer":{"_account_id":9216,"name":"Joel Wright","email":"joel.wright@gmail.com","username":"jjw-sohonet"},"state":"REVIEWER"}],"messages":[{"id":"69f34b985147f7bf38451174fb846360a76f3062","author":{"_account_id":11356,"name":"Louis Taylor","email":"louis@kragniz.eu","username":"kragniz"},"date":"2015-06-09 17:07:22.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"d410c193556d6687130f9a7090d766fa4f6a8de5","author":{"_account_id":6968,"name":"Christian Schwede","email":"cschwede@nvidia.com","username":"cschwede"},"date":"2015-06-09 17:58:03.000000000","message":"Patch Set 1: Code-Review-1\n\n-1 for two reasons:\n\n1. This patch is inconsistent; either change \"obj\" everywhere to \"name\", or not at all - this is quite irritating when reading the code;\n2. In general I prefer to know what the variable is referring to. A name - which name? Account, container, object, something else?\n\n\"objname\" might be better, but then it should be changed everywhere in the source code.","accounts_in_message":[],"_revision_number":1},{"id":"b8adfac408fc83f28d862d63e63a933f757deaae","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-06-09 18:00:54.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-swiftclient-python26 http://logs.openstack.org/15/189815/1/check/gate-python-swiftclient-python26/edf4bcf/ : SUCCESS in 1m 16s\n- gate-python-swiftclient-pep8 http://logs.openstack.org/15/189815/1/check/gate-python-swiftclient-pep8/b7f5431/ : SUCCESS in 48s\n- gate-python-swiftclient-docs http://docs-draft.openstack.org/15/189815/1/check/gate-python-swiftclient-docs/bc94bbb//doc/build/html/ : SUCCESS in 1m 07s\n- gate-python-swiftclient-python27 http://logs.openstack.org/15/189815/1/check/gate-python-swiftclient-python27/7f180e4/ : SUCCESS in 56s\n- gate-python-swiftclient-python34 http://logs.openstack.org/15/189815/1/check/gate-python-swiftclient-python34/2e6e16d/ : SUCCESS in 2m 03s\n- gate-python-swiftclient-pypy http://logs.openstack.org/15/189815/1/check/gate-python-swiftclient-pypy/187cf29/ : SUCCESS in 1m 19s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-swiftclient http://logs.openstack.org/15/189815/1/check/gate-tempest-dsvm-neutron-src-python-swiftclient/f5071c7/ : FAILURE in 44m 37s\n- check-swift-dsvm-functional http://logs.openstack.org/15/189815/1/check/check-swift-dsvm-functional/67e7cac/ : SUCCESS in 29m 24s\n- check-swiftclient-dsvm-functional http://logs.openstack.org/15/189815/1/check/check-swiftclient-dsvm-functional/f23a759/ : SUCCESS in 21m 06s","accounts_in_message":[],"_revision_number":1},{"id":"a23487eb83fba4263ab733c5be4249299c7c6c33","author":{"_account_id":11356,"name":"Louis Taylor","email":"louis@kragniz.eu","username":"kragniz"},"date":"2015-06-09 18:26:01.000000000","message":"Patch Set 1:\n\nAs mentioned in the commit message, the functions which do anything with this already call it \u0027name\u0027 (for example https://github.com/openstack/python-swiftclient/blob/master/swiftclient/client.py#L864), but the friendly wrapper names it differently (displayed to end users in the documentation here: http://docs.openstack.org/developer/python-swiftclient/swiftclient.html#swiftclient.client.Connection.get_object).","accounts_in_message":[],"_revision_number":1},{"id":"b403d62abc99ad0b6f846a4f1e23072a9958e1cc","author":{"_account_id":6968,"name":"Christian Schwede","email":"cschwede@nvidia.com","username":"cschwede"},"date":"2015-06-09 19:42:48.000000000","message":"Patch Set 1:\n\nLuis: ah, got me :)\n\nWell, looks like I didn\u0027t remember that correctly - so I agree with you, making it more consistent would be great.\n\nHowever, swiftclient/service.py still uses \"obj\"; even worse, sometimes it\u0027s \"object_name\" (see http://docs.openstack.org/developer/python-swiftclient/swiftclient.html#module-swiftclient.service). So a patch should adress this as well.\n\nI\u0027m worried about that this change might break tools that use swiftclient. I think we should discuss this in a Swift team meeting (https://wiki.openstack.org/wiki/Meetings/Swift), what do you think?","accounts_in_message":[],"_revision_number":1},{"id":"c23bbe703a0b0c1eca9adeda217e9b818a3d38ce","author":{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},"date":"2015-06-10 00:11:32.000000000","message":"Patch Set 1:\n\nrecheck no bug","accounts_in_message":[],"_revision_number":1},{"id":"c05304552da8699453ba3a7de9b1bb949b5ddf21","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-06-10 01:04:22.000000000","message":"Patch Set 1:\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-swiftclient-python26 http://logs.openstack.org/15/189815/1/check/gate-python-swiftclient-python26/60f78cd/ : SUCCESS in 49s\n- gate-python-swiftclient-pep8 http://logs.openstack.org/15/189815/1/check/gate-python-swiftclient-pep8/789f000/ : SUCCESS in 53s\n- gate-python-swiftclient-docs http://docs-draft.openstack.org/15/189815/1/check/gate-python-swiftclient-docs/a9ecb4c//doc/build/html/ : SUCCESS in 57s\n- gate-python-swiftclient-python27 http://logs.openstack.org/15/189815/1/check/gate-python-swiftclient-python27/8dba79e/ : SUCCESS in 1m 03s\n- gate-python-swiftclient-python34 http://logs.openstack.org/15/189815/1/check/gate-python-swiftclient-python34/a943f0e/ : SUCCESS in 2m 48s\n- gate-python-swiftclient-pypy http://logs.openstack.org/15/189815/1/check/gate-python-swiftclient-pypy/82091b6/ : SUCCESS in 1m 45s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-swiftclient http://logs.openstack.org/15/189815/1/check/gate-tempest-dsvm-neutron-src-python-swiftclient/7e27dd7/ : FAILURE in 40m 59s\n- check-swift-dsvm-functional http://logs.openstack.org/15/189815/1/check/check-swift-dsvm-functional/7538679/ : SUCCESS in 34m 05s\n- check-swiftclient-dsvm-functional http://logs.openstack.org/15/189815/1/check/check-swiftclient-dsvm-functional/4c14ec6/ : SUCCESS in 19m 53s","accounts_in_message":[],"_revision_number":1},{"id":"10ed38e4a98e2bf8442c6c5534d29f211645c316","author":{"_account_id":11356,"name":"Louis Taylor","email":"louis@kragniz.eu","username":"kragniz"},"date":"2015-06-10 10:39:29.000000000","message":"Patch Set 1:\n\nI\u0027m fine with talking about this at today\u0027s meeting, if people want that.","accounts_in_message":[],"_revision_number":1},{"id":"ef7b04022cd9c04aa608e4811d7a5e0ac6132912","author":{"_account_id":6968,"name":"Christian Schwede","email":"cschwede@nvidia.com","username":"cschwede"},"date":"2015-06-10 12:11:07.000000000","message":"Patch Set 1:\n\nAdded Joel.-\n\n@Joel: what do you think about changing argument names?","accounts_in_message":[],"_revision_number":1},{"id":"77134cec242b81e7e0f4c486b4feaaf6b78fcd57","author":{"_account_id":9216,"name":"Joel Wright","email":"joel.wright@gmail.com","username":"jjw-sohonet"},"date":"2015-06-10 15:16:17.000000000","message":"Patch Set 1:\n\nHonestly I\u0027m not sure how I feel about this. I agree with the spirit of the patch both because \u0027obj\u0027 could cause confusion, and because of the inconsistent naming.\n\nWe\u0027re already using \u0027name\u0027 elsewhere, so maybe that\u0027s the best option, but sadly it looks like talking to an object-store in an object-oriented language is always going to be a source of confusion :(\n\nBecause this will only affect the docs I see no reason to stop it, but maybe a more helpful change than just renaming the argument would be to add appropriate docstrings to all the wrapper methods as well.\n\n@Christian: what do you think?","accounts_in_message":[],"_revision_number":1},{"id":"203b0ea50042dc92d4d0a6d76d1dc581844a0009","author":{"_account_id":9216,"name":"Joel Wright","email":"joel.wright@gmail.com","username":"jjw-sohonet"},"date":"2015-06-10 15:19:58.000000000","message":"Patch Set 1:\n\nSorry, forgot to say that I agree it would be good to be consistent across swiftclient.client and swiftclient.service as well.","accounts_in_message":[],"_revision_number":1},{"id":"9a2f1a46b9d40d718a27ff1d57e4c344b24ec704","author":{"_account_id":6968,"name":"Christian Schwede","email":"cschwede@nvidia.com","username":"cschwede"},"date":"2015-06-10 15:31:04.000000000","message":"Patch Set 1:\n\n@Joel: my concern is that people actually use keyword arguments, and this will break compatibility then. At least we need a new tagged version afterwards, and a clear statement that this might break things. And we should make it consistent everywhere in the code then.","accounts_in_message":[],"_revision_number":1},{"id":"d909d82115c5994fb25996d9b79f5e4ef947fb0e","author":{"_account_id":11356,"name":"Louis Taylor","email":"louis@kragniz.eu","username":"kragniz"},"date":"2015-06-10 22:06:56.000000000","message":"Patch Set 1:\n\nHi christian, you\u0027ll see they\u0027re not keyword arguments, just regular ones. Unless users are doing crazy-pants introspection, this shouldn\u0027t effect them.","accounts_in_message":[],"_revision_number":1},{"id":"c738974ee8389667a3d4dc3cf9cf9053965aa981","author":{"_account_id":6968,"name":"Christian Schwede","email":"cschwede@nvidia.com","username":"cschwede"},"date":"2015-06-11 07:56:18.000000000","message":"Patch Set 1:\n\nrecheck no bug","accounts_in_message":[],"_revision_number":1},{"id":"d952d95c74c41fe5d4c2fac4221cc9f3366c9d16","author":{"_account_id":6968,"name":"Christian Schwede","email":"cschwede@nvidia.com","username":"cschwede"},"date":"2015-06-11 07:56:53.000000000","message":"Patch Set 1: -Code-Review\n\n@Luis: yes, you\u0027re right, there are no keywords changed in this patch; I had in mind to make the whole codebase consistent, because right now we have a bunch of different arg/kwarg names:\n\n obj\n name\n object_name\n objects","accounts_in_message":[],"_revision_number":1},{"id":"cd904bfa3d70b6446ff69ea28c149ef823e08c25","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-06-11 08:37:43.000000000","message":"Patch Set 1:\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-swiftclient-python26 http://logs.openstack.org/15/189815/1/check/gate-python-swiftclient-python26/42abcbc/ : SUCCESS in 56s\n- gate-python-swiftclient-pep8 http://logs.openstack.org/15/189815/1/check/gate-python-swiftclient-pep8/da8e167/ : SUCCESS in 1m 04s\n- gate-python-swiftclient-docs http://docs-draft.openstack.org/15/189815/1/check/gate-python-swiftclient-docs/04a68e7//doc/build/html/ : SUCCESS in 57s\n- gate-python-swiftclient-python27 http://logs.openstack.org/15/189815/1/check/gate-python-swiftclient-python27/1f6e09e/ : SUCCESS in 1m 00s\n- gate-python-swiftclient-python34 http://logs.openstack.org/15/189815/1/check/gate-python-swiftclient-python34/51bab9d/ : SUCCESS in 2m 13s\n- gate-python-swiftclient-pypy http://logs.openstack.org/15/189815/1/check/gate-python-swiftclient-pypy/2bbbbef/ : SUCCESS in 1m 37s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-swiftclient http://logs.openstack.org/15/189815/1/check/gate-tempest-dsvm-neutron-src-python-swiftclient/144bfaf/ : FAILURE in 41m 18s\n- check-swift-dsvm-functional http://logs.openstack.org/15/189815/1/check/check-swift-dsvm-functional/2a99c8c/ : SUCCESS in 25m 13s\n- check-swiftclient-dsvm-functional http://logs.openstack.org/15/189815/1/check/check-swiftclient-dsvm-functional/430dff2/ : SUCCESS in 17m 39s","accounts_in_message":[],"_revision_number":1},{"id":"2b50b9558a82002b98177abae6a0061408967c1f","author":{"_account_id":9216,"name":"Joel Wright","email":"joel.wright@gmail.com","username":"jjw-sohonet"},"date":"2015-06-11 13:38:51.000000000","message":"Patch Set 1:\n\n@Christian: The changes to swiftclient.service would be more challenging because I\u0027m sure some of those are kwargs, but at the very least this patch would reduce the number of possibilities for \u0027object_name\u0027 from 4 to 3 without affecting anyone\u0027s existing code. \n\nThis is probably not be the end of the story, but it seems we\u0027re stuck with \u0027name\u0027 in swiftclient.client without breaking backwards compatibility, so I can see no reason no reason to block this.","accounts_in_message":[],"_revision_number":1},{"id":"c1ca114b2ab367d197425c307c64b267c9781a25","author":{"_account_id":11356,"name":"Louis Taylor","email":"louis@kragniz.eu","username":"kragniz"},"date":"2015-06-15 08:56:16.000000000","message":"Patch Set 1:\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"6b685312bd666137eef9c073f4efd32fd6333da6","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-06-15 09:35:41.000000000","message":"Patch Set 1:\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-swiftclient-python26 http://logs.openstack.org/15/189815/1/check/gate-python-swiftclient-python26/721fce0/ : SUCCESS in 53s\n- gate-python-swiftclient-pep8 http://logs.openstack.org/15/189815/1/check/gate-python-swiftclient-pep8/a12979f/ : SUCCESS in 1m 01s\n- gate-python-swiftclient-docs http://docs-draft.openstack.org/15/189815/1/check/gate-python-swiftclient-docs/3f600c1//doc/build/html/ : SUCCESS in 1m 07s\n- gate-python-swiftclient-python27 http://logs.openstack.org/15/189815/1/check/gate-python-swiftclient-python27/961c36b/ : SUCCESS in 45s\n- gate-python-swiftclient-python34 http://logs.openstack.org/15/189815/1/check/gate-python-swiftclient-python34/f7a5dbe/ : SUCCESS in 1m 38s\n- gate-python-swiftclient-pypy http://logs.openstack.org/15/189815/1/check/gate-python-swiftclient-pypy/b0e23a2/ : SUCCESS in 1m 30s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-swiftclient http://logs.openstack.org/15/189815/1/check/gate-tempest-dsvm-neutron-src-python-swiftclient/3187a30/ : FAILURE in 37m 58s\n- check-swift-dsvm-functional http://logs.openstack.org/15/189815/1/check/check-swift-dsvm-functional/1d389c1/ : SUCCESS in 25m 40s\n- check-swiftclient-dsvm-functional http://logs.openstack.org/15/189815/1/check/check-swiftclient-dsvm-functional/fa74ef4/ : SUCCESS in 24m 04s","accounts_in_message":[],"_revision_number":1},{"id":"7e23cea0ea0dc09e8cc62b0dc433f0299f034cc3","author":{"_account_id":9216,"name":"Joel Wright","email":"joel.wright@gmail.com","username":"jjw-sohonet"},"date":"2015-06-17 13:16:05.000000000","message":"Patch Set 1:\n\nrecheck no bug","accounts_in_message":[],"_revision_number":1},{"id":"8fb90c617f69ade3e7f10d6a28caebecc5352342","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-06-17 13:48:56.000000000","message":"Patch Set 1:\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-swiftclient-python26 http://logs.openstack.org/15/189815/1/check/gate-python-swiftclient-python26/6ebe65c/ : SUCCESS in 51s\n- gate-python-swiftclient-pep8 http://logs.openstack.org/15/189815/1/check/gate-python-swiftclient-pep8/51a4905/ : SUCCESS in 43s\n- gate-python-swiftclient-docs http://docs-draft.openstack.org/15/189815/1/check/gate-python-swiftclient-docs/bc433d8//doc/build/html/ : SUCCESS in 50s\n- gate-python-swiftclient-python27 http://logs.openstack.org/15/189815/1/check/gate-python-swiftclient-python27/dee0034/ : SUCCESS in 55s\n- gate-python-swiftclient-python34 http://logs.openstack.org/15/189815/1/check/gate-python-swiftclient-python34/216c893/ : SUCCESS in 2m 07s\n- gate-python-swiftclient-pypy http://logs.openstack.org/15/189815/1/check/gate-python-swiftclient-pypy/06eca76/ : SUCCESS in 1m 35s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-swiftclient http://logs.openstack.org/15/189815/1/check/gate-tempest-dsvm-neutron-src-python-swiftclient/911d330/ : FAILURE in 32m 15s\n- check-swift-dsvm-functional http://logs.openstack.org/15/189815/1/check/check-swift-dsvm-functional/ef01b9f/ : SUCCESS in 22m 59s\n- check-swiftclient-dsvm-functional http://logs.openstack.org/15/189815/1/check/check-swiftclient-dsvm-functional/ec4b425/ : SUCCESS in 17m 17s","accounts_in_message":[],"_revision_number":1},{"id":"d8216b21d35122614bcda1bd2e57da21eaf72ba8","author":{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},"date":"2015-06-17 21:05:57.000000000","message":"Patch Set 1:\n\nrecheck no bug","accounts_in_message":[],"_revision_number":1},{"id":"7eedc0f47f31cac8c0012b0dffc5aea8473af0b0","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-06-17 21:48:39.000000000","message":"Patch Set 1:\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-swiftclient-python26 http://logs.openstack.org/15/189815/1/check/gate-python-swiftclient-python26/d05e2ca/ : SUCCESS in 48s\n- gate-python-swiftclient-pep8 http://logs.openstack.org/15/189815/1/check/gate-python-swiftclient-pep8/d500af7/ : SUCCESS in 44s\n- gate-python-swiftclient-docs http://docs-draft.openstack.org/15/189815/1/check/gate-python-swiftclient-docs/f9bcb21//doc/build/html/ : SUCCESS in 1m 04s\n- gate-python-swiftclient-python27 http://logs.openstack.org/15/189815/1/check/gate-python-swiftclient-python27/a9b62b3/ : SUCCESS in 45s\n- gate-python-swiftclient-python34 http://logs.openstack.org/15/189815/1/check/gate-python-swiftclient-python34/b2e2d0b/ : SUCCESS in 2m 09s\n- gate-python-swiftclient-pypy http://logs.openstack.org/15/189815/1/check/gate-python-swiftclient-pypy/2abe181/ : SUCCESS in 1m 21s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-swiftclient http://logs.openstack.org/15/189815/1/check/gate-tempest-dsvm-neutron-src-python-swiftclient/59d1f04/ : FAILURE in 40m 25s\n- check-swift-dsvm-functional http://logs.openstack.org/15/189815/1/check/check-swift-dsvm-functional/2820c90/ : SUCCESS in 25m 27s\n- check-swiftclient-dsvm-functional http://logs.openstack.org/15/189815/1/check/check-swiftclient-dsvm-functional/c1c90f8/ : SUCCESS in 14m 59s","accounts_in_message":[],"_revision_number":1},{"id":"ac1507024d14a91ad1b0db4ce3c5bf799e31de0d","author":{"_account_id":9216,"name":"Joel Wright","email":"joel.wright@gmail.com","username":"jjw-sohonet"},"date":"2015-06-18 14:15:33.000000000","message":"Patch Set 1:\n\nrecheck no bug","accounts_in_message":[],"_revision_number":1},{"id":"769e77e6d31d372d7735cbcb6e6b8a455b629eb8","author":{"_account_id":9216,"name":"Joel Wright","email":"joel.wright@gmail.com","username":"jjw-sohonet"},"date":"2015-06-18 14:16:56.000000000","message":"Patch Set 1:\n\nI\u0027m trying recheck one last time. Was on #openstack-qa last night asking about this error and we can\u0027t come up with a reason for it. If this latest test fails I\u0027ll go onto raise it on #openstack-infra...","accounts_in_message":[],"_revision_number":1},{"id":"a218ce7d67866b357ea77e641cf44dd073d36db9","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-06-18 15:01:10.000000000","message":"Patch Set 1:\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-swiftclient-python26 http://logs.openstack.org/15/189815/1/check/gate-python-swiftclient-python26/ce91884/ : SUCCESS in 53s\n- gate-python-swiftclient-pep8 http://logs.openstack.org/15/189815/1/check/gate-python-swiftclient-pep8/1cc5199/ : SUCCESS in 45s\n- gate-python-swiftclient-docs http://docs-draft.openstack.org/15/189815/1/check/gate-python-swiftclient-docs/6c81641//doc/build/html/ : SUCCESS in 1m 01s\n- gate-python-swiftclient-python27 http://logs.openstack.org/15/189815/1/check/gate-python-swiftclient-python27/2dc30ba/ : SUCCESS in 53s\n- gate-python-swiftclient-python34 http://logs.openstack.org/15/189815/1/check/gate-python-swiftclient-python34/443fd4d/ : SUCCESS in 1m 52s\n- gate-python-swiftclient-pypy http://logs.openstack.org/15/189815/1/check/gate-python-swiftclient-pypy/aff32c6/ : SUCCESS in 1m 14s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-swiftclient http://logs.openstack.org/15/189815/1/check/gate-tempest-dsvm-neutron-src-python-swiftclient/8b89874/ : FAILURE in 41m 21s\n- check-swift-dsvm-functional http://logs.openstack.org/15/189815/1/check/check-swift-dsvm-functional/d819d69/ : SUCCESS in 29m 24s\n- check-swiftclient-dsvm-functional http://logs.openstack.org/15/189815/1/check/check-swiftclient-dsvm-functional/4ac2121/ : SUCCESS in 20m 04s","accounts_in_message":[],"_revision_number":1},{"id":"88548d57432d09cebead59eceb11d76033286d18","author":{"_account_id":9216,"name":"Joel Wright","email":"joel.wright@gmail.com","username":"jjw-sohonet"},"date":"2015-06-18 17:14:43.000000000","message":"Patch Set 1:\n\nrecheck no bug","accounts_in_message":[],"_revision_number":1},{"id":"249ca62b46fd0826dc3c5ed9cf0400613f6d5723","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-06-18 18:15:36.000000000","message":"Patch Set 1:\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-swiftclient-python26 http://logs.openstack.org/15/189815/1/check/gate-python-swiftclient-python26/1755729/ : SUCCESS in 1m 02s\n- gate-python-swiftclient-pep8 http://logs.openstack.org/15/189815/1/check/gate-python-swiftclient-pep8/65719ed/ : SUCCESS in 58s\n- gate-python-swiftclient-docs http://docs-draft.openstack.org/15/189815/1/check/gate-python-swiftclient-docs/5981591//doc/build/html/ : SUCCESS in 1m 00s\n- gate-python-swiftclient-python27 http://logs.openstack.org/15/189815/1/check/gate-python-swiftclient-python27/d29920a/ : SUCCESS in 1m 01s\n- gate-python-swiftclient-python34 http://logs.openstack.org/15/189815/1/check/gate-python-swiftclient-python34/a858b23/ : SUCCESS in 1m 46s\n- gate-python-swiftclient-pypy http://logs.openstack.org/15/189815/1/check/gate-python-swiftclient-pypy/63ad04e/ : SUCCESS in 1m 14s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-swiftclient http://logs.openstack.org/15/189815/1/check/gate-tempest-dsvm-neutron-src-python-swiftclient/609edc3/ : FAILURE in 40m 27s\n- check-swift-dsvm-functional http://logs.openstack.org/15/189815/1/check/check-swift-dsvm-functional/0ddd211/ : SUCCESS in 27m 03s\n- check-swiftclient-dsvm-functional http://logs.openstack.org/15/189815/1/check/check-swiftclient-dsvm-functional/bac1eb2/ : SUCCESS in 23m 49s","accounts_in_message":[],"_revision_number":1},{"id":"9f674faa230d47e329e48174714b591dae780ac3","author":{"_account_id":9216,"name":"Joel Wright","email":"joel.wright@gmail.com","username":"jjw-sohonet"},"date":"2015-06-21 21:11:29.000000000","message":"Patch Set 1:\n\nrecheck no bug","accounts_in_message":[],"_revision_number":1},{"id":"c3ac5aa1ccc18c6d4cd2346d05f9406e6fb62da3","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-06-21 21:48:56.000000000","message":"Patch Set 1:\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-swiftclient-python26 http://logs.openstack.org/15/189815/1/check/gate-python-swiftclient-python26/f90bcc4/ : SUCCESS in 1m 02s\n- gate-python-swiftclient-pep8 http://logs.openstack.org/15/189815/1/check/gate-python-swiftclient-pep8/785221d/ : SUCCESS in 52s\n- gate-python-swiftclient-docs http://docs-draft.openstack.org/15/189815/1/check/gate-python-swiftclient-docs/414be09//doc/build/html/ : SUCCESS in 1m 04s\n- gate-python-swiftclient-python27 http://logs.openstack.org/15/189815/1/check/gate-python-swiftclient-python27/38937c5/ : SUCCESS in 48s\n- gate-python-swiftclient-python34 http://logs.openstack.org/15/189815/1/check/gate-python-swiftclient-python34/febf55e/ : SUCCESS in 2m 59s\n- gate-python-swiftclient-pypy http://logs.openstack.org/15/189815/1/check/gate-python-swiftclient-pypy/a477158/ : SUCCESS in 1m 15s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-swiftclient http://logs.openstack.org/15/189815/1/check/gate-tempest-dsvm-neutron-src-python-swiftclient/d42f8bd/ : FAILURE in 37m 21s\n- check-swift-dsvm-functional http://logs.openstack.org/15/189815/1/check/check-swift-dsvm-functional/7ce43da/ : SUCCESS in 23m 43s\n- check-swiftclient-dsvm-functional http://logs.openstack.org/15/189815/1/check/check-swiftclient-dsvm-functional/07f1947/ : SUCCESS in 18m 51s","accounts_in_message":[],"_revision_number":1},{"id":"8c0f5697ae456f0b30dc0e12b67fc49a22e25409","author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"date":"2015-06-24 22:25:52.000000000","message":"Patch Set 2: Commit message was updated","accounts_in_message":[],"_revision_number":2},{"id":"94fb6b2d73f40d655a5d7b49a25ae5761af678cb","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-06-24 23:02:37.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-swiftclient-python26 http://logs.openstack.org/15/189815/2/check/gate-python-swiftclient-python26/f57b823/ : SUCCESS in 1m 13s\n- gate-python-swiftclient-pep8 http://logs.openstack.org/15/189815/2/check/gate-python-swiftclient-pep8/d71475f/ : SUCCESS in 1m 08s\n- gate-python-swiftclient-docs http://docs-draft.openstack.org/15/189815/2/check/gate-python-swiftclient-docs/7fdb88e//doc/build/html/ : SUCCESS in 40s\n- gate-python-swiftclient-python27 http://logs.openstack.org/15/189815/2/check/gate-python-swiftclient-python27/aae3e96/ : SUCCESS in 47s\n- gate-python-swiftclient-python34 http://logs.openstack.org/15/189815/2/check/gate-python-swiftclient-python34/bf0d9cb/ : SUCCESS in 2m 26s\n- gate-python-swiftclient-pypy http://logs.openstack.org/15/189815/2/check/gate-python-swiftclient-pypy/b4e1598/ : SUCCESS in 1m 49s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-swiftclient http://logs.openstack.org/15/189815/2/check/gate-tempest-dsvm-neutron-src-python-swiftclient/3ee4a18/ : FAILURE in 35m 43s\n- check-swift-dsvm-functional http://logs.openstack.org/15/189815/2/check/check-swift-dsvm-functional/16dc4f9/ : SUCCESS in 25m 45s\n- check-swiftclient-dsvm-functional http://logs.openstack.org/15/189815/2/check/check-swiftclient-dsvm-functional/093ab18/ : FAILURE in 15m 19s","accounts_in_message":[],"_revision_number":2},{"id":"c6b553bfd483ce0db8af4bd1173138e1b611d5bc","author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"date":"2015-06-24 23:28:26.000000000","message":"Patch Set 2:\n\nrecheck","accounts_in_message":[],"_revision_number":2},{"id":"62f67c702ac1aaccb70ef61f526547b54a40be45","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-06-25 00:00:19.000000000","message":"Patch Set 2:\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-swiftclient-python26 http://logs.openstack.org/15/189815/2/check/gate-python-swiftclient-python26/fb370b5/ : SUCCESS in 53s\n- gate-python-swiftclient-pep8 http://logs.openstack.org/15/189815/2/check/gate-python-swiftclient-pep8/553600e/ : SUCCESS in 52s\n- gate-python-swiftclient-docs http://docs-draft.openstack.org/15/189815/2/check/gate-python-swiftclient-docs/3a1d4d4//doc/build/html/ : SUCCESS in 42s\n- gate-python-swiftclient-python27 http://logs.openstack.org/15/189815/2/check/gate-python-swiftclient-python27/fac69ad/ : SUCCESS in 1m 06s\n- gate-python-swiftclient-python34 http://logs.openstack.org/15/189815/2/check/gate-python-swiftclient-python34/a979253/ : SUCCESS in 1m 41s\n- gate-python-swiftclient-pypy http://logs.openstack.org/15/189815/2/check/gate-python-swiftclient-pypy/94659f0/ : SUCCESS in 2m 23s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-swiftclient http://logs.openstack.org/15/189815/2/check/gate-tempest-dsvm-neutron-src-python-swiftclient/3daa9e5/ : FAILURE in 31m 45s\n- check-swift-dsvm-functional http://logs.openstack.org/15/189815/2/check/check-swift-dsvm-functional/94dafbf/ : SUCCESS in 25m 53s\n- check-swiftclient-dsvm-functional http://logs.openstack.org/15/189815/2/check/check-swiftclient-dsvm-functional/da94ae2/ : FAILURE in 15m 56s","accounts_in_message":[],"_revision_number":2},{"id":"1ae243c4cf14b524cdbb874b0f372299b2172535","author":{"_account_id":6968,"name":"Christian Schwede","email":"cschwede@nvidia.com","username":"cschwede"},"date":"2015-06-25 05:23:16.000000000","message":"Patch Set 2:\n\nrecheck","accounts_in_message":[],"_revision_number":2},{"id":"fabca740fdb54ad876949327e0b5d1dfead7d37c","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-06-25 06:01:10.000000000","message":"Patch Set 2:\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-swiftclient-python26 http://logs.openstack.org/15/189815/2/check/gate-python-swiftclient-python26/ff99719/ : SUCCESS in 49s\n- gate-python-swiftclient-pep8 http://logs.openstack.org/15/189815/2/check/gate-python-swiftclient-pep8/9510449/ : SUCCESS in 40s\n- gate-python-swiftclient-docs http://docs-draft.openstack.org/15/189815/2/check/gate-python-swiftclient-docs/945ad22//doc/build/html/ : SUCCESS in 42s\n- gate-python-swiftclient-python27 http://logs.openstack.org/15/189815/2/check/gate-python-swiftclient-python27/62dccd4/ : SUCCESS in 58s\n- gate-python-swiftclient-python34 http://logs.openstack.org/15/189815/2/check/gate-python-swiftclient-python34/bf652c3/ : SUCCESS in 1m 48s\n- gate-python-swiftclient-pypy http://logs.openstack.org/15/189815/2/check/gate-python-swiftclient-pypy/e6252b6/ : SUCCESS in 1m 45s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-swiftclient http://logs.openstack.org/15/189815/2/check/gate-tempest-dsvm-neutron-src-python-swiftclient/7dee626/ : FAILURE in 37m 47s\n- check-swift-dsvm-functional http://logs.openstack.org/15/189815/2/check/check-swift-dsvm-functional/bafc993/ : SUCCESS in 27m 59s\n- check-swiftclient-dsvm-functional http://logs.openstack.org/15/189815/2/check/check-swiftclient-dsvm-functional/2e04ab8/ : FAILURE in 17m 30s","accounts_in_message":[],"_revision_number":2},{"id":"f81d9ddcae855521f87873c02f4a2abaf55a22c7","author":{"_account_id":6968,"name":"Christian Schwede","email":"cschwede@nvidia.com","username":"cschwede"},"date":"2015-06-25 06:29:23.000000000","message":"Patch Set 2:\n\nHmm, looks like an older glance_store version is still in use - the error is still there: http://logs.openstack.org/15/189815/2/check/gate-tempest-dsvm-neutron-src-python-swiftclient/7dee626/logs/screen-g-api.txt.gz\n\nBut the setup reports that the last version is installed: http://logs.openstack.org/15/189815/2/check/gate-tempest-dsvm-neutron-src-python-swiftclient/7dee626/logs/devstack-gate-setup-workspace-new.txt.gz\n\"HEAD is now at 01c8ccd Do not used named args when using swiftclient\"\n\nAlso, there seems to be a pip-related error now as well, swiftclient tests now fail too :/","accounts_in_message":[],"_revision_number":2},{"id":"eb3810b7523a0fe0172390bc93febc441dde50d7","author":{"_account_id":6968,"name":"Christian Schwede","email":"cschwede@nvidia.com","username":"cschwede"},"date":"2015-06-25 09:13:15.000000000","message":"Patch Set 3: Patch Set 2 was rebased","accounts_in_message":[],"_revision_number":2},{"id":"651266c1400f18a7447ffea9ec32fd463f4cb681","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-06-25 09:53:09.000000000","message":"Patch Set 3: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-swiftclient-python26 http://logs.openstack.org/15/189815/3/check/gate-python-swiftclient-python26/e1c7cc8/ : SUCCESS in 1m 01s\n- gate-python-swiftclient-pep8 http://logs.openstack.org/15/189815/3/check/gate-python-swiftclient-pep8/ddbf30e/ : SUCCESS in 43s\n- gate-python-swiftclient-docs http://docs-draft.openstack.org/15/189815/3/check/gate-python-swiftclient-docs/77c9bed//doc/build/html/ : SUCCESS in 54s\n- gate-python-swiftclient-python27 http://logs.openstack.org/15/189815/3/check/gate-python-swiftclient-python27/81d90ec/ : SUCCESS in 1m 07s\n- gate-python-swiftclient-python34 http://logs.openstack.org/15/189815/3/check/gate-python-swiftclient-python34/17a0077/ : SUCCESS in 2m 09s\n- gate-python-swiftclient-pypy http://logs.openstack.org/15/189815/3/check/gate-python-swiftclient-pypy/2afdd02/ : SUCCESS in 1m 49s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-swiftclient http://logs.openstack.org/15/189815/3/check/gate-tempest-dsvm-neutron-src-python-swiftclient/4953c53/ : FAILURE in 37m 18s\n- check-swift-dsvm-functional http://logs.openstack.org/15/189815/3/check/check-swift-dsvm-functional/7b45f00/ : SUCCESS in 25m 49s\n- check-swiftclient-dsvm-functional http://logs.openstack.org/15/189815/3/check/check-swiftclient-dsvm-functional/98e583c/ : FAILURE in 20m 08s","accounts_in_message":[],"_revision_number":3},{"id":"f164b277c2e4873e3376c3fc5d2f670deaeaacdb","author":{"_account_id":6968,"name":"Christian Schwede","email":"cschwede@nvidia.com","username":"cschwede"},"date":"2015-06-25 10:56:30.000000000","message":"Patch Set 3: Code-Review-2\n\nPut on hold after discussing this on IRC.\n\nWe need to be sure to document API changes very well, and might want to bundle multiple changes in a new (major) release. This needs more discussions.","accounts_in_message":[],"_revision_number":3},{"id":"c9bb90395a903b61011e89cf7e4e50619f4f2d04","author":{"_account_id":9216,"name":"Joel Wright","email":"joel.wright@gmail.com","username":"jjw-sohonet"},"date":"2015-06-25 14:01:11.000000000","message":"Patch Set 3: Code-Review-2\n\nAgree with Christian, this needs to be put on hold until we absolutely need to make an API breaking change.\n\nIt would be nice to see a separate patch to address the confusion in the autogenerated documentation though. Perhaps we could add docstrings that call out the relationship between `obj` and `name` in the related methods.","accounts_in_message":[],"_revision_number":3},{"id":"b24004f56a6dd86fd13ac60a91f4b18b446d52ad","author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"date":"2017-12-18 12:12:20.000000000","message":"Removed reviewer Jenkins with the following votes:\n\n* Verified-1 by Jenkins (3)\n","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"e84f58815a71662697a0f47088be0cf929aa9d8b","revisions":{"ba47cbe51074f7506cf1d6bcde12ee0a3fafb631":{"kind":"REWORK","_number":1,"created":"2015-06-09 17:07:22.000000000","uploader":{"_account_id":11356,"name":"Louis Taylor","email":"louis@kragniz.eu","username":"kragniz"},"ref":"refs/changes/15/189815/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-swiftclient","ref":"refs/changes/15/189815/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/15/189815/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/15/189815/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/15/189815/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-swiftclient refs/changes/15/189815/1"}}},"commit":{"parents":[{"commit":"ec3e2ab3a099b1276ae5d87fda936567f64423dc","subject":"Merge \"Allow reading from object body on download\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/ec3e2ab3a099b1276ae5d87fda936567f64423dc"}]}],"author":{"name":"Louis Taylor","email":"louis@kragniz.eu","date":"2015-06-09 16:45:24.000000000","tz":0},"committer":{"name":"Louis Taylor","email":"louis@kragniz.eu","date":"2015-06-09 17:07:09.000000000","tz":0},"subject":"Rename `obj` to `name` in *_object wrappers","message":"Rename `obj` to `name` in *_object wrappers\n\nThis patch renames `obj` to `name` in the function signatures of\nclient.Connection.get_object and similar. This aims to reduce the\nambiguity of the autogenerated documentation, since the functions\nrequire the name of the swift object, not a reference to a python\nobject. The methods which are wrapped also refer to it as `name`.\n\nChange-Id: I355ad2827a2f7c14526db6bbb691cc2d2a880b2a\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/ba47cbe51074f7506cf1d6bcde12ee0a3fafb631"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/ba47cbe51074f7506cf1d6bcde12ee0a3fafb631"}]},"branch":"refs/heads/master"},"dcfc94c11d66eca64da399d8e6f804079bd9e8ad":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2015-06-24 22:25:52.000000000","uploader":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"ref":"refs/changes/15/189815/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-swiftclient","ref":"refs/changes/15/189815/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/15/189815/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/15/189815/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/15/189815/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-swiftclient refs/changes/15/189815/2"}}},"commit":{"parents":[{"commit":"ec3e2ab3a099b1276ae5d87fda936567f64423dc","subject":"Merge \"Allow reading from object body on download\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/ec3e2ab3a099b1276ae5d87fda936567f64423dc"}]}],"author":{"name":"Louis Taylor","email":"louis@kragniz.eu","date":"2015-06-09 16:45:24.000000000","tz":0},"committer":{"name":"Ian Cordasco","email":"ian.cordasco@rackspace.com","date":"2015-06-24 22:25:52.000000000","tz":0},"subject":"Rename `obj` to `name` in *_object wrappers","message":"Rename `obj` to `name` in *_object wrappers\n\nThis patch renames `obj` to `name` in the function signatures of\nclient.Connection.get_object and similar. This aims to reduce the\nambiguity of the autogenerated documentation, since the functions\nrequire the name of the swift object, not a reference to a python\nobject. The methods which are wrapped also refer to it as `name`.\n\nDepends-On: I3f4e3eb8d91edbfd10dc2233e3e83a3f90313cac\nChange-Id: I355ad2827a2f7c14526db6bbb691cc2d2a880b2a\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/dcfc94c11d66eca64da399d8e6f804079bd9e8ad"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/dcfc94c11d66eca64da399d8e6f804079bd9e8ad"}]},"branch":"refs/heads/master"},"e84f58815a71662697a0f47088be0cf929aa9d8b":{"kind":"TRIVIAL_REBASE","_number":3,"created":"2015-06-25 09:13:15.000000000","uploader":{"_account_id":6968,"name":"Christian Schwede","email":"cschwede@nvidia.com","username":"cschwede"},"ref":"refs/changes/15/189815/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-swiftclient","ref":"refs/changes/15/189815/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/15/189815/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/15/189815/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/15/189815/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-swiftclient refs/changes/15/189815/3"}}},"commit":{"parents":[{"commit":"7c716997a8ede3f98741709b0594340df9849a76","subject":"Fix docstring typo for SwiftService.upload","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/7c716997a8ede3f98741709b0594340df9849a76"}]}],"author":{"name":"Louis Taylor","email":"louis@kragniz.eu","date":"2015-06-09 16:45:24.000000000","tz":0},"committer":{"name":"Christian Schwede","email":"cschwede@redhat.com","date":"2015-06-25 09:13:12.000000000","tz":0},"subject":"Rename `obj` to `name` in *_object wrappers","message":"Rename `obj` to `name` in *_object wrappers\n\nThis patch renames `obj` to `name` in the function signatures of\nclient.Connection.get_object and similar. This aims to reduce the\nambiguity of the autogenerated documentation, since the functions\nrequire the name of the swift object, not a reference to a python\nobject. The methods which are wrapped also refer to it as `name`.\n\nDepends-On: I3f4e3eb8d91edbfd10dc2233e3e83a3f90313cac\nChange-Id: I355ad2827a2f7c14526db6bbb691cc2d2a880b2a\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/e84f58815a71662697a0f47088be0cf929aa9d8b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/e84f58815a71662697a0f47088be0cf929aa9d8b"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"OK","labels":[{"label":"Verified","status":"MAY"},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":6968,"name":"Christian Schwede","email":"cschwede@nvidia.com","username":"cschwede"}},{"label":"Workflow","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{"label:Verified\u003dMAX":"","label:Verified\u003dMIN":""}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":["label:Code-Review\u003dMIN"],"failing_atoms":["label:Code-Review\u003dMAX"],"atom_explanations":{"label:Code-Review\u003dMAX":"","label:Code-Review\u003dMIN":""}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Workflow\u003dMAX","label:Workflow\u003dMIN"],"atom_explanations":{"label:Workflow\u003dMAX":"","label:Workflow\u003dMIN":""}}}]}