)]}'
{"id":"openstack%2Fpython-swiftclient~205672","triplet_id":"openstack%2Fpython-swiftclient~master~I0d9593eb5b072c8e3fa84f7d5a4c948c0bc6037a","project":"openstack/python-swiftclient","branch":"master","topic":"connection_get_auth_setattr","hashtags":[],"change_id":"I0d9593eb5b072c8e3fa84f7d5a4c948c0bc6037a","subject":"make Connection.get_auth set url and token attributes on self","status":"MERGED","created":"2015-07-24 18:52:07.000000000","updated":"2015-08-06 23:14:51.000000000","submitted":"2015-08-06 23:14:50.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"bf96b1fc13f0deb54933a12f0d8a5ec9b8c1571a","_number":205672,"virtual_id_number":205672,"owner":{"_account_id":9878,"name":"Zack M. Davis","email":"zdavis@swiftstack.com","username":"zackmdavis"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2015-08-06 23:14:50.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":12279,"name":"Janie Richling","email":"jrichli@us.ibm.com","username":"jrichli"},{"value":0,"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"value":0,"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"recommended":{"_account_id":12279,"name":"Janie Richling","email":"jrichli@us.ibm.com","username":"jrichli"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2015-08-04 03:34:49.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":12279,"name":"Janie Richling","email":"jrichli@us.ibm.com","username":"jrichli"},{"value":2,"date":"2015-08-04 00:21:04.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"value":2,"date":"2015-08-06 20:48:24.000000000","_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":12279,"name":"Janie Richling","email":"jrichli@us.ibm.com","username":"jrichli"},{"value":0,"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"value":1,"date":"2015-08-06 20:48:24.000000000","_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},{"_account_id":12279,"name":"Janie Richling","email":"jrichli@us.ibm.com","username":"jrichli"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-08-04 00:21:04.000000000","updated_by":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"reviewer":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"state":"REVIEWER"},{"updated":"2015-08-04 03:34:49.000000000","updated_by":{"_account_id":12279,"name":"Janie Richling","email":"jrichli@us.ibm.com","username":"jrichli"},"reviewer":{"_account_id":12279,"name":"Janie Richling","email":"jrichli@us.ibm.com","username":"jrichli"},"state":"REVIEWER"},{"updated":"2015-08-06 20:48:24.000000000","updated_by":{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},"reviewer":{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},"state":"REVIEWER"},{"updated":"2015-08-06 23:14:50.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"33711b87f7186d70b0d99375a6f06dc0364257d1","author":{"_account_id":9878,"name":"Zack M. Davis","email":"zdavis@swiftstack.com","username":"zackmdavis"},"date":"2015-07-24 18:52:07.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"0d633ae231b6f81d347141661d5a2022d5f846aa","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-07-24 21:12:42.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-swiftclient-python26 http://logs.openstack.org/72/205672/1/check/gate-python-swiftclient-python26/49a3309/ : SUCCESS in 58s\n- gate-python-swiftclient-pep8 http://logs.openstack.org/72/205672/1/check/gate-python-swiftclient-pep8/75ad8d5/ : SUCCESS in 54s\n- gate-python-swiftclient-docs http://docs-draft.openstack.org/72/205672/1/check/gate-python-swiftclient-docs/6557a8e//doc/build/html/ : SUCCESS in 1m 13s\n- gate-python-swiftclient-python27 http://logs.openstack.org/72/205672/1/check/gate-python-swiftclient-python27/0733630/ : SUCCESS in 1m 01s\n- gate-python-swiftclient-python34 http://logs.openstack.org/72/205672/1/check/gate-python-swiftclient-python34/6ac29fe/ : SUCCESS in 1m 50s\n- gate-python-swiftclient-pypy http://logs.openstack.org/72/205672/1/check/gate-python-swiftclient-pypy/7a025e3/ : SUCCESS in 1m 48s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-swiftclient http://logs.openstack.org/72/205672/1/check/gate-tempest-dsvm-neutron-src-python-swiftclient/54a3822/ : SUCCESS in 1h 04m 24s\n- gate-swift-dsvm-functional http://logs.openstack.org/72/205672/1/check/gate-swift-dsvm-functional/5bb7011/ : SUCCESS in 36m 35s\n- gate-swiftclient-dsvm-functional http://logs.openstack.org/72/205672/1/check/gate-swiftclient-dsvm-functional/d8db528/ : SUCCESS in 27m 33s","accounts_in_message":[],"_revision_number":1},{"id":"5ca15d5810e1630742c1c6218d3689e48790d095","author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"date":"2015-08-04 00:21:04.000000000","message":"Patch Set 1: Code-Review+2\n\nseems fine, preauthurl get\u0027s plumbed (via os_options) into get_auth - setting self.url, self.token \u003d get_auth is exactly what the _retry function already does if either of these attributes is not set for any reason.\n\nI guess you could make the argument that _retry should be simplified to not bother with the return value of get_auth (since the method is already doing it).","accounts_in_message":[],"_revision_number":1},{"id":"48cfe85f9360494e9e380e359c217f36c64f2dd8","author":{"_account_id":12279,"name":"Janie Richling","email":"jrichli@us.ibm.com","username":"jrichli"},"date":"2015-08-04 03:34:49.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"292b8ca7211d7c777bddd70e2986ad9b4e803088","author":{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},"date":"2015-08-06 20:48:24.000000000","message":"Patch Set 1: Workflow+1 Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"2855096a7ea2711f8ed998651364501b46fb8f95","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-08-06 20:48:29.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"d9bad484d54e6bda12d214808795fa7d9b8f5c8b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-08-06 23:14:50.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-swiftclient-python26 http://logs.openstack.org/72/205672/1/gate/gate-python-swiftclient-python26/1bb3823/ : SUCCESS in 48s\n- gate-python-swiftclient-docs http://docs-draft.openstack.org/72/205672/1/gate/gate-python-swiftclient-docs/ff88142//doc/build/html/ : SUCCESS in 45s\n- gate-python-swiftclient-pep8 http://logs.openstack.org/72/205672/1/gate/gate-python-swiftclient-pep8/0aa6042/ : SUCCESS in 39s\n- gate-python-swiftclient-python27 http://logs.openstack.org/72/205672/1/gate/gate-python-swiftclient-python27/8a1424c/ : SUCCESS in 47s\n- gate-python-swiftclient-python34 http://logs.openstack.org/72/205672/1/gate/gate-python-swiftclient-python34/bbe3005/ : SUCCESS in 1m 31s\n- gate-tempest-dsvm-neutron-src-python-swiftclient http://logs.openstack.org/72/205672/1/gate/gate-tempest-dsvm-neutron-src-python-swiftclient/e11473a/ : SUCCESS in 1h 05m 36s\n- gate-swift-dsvm-functional http://logs.openstack.org/72/205672/1/gate/gate-swift-dsvm-functional/e4b9f13/ : SUCCESS in 35m 09s\n- gate-swiftclient-dsvm-functional http://logs.openstack.org/72/205672/1/gate/gate-swiftclient-dsvm-functional/248dbe5/ : SUCCESS in 25m 50s","accounts_in_message":[],"_revision_number":1},{"id":"078e5a14421e5582171959eaec52826244a19c57","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-08-06 23:14:51.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"3cd1faa7afdfc829ee218f86b9bc9d914c0d0b75","revisions":{"3cd1faa7afdfc829ee218f86b9bc9d914c0d0b75":{"kind":"REWORK","_number":1,"created":"2015-07-24 18:52:07.000000000","uploader":{"_account_id":9878,"name":"Zack M. Davis","email":"zdavis@swiftstack.com","username":"zackmdavis"},"ref":"refs/changes/72/205672/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-swiftclient","ref":"refs/changes/72/205672/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/72/205672/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/72/205672/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/72/205672/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-swiftclient refs/changes/72/205672/1"}}},"commit":{"parents":[{"commit":"63998b481c7fd2d242efa12e2ca5b959bcdd113b","subject":"Merge \"Python 3: Replacing unicode with six.text_type for py3 compatibility\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/63998b481c7fd2d242efa12e2ca5b959bcdd113b"}]}],"author":{"name":"Zack M. Davis","email":"zdavis@swiftstack.com","date":"2015-07-24 17:57:29.000000000","tz":-420},"committer":{"name":"Zack M. Davis","email":"zdavis@swiftstack.com","date":"2015-07-24 17:57:29.000000000","tz":-420},"subject":"make Connection.get_auth set url and token attributes on self","message":"make Connection.get_auth set url and token attributes on self\n\nWhen a Connection is first __init__ialized (without providing a\npreauthurl or preauthtoken), the url and token attributes are None; they\nget set (to be reused on future requests) after one of the wrapper\nmethods internally using _retry (head_account, get_container,\nput_object, and similar friends) is called. However, this had not been\nthe case for get_auth, much to the momentary confusion and\ndisappointment of programmers using swiftclient who expected to be able\nto get the token or storage URL off the Connection object after calling\nget_auth (perhaps in order to make an unusual kind of request that\nswiftclient doesn\u0027t already have a function for). This commit makes\nget_auth set the url and token attributes as one might expect.\n\nChange-Id: I0d9593eb5b072c8e3fa84f7d5a4c948c0bc6037a\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/3cd1faa7afdfc829ee218f86b9bc9d914c0d0b75"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/3cd1faa7afdfc829ee218f86b9bc9d914c0d0b75"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}