)]}'
{"id":"openstack%2Fpython-swiftclient~214752","triplet_id":"openstack%2Fpython-swiftclient~master~I5fb349b2f7808a3f97d95fc7db6b5cf5842a9f7c","project":"openstack/python-swiftclient","branch":"master","topic":"bug/1475516","hashtags":[],"change_id":"I5fb349b2f7808a3f97d95fc7db6b5cf5842a9f7c","subject":"Drop flake8 ignores for already-passing tests","status":"MERGED","created":"2015-08-19 18:50:04.000000000","updated":"2015-09-03 02:19:11.000000000","submitted":"2015-09-03 02:19:09.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"7badc1421dc70359e7254e0c72800416412d753a","_number":214752,"virtual_id_number":214752,"owner":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":9216,"name":"Joel Wright","email":"joel.wright@gmail.com","username":"jjw-sohonet"},{"value":0,"_account_id":12193,"name":"Hisashi Osanai","email":"osanai.hisashi@jp.fujitsu.com","username":"ho"},{"value":2,"date":"2015-09-03 02:19:09.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":17156,"name":"Hamdi Roumani","email":"roumani@ca.ibm.com","username":"hroumani"},{"value":0,"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":9216,"name":"Joel Wright","email":"joel.wright@gmail.com","username":"jjw-sohonet"},"all":[{"value":2,"date":"2015-09-02 12:40:49.000000000","_account_id":9216,"name":"Joel Wright","email":"joel.wright@gmail.com","username":"jjw-sohonet"},{"value":1,"date":"2015-08-20 02:25:35.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":12193,"name":"Hisashi Osanai","email":"osanai.hisashi@jp.fujitsu.com","username":"ho"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":17156,"name":"Hamdi Roumani","email":"roumani@ca.ibm.com","username":"hroumani"},{"value":2,"date":"2015-08-19 22:01:51.000000000","_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":9216,"name":"Joel Wright","email":"joel.wright@gmail.com","username":"jjw-sohonet"},"all":[{"value":1,"date":"2015-09-02 12:40:49.000000000","_account_id":9216,"name":"Joel Wright","email":"joel.wright@gmail.com","username":"jjw-sohonet"},{"value":0,"_account_id":12193,"name":"Hisashi Osanai","email":"osanai.hisashi@jp.fujitsu.com","username":"ho"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":17156,"name":"Hamdi Roumani","email":"roumani@ca.ibm.com","username":"hroumani"},{"value":0,"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},{"_account_id":9216,"name":"Joel Wright","email":"joel.wright@gmail.com","username":"jjw-sohonet"},{"_account_id":12193,"name":"Hisashi Osanai","email":"osanai.hisashi@jp.fujitsu.com","username":"ho"},{"_account_id":17156,"name":"Hamdi Roumani","email":"roumani@ca.ibm.com","username":"hroumani"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-08-19 18:55:22.000000000","updated_by":{"_account_id":17156,"name":"Hamdi Roumani","email":"roumani@ca.ibm.com","username":"hroumani"},"reviewer":{"_account_id":17156,"name":"Hamdi Roumani","email":"roumani@ca.ibm.com","username":"hroumani"},"state":"REVIEWER"},{"updated":"2015-08-19 22:01:51.000000000","updated_by":{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},"reviewer":{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},"state":"REVIEWER"},{"updated":"2015-08-20 02:25:35.000000000","updated_by":{"_account_id":12193,"name":"Hisashi Osanai","email":"osanai.hisashi@jp.fujitsu.com","username":"ho"},"reviewer":{"_account_id":12193,"name":"Hisashi Osanai","email":"osanai.hisashi@jp.fujitsu.com","username":"ho"},"state":"REVIEWER"},{"updated":"2015-09-02 12:40:49.000000000","updated_by":{"_account_id":9216,"name":"Joel Wright","email":"joel.wright@gmail.com","username":"jjw-sohonet"},"reviewer":{"_account_id":9216,"name":"Joel Wright","email":"joel.wright@gmail.com","username":"jjw-sohonet"},"state":"REVIEWER"},{"updated":"2015-09-03 02:19:09.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"6086c080be66d5aa45a693c3eb803e1c4004de4a","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2015-08-19 18:50:04.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"93c28b3b68275edc7d131cfdfd67249ed0c16e90","author":{"_account_id":17156,"name":"Hamdi Roumani","email":"roumani@ca.ibm.com","username":"hroumani"},"date":"2015-08-19 18:55:22.000000000","message":"Patch Set 1: Code-Review+1\n\nThis looks good !  The only comment I\u0027d make now is the discrepancy between this and swift, where for example 401 is ignored (and I think some folks commented about how they wanted that still).  No personal preference though ! : )","accounts_in_message":[],"_revision_number":1},{"id":"0a0155baeb3870d2a3132f5db6ff102a38e65ab2","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-08-19 20:11:23.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-swiftclient-python26 http://logs.openstack.org/52/214752/1/check/gate-python-swiftclient-python26/46661f9/ : SUCCESS in 51s\n- gate-python-swiftclient-pep8 http://logs.openstack.org/52/214752/1/check/gate-python-swiftclient-pep8/dd8c09b/ : SUCCESS in 51s\n- gate-python-swiftclient-docs http://docs-draft.openstack.org/52/214752/1/check/gate-python-swiftclient-docs/b2f1e99//doc/build/html/ : SUCCESS in 44s\n- gate-python-swiftclient-python27 http://logs.openstack.org/52/214752/1/check/gate-python-swiftclient-python27/f1093b6/ : SUCCESS in 54s\n- gate-python-swiftclient-python34 http://logs.openstack.org/52/214752/1/check/gate-python-swiftclient-python34/96b4bd8/ : SUCCESS in 2m 10s\n- gate-python-swiftclient-pypy http://logs.openstack.org/52/214752/1/check/gate-python-swiftclient-pypy/f535093/ : SUCCESS in 1m 57s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-swiftclient http://logs.openstack.org/52/214752/1/check/gate-tempest-dsvm-neutron-src-python-swiftclient/1e6258d/ : SUCCESS in 1h 10m 39s\n- gate-swift-dsvm-functional http://logs.openstack.org/52/214752/1/check/gate-swift-dsvm-functional/a931fa3/ : SUCCESS in 29m 40s\n- gate-swiftclient-dsvm-functional http://logs.openstack.org/52/214752/1/check/gate-swiftclient-dsvm-functional/e73edf8/ : SUCCESS in 29m 01s","accounts_in_message":[],"_revision_number":1},{"id":"a57990f8e303454f735aeb5ab6f36a5b6f76ba6b","author":{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},"date":"2015-08-19 21:37:31.000000000","message":"Patch Set 1: Code-Review-1\n\nI do not like H401.\n\nThese hacking checks are overdone.\n\n\n\nI do not want this check in Swift\n\n(I hope that you don\u0027t feel miffed).\n\n\n\nI do not want it in the client.\n\nI do not want it from a giant.\n\nI do not want it in a house.\n\nI do not want it from a mouse.\n\n\n\nKeep it out of my source tree!\n\nH401? You leave me be!\n\n\n\nI do not want it in the rain.\n\nNot in the dark, not on a train.\n\nNot in a car, not in a tree.\n\nI do not like this check, you see.\n\nNot in a house, not in a box.\n\nNot with a mouse, not with a fox.\n\nI do not like it here or there.\n\nI do not like it anywhere.\n\n\n\nI do not like H401.\n\nBut writing this review was fun.","accounts_in_message":[],"_revision_number":1},{"id":"2aa140ea940a52f9bbeb2a5c9c9457f6ce14928e","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2015-08-19 21:55:04.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"fccf8f9aac92fa2e7f47521fc9076ff9640f110e","author":{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},"date":"2015-08-19 22:01:51.000000000","message":"Patch Set 2: Code-Review+2\n\nEh, as long as they\u0027re passing already.","accounts_in_message":[],"_revision_number":2},{"id":"e5f25f8e17e58bc29a1371117b9d10050a6ac4d7","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-08-20 00:54:53.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-swiftclient-python26 http://logs.openstack.org/52/214752/2/check/gate-python-swiftclient-python26/c1e079f/ : SUCCESS in 57s\n- gate-python-swiftclient-pep8 http://logs.openstack.org/52/214752/2/check/gate-python-swiftclient-pep8/f6add3b/ : SUCCESS in 52s\n- gate-python-swiftclient-docs http://docs-draft.openstack.org/52/214752/2/check/gate-python-swiftclient-docs/958283b//doc/build/html/ : SUCCESS in 58s\n- gate-python-swiftclient-python27 http://logs.openstack.org/52/214752/2/check/gate-python-swiftclient-python27/6ab12cd/ : SUCCESS in 54s\n- gate-python-swiftclient-python34 http://logs.openstack.org/52/214752/2/check/gate-python-swiftclient-python34/2cb100d/ : SUCCESS in 2m 37s\n- gate-python-swiftclient-pypy http://logs.openstack.org/52/214752/2/check/gate-python-swiftclient-pypy/1e1e92c/ : SUCCESS in 1m 47s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-swiftclient http://logs.openstack.org/52/214752/2/check/gate-tempest-dsvm-neutron-src-python-swiftclient/17446ca/ : SUCCESS in 1h 17m 19s\n- gate-swift-dsvm-functional http://logs.openstack.org/52/214752/2/check/gate-swift-dsvm-functional/ed85a83/ : SUCCESS in 33m 52s\n- gate-swiftclient-dsvm-functional http://logs.openstack.org/52/214752/2/check/gate-swiftclient-dsvm-functional/1f13bbb/ : SUCCESS in 30m 55s","accounts_in_message":[],"_revision_number":2},{"id":"8368adf03ec2268d167fbdb7bae45e7f4683aa31","author":{"_account_id":12193,"name":"Hisashi Osanai","email":"osanai.hisashi@jp.fujitsu.com","username":"ho"},"date":"2015-08-20 02:25:35.000000000","message":"Patch Set 2: Code-Review+1\n\nLGTM. I\u0027m curios about this patch procedure with parent one. I  thought this is because hack-a-thon\u0027s agreement. So I put +1 here.","accounts_in_message":[],"_revision_number":2},{"id":"bfad10a46d1d33066598a8f27ae90c7cf89d5ab9","author":{"_account_id":9216,"name":"Joel Wright","email":"joel.wright@gmail.com","username":"jjw-sohonet"},"date":"2015-09-02 12:40:49.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"f8cb8ef7b84d4799c8b2c7795bc9fa9f97ec136e","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-09-02 12:41:55.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"ef1c2ca0b161583864a18704c5a97ee700216031","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-09-03 02:19:09.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-swiftclient-python26 http://logs.openstack.org/52/214752/2/gate/gate-python-swiftclient-python26/9ed36e9/ : SUCCESS in 51s\n- gate-python-swiftclient-docs http://docs-draft.openstack.org/52/214752/2/gate/gate-python-swiftclient-docs/b3a4817//doc/build/html/ : SUCCESS in 54s\n- gate-python-swiftclient-pep8 http://logs.openstack.org/52/214752/2/gate/gate-python-swiftclient-pep8/2aa58ff/ : SUCCESS in 48s\n- gate-python-swiftclient-python27 http://logs.openstack.org/52/214752/2/gate/gate-python-swiftclient-python27/e8f0f24/ : SUCCESS in 55s\n- gate-python-swiftclient-python34 http://logs.openstack.org/52/214752/2/gate/gate-python-swiftclient-python34/3873801/ : SUCCESS in 2m 15s\n- gate-tempest-dsvm-neutron-src-python-swiftclient http://logs.openstack.org/52/214752/2/gate/gate-tempest-dsvm-neutron-src-python-swiftclient/8d60421/ : SUCCESS in 1h 09m 32s\n- gate-swift-dsvm-functional http://logs.openstack.org/52/214752/2/gate/gate-swift-dsvm-functional/fd66d59/ : SUCCESS in 34m 08s\n- gate-swiftclient-dsvm-functional http://logs.openstack.org/52/214752/2/gate/gate-swiftclient-dsvm-functional/32d2716/ : SUCCESS in 28m 21s","accounts_in_message":[],"_revision_number":2},{"id":"c778a34eccfc62a34ccadbb657a952a79d4b5970","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-09-03 02:19:11.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"91d82aff25d1c7887046db81a91aed263d15ab20","revisions":{"2ec6ceca83592941cf3e2b535910af84b1d53f61":{"kind":"REWORK","_number":1,"created":"2015-08-19 18:50:04.000000000","uploader":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"ref":"refs/changes/52/214752/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-swiftclient","ref":"refs/changes/52/214752/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/52/214752/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/52/214752/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/52/214752/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-swiftclient refs/changes/52/214752/1"}}},"commit":{"parents":[{"commit":"38a82e903514c242810e677f12f5eebdb775ef0b","subject":"flake8 ignores same hacks as swift","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/38a82e903514c242810e677f12f5eebdb775ef0b"}]}],"author":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2015-08-19 18:43:08.000000000","tz":-420},"committer":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2015-08-19 18:48:52.000000000","tz":-420},"subject":"Drop flake8 ignores for already-passing tests","message":"Drop flake8 ignores for already-passing tests\n\nAdditionally, fix the handful of H401 violations and drop that ignore\n\nChange-Id: I5fb349b2f7808a3f97d95fc7db6b5cf5842a9f7c\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/2ec6ceca83592941cf3e2b535910af84b1d53f61"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/2ec6ceca83592941cf3e2b535910af84b1d53f61"}]},"branch":"refs/heads/master"},"91d82aff25d1c7887046db81a91aed263d15ab20":{"kind":"REWORK","_number":2,"created":"2015-08-19 21:55:04.000000000","uploader":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"ref":"refs/changes/52/214752/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-swiftclient","ref":"refs/changes/52/214752/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/52/214752/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/52/214752/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/52/214752/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-swiftclient refs/changes/52/214752/2"}}},"commit":{"parents":[{"commit":"38a82e903514c242810e677f12f5eebdb775ef0b","subject":"flake8 ignores same hacks as swift","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/38a82e903514c242810e677f12f5eebdb775ef0b"}]}],"author":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2015-08-19 18:43:08.000000000","tz":-420},"committer":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2015-08-19 21:54:03.000000000","tz":-420},"subject":"Drop flake8 ignores for already-passing tests","message":"Drop flake8 ignores for already-passing tests\n\nChange-Id: I5fb349b2f7808a3f97d95fc7db6b5cf5842a9f7c\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/91d82aff25d1c7887046db81a91aed263d15ab20"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/91d82aff25d1c7887046db81a91aed263d15ab20"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}