)]}'
{"id":"openstack%2Fpython-swiftclient~220697","triplet_id":"openstack%2Fpython-swiftclient~master~I8c02bfb4a0ef059e781be5e08fcde13fb1be5b88","project":"openstack/python-swiftclient","branch":"master","topic":"http_status_none","hashtags":[],"change_id":"I8c02bfb4a0ef059e781be5e08fcde13fb1be5b88","subject":"make ClientException.http_status default to None rather than 0","status":"MERGED","created":"2015-09-04 23:25:15.000000000","updated":"2015-09-10 21:47:47.000000000","submitted":"2015-09-10 21:47:43.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"ec63bb4f77de0a11ea5f5dc57b50267c167536da","_number":220697,"virtual_id_number":220697,"owner":{"_account_id":9878,"name":"Zack M. Davis","email":"zdavis@swiftstack.com","username":"zackmdavis"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2015-09-10 21:47:43.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"date":"2015-09-10 16:49:47.000000000","_account_id":9878,"name":"Zack M. Davis","email":"zdavis@swiftstack.com","username":"zackmdavis"},{"value":0,"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},{"value":0,"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":9878,"name":"Zack M. Davis","email":"zdavis@swiftstack.com","username":"zackmdavis"},{"value":2,"date":"2015-09-10 10:37:43.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},{"value":2,"date":"2015-09-08 17:57:48.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":9878,"name":"Zack M. Davis","email":"zdavis@swiftstack.com","username":"zackmdavis"},{"value":1,"date":"2015-09-10 10:37:43.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},{"value":0,"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},{"_account_id":9878,"name":"Zack M. Davis","email":"zdavis@swiftstack.com","username":"zackmdavis"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-09-08 17:57:48.000000000","updated_by":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"reviewer":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"state":"REVIEWER"},{"updated":"2015-09-10 10:37:43.000000000","updated_by":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"reviewer":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"state":"REVIEWER"},{"updated":"2015-09-10 21:47:43.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"9ebd5c70e75f1ab2451438f26c972aa20af91909","author":{"_account_id":9878,"name":"Zack M. Davis","email":"zdavis@swiftstack.com","username":"zackmdavis"},"date":"2015-09-04 23:25:15.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"1d2703e7b5e1b5d7499e188f0b5a7f966caea489","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-09-05 00:31:39.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-swiftclient-python26 http://logs.openstack.org/97/220697/1/check/gate-python-swiftclient-python26/bfb3225/ : SUCCESS in 49s\n- gate-python-swiftclient-pep8 http://logs.openstack.org/97/220697/1/check/gate-python-swiftclient-pep8/b25f70d/ : SUCCESS in 45s\n- gate-python-swiftclient-docs http://docs-draft.openstack.org/97/220697/1/check/gate-python-swiftclient-docs/ea05c99//doc/build/html/ : SUCCESS in 1m 00s\n- gate-python-swiftclient-python27 http://logs.openstack.org/97/220697/1/check/gate-python-swiftclient-python27/41c2ff9/ : SUCCESS in 46s\n- gate-python-swiftclient-python34 http://logs.openstack.org/97/220697/1/check/gate-python-swiftclient-python34/6892b00/ : SUCCESS in 1m 57s\n- gate-python-swiftclient-pypy http://logs.openstack.org/97/220697/1/check/gate-python-swiftclient-pypy/b9cbc74/ : SUCCESS in 1m 50s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-swiftclient http://logs.openstack.org/97/220697/1/check/gate-tempest-dsvm-neutron-src-python-swiftclient/3a1cc38/ : SUCCESS in 1h 04m 36s\n- gate-swift-dsvm-functional http://logs.openstack.org/97/220697/1/check/gate-swift-dsvm-functional/2bf2ae6/ : SUCCESS in 32m 58s\n- gate-swiftclient-dsvm-functional http://logs.openstack.org/97/220697/1/check/gate-swiftclient-dsvm-functional/ae0e2d1/ : SUCCESS in 29m 56s","accounts_in_message":[],"_revision_number":1},{"id":"bf4a0ccc05d84e6b874400486591e53033da9a1d","author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"date":"2015-09-08 17:57:48.000000000","message":"Patch Set 1: Code-Review+2\n\nGreat commit message, justification is sound, nice work.\n\nA test update in tests.unit.test_swiftclient.TestHTTPConnection would probably also look very good, possibly as a follow up.","accounts_in_message":[],"_revision_number":1},{"id":"a33981bf538f2da22d965afcbebe675cc39e35a5","author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"date":"2015-09-10 10:37:43.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\nmakes sense","accounts_in_message":[],"_revision_number":1},{"id":"13cfa89a4e70b7570089c00394c671c8aa8f6b01","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-09-10 10:37:49.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"c52005cbd8effb46569d56839f26664a39013c1d","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-09-10 16:02:35.000000000","message":"Patch Set 1: Verified-2\n\nBuild failed (gate pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-swiftclient-python26 http://logs.openstack.org/97/220697/1/gate/gate-python-swiftclient-python26/9632ea5/ : FAILURE in 46s\n- gate-python-swiftclient-docs http://docs-draft.openstack.org/97/220697/1/gate/gate-python-swiftclient-docs/f43b6dd//doc/build/html/ : SUCCESS in 1m 07s\n- gate-python-swiftclient-pep8 http://logs.openstack.org/97/220697/1/gate/gate-python-swiftclient-pep8/331cc79/ : SUCCESS in 1m 06s\n- gate-python-swiftclient-python27 http://logs.openstack.org/97/220697/1/gate/gate-python-swiftclient-python27/47cc9f9/ : SUCCESS in 1m 45s\n- gate-python-swiftclient-python34 http://logs.openstack.org/97/220697/1/gate/gate-python-swiftclient-python34/de47973/ : SUCCESS in 2m 09s\n- gate-tempest-dsvm-neutron-src-python-swiftclient http://logs.openstack.org/97/220697/1/gate/gate-tempest-dsvm-neutron-src-python-swiftclient/d533064/ : SUCCESS in 1h 01m 02s\n- gate-swift-dsvm-functional http://logs.openstack.org/97/220697/1/gate/gate-swift-dsvm-functional/3fa7fef/ : SUCCESS in 25m 28s\n- gate-swiftclient-dsvm-functional http://logs.openstack.org/97/220697/1/gate/gate-swiftclient-dsvm-functional/c0ead8e/ : SUCCESS in 25m 11s","accounts_in_message":[],"_revision_number":1},{"id":"560a7808d2496383fc3f3977f67c81f93b34c210","author":{"_account_id":9878,"name":"Zack M. Davis","email":"zdavis@swiftstack.com","username":"zackmdavis"},"date":"2015-09-10 16:49:47.000000000","message":"Patch Set 1:\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"42b02127d564b567a59c7381128f9114ee5e3ea4","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-09-10 20:22:47.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-swiftclient-python26 http://logs.openstack.org/97/220697/1/check/gate-python-swiftclient-python26/b48e70b/ : SUCCESS in 1m 03s\n- gate-python-swiftclient-pep8 http://logs.openstack.org/97/220697/1/check/gate-python-swiftclient-pep8/d067def/ : SUCCESS in 54s\n- gate-python-swiftclient-docs http://docs-draft.openstack.org/97/220697/1/check/gate-python-swiftclient-docs/38062dd//doc/build/html/ : SUCCESS in 54s\n- gate-python-swiftclient-python27 http://logs.openstack.org/97/220697/1/check/gate-python-swiftclient-python27/3c66add/ : SUCCESS in 42s\n- gate-python-swiftclient-python34 http://logs.openstack.org/97/220697/1/check/gate-python-swiftclient-python34/6458c8b/ : SUCCESS in 2m 11s\n- gate-python-swiftclient-pypy http://logs.openstack.org/97/220697/1/check/gate-python-swiftclient-pypy/dedc840/ : SUCCESS in 1m 43s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-swiftclient http://logs.openstack.org/97/220697/1/check/gate-tempest-dsvm-neutron-src-python-swiftclient/86163a8/ : SUCCESS in 1h 14m 39s\n- gate-swift-dsvm-functional http://logs.openstack.org/97/220697/1/check/gate-swift-dsvm-functional/6f3b13d/ : SUCCESS in 31m 55s\n- gate-swiftclient-dsvm-functional http://logs.openstack.org/97/220697/1/check/gate-swiftclient-dsvm-functional/fe7ecb6/ : SUCCESS in 25m 42s","accounts_in_message":[],"_revision_number":1},{"id":"a2c470820ad737851c32e503167fd2b6009b25e0","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-09-10 20:22:54.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"aa9d42508b80c5bbe49ae573d6d3b9f79e926592","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-09-10 21:47:43.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-swiftclient-python26 http://logs.openstack.org/97/220697/1/gate/gate-python-swiftclient-python26/2b9497b/ : SUCCESS in 57s\n- gate-python-swiftclient-docs http://docs-draft.openstack.org/97/220697/1/gate/gate-python-swiftclient-docs/a9c3f97//doc/build/html/ : SUCCESS in 1m 03s\n- gate-python-swiftclient-pep8 http://logs.openstack.org/97/220697/1/gate/gate-python-swiftclient-pep8/2be67d2/ : SUCCESS in 37s\n- gate-python-swiftclient-python27 http://logs.openstack.org/97/220697/1/gate/gate-python-swiftclient-python27/6332362/ : SUCCESS in 58s\n- gate-python-swiftclient-python34 http://logs.openstack.org/97/220697/1/gate/gate-python-swiftclient-python34/0fec45d/ : SUCCESS in 1m 28s\n- gate-tempest-dsvm-neutron-src-python-swiftclient http://logs.openstack.org/97/220697/1/gate/gate-tempest-dsvm-neutron-src-python-swiftclient/3c4d9e8/ : SUCCESS in 58m 43s\n- gate-swift-dsvm-functional http://logs.openstack.org/97/220697/1/gate/gate-swift-dsvm-functional/6c469f2/ : SUCCESS in 28m 53s\n- gate-swiftclient-dsvm-functional http://logs.openstack.org/97/220697/1/gate/gate-swiftclient-dsvm-functional/bd004c5/ : SUCCESS in 21m 24s","accounts_in_message":[],"_revision_number":1},{"id":"4b59c6886859e2c8338d43ddf8e580649c94035d","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-09-10 21:47:47.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"5ae4b42392dfabe366531d2545629947aad76bba","revisions":{"5ae4b42392dfabe366531d2545629947aad76bba":{"kind":"REWORK","_number":1,"created":"2015-09-04 23:25:15.000000000","uploader":{"_account_id":9878,"name":"Zack M. Davis","email":"zdavis@swiftstack.com","username":"zackmdavis"},"ref":"refs/changes/97/220697/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-swiftclient","ref":"refs/changes/97/220697/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/97/220697/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/97/220697/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/97/220697/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-swiftclient refs/changes/97/220697/1"}}},"commit":{"parents":[{"commit":"93666bb84abc1edc36fbb3ef5ec194cf774e4826","subject":"Merge \"Log and report trace on service operation fails\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/93666bb84abc1edc36fbb3ef5ec194cf774e4826"}]}],"author":{"name":"Zack M. Davis","email":"zdavis@swiftstack.com","date":"2015-09-04 22:45:48.000000000","tz":-420},"committer":{"name":"Zack M. Davis","email":"zdavis@swiftstack.com","date":"2015-09-04 23:24:54.000000000","tz":-420},"subject":"make ClientException.http_status default to None rather than 0","message":"make ClientException.http_status default to None rather than 0\n\nThe extant default of zero is a bit counterintuitive;\ninsufficiently-careful programmers using swiftclient in their\napplication might, without carefully reading the source or\ndocumentation, write buggy code based on the assumption that the\n`http_status` attribute is absent or defaults to None if ClientException\nis raised for reasons other than to indicate an unsuccessful HTTP\nrequest. (However improbable this scenario may seem, the present author\ncan sadly attest to it having actually happened at least once.)\n\nJust changing the default would break some tests on Python 3, due to the\n`500 \u003c\u003d err.http_status \u003c\u003d 599` comparison in Connection\u0027s _retry\nmethod (NoneType and int are not orderable in the Python 3.x series);\nthus, the case where http_status is None is explicitly folded into a\ncode branch that logs and reraises (whereas previously it would have\nfallen through to an `else` branch where it would be logged and reraised\njust the same).\n\nWhile we\u0027re here, we might as well make ClientException\u0027s __init__ use\nsuper() (although admittedly the kinds of multiple-inheritance scenarios\nin which `super` truly shines seem unlikely to occur here).\n\nChange-Id: I8c02bfb4a0ef059e781be5e08fcde13fb1be5b88\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/5ae4b42392dfabe366531d2545629947aad76bba"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/5ae4b42392dfabe366531d2545629947aad76bba"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
