)]}'
{"id":"openstack%2Fpython-swiftclient~221219","triplet_id":"openstack%2Fpython-swiftclient~master~Ia82697c093529076b0bbcc6bccd577afdf0839e1","project":"openstack/python-swiftclient","branch":"master","topic":"p-fix-upload-delete-test","hashtags":[],"change_id":"Ia82697c093529076b0bbcc6bccd577afdf0839e1","subject":"Initialise delete_object mock before it is called","status":"MERGED","created":"2015-09-08 09:39:36.000000000","updated":"2015-09-08 14:06:22.000000000","submitted":"2015-09-08 14:06:20.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"89929a0910d6e355f02bf38e352c0a9032d2ab57","_number":221219,"virtual_id_number":221219,"owner":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":9216,"name":"Joel Wright","email":"joel.wright@gmail.com","username":"jjw-sohonet"},{"value":2,"date":"2015-09-08 14:06:20.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"date":"2015-09-08 09:42:35.000000000","_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},{"value":0,"_account_id":6968,"name":"Christian Schwede","email":"cschwede@nvidia.com","username":"cschwede"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":9216,"name":"Joel Wright","email":"joel.wright@gmail.com","username":"jjw-sohonet"},"all":[{"value":2,"date":"2015-09-08 12:44:00.000000000","_account_id":9216,"name":"Joel Wright","email":"joel.wright@gmail.com","username":"jjw-sohonet"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},{"value":2,"date":"2015-09-08 11:53:43.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":6968,"name":"Christian Schwede","email":"cschwede@nvidia.com","username":"cschwede"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":9216,"name":"Joel Wright","email":"joel.wright@gmail.com","username":"jjw-sohonet"},"all":[{"value":1,"date":"2015-09-08 12:44:00.000000000","_account_id":9216,"name":"Joel Wright","email":"joel.wright@gmail.com","username":"jjw-sohonet"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},{"value":0,"_account_id":6968,"name":"Christian Schwede","email":"cschwede@nvidia.com","username":"cschwede"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":6968,"name":"Christian Schwede","email":"cschwede@nvidia.com","username":"cschwede"},{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},{"_account_id":9216,"name":"Joel Wright","email":"joel.wright@gmail.com","username":"jjw-sohonet"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-09-08 11:53:43.000000000","updated_by":{"_account_id":6968,"name":"Christian Schwede","email":"cschwede@nvidia.com","username":"cschwede"},"reviewer":{"_account_id":6968,"name":"Christian Schwede","email":"cschwede@nvidia.com","username":"cschwede"},"state":"REVIEWER"},{"updated":"2015-09-08 12:44:00.000000000","updated_by":{"_account_id":9216,"name":"Joel Wright","email":"joel.wright@gmail.com","username":"jjw-sohonet"},"reviewer":{"_account_id":9216,"name":"Joel Wright","email":"joel.wright@gmail.com","username":"jjw-sohonet"},"state":"REVIEWER"},{"updated":"2015-09-08 14:06:20.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"655cad18a955b68c4b65937be413802564a48d82","author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"date":"2015-09-08 09:39:36.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"9dfafa52e934cb98a59d989f4a1b29954dbc6d1b","author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"date":"2015-09-08 09:42:35.000000000","message":"Patch Set 1:\n\nI\u0027ve only tagged this with Partial-Bug because I can\u0027t be sure it *closes* the bug. I have never managed to reproduce the test failure OMM.","accounts_in_message":[],"_revision_number":1},{"id":"fe66f5ccca57c8485c81d595c02c58c8e6f829d1","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-09-08 10:41:23.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-swiftclient-python26 http://logs.openstack.org/19/221219/1/check/gate-python-swiftclient-python26/9002739/ : SUCCESS in 1m 14s\n- gate-python-swiftclient-pep8 http://logs.openstack.org/19/221219/1/check/gate-python-swiftclient-pep8/207c28e/ : SUCCESS in 54s\n- gate-python-swiftclient-docs http://docs-draft.openstack.org/19/221219/1/check/gate-python-swiftclient-docs/416f871//doc/build/html/ : SUCCESS in 49s\n- gate-python-swiftclient-python27 http://logs.openstack.org/19/221219/1/check/gate-python-swiftclient-python27/e635c12/ : SUCCESS in 49s\n- gate-python-swiftclient-python34 http://logs.openstack.org/19/221219/1/check/gate-python-swiftclient-python34/81baea1/ : SUCCESS in 3m 03s\n- gate-python-swiftclient-pypy http://logs.openstack.org/19/221219/1/check/gate-python-swiftclient-pypy/f33cb00/ : SUCCESS in 1m 19s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-swiftclient http://logs.openstack.org/19/221219/1/check/gate-tempest-dsvm-neutron-src-python-swiftclient/5e928f7/ : SUCCESS in 1h 01m 33s\n- gate-swift-dsvm-functional http://logs.openstack.org/19/221219/1/check/gate-swift-dsvm-functional/4ce4134/ : SUCCESS in 33m 57s\n- gate-swiftclient-dsvm-functional http://logs.openstack.org/19/221219/1/check/gate-swiftclient-dsvm-functional/7da0c00/ : SUCCESS in 26m 30s","accounts_in_message":[],"_revision_number":1},{"id":"7d34f663e87c2dd25a40181f46ccf434d7ffa307","author":{"_account_id":6968,"name":"Christian Schwede","email":"cschwede@nvidia.com","username":"cschwede"},"date":"2015-09-08 11:53:43.000000000","message":"Patch Set 1: Code-Review+2\n\nDifficult to debug, but the code change \u0026 explanation makes sense to me, it does IMO no harm to add some initalizing, thus adding my +2.","accounts_in_message":[],"_revision_number":1},{"id":"1089d791e6e5a7e7a3d6c3da8639b1946be233ec","author":{"_account_id":9216,"name":"Joel Wright","email":"joel.wright@gmail.com","username":"jjw-sohonet"},"date":"2015-09-08 12:44:00.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\nI have been unsuccessfully trying to recreate the original issue, but there is anecdotal evidence that mock can have issues with threaded applications. This patch clearly does no harm, so +2 from me.","accounts_in_message":[],"_revision_number":1},{"id":"f51fa5653d5a4bb579a277603b53d02c714621f4","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-09-08 12:44:06.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"32859620af52730aae62120999e33e6c87b5c414","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-09-08 14:06:20.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-swiftclient-python26 http://logs.openstack.org/19/221219/1/gate/gate-python-swiftclient-python26/99634f2/ : SUCCESS in 1m 16s\n- gate-python-swiftclient-docs http://docs-draft.openstack.org/19/221219/1/gate/gate-python-swiftclient-docs/f202731//doc/build/html/ : SUCCESS in 2m 07s\n- gate-python-swiftclient-pep8 http://logs.openstack.org/19/221219/1/gate/gate-python-swiftclient-pep8/fce20e4/ : SUCCESS in 48s\n- gate-python-swiftclient-python27 http://logs.openstack.org/19/221219/1/gate/gate-python-swiftclient-python27/c3ce91c/ : SUCCESS in 59s\n- gate-python-swiftclient-python34 http://logs.openstack.org/19/221219/1/gate/gate-python-swiftclient-python34/4d3902e/ : SUCCESS in 4m 55s\n- gate-tempest-dsvm-neutron-src-python-swiftclient http://logs.openstack.org/19/221219/1/gate/gate-tempest-dsvm-neutron-src-python-swiftclient/913bce6/ : SUCCESS in 52m 51s\n- gate-swift-dsvm-functional http://logs.openstack.org/19/221219/1/gate/gate-swift-dsvm-functional/1b469b8/ : SUCCESS in 35m 05s\n- gate-swiftclient-dsvm-functional http://logs.openstack.org/19/221219/1/gate/gate-swiftclient-dsvm-functional/052d8af/ : SUCCESS in 31m 16s","accounts_in_message":[],"_revision_number":1},{"id":"a50b1f2cf32d989c61686ed0a79846c6b6889f23","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-09-08 14:06:22.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"1841bd6010e91859a4fe97afa4da980b8daa1e03","revisions":{"1841bd6010e91859a4fe97afa4da980b8daa1e03":{"kind":"REWORK","_number":1,"created":"2015-09-08 09:39:36.000000000","uploader":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"ref":"refs/changes/19/221219/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-swiftclient","ref":"refs/changes/19/221219/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/19/221219/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/19/221219/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/19/221219/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-swiftclient refs/changes/19/221219/1"}}},"commit":{"parents":[{"commit":"7cd2a01cda4ac592dee465d4acf8a0b246354328","subject":"updated changelog for 2.6.0 release","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/7cd2a01cda4ac592dee465d4acf8a0b246354328"}]}],"author":{"name":"Alistair Coles","email":"alistair.coles@hp.com","date":"2015-09-08 09:22:32.000000000","tz":60},"committer":{"name":"Alistair Coles","email":"alistair.coles@hp.com","date":"2015-09-08 09:22:32.000000000","tz":60},"subject":"Initialise delete_object mock before it is called","message":"Initialise delete_object mock before it is called\n\nAttempt to fix the linked bug by initialising the mock instance for\nConnection.delete_object before calling the SwiftService upload\nmethod, so that the delete_object mock already exists before the\ndelete_segments jobs that run in multiple threads call it.  Otherwise\nthere is a risk that the delete_segment job threads could race while\ncreating either the delete_object mock or the\ndelete_object.return_value mock, resulting in each thread getting a\ndifferent instance. That would explain the intermittent test failures\nreported in the bug.\n\nChange-Id: Ia82697c093529076b0bbcc6bccd577afdf0839e1\nPartial-Bug: #1480223\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/1841bd6010e91859a4fe97afa4da980b8daa1e03"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/1841bd6010e91859a4fe97afa4da980b8daa1e03"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}