)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"7de7b0fe7ae33e03420081a7831024c794e97ed5","unresolved":false,"context_lines":[{"line_number":22,"context_line":" * Use setUp for setup, not __init__"},{"line_number":23,"context_line":" * Replace assertIn(key, dict) and assertEqual(foo, dict[key]) with"},{"line_number":24,"context_line":"   assertEqual(foo, dict.get(key)) when key is a literal and foo is not"},{"line_number":25,"context_line":"   None"},{"line_number":26,"context_line":" * Use mock.patch.object instead of manually patching for tests"},{"line_number":27,"context_line":" * Use six.binary_type instead of type(\u0027\u0027.encode(\u0027utf-8\u0027))"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7a2fa921_77cca335","line":25,"updated":"2015-10-06 11:23:47.000000000","message":"nit: Removing some of these assertions could be a little over-zealous: It can be useful to have the separate assertion that the header exists before asserting the header\u0027s value. If this assertion fails with \u0027stoken\u0027 !\u003d None it it will require more digging to determine if the header was not in the dict, or was there but had value None.","commit_id":"c9340ebea43b360e3a108f2dab2ecebe374d046a"}],"swiftclient/client.py":[{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"7de7b0fe7ae33e03420081a7831024c794e97ed5","unresolved":false,"context_lines":[{"line_number":44,"context_line":"                           (\u0027container\u0027, \u0027account\u0027, \u0027object\u0027))"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"try:"},{"line_number":47,"context_line":"    from logging.handlers import NullHandler"},{"line_number":48,"context_line":"except ImportError:"},{"line_number":49,"context_line":"    # Added in Python 2.7"},{"line_number":50,"context_line":"    class NullHandler(logging.Handler):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a2fa921_e15eb144","line":47,"updated":"2015-10-06 11:23:47.000000000","message":"in py27 NullHandler is in logging not logging.handlers","commit_id":"c9340ebea43b360e3a108f2dab2ecebe374d046a"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"ac68d03d58e21c2a23470819b05fc716f46ef102","unresolved":false,"context_lines":[{"line_number":44,"context_line":"                           (\u0027container\u0027, \u0027account\u0027, \u0027object\u0027))"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"try:"},{"line_number":47,"context_line":"    from logging.handlers import NullHandler"},{"line_number":48,"context_line":"except ImportError:"},{"line_number":49,"context_line":"    # Added in Python 2.7"},{"line_number":50,"context_line":"    class NullHandler(logging.Handler):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a2fa921_8549f78d","line":47,"in_reply_to":"7a2fa921_e15eb144","updated":"2015-10-06 16:59:31.000000000","message":"...yet *nowhere* mentioned in https://docs.python.org/2/library/logging.html, and *actually* documented in https://docs.python.org/2/library/logging.handlers.html :(\n\nWill fix.","commit_id":"c9340ebea43b360e3a108f2dab2ecebe374d046a"}],"tests/unit/test_multithreading.py":[{"author":{"_account_id":9878,"name":"Zack M. Davis","email":"zdavis@swiftstack.com","username":"zackmdavis"},"change_message_id":"8c0b80a2968efcf8f0609457ad3fb79f95d430d9","unresolved":false,"context_lines":[{"line_number":88,"context_line":"            except Exception as e:"},{"line_number":89,"context_line":"                self.assertEqual(\u0027I went boom!\u0027, str(e))"},{"line_number":90,"context_line":"            else:"},{"line_number":91,"context_line":"                self.fail(\u0027I never went boom!\u0027)"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"            # Has the connection been returned to the pool?"},{"line_number":94,"context_line":"            f \u003d pool.submit(self._func, \"succeed\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_6c36c304","line":91,"updated":"2015-09-10 22:18:10.000000000","message":"While this message is certainly not less informative than what it replaces (\"AssertionError: False is not true\"), I think we could do better. (\"Expected an exception to be raised\"? \"Job did not fail\"?)","commit_id":"c9340ebea43b360e3a108f2dab2ecebe374d046a"}],"tests/unit/test_service.py":[{"author":{"_account_id":9878,"name":"Zack M. Davis","email":"zdavis@swiftstack.com","username":"zackmdavis"},"change_message_id":"8c0b80a2968efcf8f0609457ad3fb79f95d430d9","unresolved":false,"context_lines":[{"line_number":83,"context_line":"        self.assertEqual(sr._expected_etag, None)"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"        self.assertNotEqual(sr._actual_md5, None)"},{"line_number":86,"context_line":"        self.assertIs(type(sr._actual_md5), self.md5_type)"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    def test_create_with_large_object_headers(self):"},{"line_number":89,"context_line":"        # md5 should not be initialized if large object headers are present"}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_0f537917","line":86,"updated":"2015-09-10 22:18:10.000000000","message":"I was going to say, \"Should we use `assertIsInstance` here, too?\", but then I saw the note in the unittest docs that says \"To check for the exact type, use assertIs(type(obj), cls)\", and realized that this must be what the commit message meant about \"Tighten some isinstance assertions\".","commit_id":"c9340ebea43b360e3a108f2dab2ecebe374d046a"}]}
