)]}'
{"id":"openstack%2Fpython-swiftclient~222009","triplet_id":"openstack%2Fpython-swiftclient~master~I2138ea553378ce88810b7353147c8645a8f8c90e","project":"openstack/python-swiftclient","branch":"master","topic":"cleanup","hashtags":[],"change_id":"I2138ea553378ce88810b7353147c8645a8f8c90e","subject":"Miscellaneous (mostly test) cleanup","status":"MERGED","created":"2015-09-10 01:21:43.000000000","updated":"2015-10-09 01:52:17.000000000","submitted":"2015-10-09 01:52:16.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":5,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"012125b99efc57767030002f8b82e383c43ee6c2","_number":222009,"virtual_id_number":222009,"owner":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":12193,"name":"Hisashi Osanai","email":"osanai.hisashi@jp.fujitsu.com","username":"ho"},{"value":2,"date":"2015-10-09 01:52:16.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":9878,"name":"Zack M. Davis","email":"zdavis@swiftstack.com","username":"zackmdavis"},{"value":0,"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},{"value":0,"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"value":0,"date":"2015-10-08 05:34:51.000000000","_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"recommended":{"_account_id":12193,"name":"Hisashi Osanai","email":"osanai.hisashi@jp.fujitsu.com","username":"ho"},"all":[{"value":1,"date":"2015-10-08 05:45:57.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":12193,"name":"Hisashi Osanai","email":"osanai.hisashi@jp.fujitsu.com","username":"ho"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":9878,"name":"Zack M. Davis","email":"zdavis@swiftstack.com","username":"zackmdavis"},{"value":2,"date":"2015-10-08 08:38:57.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},{"value":2,"date":"2015-10-08 23:12:12.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"value":0,"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"all":[{"value":0,"_account_id":12193,"name":"Hisashi Osanai","email":"osanai.hisashi@jp.fujitsu.com","username":"ho"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":9878,"name":"Zack M. Davis","email":"zdavis@swiftstack.com","username":"zackmdavis"},{"value":0,"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},{"value":1,"date":"2015-10-08 23:12:12.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"value":0,"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},{"_account_id":9878,"name":"Zack M. Davis","email":"zdavis@swiftstack.com","username":"zackmdavis"},{"_account_id":12193,"name":"Hisashi Osanai","email":"osanai.hisashi@jp.fujitsu.com","username":"ho"},{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-10-06 17:09:11.000000000","updated_by":{"_account_id":9878,"name":"Zack M. Davis","email":"zdavis@swiftstack.com","username":"zackmdavis"},"reviewer":{"_account_id":9878,"name":"Zack M. Davis","email":"zdavis@swiftstack.com","username":"zackmdavis"},"state":"REVIEWER"},{"updated":"2015-10-08 05:45:57.000000000","updated_by":{"_account_id":12193,"name":"Hisashi Osanai","email":"osanai.hisashi@jp.fujitsu.com","username":"ho"},"reviewer":{"_account_id":12193,"name":"Hisashi Osanai","email":"osanai.hisashi@jp.fujitsu.com","username":"ho"},"state":"REVIEWER"},{"updated":"2015-10-08 08:38:57.000000000","updated_by":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"reviewer":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"state":"REVIEWER"},{"updated":"2015-10-08 23:12:12.000000000","updated_by":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"reviewer":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"state":"REVIEWER"},{"updated":"2015-10-09 01:52:16.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"11b97d812cfab7a380db2ba3570cfda2e8cb82b0","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2015-09-10 01:21:43.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"2391131cbf6da1ae756047ed3a6357ac9515c890","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-09-10 02:30:38.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-swiftclient-python26 http://logs.openstack.org/09/222009/1/check/gate-python-swiftclient-python26/5692b48/ : SUCCESS in 50s\n- gate-python-swiftclient-pep8 http://logs.openstack.org/09/222009/1/check/gate-python-swiftclient-pep8/9bfe80d/ : SUCCESS in 51s\n- gate-python-swiftclient-docs http://docs-draft.openstack.org/09/222009/1/check/gate-python-swiftclient-docs/a970791//doc/build/html/ : SUCCESS in 55s\n- gate-python-swiftclient-python27 http://logs.openstack.org/09/222009/1/check/gate-python-swiftclient-python27/d5c7af9/ : SUCCESS in 57s\n- gate-python-swiftclient-python34 http://logs.openstack.org/09/222009/1/check/gate-python-swiftclient-python34/189f9c5/ : SUCCESS in 2m 45s\n- gate-python-swiftclient-pypy http://logs.openstack.org/09/222009/1/check/gate-python-swiftclient-pypy/34c9a95/ : SUCCESS in 2m 09s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-swiftclient http://logs.openstack.org/09/222009/1/check/gate-tempest-dsvm-neutron-src-python-swiftclient/92f92f1/ : SUCCESS in 1h 08m 39s\n- gate-swift-dsvm-functional http://logs.openstack.org/09/222009/1/check/gate-swift-dsvm-functional/c5a2bc0/ : SUCCESS in 26m 14s\n- gate-swiftclient-dsvm-functional http://logs.openstack.org/09/222009/1/check/gate-swiftclient-dsvm-functional/e89e0dd/ : SUCCESS in 20m 48s","accounts_in_message":[],"_revision_number":1},{"id":"8c0b80a2968efcf8f0609457ad3fb79f95d430d9","author":{"_account_id":9878,"name":"Zack M. Davis","email":"zdavis@swiftstack.com","username":"zackmdavis"},"date":"2015-09-10 22:18:10.000000000","message":"Patch Set 1: Code-Review+1\n\n(2 comments)\n\nAs long as we\u0027re doing a miscellaneous cleanup patch, we could also fix the shadowing of the builtin `bytes` type in utils.prt_bytes.","accounts_in_message":[],"_revision_number":1},{"id":"ca6de44198e530991651b1c81076ffad3c914414","author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"date":"2015-09-16 20:16:59.000000000","message":"Patch Set 1: Code-Review+2\n\nthis change is epic - I don\u0027t know how you make time for this stuff - can we just merge this now and get all the \"conflicting with all the other patches\" over with?","accounts_in_message":[],"_revision_number":1},{"id":"7b3db59e42d28b22915d4810322b141faac17e02","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2015-09-16 21:39:01.000000000","message":"Patch Set 1:\n\nZack, addressed the bytes issue in a follow-up patch.\n\nClay, mainly I just got tired of having crappy failure messages while re-working my bulkdelete change :)","accounts_in_message":[],"_revision_number":1},{"id":"7de7b0fe7ae33e03420081a7831024c794e97ed5","author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"date":"2015-10-06 11:23:47.000000000","message":"Patch Set 1: Code-Review-1\n\n(2 comments)\n\n-1 only because of the bad import from logging. AFAICT NullHandler is, deviously, in logging, not logging.handlers in py27 and py3.","accounts_in_message":[],"_revision_number":1},{"id":"ac68d03d58e21c2a23470819b05fc716f46ef102","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2015-10-06 16:59:31.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"81f654589c7af4e949bf779269b512c2012e3a19","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2015-10-06 17:04:58.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"4422afd57694f14330a17c3fda49fd2889a6d735","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2015-10-06 17:05:21.000000000","message":"Patch Set 2:\n\nAlso squashed in https://review.openstack.org/#/c/224319/","accounts_in_message":[],"_revision_number":2},{"id":"0f6c248258eadb4be1ba54fc60954c2639a0d2e7","author":{"_account_id":9878,"name":"Zack M. Davis","email":"zdavis@swiftstack.com","username":"zackmdavis"},"date":"2015-10-06 17:09:11.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"03c0cf3629434fb349ac78940937a14e1eb73df4","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-10-06 18:54:38.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-swiftclient-python26 http://logs.openstack.org/09/222009/2/check/gate-python-swiftclient-python26/5f1a804/ : SUCCESS in 1m 02s\n- gate-python-swiftclient-pep8 http://logs.openstack.org/09/222009/2/check/gate-python-swiftclient-pep8/e0feaab/ : SUCCESS in 1m 02s\n- gate-python-swiftclient-docs http://docs-draft.openstack.org/09/222009/2/check/gate-python-swiftclient-docs/4f278ca//doc/build/html/ : SUCCESS in 58s\n- gate-python-swiftclient-python27 http://logs.openstack.org/09/222009/2/check/gate-python-swiftclient-python27/91194b6/ : SUCCESS in 33s\n- gate-python-swiftclient-python34 http://logs.openstack.org/09/222009/2/check/gate-python-swiftclient-python34/d260d59/ : SUCCESS in 59s\n- gate-python-swiftclient-pypy http://logs.openstack.org/09/222009/2/check/gate-python-swiftclient-pypy/aeac5d5/ : SUCCESS in 59s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-swiftclient http://logs.openstack.org/09/222009/2/check/gate-tempest-dsvm-neutron-src-python-swiftclient/7c6f1cd/ : SUCCESS in 1h 11m 16s\n- gate-swift-dsvm-functional http://logs.openstack.org/09/222009/2/check/gate-swift-dsvm-functional/723f255/ : SUCCESS in 37m 18s\n- gate-swiftclient-dsvm-functional http://logs.openstack.org/09/222009/2/check/gate-swiftclient-dsvm-functional/a22df81/ : SUCCESS in 30m 34s","accounts_in_message":[],"_revision_number":2},{"id":"dff83ba8ed183438b9a884b7b39a26995f0fe419","author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"date":"2015-10-07 08:50:50.000000000","message":"Patch Set 2: Code-Review+2\n\n@Tim yes, that logging doc is odd!","accounts_in_message":[],"_revision_number":2},{"id":"39d0cbb8d092ebe260da8a1b9f305a30d26f4f5d","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-10-08 05:11:52.000000000","message":"Patch Set 2: Verified-1\n\nMerge Failed.\n\nThis change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.","accounts_in_message":[],"_revision_number":2},{"id":"17a313530a8c07fc76273763e7e2a4d71ba386a8","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2015-10-08 05:34:24.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"c1d64190add6589b5099f46228728e1de327dae3","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2015-10-08 05:34:51.000000000","message":"Patch Set 3:\n\nRebased to resolve merge conflict.","accounts_in_message":[],"_revision_number":3},{"id":"2e85769a396ef255a99a02cfbb15a835de05aee9","author":{"_account_id":12193,"name":"Hisashi Osanai","email":"osanai.hisashi@jp.fujitsu.com","username":"ho"},"date":"2015-10-08 05:45:57.000000000","message":"Patch Set 3: Code-Review+1\n\nI like it!","accounts_in_message":[],"_revision_number":3},{"id":"a2722be2c59ea60b1df92dc3c554a1c8d7c55af7","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-10-08 06:27:28.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-swiftclient-python26 http://logs.openstack.org/09/222009/3/check/gate-python-swiftclient-python26/d609084/ : SUCCESS in 50s\n- gate-python-swiftclient-pep8 http://logs.openstack.org/09/222009/3/check/gate-python-swiftclient-pep8/4200121/ : SUCCESS in 45s\n- gate-python-swiftclient-docs http://docs-draft.openstack.org/09/222009/3/check/gate-python-swiftclient-docs/ce9a15f//doc/build/html/ : SUCCESS in 56s\n- gate-python-swiftclient-python27 http://logs.openstack.org/09/222009/3/check/gate-python-swiftclient-python27/2595961/ : SUCCESS in 50s\n- gate-python-swiftclient-python34 http://logs.openstack.org/09/222009/3/check/gate-python-swiftclient-python34/83d9aaf/ : SUCCESS in 1m 40s\n- gate-python-swiftclient-pypy http://logs.openstack.org/09/222009/3/check/gate-python-swiftclient-pypy/5aa3da6/ : SUCCESS in 1m 38s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-swiftclient http://logs.openstack.org/09/222009/3/check/gate-tempest-dsvm-neutron-src-python-swiftclient/f31369c/ : SUCCESS in 52m 51s\n- gate-swift-dsvm-functional http://logs.openstack.org/09/222009/3/check/gate-swift-dsvm-functional/481a88a/ : SUCCESS in 28m 31s\n- gate-swiftclient-dsvm-functional http://logs.openstack.org/09/222009/3/check/gate-swiftclient-dsvm-functional/5f23aa9/ : SUCCESS in 21m 32s","accounts_in_message":[],"_revision_number":3},{"id":"d1004f675618d17fb43d07b34ada8b2da70996dc","author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"date":"2015-10-08 08:38:57.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"8211ea51b967be27810ba26c57d1c2c6c498d558","author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"date":"2015-10-08 23:12:12.000000000","message":"Patch Set 3: Code-Review+2 Workflow+1\n\nyay!","accounts_in_message":[],"_revision_number":3},{"id":"05944de50c229d556b8aaa3d4f54ef72e25dc334","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-10-08 23:12:18.000000000","message":"Patch Set 3: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":3},{"id":"aa52277332574db2920078d248f1a9bc0ce24fcb","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-10-09 01:52:16.000000000","message":"Patch Set 3: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-swiftclient-python26 http://logs.openstack.org/09/222009/3/gate/gate-python-swiftclient-python26/054fc3b/ : SUCCESS in 51s\n- gate-python-swiftclient-docs http://docs-draft.openstack.org/09/222009/3/gate/gate-python-swiftclient-docs/d435270//doc/build/html/ : SUCCESS in 50s\n- gate-python-swiftclient-pep8 http://logs.openstack.org/09/222009/3/gate/gate-python-swiftclient-pep8/a4580b5/ : SUCCESS in 44s\n- gate-python-swiftclient-python27 http://logs.openstack.org/09/222009/3/gate/gate-python-swiftclient-python27/70fa887/ : SUCCESS in 50s\n- gate-python-swiftclient-python34 http://logs.openstack.org/09/222009/3/gate/gate-python-swiftclient-python34/4439e33/ : SUCCESS in 1m 51s\n- gate-tempest-dsvm-neutron-src-python-swiftclient http://logs.openstack.org/09/222009/3/gate/gate-tempest-dsvm-neutron-src-python-swiftclient/52827c3/ : SUCCESS in 1h 04m 45s\n- gate-swift-dsvm-functional http://logs.openstack.org/09/222009/3/gate/gate-swift-dsvm-functional/7cee233/ : SUCCESS in 33m 41s\n- gate-swiftclient-dsvm-functional http://logs.openstack.org/09/222009/3/gate/gate-swiftclient-dsvm-functional/2588294/ : SUCCESS in 31m 12s","accounts_in_message":[],"_revision_number":3},{"id":"be13b01f9d36a245306ce770c38eafc5447e30d1","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-10-09 01:52:17.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"9fed7ed5e1f6dd3e589a35e3ee4abecb676f2188","revisions":{"c9340ebea43b360e3a108f2dab2ecebe374d046a":{"kind":"REWORK","_number":1,"created":"2015-09-10 01:21:43.000000000","uploader":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"ref":"refs/changes/09/222009/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-swiftclient","ref":"refs/changes/09/222009/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/09/222009/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/09/222009/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/09/222009/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-swiftclient refs/changes/09/222009/1"}}},"commit":{"parents":[{"commit":"a2c84e0c937c49557f905b018eddac9ba82ea2dd","subject":"Add links for release notes tool","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/a2c84e0c937c49557f905b018eddac9ba82ea2dd"}]}],"author":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2015-09-10 00:41:21.000000000","tz":-420},"committer":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2015-09-10 01:20:46.000000000","tz":-420},"subject":"Miscellaneous (mostly test) cleanup","message":"Miscellaneous (mostly test) cleanup\n\n * Always use testtools.TestCase, since we\u0027re relying on testtools\n * Always use mock (as opposed to unittest.mock) since we\u0027re relying on\n   mock\n * Add note about when a missing logging handler was added\n * Stop %-formatting the giant usage string that doesn\u0027t actually need\n   any formatting\n * Prefer assertIs, assertIn, assertIsInstance over assertTrue\n * Use else-self.fail instead of sentinel values\n * Check resp.get(\u0027error\u0027) is None before checking resp[\u0027success\u0027] is\n   True, so test failures actually tell you something useful\n * Tighten some isinstance assertions\n * Import MockHttpTest from correct location\n * Only populate clean_os_environ once\n * Use setUp for setup, not __init__\n * Replace assertIn(key, dict) and assertEqual(foo, dict[key]) with\n   assertEqual(foo, dict.get(key)) when key is a literal and foo is not\n   None\n * Use mock.patch.object instead of manually patching for tests\n * Use six.binary_type instead of type(\u0027\u0027.encode(\u0027utf-8\u0027))\n\nChange-Id: I2138ea553378ce88810b7353147c8645a8f8c90e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/c9340ebea43b360e3a108f2dab2ecebe374d046a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/c9340ebea43b360e3a108f2dab2ecebe374d046a"}]},"branch":"refs/heads/master"},"bbdee8dc9e6867bd593c741094949c63c7838277":{"kind":"REWORK","_number":2,"created":"2015-10-06 17:04:58.000000000","uploader":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"ref":"refs/changes/09/222009/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-swiftclient","ref":"refs/changes/09/222009/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/09/222009/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/09/222009/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/09/222009/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-swiftclient refs/changes/09/222009/2"}}},"commit":{"parents":[{"commit":"a2c84e0c937c49557f905b018eddac9ba82ea2dd","subject":"Add links for release notes tool","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/a2c84e0c937c49557f905b018eddac9ba82ea2dd"}]}],"author":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2015-09-10 00:41:21.000000000","tz":-420},"committer":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2015-10-06 17:03:29.000000000","tz":-420},"subject":"Miscellaneous (mostly test) cleanup","message":"Miscellaneous (mostly test) cleanup\n\n * Always use testtools.TestCase, since we\u0027re relying on testtools\n * Always use mock (as opposed to unittest.mock) since we\u0027re relying on\n   mock\n * Add note about when a missing logging handler was added\n * Stop %-formatting the giant usage string that doesn\u0027t actually need\n   any formatting\n * Prefer assertIs, assertIn, assertIsInstance over assertTrue\n * Use else-self.fail instead of sentinel values\n * Check resp.get(\u0027error\u0027) is None before checking resp[\u0027success\u0027] is\n   True, so test failures actually tell you something useful\n * Tighten some isinstance assertions\n * Import MockHttpTest from correct location\n * Only populate clean_os_environ once\n * Use setUp for setup, not __init__\n * Replace assertIn(key, dict) and assertEqual(foo, dict[key]) with\n   assertEqual(foo, dict.get(key)) when key is a literal and foo is not\n   None\n * Use mock.patch.object instead of manually patching for tests\n * Use six.binary_type instead of type(\u0027\u0027.encode(\u0027utf-8\u0027))\n * Stop shadowing builtin bytes\n * Reclaim some margin\n * Stop checking the return-type of encode_utf8; we already know it\u0027s\n   bytes\n\nChange-Id: I2138ea553378ce88810b7353147c8645a8f8c90e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/bbdee8dc9e6867bd593c741094949c63c7838277"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/bbdee8dc9e6867bd593c741094949c63c7838277"}]},"branch":"refs/heads/master"},"9fed7ed5e1f6dd3e589a35e3ee4abecb676f2188":{"kind":"REWORK","_number":3,"created":"2015-10-08 05:34:24.000000000","uploader":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"ref":"refs/changes/09/222009/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-swiftclient","ref":"refs/changes/09/222009/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/09/222009/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/09/222009/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/09/222009/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-swiftclient refs/changes/09/222009/3"}}},"commit":{"parents":[{"commit":"43b2c6bfe5140f32a37638985bd4cb7b73988160","subject":"Make more assertions in client unit tests","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/43b2c6bfe5140f32a37638985bd4cb7b73988160"}]}],"author":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2015-09-10 00:41:21.000000000","tz":-420},"committer":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2015-10-08 05:33:42.000000000","tz":-420},"subject":"Miscellaneous (mostly test) cleanup","message":"Miscellaneous (mostly test) cleanup\n\n * Always use testtools.TestCase, since we\u0027re relying on testtools\n * Always use mock (as opposed to unittest.mock) since we\u0027re relying on\n   mock\n * Add note about when a missing logging handler was added\n * Stop %-formatting the giant usage string that doesn\u0027t actually need\n   any formatting\n * Prefer assertIs, assertIn, assertIsInstance over assertTrue\n * Use else-self.fail instead of sentinel values\n * Check resp.get(\u0027error\u0027) is None before checking resp[\u0027success\u0027] is\n   True, so test failures actually tell you something useful\n * Tighten some isinstance assertions\n * Import MockHttpTest from correct location\n * Only populate clean_os_environ once\n * Use setUp for setup, not __init__\n * Replace assertIn(key, dict) and assertEqual(foo, dict[key]) with\n   assertEqual(foo, dict.get(key)) when key is a literal and foo is not\n   None\n * Use mock.patch.object instead of manually patching for tests\n * Use six.binary_type instead of type(\u0027\u0027.encode(\u0027utf-8\u0027))\n * Stop shadowing builtin bytes\n * Reclaim some margin\n * Stop checking the return-type of encode_utf8; we already know it\u0027s\n   bytes\n\nChange-Id: I2138ea553378ce88810b7353147c8645a8f8c90e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/9fed7ed5e1f6dd3e589a35e3ee4abecb676f2188"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/9fed7ed5e1f6dd3e589a35e3ee4abecb676f2188"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
