)]}'
{"swiftclient/client.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"cc744172bc332a5d54a810ebf7f985f69f248da3","unresolved":false,"context_lines":[{"line_number":975,"context_line":"    :param name: object name to get info for"},{"line_number":976,"context_line":"    :param http_conn: HTTP connection object (If None, it will create the"},{"line_number":977,"context_line":"                      conn object)"},{"line_number":978,"context_line":"    :param headers: additional headers to include in the request"},{"line_number":979,"context_line":"    :param service_token: service auth token"},{"line_number":980,"context_line":"    :returns: a dict containing the response\u0027s headers (all header names will"},{"line_number":981,"context_line":"              be lowercase)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_dc4b1658","line":978,"updated":"2015-09-22 16:18:36.000000000","message":"Consider swapping with service_token, to match parameter order.","commit_id":"d0f425ac73ee1bc81b265ebcc2ff04696a192535"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"0043339811403b0e8cab68440395711968359538","unresolved":false,"context_lines":[{"line_number":975,"context_line":"    :param name: object name to get info for"},{"line_number":976,"context_line":"    :param http_conn: HTTP connection object (If None, it will create the"},{"line_number":977,"context_line":"                      conn object)"},{"line_number":978,"context_line":"    :param headers: additional headers to include in the request"},{"line_number":979,"context_line":"    :param service_token: service auth token"},{"line_number":980,"context_line":"    :returns: a dict containing the response\u0027s headers (all header names will"},{"line_number":981,"context_line":"              be lowercase)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_7220f19b","line":978,"in_reply_to":"ba15a1d1_dc4b1658","updated":"2015-09-22 16:57:26.000000000","message":"Absolutely! Will fix.","commit_id":"d0f425ac73ee1bc81b265ebcc2ff04696a192535"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"cc744172bc332a5d54a810ebf7f985f69f248da3","unresolved":false,"context_lines":[{"line_number":1455,"context_line":"        \"\"\"Wrapper for :func:`post_account`\"\"\""},{"line_number":1456,"context_line":"        return self._retry(None, post_account, headers,"},{"line_number":1457,"context_line":"                           response_dict\u003dresponse_dict)"},{"line_number":1458,"context_line":""},{"line_number":1459,"context_line":"    def head_container(self, container):"},{"line_number":1460,"context_line":"        \"\"\"Wrapper for :func:`head_container`\"\"\""},{"line_number":1461,"context_line":"        return self._retry(None, head_container, container)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_bc85025a","line":1458,"updated":"2015-09-22 16:18:36.000000000","message":"Should we plumb headers through here, as was done with get_container and head_object below?","commit_id":"d0f425ac73ee1bc81b265ebcc2ff04696a192535"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"0043339811403b0e8cab68440395711968359538","unresolved":false,"context_lines":[{"line_number":1455,"context_line":"        \"\"\"Wrapper for :func:`post_account`\"\"\""},{"line_number":1456,"context_line":"        return self._retry(None, post_account, headers,"},{"line_number":1457,"context_line":"                           response_dict\u003dresponse_dict)"},{"line_number":1458,"context_line":""},{"line_number":1459,"context_line":"    def head_container(self, container):"},{"line_number":1460,"context_line":"        \"\"\"Wrapper for :func:`head_container`\"\"\""},{"line_number":1461,"context_line":"        return self._retry(None, head_container, container)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_f2f2c199","line":1458,"in_reply_to":"ba15a1d1_bc85025a","updated":"2015-09-22 16:57:26.000000000","message":"I hesitated over whether to fix this anomaly and decided not to.\n\nThe changes in the dependent patch that this was intended to just clean up were for a specific use case that requires passing a crypto key header for object requests and container GETs but I guess there was no use case for container HEAD. \n\nIn the end I chose not to get into scope creep - delete_object likewise could pass through headers, and there are module functions that could be made to accept headers.","commit_id":"d0f425ac73ee1bc81b265ebcc2ff04696a192535"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"0043339811403b0e8cab68440395711968359538","unresolved":false,"context_lines":[{"line_number":1487,"context_line":"        return self._retry(None, delete_container, container,"},{"line_number":1488,"context_line":"                           response_dict\u003dresponse_dict)"},{"line_number":1489,"context_line":""},{"line_number":1490,"context_line":"    def head_object(self, container, obj, headers\u003dNone):"},{"line_number":1491,"context_line":"        \"\"\"Wrapper for :func:`head_object`\"\"\""},{"line_number":1492,"context_line":"        return self._retry(None, head_object, container, obj, headers\u003dheaders)"},{"line_number":1493,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_ad04ee7d","line":1490,"updated":"2015-09-22 16:57:26.000000000","message":"OK so I see now that here I did in fact allow some scope creep :/ In my defence that\u0027s because I think the crypto use case would need to pass a header for object HEADs.\n\nI\u0027m thinking that either I revert this change and make this patch simply doc and tests fixups for existing behavior, or add headers parameter to delete_object and head_container.","commit_id":"d0f425ac73ee1bc81b265ebcc2ff04696a192535"}]}