)]}'
{"id":"openstack%2Fpython-swiftclient~226654","triplet_id":"openstack%2Fpython-swiftclient~master~Id1c48235d7d97fd1b0feec6c19ed59a87bebdf89","project":"openstack/python-swiftclient","branch":"master","topic":"cleanup","hashtags":[],"change_id":"Id1c48235d7d97fd1b0feec6c19ed59a87bebdf89","subject":"Make more assertions in client unit tests","status":"MERGED","created":"2015-09-23 08:57:11.000000000","updated":"2015-10-08 05:08:24.000000000","submitted":"2015-10-08 05:08:23.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"7f1971cac88e420217ea953c704eed49d850a02e","_number":226654,"virtual_id_number":226654,"owner":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2015-10-08 05:08:23.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":6968,"name":"Christian Schwede","email":"cschwede@nvidia.com","username":"cschwede"},{"value":0,"_account_id":16206,"name":"chenhuayi","email":"chenhuayi@huawei.com","username":"chenhuayi2"},{"value":0,"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":6968,"name":"Christian Schwede","email":"cschwede@nvidia.com","username":"cschwede"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2015-10-07 13:25:57.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":6968,"name":"Christian Schwede","email":"cschwede@nvidia.com","username":"cschwede"},{"value":1,"date":"2015-09-24 16:47:07.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":16206,"name":"chenhuayi","email":"chenhuayi@huawei.com","username":"chenhuayi2"},{"value":2,"date":"2015-10-07 21:12:47.000000000","_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":6968,"name":"Christian Schwede","email":"cschwede@nvidia.com","username":"cschwede"},{"value":0,"_account_id":16206,"name":"chenhuayi","email":"chenhuayi@huawei.com","username":"chenhuayi2"},{"value":1,"date":"2015-10-07 21:12:47.000000000","_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},{"_account_id":6968,"name":"Christian Schwede","email":"cschwede@nvidia.com","username":"cschwede"},{"_account_id":16206,"name":"chenhuayi","email":"chenhuayi@huawei.com","username":"chenhuayi2"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-09-24 16:47:07.000000000","updated_by":{"_account_id":16206,"name":"chenhuayi","email":"chenhuayi@huawei.com","username":"chenhuayi2"},"reviewer":{"_account_id":16206,"name":"chenhuayi","email":"chenhuayi@huawei.com","username":"chenhuayi2"},"state":"REVIEWER"},{"updated":"2015-10-07 13:25:57.000000000","updated_by":{"_account_id":6968,"name":"Christian Schwede","email":"cschwede@nvidia.com","username":"cschwede"},"reviewer":{"_account_id":6968,"name":"Christian Schwede","email":"cschwede@nvidia.com","username":"cschwede"},"state":"REVIEWER"},{"updated":"2015-10-07 21:12:47.000000000","updated_by":{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},"reviewer":{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},"state":"REVIEWER"},{"updated":"2015-10-08 05:08:23.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"9ebc6c3ada73b6f9ddc49c14b0844530700d203f","author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"date":"2015-09-23 08:57:11.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"b44867b49bd9b46908ad9861ee2696b1d7fae1d6","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-09-23 09:51:31.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-swiftclient-python26 http://logs.openstack.org/54/226654/1/check/gate-python-swiftclient-python26/a478a03/ : SUCCESS in 50s\n- gate-python-swiftclient-pep8 http://logs.openstack.org/54/226654/1/check/gate-python-swiftclient-pep8/af03314/ : SUCCESS in 48s\n- gate-python-swiftclient-docs http://docs-draft.openstack.org/54/226654/1/check/gate-python-swiftclient-docs/596b6a9//doc/build/html/ : SUCCESS in 54s\n- gate-python-swiftclient-python27 http://logs.openstack.org/54/226654/1/check/gate-python-swiftclient-python27/30478b0/ : SUCCESS in 1m 01s\n- gate-python-swiftclient-python34 http://logs.openstack.org/54/226654/1/check/gate-python-swiftclient-python34/1c31ed1/ : SUCCESS in 2m 15s\n- gate-python-swiftclient-pypy http://logs.openstack.org/54/226654/1/check/gate-python-swiftclient-pypy/84c7f7a/ : SUCCESS in 1m 31s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-swiftclient http://logs.openstack.org/54/226654/1/check/gate-tempest-dsvm-neutron-src-python-swiftclient/a6cac37/ : SUCCESS in 53m 30s\n- gate-swift-dsvm-functional http://logs.openstack.org/54/226654/1/check/gate-swift-dsvm-functional/54ebdcb/ : SUCCESS in 27m 04s\n- gate-swiftclient-dsvm-functional http://logs.openstack.org/54/226654/1/check/gate-swiftclient-dsvm-functional/fe5c7e0/ : SUCCESS in 19m 45s","accounts_in_message":[],"_revision_number":1},{"id":"cd648ffacfbca586fc7515981eb411f776e4d863","author":{"_account_id":16206,"name":"chenhuayi","email":"chenhuayi@huawei.com","username":"chenhuayi2"},"date":"2015-09-24 16:47:07.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"2a5bb9d20e598e2f6d14a2e352a5ffb555f73813","author":{"_account_id":6968,"name":"Christian Schwede","email":"cschwede@nvidia.com","username":"cschwede"},"date":"2015-10-07 13:25:57.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"59d84eca5282a7d345c32fd11069f75751b0aca2","author":{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},"date":"2015-10-07 21:12:47.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"45b8f66aaf2911dd3f487846e57df4364dcae7a7","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-10-07 21:12:54.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"c4b386d38c5e8b01b46950f9d9ade315fadc2c8e","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-10-08 05:08:23.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-swiftclient-python26 http://logs.openstack.org/54/226654/1/gate/gate-python-swiftclient-python26/76e07ce/ : SUCCESS in 49s\n- gate-python-swiftclient-docs http://docs-draft.openstack.org/54/226654/1/gate/gate-python-swiftclient-docs/4e64658//doc/build/html/ : SUCCESS in 48s\n- gate-python-swiftclient-pep8 http://logs.openstack.org/54/226654/1/gate/gate-python-swiftclient-pep8/62bd2fd/ : SUCCESS in 43s\n- gate-python-swiftclient-python27 http://logs.openstack.org/54/226654/1/gate/gate-python-swiftclient-python27/21e4d05/ : SUCCESS in 56s\n- gate-python-swiftclient-python34 http://logs.openstack.org/54/226654/1/gate/gate-python-swiftclient-python34/dfc59a4/ : SUCCESS in 2m 07s\n- gate-tempest-dsvm-neutron-src-python-swiftclient http://logs.openstack.org/54/226654/1/gate/gate-tempest-dsvm-neutron-src-python-swiftclient/d18c82c/ : SUCCESS in 1h 23m 29s\n- gate-swift-dsvm-functional http://logs.openstack.org/54/226654/1/gate/gate-swift-dsvm-functional/5e24209/ : SUCCESS in 32m 28s\n- gate-swiftclient-dsvm-functional http://logs.openstack.org/54/226654/1/gate/gate-swiftclient-dsvm-functional/72f580a/ : SUCCESS in 26m 25s","accounts_in_message":[],"_revision_number":1},{"id":"5a66931fc96d04c93598e371bbdf4bb6331f35a0","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-10-08 05:08:24.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"43b2c6bfe5140f32a37638985bd4cb7b73988160","revisions":{"43b2c6bfe5140f32a37638985bd4cb7b73988160":{"kind":"REWORK","_number":1,"created":"2015-09-23 08:57:11.000000000","uploader":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"ref":"refs/changes/54/226654/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-swiftclient","ref":"refs/changes/54/226654/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/54/226654/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/54/226654/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/54/226654/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-swiftclient refs/changes/54/226654/1"}}},"commit":{"parents":[{"commit":"305cd6253fc4144e3afece6f39aaaabf68ecb160","subject":"Actually make assertions when testing get_account and get_container","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/305cd6253fc4144e3afece6f39aaaabf68ecb160"}]}],"author":{"name":"Alistair Coles","email":"alistair.coles@hp.com","date":"2015-09-23 08:55:10.000000000","tz":60},"committer":{"name":"Alistair Coles","email":"alistair.coles@hp.com","date":"2015-09-23 08:55:10.000000000","tz":60},"subject":"Make more assertions in client unit tests","message":"Make more assertions in client unit tests\n\nSome tests rely on the fake connection checking expected request\nparameters, but that assumes that the fake ocnnection is even called,\nwhich is not being checked. Add more explicit assertions that requests\nare in fact made.\n\nChange-Id: Id1c48235d7d97fd1b0feec6c19ed59a87bebdf89\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/43b2c6bfe5140f32a37638985bd4cb7b73988160"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/43b2c6bfe5140f32a37638985bd4cb7b73988160"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
