)]}'
{"id":"openstack%2Fpython-swiftclient~23577","triplet_id":"openstack%2Fpython-swiftclient~master~I618ec45520ba81905ce2ead4d61f192d21ae3489","project":"openstack/python-swiftclient","branch":"master","topic":"bug/1147232","hashtags":[],"change_id":"I618ec45520ba81905ce2ead4d61f192d21ae3489","subject":"Enhance put_object to inform when chunk is ignored","status":"MERGED","created":"2013-03-05 17:05:41.000000000","updated":"2013-03-22 10:00:47.000000000","submitted":"2013-03-22 10:00:47.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"3123a77a2aa336c6884cb3efdc66a415018936c1","_number":23577,"virtual_id_number":23577,"owner":{"_account_id":5499,"name":"jola-mirecka","email":"jola.mirecka@hp.com","username":"jola-mirecka"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},{"value":2,"date":"2013-03-22 10:00:47.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":5499,"name":"jola-mirecka","email":"jola.mirecka@hp.com","username":"jola-mirecka"},{"value":0,"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"all":[{"value":2,"date":"2013-03-22 09:59:06.000000000","_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":5499,"name":"jola-mirecka","email":"jola.mirecka@hp.com","username":"jola-mirecka"},{"value":2,"date":"2013-03-21 20:37:16.000000000","_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"all":[{"value":1,"date":"2013-03-22 09:59:06.000000000","_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":5499,"name":"jola-mirecka","email":"jola.mirecka@hp.com","username":"jola-mirecka"},{"value":0,"date":"2013-03-08 22:23:02.000000000","_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},{"_account_id":5499,"name":"jola-mirecka","email":"jola.mirecka@hp.com","username":"jola-mirecka"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2013-03-08 22:23:02.000000000","updated_by":{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},"reviewer":{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},"state":"REVIEWER"},{"updated":"2013-03-22 09:59:06.000000000","updated_by":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"reviewer":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"state":"REVIEWER"},{"updated":"2013-03-22 10:00:47.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"9f722e50bfb2d5bb81aa462f50121365def96c4b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-03-05 17:12:52.000000000","message":"Patch Set 1: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/23577/1/check/gate-python-swiftclient-pep8/205 : SUCCESS\n- http://logs.openstack.org/23577/1/check/gate-python-swiftclient-docs/156 : SUCCESS\n- http://logs.openstack.org/23577/1/check/gate-python-swiftclient-python26/204 : SUCCESS\n- http://logs.openstack.org/23577/1/check/gate-python-swiftclient-python27/204 : SUCCESS\n","accounts_in_message":[],"_revision_number":1},{"id":"b7dd2254c2483ddebac639f455a8f083f0386274","author":{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},"date":"2013-03-05 22:41:03.000000000","message":"Patch Set 1: I would prefer that you didn\u0027t merge this\n\nI like the warning when I pass a non-file-like object and a chunk_size parameter, because then it\u0027s telling me what I\u0027m doing wrong.\n\nI don\u0027t like the warning when I pass a non-file-like object but I do not pass a chunk_size parameter. I should be able to pass in a string to put_object() without getting a warning.\n\nTo clarify, I want this behavior:\n\n    put_object(url, contents\u003dfilelike, chunk_size\u003d32768)    # no warnings.\n\n    put_object(url, contents\u003da_string)   # no warnings (CURRENTLY BROKEN)\n\n    put_object(url, contents\u003da_string, chunk_size\u003d32768)   # warning!\n\n\nI like the direction this change is going, but the spurious warning needs to be addressed.","accounts_in_message":[],"_revision_number":1},{"id":"39da57931095573ffa46b8db8b4ebc2331e6241f","author":{"_account_id":5499,"name":"jola-mirecka","email":"jola.mirecka@hp.com","username":"jola-mirecka"},"date":"2013-03-06 15:35:05.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"ae2bf86c14806c9069dadd03b6436434da96d14c","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-03-06 15:35:26.000000000","message":"Patch Set 2: Doesn\u0027t seem to work\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGithub#Test_Failures\n\n- http://logs.openstack.org/23577/2/check/gate-python-swiftclient-pep8/206 : FAILURE\n- gate-python-swiftclient-docs : SKIPPED\n- gate-python-swiftclient-python26 : SKIPPED\n- gate-python-swiftclient-python27 : SKIPPED\n","accounts_in_message":[],"_revision_number":2},{"id":"1430f67e4d6743410d1bac6eea2cfbb09c38a017","author":{"_account_id":5499,"name":"jola-mirecka","email":"jola.mirecka@hp.com","username":"jola-mirecka"},"date":"2013-03-06 15:38:44.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"eea976b3177fa0be19d2be5234a89a02ba5be4cf","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-03-06 15:40:55.000000000","message":"Patch Set 3: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/23577/3/check/gate-python-swiftclient-pep8/207 : SUCCESS\n- http://logs.openstack.org/23577/3/check/gate-python-swiftclient-docs/157 : SUCCESS\n- http://logs.openstack.org/23577/3/check/gate-python-swiftclient-python26/205 : SUCCESS\n- http://logs.openstack.org/23577/3/check/gate-python-swiftclient-python27/205 : SUCCESS\n","accounts_in_message":[],"_revision_number":3},{"id":"4713f53d465913cae924fe03188f711f25b4f44d","author":{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},"date":"2013-03-08 22:23:02.000000000","message":"Patch Set 3: Looks good to me, but someone else must approve\n\nLooks good. I haven\u0027t had a chance to try it out yet, though, hence the +1 instead of +2. I\u0027ll update once I find time to try it.","accounts_in_message":[],"_revision_number":3},{"id":"cf646a3163a94a3acc93c140b6c3168fc20b4a4d","author":{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},"date":"2013-03-21 20:37:16.000000000","message":"Patch Set 3: Looks good to me (core reviewer)\n\nTried it; works for me.","accounts_in_message":[],"_revision_number":3},{"id":"276bb43db0317d731f6f693d082e0dc4306548dd","author":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"date":"2013-03-22 09:59:06.000000000","message":"Patch Set 3: Looks good to me (core reviewer); Approved\n\n","accounts_in_message":[],"_revision_number":3},{"id":"033da11074bc2d5f8dfcf9c8f289b9db40820bc2","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-03-22 09:59:07.000000000","message":"Patch Set 3: No score\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":3},{"id":"e4c3d6c2ae8815108fddba30965ae1ca752c0323","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-03-22 10:00:47.000000000","message":"Patch Set 3: Verified\n\nBuild succeeded.\n\n- http://logs.openstack.org/23577/3/gate/gate-python-swiftclient-docs/167 : SUCCESS\n- http://logs.openstack.org/23577/3/gate/gate-python-swiftclient-pep8/217 : SUCCESS\n- http://logs.openstack.org/23577/3/gate/gate-python-swiftclient-python26/215 : SUCCESS\n- http://logs.openstack.org/23577/3/gate/gate-python-swiftclient-python27/215 : SUCCESS\n","accounts_in_message":[],"_revision_number":3},{"id":"63c6758a3c58bbb7d16728010350cdad3bf9ee4d","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-03-22 10:00:47.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"d90b768e509e41a2ab4f8d26b1093fd329167102","revisions":{"a53dc49453dbbc5df44ba9e3527807dad3dfd1f9":{"kind":"REWORK","_number":1,"created":"2013-03-05 17:05:41.000000000","uploader":{"_account_id":5499,"name":"jola-mirecka","email":"jola.mirecka@hp.com","username":"jola-mirecka"},"ref":"refs/changes/77/23577/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-swiftclient","ref":"refs/changes/77/23577/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/77/23577/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/77/23577/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/77/23577/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-swiftclient refs/changes/77/23577/1"}}},"commit":{"parents":[{"commit":"999e1c0f02ab4f697a0bf66c95f1744c86dc4523","subject":"Merge \"Added \"/\" check when list containers.\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/999e1c0f02ab4f697a0bf66c95f1744c86dc4523"}]}],"author":{"name":"jola-mirecka","email":"jola.mirecka@hp.com","date":"2013-03-05 16:56:02.000000000","tz":0},"committer":{"name":"jola-mirecka","email":"jola.mirecka@hp.com","date":"2013-03-05 17:04:00.000000000","tz":0},"subject":"Enhance put_object to inform when chunk is ignored","message":"Enhance put_object to inform when chunk is ignored\n\nChanged documentation for chunk_size parameter to indicate\nthat it can be used only with file like objects.\n\nAlso added a UserWarning when using a string contents to inform\nthat chunk_size will be ignored.\n\nAdded a unit test to check whether the warning is working\ncorrectly.\n\nFixes: bug #1147232\nChange-Id: I618ec45520ba81905ce2ead4d61f192d21ae3489\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/a53dc49453dbbc5df44ba9e3527807dad3dfd1f9"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/a53dc49453dbbc5df44ba9e3527807dad3dfd1f9"}]},"branch":"refs/heads/master"},"6fef2fc3aae88c6dc0b3439d6958b9aa1b4c4112":{"kind":"REWORK","_number":2,"created":"2013-03-06 15:35:05.000000000","uploader":{"_account_id":5499,"name":"jola-mirecka","email":"jola.mirecka@hp.com","username":"jola-mirecka"},"ref":"refs/changes/77/23577/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-swiftclient","ref":"refs/changes/77/23577/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/77/23577/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/77/23577/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/77/23577/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-swiftclient refs/changes/77/23577/2"}}},"commit":{"parents":[{"commit":"999e1c0f02ab4f697a0bf66c95f1744c86dc4523","subject":"Merge \"Added \"/\" check when list containers.\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/999e1c0f02ab4f697a0bf66c95f1744c86dc4523"}]}],"author":{"name":"jola-mirecka","email":"jola.mirecka@hp.com","date":"2013-03-05 16:56:02.000000000","tz":0},"committer":{"name":"jola-mirecka","email":"jola.mirecka@hp.com","date":"2013-03-06 15:35:08.000000000","tz":0},"subject":"Enhance put_object to inform when chunk is ignored","message":"Enhance put_object to inform when chunk is ignored\n\nChanged documentation for chunk_size parameter to indicate\nthat it can be used only with file like objects.\n\nAlso added a UserWarning when using a string contents to inform\nthat chunk_size will be ignored.\n\nAdded a unit test to check whether the warning is working\ncorrectly.\n\nFixes: bug #1147232\nChange-Id: I618ec45520ba81905ce2ead4d61f192d21ae3489\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/6fef2fc3aae88c6dc0b3439d6958b9aa1b4c4112"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/6fef2fc3aae88c6dc0b3439d6958b9aa1b4c4112"}]},"branch":"refs/heads/master"},"d90b768e509e41a2ab4f8d26b1093fd329167102":{"kind":"REWORK","_number":3,"created":"2013-03-06 15:38:44.000000000","uploader":{"_account_id":5499,"name":"jola-mirecka","email":"jola.mirecka@hp.com","username":"jola-mirecka"},"ref":"refs/changes/77/23577/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-swiftclient","ref":"refs/changes/77/23577/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/77/23577/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/77/23577/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/77/23577/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-swiftclient refs/changes/77/23577/3"}}},"commit":{"parents":[{"commit":"999e1c0f02ab4f697a0bf66c95f1744c86dc4523","subject":"Merge \"Added \"/\" check when list containers.\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/999e1c0f02ab4f697a0bf66c95f1744c86dc4523"}]}],"author":{"name":"jola-mirecka","email":"jola.mirecka@hp.com","date":"2013-03-05 16:56:02.000000000","tz":0},"committer":{"name":"jola-mirecka","email":"jola.mirecka@hp.com","date":"2013-03-06 15:38:50.000000000","tz":0},"subject":"Enhance put_object to inform when chunk is ignored","message":"Enhance put_object to inform when chunk is ignored\n\nChanged documentation for chunk_size parameter to indicate\nthat it can be used only with file like objects.\n\nAlso added a UserWarning when using a string contents to inform\nthat chunk_size will be ignored.\n\nAdded a unit test to check whether the warning is working\ncorrectly.\n\nFixes: bug #1147232\nChange-Id: I618ec45520ba81905ce2ead4d61f192d21ae3489\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/d90b768e509e41a2ab4f8d26b1093fd329167102"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/d90b768e509e41a2ab4f8d26b1093fd329167102"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
