)]}'
{"swiftclient/client.py":[{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"5c4dda5248948c7ef2b462aca6b76bbc6c091a2a","unresolved":false,"context_lines":[{"line_number":420,"context_line":"    endpoint_type \u003d os_options.get(\u0027endpoint_type\u0027) or \u0027publicURL\u0027"},{"line_number":421,"context_line":"    try:"},{"line_number":422,"context_line":"        filter_kwargs \u003d {}"},{"line_number":423,"context_line":"        if \u0027region_name\u0027 in os_options:"},{"line_number":424,"context_line":"            filter_kwargs[\u0027attr\u0027] \u003d \u0027region\u0027"},{"line_number":425,"context_line":"            filter_kwargs[\u0027filter_value\u0027] \u003d os_options[\u0027region_name\u0027]"},{"line_number":426,"context_line":"        endpoint \u003d _ksclient.service_catalog.url_for("}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_a99b3a65","line":423,"updated":"2015-12-02 18:33:14.000000000","message":"I think this needs to be \n\n  if os_options.get(\u0027region_name\u0027)\n\nAt least thats the only way I could remove the warning when using swift_stat","commit_id":"8c4ae0c6cf5595c79112efae604f60992a7f87ed"}],"tests/unit/test_shell.py":[{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"8194568f95be3c5c4f12c890297d1fdf3ecba62e","unresolved":false,"context_lines":[{"line_number":1461,"context_line":"                key \u003d \u0027filter_value\u0027"},{"line_number":1462,"context_line":"                if expected is None:"},{"line_number":1463,"context_line":"                    check_attr \u003d False"},{"line_number":1464,"context_line":"                    self.assertNotIn(key, actual_args)"},{"line_number":1465,"context_line":"                    continue"},{"line_number":1466,"context_line":"            self.assertIn(key, actual_args)"},{"line_number":1467,"context_line":"            self.assertEqual(expected, actual_args[key],"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a740942_73a3019e","line":1464,"updated":"2015-12-07 18:39:14.000000000","message":"Check for the other offender:\n\n  self.assertNotIn(\u0027attr\u0027, actual_args)\n\nIf \u0027filter_value\u0027 is removed from the args but \u0027attr\u0027 is passed in the args then I see the offending warning, so best test that both are removed when there is no region_name value","commit_id":"7d31f43f924f32a5caa378c38153c0780acea1c2"},{"author":{"_account_id":8037,"name":"renminmin","email":"rmm0811@gmail.com","username":"renminmin"},"change_message_id":"55c42568e26db7c4db34b76912d423f47a066481","unresolved":false,"context_lines":[{"line_number":1455,"context_line":"        self.assertEqual(len(fake_ks.client.service_catalog.calls), 1)"},{"line_number":1456,"context_line":"        actual_args \u003d fake_ks.client.service_catalog.calls[0]"},{"line_number":1457,"context_line":"        for key in self.catalog_opts.keys():"},{"line_number":1458,"context_line":"            expected \u003d os_opts.get(key, self.defaults.get(key))"},{"line_number":1459,"context_line":"            key \u003d key.replace(\u0027-\u0027, \u0027_\u0027)"},{"line_number":1460,"context_line":"            if key \u003d\u003d \u0027region_name\u0027:"},{"line_number":1461,"context_line":"                key \u003d \u0027filter_value\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a7e1126_0e14804a","line":1458,"range":{"start_line":1458,"start_character":61,"end_line":1458,"end_character":63},"updated":"2015-12-22 06:10:50.000000000","message":"If key is \u0027region_name\u0027, self.defaults.get(key) always return None because defaults is static dictionary structure, right?","commit_id":"2345ae54f1395783d39d31226a0e7a9ea7ac557a"},{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"fa067fdf576593c733750ed3391e90898533e872","unresolved":false,"context_lines":[{"line_number":1455,"context_line":"        self.assertEqual(len(fake_ks.client.service_catalog.calls), 1)"},{"line_number":1456,"context_line":"        actual_args \u003d fake_ks.client.service_catalog.calls[0]"},{"line_number":1457,"context_line":"        for key in self.catalog_opts.keys():"},{"line_number":1458,"context_line":"            expected \u003d os_opts.get(key, self.defaults.get(key))"},{"line_number":1459,"context_line":"            key \u003d key.replace(\u0027-\u0027, \u0027_\u0027)"},{"line_number":1460,"context_line":"            if key \u003d\u003d \u0027region_name\u0027:"},{"line_number":1461,"context_line":"                key \u003d \u0027filter_value\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a7e1126_532ea8a5","line":1458,"range":{"start_line":1458,"start_character":61,"end_line":1458,"end_character":63},"in_reply_to":"3a7e1126_0e14804a","updated":"2015-12-22 08:51:07.000000000","message":"Sure, but in some of the tests os_opts includes a \u0027region_name\u0027 (for example in test_all_args_passed_to_keystone). So will call self.defaults.get(key) when it doesn\u0027t appear in os_opts.","commit_id":"2345ae54f1395783d39d31226a0e7a9ea7ac557a"},{"author":{"_account_id":8037,"name":"renminmin","email":"rmm0811@gmail.com","username":"renminmin"},"change_message_id":"55c42568e26db7c4db34b76912d423f47a066481","unresolved":false,"context_lines":[{"line_number":1460,"context_line":"            if key \u003d\u003d \u0027region_name\u0027:"},{"line_number":1461,"context_line":"                key \u003d \u0027filter_value\u0027"},{"line_number":1462,"context_line":"                if expected is None:"},{"line_number":1463,"context_line":"                    check_attr \u003d False"},{"line_number":1464,"context_line":"                    self.assertNotIn(key, actual_args)"},{"line_number":1465,"context_line":"                    self.assertNotIn(\u0027attr\u0027, actual_args)"},{"line_number":1466,"context_line":"                    continue"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a7e1126_2985b658","line":1463,"range":{"start_line":1463,"start_character":33,"end_line":1463,"end_character":38},"updated":"2015-12-22 06:10:50.000000000","message":"check_attr will be always False","commit_id":"2345ae54f1395783d39d31226a0e7a9ea7ac557a"}]}