)]}'
{"id":"openstack%2Fpython-swiftclient~25135","triplet_id":"openstack%2Fpython-swiftclient~master~Id60a2cd88bd814d1dcbeca951764c9d236500837","project":"openstack/python-swiftclient","branch":"master","topic":"bug/1158819","hashtags":[],"change_id":"Id60a2cd88bd814d1dcbeca951764c9d236500837","subject":"Fixed pep8 errors in test directory.","status":"MERGED","created":"2013-03-22 15:00:56.000000000","updated":"2013-03-26 09:06:36.000000000","submitted":"2013-03-26 09:06:36.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"1a4b75b83de58d5b46d5b694d121ab7946fa0fae","_number":25135,"virtual_id_number":25135,"owner":{"_account_id":5499,"name":"jola-mirecka","email":"jola.mirecka@hp.com","username":"jola-mirecka"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},{"value":2,"date":"2013-03-26 09:06:36.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"all":[{"value":2,"date":"2013-03-26 09:04:31.000000000","_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2013-03-25 20:11:04.000000000","_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"all":[{"value":1,"date":"2013-03-26 09:04:31.000000000","_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"date":"2013-03-25 20:11:04.000000000","_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2013-03-25 20:11:04.000000000","updated_by":{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},"reviewer":{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},"state":"REVIEWER"},{"updated":"2013-03-26 09:04:31.000000000","updated_by":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"reviewer":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"state":"REVIEWER"},{"updated":"2013-03-26 09:06:36.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"dd9700a75f089e22c848b84542c1717fee632a7d","author":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"date":"2013-03-22 15:16:44.000000000","message":"Patch Set 1:\n\nThanks for the PEP8 fixes but for tox.ini changes it was decided that we don\u0027t gate on PEP8 for tests. we can change that if others swift core don\u0027t mind it.","accounts_in_message":[],"_revision_number":1},{"id":"2f1c9bfa98a8bf324931ed9c650bfe98f8c33ada","author":{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},"date":"2013-03-25 20:11:04.000000000","message":"Patch Set 1: Looks good to me (core reviewer)\n\nI\u0027m happy to require PEP8 for tests.\n\nFor Swift, what I don\u0027t want is to have another giant pile of Gerrit reviews that each go around touching a particular file to make it PEP8 compliant, or worse, make *part* of a particular file PEP8 compliant. That just leads to a ton of noise in Gerrit. Worse yet, you get people standing around bikeshedding about parens versus backslashes and other trivial crap, and it winds up drowning the useful work in a sea of useless.\n\nSince this commit (a) turns on PEP8 gating for tests, *and* (b) fixes all the PEP8 errors in the tests, I\u0027m more than happy to merge it.*\n\nJust my opinion, though. Don\u0027t take it as some sort of consensus. :)\n\n* Note to future readers of this comment: if you\u0027re thinking of turning on PEP8 gating for Swift\u0027s tests, you should know that reviewers also dislike enormous diffs that touch dozens and dozens of files. Caveat coder.","accounts_in_message":[],"_revision_number":1},{"id":"0dfb99b3394ad5d40700edc757294c487bce12c6","author":{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},"date":"2013-03-25 21:12:38.000000000","message":"Patch Set 1:\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"46a1142e57af0f443158266c10336725d9fcb5e2","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-03-25 21:15:29.000000000","message":"Patch Set 1: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/25135/1/check/gate-python-swiftclient-pep8/223 : SUCCESS\n- http://logs.openstack.org/25135/1/check/gate-python-swiftclient-docs/173 : SUCCESS\n- http://logs.openstack.org/25135/1/check/gate-python-swiftclient-python26/221 : SUCCESS\n- http://logs.openstack.org/25135/1/check/gate-python-swiftclient-python26-rhel6/6 : SUCCESS (non-voting)\n- http://logs.openstack.org/25135/1/check/gate-python-swiftclient-python27/221 : SUCCESS\n","accounts_in_message":[],"_revision_number":1},{"id":"256ee3456cff35e0e025e3422bd8d8ba86dd171f","author":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"date":"2013-03-26 09:04:31.000000000","message":"Patch Set 1: Looks good to me (core reviewer); Approved\n\n@sam that makes us two at least and I like enforcing pep8 for python-swiftclient at least.","accounts_in_message":[],"_revision_number":1},{"id":"08da19568c6a2111bbec547734dcf711de0678d8","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-03-26 09:04:32.000000000","message":"Patch Set 1: No score\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"d2103b335cbee7417d5c941b116a3a2ad6572258","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-03-26 09:06:36.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":1},{"id":"5d6bd88f823847aa55ed7d935b79c05bf912b5fb","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-03-26 09:06:36.000000000","message":"Patch Set 1: Verified\n\nBuild succeeded.\n\n- http://logs.openstack.org/25135/1/gate/gate-python-swiftclient-docs/175 : SUCCESS\n- http://logs.openstack.org/25135/1/gate/gate-python-swiftclient-pep8/225 : SUCCESS\n- http://logs.openstack.org/25135/1/gate/gate-python-swiftclient-python26/223 : SUCCESS\n- http://logs.openstack.org/25135/1/gate/gate-python-swiftclient-python27/223 : SUCCESS\n","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"8ea9c4aae8837842a54f513866521d0d473d781f","revisions":{"8ea9c4aae8837842a54f513866521d0d473d781f":{"kind":"REWORK","_number":1,"created":"2013-03-22 15:00:56.000000000","uploader":{"_account_id":5499,"name":"jola-mirecka","email":"jola.mirecka@hp.com","username":"jola-mirecka"},"ref":"refs/changes/35/25135/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-swiftclient","ref":"refs/changes/35/25135/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/35/25135/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/35/25135/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/35/25135/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-swiftclient refs/changes/35/25135/1"}}},"commit":{"parents":[{"commit":"4f57f815b3847c9f4a2edc20784a770b806f4045","subject":"Merge \"Enhance put_object to inform when chunk is ignored\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/4f57f815b3847c9f4a2edc20784a770b806f4045"}]}],"author":{"name":"jola-mirecka","email":"jola.mirecka@hp.com","date":"2013-03-22 14:59:57.000000000","tz":0},"committer":{"name":"jola-mirecka","email":"jola.mirecka@hp.com","date":"2013-03-22 15:00:40.000000000","tz":0},"subject":"Fixed pep8 errors in test directory.","message":"Fixed pep8 errors in test directory.\n\nFiles test_swiftclient.py and utils.py had all pep8 errors\nfixed.\n\nAlso added tests directory to tox.ini file, so that\npep8 would monitor tests directory by default.\n\nChange-Id: Id60a2cd88bd814d1dcbeca951764c9d236500837\nFixes: bug #1158819\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/8ea9c4aae8837842a54f513866521d0d473d781f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/8ea9c4aae8837842a54f513866521d0d473d781f"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}