)]}'
{"id":"openstack%2Fpython-swiftclient~253316","triplet_id":"openstack%2Fpython-swiftclient~master~I124c8e22eb705c1bf61c45f54e62dbc64fa80a7f","project":"openstack/python-swiftclient","branch":"master","topic":"bug/1277104","hashtags":[],"change_id":"I124c8e22eb705c1bf61c45f54e62dbc64fa80a7f","subject":"Fix the parameter order of assertEqual in swiftclient","status":"ABANDONED","created":"2015-12-04 04:32:39.000000000","updated":"2015-12-15 17:35:11.000000000","total_comment_count":4,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"29fe3ae5bc64d270c66e16cbfa4d1697970589f6","_number":253316,"virtual_id_number":253316,"owner":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":1,"date":"2015-12-05 01:10:17.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":17589,"name":"Darla Ahlert","email":"da741q@att.com","username":"darla.ahlert"},{"date":"2015-12-05 00:45:49.000000000","_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},{"_account_id":330,"name":"John Dickinson","email":"me@not.mn","username":"notmyname"},{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"rejected":{"_account_id":330,"name":"John Dickinson","email":"me@not.mn","username":"notmyname"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":17589,"name":"Darla Ahlert","email":"da741q@att.com","username":"darla.ahlert"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},{"value":-2,"date":"2015-12-05 00:09:41.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":330,"name":"John Dickinson","email":"me@not.mn","username":"notmyname"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":17589,"name":"Darla Ahlert","email":"da741q@att.com","username":"darla.ahlert"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":330,"name":"John Dickinson","email":"me@not.mn","username":"notmyname"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":330,"name":"John Dickinson","email":"me@not.mn","username":"notmyname"},{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},{"_account_id":17589,"name":"Darla Ahlert","email":"da741q@att.com","username":"darla.ahlert"},{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-12-04 15:13:43.000000000","updated_by":{"_account_id":17589,"name":"Darla Ahlert","email":"da741q@att.com","username":"darla.ahlert"},"reviewer":{"_account_id":17589,"name":"Darla Ahlert","email":"da741q@att.com","username":"darla.ahlert"},"state":"REVIEWER"},{"updated":"2015-12-04 16:34:39.000000000","updated_by":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"reviewer":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"state":"REVIEWER"},{"updated":"2015-12-05 00:09:41.000000000","updated_by":{"_account_id":330,"name":"John Dickinson","email":"me@not.mn","username":"notmyname"},"reviewer":{"_account_id":330,"name":"John Dickinson","email":"me@not.mn","username":"notmyname"},"state":"REVIEWER"},{"updated":"2015-12-05 01:10:17.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"8c0641a2d20ec2dde51efbe6af7cd8b5d907ba52","author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"date":"2015-12-04 04:32:39.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"845d3d2f519652632ba0ee9ec7357724394218a4","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-12-04 05:32:58.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-swiftclient-pep8 http://logs.openstack.org/16/253316/1/check/gate-python-swiftclient-pep8/ea03154/ : SUCCESS in 43s\n- gate-python-swiftclient-docs http://docs-draft.openstack.org/16/253316/1/check/gate-python-swiftclient-docs/9f97cf9//doc/build/html/ : SUCCESS in 50s\n- gate-python-swiftclient-python27 http://logs.openstack.org/16/253316/1/check/gate-python-swiftclient-python27/3b03637/ : SUCCESS in 53s\n- gate-python-swiftclient-python34 http://logs.openstack.org/16/253316/1/check/gate-python-swiftclient-python34/4d7a90e/ : SUCCESS in 1m 32s\n- gate-python-swiftclient-pypy http://logs.openstack.org/16/253316/1/check/gate-python-swiftclient-pypy/45e375e/ : SUCCESS in 1m 19s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-swiftclient http://logs.openstack.org/16/253316/1/check/gate-tempest-dsvm-neutron-src-python-swiftclient/7540e47/ : SUCCESS in 55m 44s\n- gate-swift-dsvm-functional http://logs.openstack.org/16/253316/1/check/gate-swift-dsvm-functional/3af4c5e/ : SUCCESS in 27m 25s\n- gate-swiftclient-dsvm-functional http://logs.openstack.org/16/253316/1/check/gate-swiftclient-dsvm-functional/afc8b56/ : SUCCESS in 21m 08s","accounts_in_message":[],"_revision_number":1},{"id":"0028cd2701e07b358cdcfc189a0419d4a146fc0d","author":{"_account_id":17589,"name":"Darla Ahlert","email":"da741q@att.com","username":"darla.ahlert"},"date":"2015-12-04 15:13:43.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"f250e2f46cc70a6bf0e60d8284de0c94ff80e7e6","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2015-12-04 16:34:39.000000000","message":"Patch Set 1: Code-Review-1\n\n(3 comments)\n\nSeems sane. -1 only because an assertion picked up an extra arg, which would make the error message less useful.\n\nMind if I ask what prompted this? Is there a tool that actually cares about argument order to assertEqual?\n\n(Side note: for some reason I thought (expected, actual) is the documented order, but that doesn\u0027t seem to be true: https://docs.python.org/3/library/unittest.html#unittest.TestCase.assertEqual -- I guess I\u0027ve just already internalized the convention?)","accounts_in_message":[],"_revision_number":1},{"id":"0723492598d45eb54910f49061df370379830a51","author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"date":"2015-12-04 17:44:05.000000000","message":"Patch Set 1:\n\n(1 comment)\n\nThe format testtools expects is assertEqual(expected, observed, message\u003d\u0027\u0027).\n\nIt seems there\u0027s also issues with the way the error output is displayed when the combined length of the expect and actual arguments are greater than 70.  With the parameters switched to (observed,actual), the resulting message is very confusing to some, which is what seems to have led to the opening of this bug report.  Here\u0027s a link to the code that results in the awkward display: https://github.com/testing-cabal/testtools/blob/master/testtools/matchers/_basic.py#L77\n\nAlso, after looking at your comment regarding the (None, actual), it seems it would be better to utilize assertIsNone(actual) instead as it\u0027s easier to read.\n\nThanks for your comments.  I\u0027ll put up the new patch set later this afternoon. :)","accounts_in_message":[],"_revision_number":1},{"id":"89f1809dff138ae5647d5088eef9efa91303d6b9","author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"date":"2015-12-05 00:03:43.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"c5b1921a3a13cf00d5cc77b04bafd055ea02d25a","author":{"_account_id":330,"name":"John Dickinson","email":"me@not.mn","username":"notmyname"},"date":"2015-12-05 00:09:41.000000000","message":"Patch Set 2: Code-Review-2\n\nSteve, first I want to say thanks for submitting a patch to swiftclient. I love that you\u0027re looking at and contributing to the project. And since I\u0027m adding a -2, I\u0027m sorry I didn\u0027t catch this one earlier.\n\nThere\u0027s been several patches like this proposed to swift and swiftclient in the past. As a community, we\u0027ve decided not to accept them, mostly because it\u0027s a style guide change that is impossible to enforce. Therefore it becomes a never-ending code churn to get things into the \"right\" order, and one which we can\u0027t actually test for (as opposed to other things like pep8 changes).\n\nThank you, but this is not a patch we want to accept at this time.","accounts_in_message":[],"_revision_number":2},{"id":"099fd138a8e9b8006368762c2bc4a0441a1a3cf9","author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"date":"2015-12-05 00:45:49.000000000","message":"Patch Set 2:\n\nJohn,\n\nThanks for the reply!  I understand how this can (and probably already does) result in churn and valuable time taken from the reviewers for the project.  As someone who\u0027s just getting exposure to working with the OpenStack project, all feedback is extremely valuable and meaningful.  I look forward to finding other ways to contribute to the project in the future.","accounts_in_message":[],"_revision_number":2},{"id":"71b2235681c22d139c201dd1e335d4e8c4fd3071","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-12-05 01:10:17.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-swiftclient-pep8 http://logs.openstack.org/16/253316/2/check/gate-python-swiftclient-pep8/c695b17/ : SUCCESS in 44s\n- gate-python-swiftclient-docs http://docs-draft.openstack.org/16/253316/2/check/gate-python-swiftclient-docs/5fec9ec//doc/build/html/ : SUCCESS in 52s\n- gate-python-swiftclient-python27 http://logs.openstack.org/16/253316/2/check/gate-python-swiftclient-python27/26ef64b/ : SUCCESS in 51s\n- gate-python-swiftclient-python34 http://logs.openstack.org/16/253316/2/check/gate-python-swiftclient-python34/f5a77a1/ : SUCCESS in 1m 36s\n- gate-python-swiftclient-pypy http://logs.openstack.org/16/253316/2/check/gate-python-swiftclient-pypy/c647c61/ : SUCCESS in 1m 10s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-swiftclient http://logs.openstack.org/16/253316/2/check/gate-tempest-dsvm-neutron-src-python-swiftclient/b9b31f6/ : SUCCESS in 1h 03m 33s\n- gate-swift-dsvm-functional http://logs.openstack.org/16/253316/2/check/gate-swift-dsvm-functional/6c9ff4a/ : SUCCESS in 27m 46s\n- gate-swiftclient-dsvm-functional http://logs.openstack.org/16/253316/2/check/gate-swiftclient-dsvm-functional/78fd3c3/ : SUCCESS in 21m 27s","accounts_in_message":[],"_revision_number":2},{"id":"da09d1734350ff4c1e9163ecc83a550c458313cb","author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"date":"2015-12-15 17:35:11.000000000","message":"Abandoned\n\nChange not applicable to the project","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"9aa2c0e9a742da59c6154e7e48ed9b257589f97c","revisions":{"2e0c64fe61f38fd42d81e58a4a792e1373661fee":{"kind":"REWORK","_number":1,"created":"2015-12-04 04:32:39.000000000","uploader":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"ref":"refs/changes/16/253316/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-swiftclient","ref":"refs/changes/16/253316/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/16/253316/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/16/253316/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/16/253316/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-swiftclient refs/changes/16/253316/1"}}},"commit":{"parents":[{"commit":"a564eb0e4cad452c5556c54c752ed896d0eb25af","subject":"Merge \"Unification of manpages and docstrings\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/a564eb0e4cad452c5556c54c752ed896d0eb25af"}]}],"author":{"name":"Steve Wilkerson","email":"sw5822@att.com","date":"2015-12-04 04:30:16.000000000","tz":-360},"committer":{"name":"Steve Wilkerson","email":"sw5822@att.com","date":"2015-12-04 04:30:16.000000000","tz":-360},"subject":"Fix the parameter order of assertEqual in swiftclient","message":"Fix the parameter order of assertEqual in swiftclient\n\nOn assertEqual, the parameter order should be (expected, actual).\nSome of the tests in python-swiftclient were written with invalid\nparameter orders.  This introduces the correct parameter order.\n\nChange-Id: I124c8e22eb705c1bf61c45f54e62dbc64fa80a7f\nPartial-Bug: 1277104\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/2e0c64fe61f38fd42d81e58a4a792e1373661fee"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/2e0c64fe61f38fd42d81e58a4a792e1373661fee"}]},"branch":"refs/heads/master"},"9aa2c0e9a742da59c6154e7e48ed9b257589f97c":{"kind":"REWORK","_number":2,"created":"2015-12-05 00:03:43.000000000","uploader":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"ref":"refs/changes/16/253316/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-swiftclient","ref":"refs/changes/16/253316/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/16/253316/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/16/253316/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/16/253316/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-swiftclient refs/changes/16/253316/2"}}},"commit":{"parents":[{"commit":"a564eb0e4cad452c5556c54c752ed896d0eb25af","subject":"Merge \"Unification of manpages and docstrings\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/a564eb0e4cad452c5556c54c752ed896d0eb25af"}]}],"author":{"name":"Steve Wilkerson","email":"sw5822@att.com","date":"2015-12-04 04:30:16.000000000","tz":-360},"committer":{"name":"Steve Wilkerson","email":"sw5822@att.com","date":"2015-12-05 00:02:55.000000000","tz":-360},"subject":"Fix the parameter order of assertEqual in swiftclient","message":"Fix the parameter order of assertEqual in swiftclient\n\nOn assertEqual, the parameter order should be (expected, actual).\nSome of the tests in python-swiftclient were written with invalid\nparameter orders.  This introduces the correct parameter order.\n\nChange-Id: I124c8e22eb705c1bf61c45f54e62dbc64fa80a7f\nPartial-Bug: 1277104\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/9aa2c0e9a742da59c6154e7e48ed9b257589f97c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/9aa2c0e9a742da59c6154e7e48ed9b257589f97c"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}