)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"037503ff6187b388a4d43af07c5725226ba595a1","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     pei ran wu \u003cwupeiran@cn.ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-12-17 13:04:39 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":":Add validation of -S option for SLO upload"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I091cdb5a048592cd4ffc295abec3747a55bcdee5"},{"line_number":10,"context_line":"Closes-bug: #1514599"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a7b0d38_3263b4b3","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":1},"updated":"2015-12-23 01:45:03.000000000","message":"Since we\u0027ll need another patchset anyway, drop the leading colon.","commit_id":"aca6113d1678fd656de42829f274c8ee4b34831c"}],"swiftclient/service.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"037503ff6187b388a4d43af07c5725226ba595a1","unresolved":false,"context_lines":[{"line_number":1339,"context_line":"            raise SwiftError(\u0027Segment size should be an integer value\u0027)"},{"line_number":1340,"context_line":""},{"line_number":1341,"context_line":"        # Check slo capability first before sending SLO"},{"line_number":1342,"context_line":"        if \u0027use_slo\u0027 in options.keys() and options[\u0027use_slo\u0027] is True:"},{"line_number":1343,"context_line":"            capabilities_result \u003d self.capabilities()"},{"line_number":1344,"context_line":"            cap_info \u003d capabilities_result[\u0027capabilities\u0027]"},{"line_number":1345,"context_line":"            if \u0027slo\u0027 in cap_info.keys():"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a7b0d38_2c94bd35","line":1342,"range":{"start_line":1342,"start_character":8,"end_line":1342,"end_character":70},"updated":"2015-12-23 01:45:03.000000000","message":"Maybe\n\n  if options.get(\u0027use_slo\u0027):\n\n?","commit_id":"aca6113d1678fd656de42829f274c8ee4b34831c"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"037503ff6187b388a4d43af07c5725226ba595a1","unresolved":false,"context_lines":[{"line_number":1345,"context_line":"            if \u0027slo\u0027 in cap_info.keys():"},{"line_number":1346,"context_line":"                slo_cap_info \u003d cap_info[\u0027slo\u0027]"},{"line_number":1347,"context_line":"                if slo_cap_info[\u0027min_segment_size\u0027] \u003e segment_size:"},{"line_number":1348,"context_line":"                    raise SwiftError("},{"line_number":1349,"context_line":"                        \"Aborting slo creation because \""},{"line_number":1350,"context_line":"                        \"the segment size should not be less than %s\""},{"line_number":1351,"context_line":"                        % slo_cap_info[\u0027min_segment_size\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a7b0d38_ecb475d2","line":1348,"range":{"start_line":1348,"start_character":20,"end_line":1348,"end_character":36},"updated":"2015-12-23 01:45:03.000000000","message":"Is it better to raise an error, or choose a usable value on the users behalf?\n\nAt the API level, I think this (raising an error) is fine, but at the CLI level (i.e., in shell.py), we should consider doing something more intelligent with the information we can get. That may be better as a separate patch, though...","commit_id":"aca6113d1678fd656de42829f274c8ee4b34831c"}]}