)]}'
{"id":"openstack%2Fpython-swiftclient~258800","triplet_id":"openstack%2Fpython-swiftclient~master~I091cdb5a048592cd4ffc295abec3747a55bcdee5","project":"openstack/python-swiftclient","branch":"master","topic":"bug/1514599","hashtags":[],"change_id":"I091cdb5a048592cd4ffc295abec3747a55bcdee5","subject":"Add validation of -S option for SLO upload","status":"NEW","created":"2015-12-17 05:04:59.000000000","updated":"2017-12-18 05:27:49.000000000","submit_type":"MERGE_IF_NECESSARY","mergeable":false,"submittable":false,"total_comment_count":3,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"a241ec77162d4e49f16dd49f00bbe3aac72baad0","_number":258800,"virtual_id_number":258800,"owner":{"_account_id":12965,"name":"pei ran wu","email":"wupeiran@cn.ibm.com","username":"wupeiran"},"actions":{},"labels":{"Verified":{"all":[{"date":"2015-12-29 03:33:41.000000000","_account_id":12965,"name":"pei ran wu","email":"wupeiran@cn.ibm.com","username":"wupeiran"},{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":12965,"name":"pei ran wu","email":"wupeiran@cn.ibm.com","username":"wupeiran"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":12965,"name":"pei ran wu","email":"wupeiran@cn.ibm.com","username":"wupeiran"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":12965,"name":"pei ran wu","email":"wupeiran@cn.ibm.com","username":"wupeiran"},{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-12-23 01:45:03.000000000","updated_by":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"reviewer":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"state":"REVIEWER"}],"messages":[{"id":"024cf9164a7a2b2bf839aeb7943d8587cd3c5383","author":{"_account_id":12965,"name":"pei ran wu","email":"wupeiran@cn.ibm.com","username":"wupeiran"},"date":"2015-12-17 05:04:59.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"cd858d70ec00679e99bf5332a60b145364a714b3","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-12-17 06:33:22.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-swiftclient-pep8 http://logs.openstack.org/00/258800/1/check/gate-python-swiftclient-pep8/0421b97/ : SUCCESS in 53s\n- gate-python-swiftclient-docs http://docs-draft.openstack.org/00/258800/1/check/gate-python-swiftclient-docs/0bc88ca//doc/build/html/ : SUCCESS in 55s\n- gate-python-swiftclient-python27 http://logs.openstack.org/00/258800/1/check/gate-python-swiftclient-python27/f0d89f4/ : SUCCESS in 1m 04s\n- gate-python-swiftclient-python34 http://logs.openstack.org/00/258800/1/check/gate-python-swiftclient-python34/fcb3fed/ : SUCCESS in 1m 32s\n- gate-python-swiftclient-pypy http://logs.openstack.org/00/258800/1/check/gate-python-swiftclient-pypy/b950985/ : SUCCESS in 1m 12s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-swiftclient http://logs.openstack.org/00/258800/1/check/gate-tempest-dsvm-neutron-src-python-swiftclient/a2da369/ : SUCCESS in 1h 25m 05s\n- gate-swift-dsvm-functional http://logs.openstack.org/00/258800/1/check/gate-swift-dsvm-functional/fc5f883/ : SUCCESS in 31m 53s\n- gate-swiftclient-dsvm-functional http://logs.openstack.org/00/258800/1/check/gate-swiftclient-dsvm-functional/0ac14e4/ : SUCCESS in 28m 37s","accounts_in_message":[],"_revision_number":1},{"id":"037503ff6187b388a4d43af07c5725226ba595a1","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2015-12-23 01:45:03.000000000","message":"Patch Set 1: Code-Review-1\n\n(3 comments)\n\nI definitely want the client to be smarter about using /info, but this will need tests. At least cover:\n\n* /info succeeds, and segment_size is good\n\n* /info succeeds, and segment_size is bad\n\nAlso, I\u0027m a little worried about older clusters, though I don\u0027t know that it\u0027s worth holding this up. First, some background:\n\n* 1.8.0 (Grizzly final release) - SLO is introduced [1]\n\n* 1.11.0 (Icehouse initial release) - /info is added, including SLO [2]\n\n* 1.12.0 (Icehouse mid-cycle release) - SLO constraints are added to /info [3]\n\nMaybe we don\u0027t care about clusters that old, but if at all possible, I\u0027d really prefer to handle a /info failure gracefully. With this patch, if I try to upload a SLO to a 1.9.2 cluster (that has SLO enabled) I get a ClientException saying \u0027Capabilities GET failed\u0027. If I try to upload a SLO to a 1.11.0 cluster (again, with SLO enabled), I get a KeyError (!). Both of these used to work.\n\n[1] https://github.com/openstack/swift/commit/2c4bf81\n\n[2] https://github.com/openstack/swift/commit/5d73da1\n\n[3] https://github.com/openstack/swift/commit/928f5c1","accounts_in_message":[],"_revision_number":1},{"id":"38755a74d4ae92c1a729b573dc97c58aa9aba590","author":{"_account_id":12965,"name":"pei ran wu","email":"wupeiran@cn.ibm.com","username":"wupeiran"},"date":"2015-12-29 03:21:17.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"4856ce62ba2dd9894ec2053661919c5ee02e0789","author":{"_account_id":12965,"name":"pei ran wu","email":"wupeiran@cn.ibm.com","username":"wupeiran"},"date":"2015-12-29 03:33:41.000000000","message":"Patch Set 2:\n\n\u003e (3 comments)\n \u003e \n \u003e I definitely want the client to be smarter about using /info, but\n \u003e this will need tests. At least cover:\n \u003e \n \u003e * /info succeeds, and segment_size is good\n \u003e \n \u003e * /info succeeds, and segment_size is bad\n \u003e \n \u003e Also, I\u0027m a little worried about older clusters, though I don\u0027t\n \u003e know that it\u0027s worth holding this up. First, some background:\n \u003e \n \u003e * 1.8.0 (Grizzly final release) - SLO is introduced [1]\n \u003e \n \u003e * 1.11.0 (Icehouse initial release) - /info is added, including SLO\n \u003e [2]\n \u003e \n \u003e * 1.12.0 (Icehouse mid-cycle release) - SLO constraints are added\n \u003e to /info [3]\n \u003e \n \u003e Maybe we don\u0027t care about clusters that old, but if at all\n \u003e possible, I\u0027d really prefer to handle a /info failure gracefully.\n \u003e With this patch, if I try to upload a SLO to a 1.9.2 cluster (that\n \u003e has SLO enabled) I get a ClientException saying \u0027Capabilities GET\n \u003e failed\u0027. If I try to upload a SLO to a 1.11.0 cluster (again, with\n \u003e SLO enabled), I get a KeyError (!). Both of these used to work.\n \u003e \n \u003e [1] https://github.com/openstack/swift/commit/2c4bf81\n \u003e \n \u003e [2] https://github.com/openstack/swift/commit/5d73da1\n \u003e \n \u003e [3] https://github.com/openstack/swift/commit/928f5c1\n\n\nHello Tim,\nThanks for your detail comments.I have updated patch accordingly.I may not cover all the things you pointed but please review if anything I miss for this fix.\nThank you!","accounts_in_message":[],"_revision_number":2},{"id":"3591e6f19878bf75b2e90137e48746c078ee765d","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-12-29 04:38:02.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-swiftclient-pep8 http://logs.openstack.org/00/258800/2/check/gate-python-swiftclient-pep8/46834c5/ : SUCCESS in 52s\n- gate-python-swiftclient-docs http://docs-draft.openstack.org/00/258800/2/check/gate-python-swiftclient-docs/c187adb//doc/build/html/ : SUCCESS in 53s\n- gate-python-swiftclient-python27 http://logs.openstack.org/00/258800/2/check/gate-python-swiftclient-python27/430cdae/ : SUCCESS in 58s\n- gate-python-swiftclient-python34 http://logs.openstack.org/00/258800/2/check/gate-python-swiftclient-python34/f943d14/ : SUCCESS in 1m 32s\n- gate-python-swiftclient-pypy http://logs.openstack.org/00/258800/2/check/gate-python-swiftclient-pypy/efdfa46/ : SUCCESS in 1m 23s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-swiftclient http://logs.openstack.org/00/258800/2/check/gate-tempest-dsvm-neutron-src-python-swiftclient/c3c679d/ : SUCCESS in 1h 16m 33s\n- gate-swift-dsvm-functional http://logs.openstack.org/00/258800/2/check/gate-swift-dsvm-functional/0b0af13/ : SUCCESS in 32m 34s\n- gate-swiftclient-dsvm-functional http://logs.openstack.org/00/258800/2/check/gate-swiftclient-dsvm-functional/ea8c735/ : SUCCESS in 19m 34s","accounts_in_message":[],"_revision_number":2},{"id":"768ca03b5cb4d49bdf78834ab4f2792383aee8cf","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-01-11 23:59:20.000000000","message":"Patch Set 2: Verified-1\n\nMerge Failed.\n\nThis change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.","accounts_in_message":[],"_revision_number":2},{"id":"ca18e38c2bf85f8e6e8402d160951b3e48688439","author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"date":"2017-12-18 05:27:49.000000000","message":"Removed reviewer Jenkins with the following votes:\n\n* Verified-1 by Jenkins (3)\n","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"926dc2eedb3c84679695f41562946c3629cb5e6e","revisions":{"aca6113d1678fd656de42829f274c8ee4b34831c":{"kind":"REWORK","_number":1,"created":"2015-12-17 05:04:59.000000000","uploader":{"_account_id":12965,"name":"pei ran wu","email":"wupeiran@cn.ibm.com","username":"wupeiran"},"ref":"refs/changes/00/258800/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-swiftclient","ref":"refs/changes/00/258800/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/00/258800/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/00/258800/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/00/258800/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-swiftclient refs/changes/00/258800/1"}}},"commit":{"parents":[{"commit":"0103465fcb5d0119459569e7952cc1c580d045e2","subject":"Test \u0027string\u0027 behaviour of get_object","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/0103465fcb5d0119459569e7952cc1c580d045e2"}]}],"author":{"name":"pei ran wu","email":"wupeiran@cn.ibm.com","date":"2015-12-17 03:53:29.000000000","tz":480},"committer":{"name":"pei ran wu","email":"wupeiran@cn.ibm.com","date":"2015-12-17 05:04:39.000000000","tz":480},"subject":":Add validation of -S option for SLO upload","message":":Add validation of -S option for SLO upload\n\nChange-Id: I091cdb5a048592cd4ffc295abec3747a55bcdee5\nCloses-bug: #1514599\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/aca6113d1678fd656de42829f274c8ee4b34831c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/aca6113d1678fd656de42829f274c8ee4b34831c"}]},"branch":"refs/heads/master"},"926dc2eedb3c84679695f41562946c3629cb5e6e":{"kind":"REWORK","_number":2,"created":"2015-12-29 03:21:17.000000000","uploader":{"_account_id":12965,"name":"pei ran wu","email":"wupeiran@cn.ibm.com","username":"wupeiran"},"ref":"refs/changes/00/258800/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-swiftclient","ref":"refs/changes/00/258800/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/00/258800/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/00/258800/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/00/258800/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-swiftclient refs/changes/00/258800/2"}}},"commit":{"parents":[{"commit":"5e13c3e845cae9d4736e7a8706f1f3ea1476878b","subject":"Merge \"Stop passing attr to keystoneclient when there\u0027s no filter_value\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/5e13c3e845cae9d4736e7a8706f1f3ea1476878b"}]}],"author":{"name":"pei ran wu","email":"wupeiran@cn.ibm.com","date":"2015-12-17 03:53:29.000000000","tz":480},"committer":{"name":"pei ran wu","email":"wupeiran@cn.ibm.com","date":"2015-12-29 03:19:24.000000000","tz":480},"subject":"Add validation of -S option for SLO upload","message":"Add validation of -S option for SLO upload\n\nCheck if slo middleware enabled and minimum segment size exceeded\n\nChange-Id: I091cdb5a048592cd4ffc295abec3747a55bcdee5\nCloses-bug: #1514599\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/926dc2eedb3c84679695f41562946c3629cb5e6e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/926dc2eedb3c84679695f41562946c3629cb5e6e"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"OK","labels":[{"label":"Verified","status":"MAY"},{"label":"Code-Review","status":"MAY"},{"label":"Workflow","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{"label:Verified\u003dMAX":"","label:Verified\u003dMIN":""}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","label:Code-Review\u003dMIN"],"atom_explanations":{"label:Code-Review\u003dMAX":"","label:Code-Review\u003dMIN":""}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Workflow\u003dMAX","label:Workflow\u003dMIN"],"atom_explanations":{"label:Workflow\u003dMAX":"","label:Workflow\u003dMIN":""}}}]}