)]}'
{"id":"openstack%2Fpython-swiftclient~259273","triplet_id":"openstack%2Fpython-swiftclient~master~Ifaa468e489a31b3ede5fa8ad30c7b0717345e11b","project":"openstack/python-swiftclient","branch":"master","topic":"bug/1516692","hashtags":[],"change_id":"Ifaa468e489a31b3ede5fa8ad30c7b0717345e11b","subject":"encode auth token in swiftclient log message","status":"ABANDONED","created":"2015-12-18 04:17:04.000000000","updated":"2016-02-26 17:11:50.000000000","total_comment_count":8,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"32cf49f9346d150f86cf5d225dc1ec01aa941e2d","_number":259273,"virtual_id_number":259273,"owner":{"_account_id":11373,"name":"Bing Hu","email":"hubingsh@cn.ibm.com","username":"hubingsh"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"date":"2016-02-19 15:02:30.000000000","_account_id":9216,"name":"Joel Wright","email":"joel.wright@gmail.com","username":"jjw-sohonet"},{"_account_id":18738,"name":"carl li","email":"carl.cheng.li@gmail.com","username":"CarlLi"},{"value":-1,"date":"2016-02-25 01:54:22.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},{"_account_id":330,"name":"John Dickinson","email":"me@not.mn","username":"notmyname"},{"date":"2016-02-19 05:22:17.000000000","_account_id":11373,"name":"Bing Hu","email":"hubingsh@cn.ibm.com","username":"hubingsh"},{"_account_id":13390,"name":"Mingyu Li","email":"mingyu.li.cn@gmail.com","username":"Microwise"},{"_account_id":16046,"name":"Fernando Diaz","email":"diazjf@us.ibm.com","username":"diazjf"},{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":9216,"name":"Joel Wright","email":"joel.wright@gmail.com","username":"jjw-sohonet"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":18738,"name":"carl li","email":"carl.cheng.li@gmail.com","username":"CarlLi"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":330,"name":"John Dickinson","email":"me@not.mn","username":"notmyname"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":11373,"name":"Bing Hu","email":"hubingsh@cn.ibm.com","username":"hubingsh"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":13390,"name":"Mingyu Li","email":"mingyu.li.cn@gmail.com","username":"Microwise"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":16046,"name":"Fernando Diaz","email":"diazjf@us.ibm.com","username":"diazjf"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":9216,"name":"Joel Wright","email":"joel.wright@gmail.com","username":"jjw-sohonet"},{"_account_id":18738,"name":"carl li","email":"carl.cheng.li@gmail.com","username":"CarlLi"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":330,"name":"John Dickinson","email":"me@not.mn","username":"notmyname"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":11373,"name":"Bing Hu","email":"hubingsh@cn.ibm.com","username":"hubingsh"},{"_account_id":13390,"name":"Mingyu Li","email":"mingyu.li.cn@gmail.com","username":"Microwise"},{"_account_id":16046,"name":"Fernando Diaz","email":"diazjf@us.ibm.com","username":"diazjf"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":330,"name":"John Dickinson","email":"me@not.mn","username":"notmyname"},{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},{"_account_id":9216,"name":"Joel Wright","email":"joel.wright@gmail.com","username":"jjw-sohonet"},{"_account_id":11373,"name":"Bing Hu","email":"hubingsh@cn.ibm.com","username":"hubingsh"},{"_account_id":13390,"name":"Mingyu Li","email":"mingyu.li.cn@gmail.com","username":"Microwise"},{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},{"_account_id":16046,"name":"Fernando Diaz","email":"diazjf@us.ibm.com","username":"diazjf"},{"_account_id":18738,"name":"carl li","email":"carl.cheng.li@gmail.com","username":"CarlLi"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-01-15 15:46:58.000000000","updated_by":{"_account_id":18738,"name":"carl li","email":"carl.cheng.li@gmail.com","username":"CarlLi"},"reviewer":{"_account_id":18738,"name":"carl li","email":"carl.cheng.li@gmail.com","username":"CarlLi"},"state":"REVIEWER"},{"updated":"2016-01-28 17:15:48.000000000","updated_by":{"_account_id":16046,"name":"Fernando Diaz","email":"diazjf@us.ibm.com","username":"diazjf"},"reviewer":{"_account_id":16046,"name":"Fernando Diaz","email":"diazjf@us.ibm.com","username":"diazjf"},"state":"REVIEWER"},{"updated":"2016-01-30 05:23:45.000000000","updated_by":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"reviewer":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"state":"REVIEWER"},{"updated":"2016-01-30 17:24:14.000000000","updated_by":{"_account_id":13390,"name":"Mingyu Li","email":"mingyu.li.cn@gmail.com","username":"Microwise"},"reviewer":{"_account_id":13390,"name":"Mingyu Li","email":"mingyu.li.cn@gmail.com","username":"Microwise"},"state":"REVIEWER"},{"updated":"2016-02-11 12:30:10.000000000","updated_by":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"reviewer":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"state":"REVIEWER"},{"updated":"2016-02-18 18:04:39.000000000","updated_by":{"_account_id":330,"name":"John Dickinson","email":"me@not.mn","username":"notmyname"},"reviewer":{"_account_id":330,"name":"John Dickinson","email":"me@not.mn","username":"notmyname"},"state":"REVIEWER"},{"updated":"2016-02-19 15:02:30.000000000","updated_by":{"_account_id":9216,"name":"Joel Wright","email":"joel.wright@gmail.com","username":"jjw-sohonet"},"reviewer":{"_account_id":9216,"name":"Joel Wright","email":"joel.wright@gmail.com","username":"jjw-sohonet"},"state":"REVIEWER"},{"updated":"2016-02-25 01:54:22.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"60e4a08b86cbddcd36db74cd67a728bc87997f41","author":{"_account_id":11373,"name":"Bing Hu","email":"hubingsh@cn.ibm.com","username":"hubingsh"},"date":"2015-12-18 04:17:04.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"dd33b50112c5ab40c7231c282ca91090f01c369f","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-12-18 05:12:31.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-swiftclient-pep8 http://logs.openstack.org/73/259273/1/check/gate-python-swiftclient-pep8/032f713/ : SUCCESS in 52s\n- gate-python-swiftclient-docs http://docs-draft.openstack.org/73/259273/1/check/gate-python-swiftclient-docs/10ccf96//doc/build/html/ : SUCCESS in 55s\n- gate-python-swiftclient-python27 http://logs.openstack.org/73/259273/1/check/gate-python-swiftclient-python27/ef0bf9a/ : SUCCESS in 1m 01s\n- gate-python-swiftclient-python34 http://logs.openstack.org/73/259273/1/check/gate-python-swiftclient-python34/83a4ef8/ : SUCCESS in 1m 51s\n- gate-python-swiftclient-pypy http://logs.openstack.org/73/259273/1/check/gate-python-swiftclient-pypy/3ad6981/ : SUCCESS in 1m 12s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-swiftclient http://logs.openstack.org/73/259273/1/check/gate-tempest-dsvm-neutron-src-python-swiftclient/430f73f/ : SUCCESS in 55m 19s\n- gate-swift-dsvm-functional http://logs.openstack.org/73/259273/1/check/gate-swift-dsvm-functional/31d769f/ : SUCCESS in 28m 09s\n- gate-swiftclient-dsvm-functional http://logs.openstack.org/73/259273/1/check/gate-swiftclient-dsvm-functional/04f19dc/ : SUCCESS in 20m 40s","accounts_in_message":[],"_revision_number":1},{"id":"5ab794e5b96f77602b394433d95abda6f370f0a6","author":{"_account_id":18738,"name":"carl li","email":"carl.cheng.li@gmail.com","username":"CarlLi"},"date":"2016-01-15 15:46:58.000000000","message":"Patch Set 1:\n\nit make sense to me.","accounts_in_message":[],"_revision_number":1},{"id":"2bf49f16dc8450aa37469a78d88dea61cd1a5dd6","author":{"_account_id":11373,"name":"Bing Hu","email":"hubingsh@cn.ibm.com","username":"hubingsh"},"date":"2016-01-16 01:48:58.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.","accounts_in_message":[],"_revision_number":2},{"id":"3882e24cc698ddcd703f46d33415b62724a9f934","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-01-16 03:11:06.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-swiftclient-pep8 http://logs.openstack.org/73/259273/2/check/gate-python-swiftclient-pep8/67ac691/ : SUCCESS in 49s\n- gate-python-swiftclient-docs http://docs-draft.openstack.org/73/259273/2/check/gate-python-swiftclient-docs/ecfa5e6//doc/build/html/ : SUCCESS in 47s\n- gate-python-swiftclient-python27 http://logs.openstack.org/73/259273/2/check/gate-python-swiftclient-python27/ada9b70/ : SUCCESS in 51s\n- gate-python-swiftclient-python34 http://logs.openstack.org/73/259273/2/check/gate-python-swiftclient-python34/6ef85fb/ : SUCCESS in 1m 33s\n- gate-python-swiftclient-pypy http://logs.openstack.org/73/259273/2/check/gate-python-swiftclient-pypy/73139e2/ : SUCCESS in 1m 32s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-swiftclient http://logs.openstack.org/73/259273/2/check/gate-tempest-dsvm-neutron-src-python-swiftclient/375c879/ : SUCCESS in 1h 19m 46s\n- gate-swift-dsvm-functional http://logs.openstack.org/73/259273/2/check/gate-swift-dsvm-functional/81e2b6b/ : SUCCESS in 33m 46s\n- gate-swiftclient-dsvm-functional http://logs.openstack.org/73/259273/2/check/gate-swiftclient-dsvm-functional/9788800/ : SUCCESS in 23m 08s","accounts_in_message":[],"_revision_number":2},{"id":"9f2d7f2c2b521a3a2c486836c1e414c98968d6f6","author":{"_account_id":16046,"name":"Fernando Diaz","email":"diazjf@us.ibm.com","username":"diazjf"},"date":"2016-01-28 17:15:48.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"970dd9ba83ff18658dab40b1c8184dc7c5fb5cfb","author":{"_account_id":11373,"name":"Bing Hu","email":"hubingsh@cn.ibm.com","username":"hubingsh"},"date":"2016-01-30 04:47:26.000000000","message":"Uploaded patch set 3: Commit message was updated.","accounts_in_message":[],"_revision_number":3},{"id":"d4580792b1b3f695dfd00c0416b42a328e8b559e","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2016-01-30 05:23:45.000000000","message":"Patch Set 3:\n\n(3 comments)\n\nNeeds tests.","accounts_in_message":[],"_revision_number":3},{"id":"21388c1938413b8a498ee24bedd2129bdd307834","author":{"_account_id":11373,"name":"Bing Hu","email":"hubingsh@cn.ibm.com","username":"hubingsh"},"date":"2016-01-30 05:24:50.000000000","message":"Patch Set 3:\n\n\u003e (1 comment)\n\nHi Fernando, thanks for your review. I just added patch description in commit message.","accounts_in_message":[],"_revision_number":3},{"id":"1a56a5741b37fdf0734f7e020dd82b04722c8069","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-01-30 05:44:42.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-swiftclient-pep8 http://logs.openstack.org/73/259273/3/check/gate-python-swiftclient-pep8/5d018d3/ : SUCCESS in 53s\n- gate-python-swiftclient-docs http://docs-draft.openstack.org/73/259273/3/check/gate-python-swiftclient-docs/7660e92//doc/build/html/ : SUCCESS in 59s\n- gate-python-swiftclient-python27 http://logs.openstack.org/73/259273/3/check/gate-python-swiftclient-python27/ec6889d/ : SUCCESS in 1m 20s\n- gate-python-swiftclient-python34 http://logs.openstack.org/73/259273/3/check/gate-python-swiftclient-python34/5e2613a/ : SUCCESS in 1m 44s\n- gate-python-swiftclient-pypy http://logs.openstack.org/73/259273/3/check/gate-python-swiftclient-pypy/ee8c0ca/ : SUCCESS in 1m 35s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-swiftclient http://logs.openstack.org/73/259273/3/check/gate-tempest-dsvm-neutron-src-python-swiftclient/5ab8bd1/ : SUCCESS in 57m 09s\n- gate-swift-dsvm-functional http://logs.openstack.org/73/259273/3/check/gate-swift-dsvm-functional/35cb354/ : SUCCESS in 29m 28s\n- gate-swiftclient-dsvm-functional http://logs.openstack.org/73/259273/3/check/gate-swiftclient-dsvm-functional/bf05c6c/ : SUCCESS in 22m 17s","accounts_in_message":[],"_revision_number":3},{"id":"91881ca423c004f1b2c8d299f993fece33678296","author":{"_account_id":13390,"name":"Mingyu Li","email":"mingyu.li.cn@gmail.com","username":"Microwise"},"date":"2016-01-30 17:24:14.000000000","message":"Patch Set 3:\n\nHi Tim Burke, In other OpenStack clients, such as python-novaclient, they use SHA1. I think maybe Bing Hu want to follow the convention.","accounts_in_message":[],"_revision_number":3},{"id":"4332a4f66d9c28bfb420548296bc51d6e5dd59c6","author":{"_account_id":13390,"name":"Mingyu Li","email":"mingyu.li.cn@gmail.com","username":"Microwise"},"date":"2016-01-30 17:45:15.000000000","message":"Patch Set 3: Code-Review-1\n\nFor swift, different from other projects in OpenStack, there would be another sensitive header \u0027X-Storage-Token\u0027, if you use the V1 Auth API. If you encode \u0027X-Auth-Token\u0027, you may want to encode \u0027X-Storage-Token\u0027 in the same way.","accounts_in_message":[],"_revision_number":3},{"id":"7b16c89cd7ec7f392f91507da060b2c3a1769e3b","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2016-02-09 19:04:24.000000000","message":"Patch Set 3: Code-Review-1\n\nGood call on the extra header. I\u0027ll also add \u0027X-Service-Token\u0027 and \u0027Set-Cookie\u0027. (The latter is know to be used by some auth systems to allow simpler browser-based auth.)\n\nI\u0027d still prefer to use a truncation scheme, though; it will simplify correlating logs between server and client.","accounts_in_message":[],"_revision_number":3},{"id":"3e4143befd349c62e99b532f4b1dc06fd888d9e2","author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"date":"2016-02-11 12:30:10.000000000","message":"Patch Set 3: Code-Review-1\n\n(4 comments)\n\nswift --debug \u003ccmd\u003e is really useful for scraping a curl command, so while I understand the need to obfuscate tokens in logging in some circumstances, I wonder if it is worth allowing plaintext tokens in other circumstance such as the command line --debug/--info options.\n\nAgree with Tim that truncation would be preferable. As well as correlating logs, it also means that if I have to use swift_auth to fetch a token and then paste it over the obfuscated token in a curl command, I get some confidence that I have the correct token, since the start would match. (Of course, in less quick and dirty situation I use an env var, but...)\n\nAlso if I am debugging failed auth, then it will be really useful to compare the token swiftclient is using vs one I get from keystone if the former is just truncated.","accounts_in_message":[],"_revision_number":3},{"id":"977d0213f78080239de58b2cffff51d08215ef72","author":{"_account_id":330,"name":"John Dickinson","email":"me@not.mn","username":"notmyname"},"date":"2016-02-18 18:04:39.000000000","message":"Patch Set 3:\n\nwe need to resolve this approach vs https://review.openstack.org/#/c/194884","accounts_in_message":[],"_revision_number":3},{"id":"bed6d0475c51feddbdf0f0a686b67f984022336a","author":{"_account_id":11373,"name":"Bing Hu","email":"hubingsh@cn.ibm.com","username":"hubingsh"},"date":"2016-02-19 05:02:00.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"b91152a3ada09e68c5acbf0711c2fe7b1353e4a1","author":{"_account_id":11373,"name":"Bing Hu","email":"hubingsh@cn.ibm.com","username":"hubingsh"},"date":"2016-02-19 05:12:25.000000000","message":"Uploaded patch set 5: Commit message was updated.","accounts_in_message":[],"_revision_number":5},{"id":"67fa2d1efd1bf58f0f88f3c29a93eec0252e6449","author":{"_account_id":11373,"name":"Bing Hu","email":"hubingsh@cn.ibm.com","username":"hubingsh"},"date":"2016-02-19 05:16:37.000000000","message":"Uploaded patch set 6: Commit message was updated.","accounts_in_message":[],"_revision_number":6},{"id":"e9976d06b13da2966e1e671b201a8e7878f26d89","author":{"_account_id":11373,"name":"Bing Hu","email":"hubingsh@cn.ibm.com","username":"hubingsh"},"date":"2016-02-19 05:22:17.000000000","message":"Patch Set 6:\n\n\u003e Uploaded patch set 6: Commit message was updated.\n\n truncate the token  instead of hash","accounts_in_message":[],"_revision_number":6},{"id":"72f7cdbba40635bb23b92dfee31ffb9a07832639","author":{"_account_id":11373,"name":"Bing Hu","email":"hubingsh@cn.ibm.com","username":"hubingsh"},"date":"2016-02-19 05:35:00.000000000","message":"Patch Set 6:\n\ntest appended","accounts_in_message":[],"_revision_number":6},{"id":"fab2e661d2e61bac1bc482ad32608caecb94fee9","author":{"_account_id":11373,"name":"Bing Hu","email":"hubingsh@cn.ibm.com","username":"hubingsh"},"date":"2016-02-19 05:47:00.000000000","message":"Patch Set 6:\n\n\u003e Uploaded patch set 3: Commit message was updated.","accounts_in_message":[],"_revision_number":6},{"id":"ba47a02a9015a6865aca29ef0d39dc308a70bd5f","author":{"_account_id":11373,"name":"Bing Hu","email":"hubingsh@cn.ibm.com","username":"hubingsh"},"date":"2016-02-19 05:49:28.000000000","message":"Patch Set 6:\n\n\u003e (3 comments)\n \u003e \n \u003e Needs tests.\n\ndone","accounts_in_message":[],"_revision_number":6},{"id":"d50658bf0c6b57b6ead7304d4b4b6f1aeb1e990e","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-02-19 06:08:01.000000000","message":"Patch Set 6: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-swiftclient-pep8 http://logs.openstack.org/73/259273/6/check/gate-python-swiftclient-pep8/d94ece8/ : SUCCESS in 32s\n- gate-python-swiftclient-docs http://docs-draft.openstack.org/73/259273/6/check/gate-python-swiftclient-docs/0e97b0b//doc/build/html/ : SUCCESS in 39s\n- gate-python-swiftclient-python27 http://logs.openstack.org/73/259273/6/check/gate-python-swiftclient-python27/857cb95/ : SUCCESS in 49s\n- gate-python-swiftclient-python34 http://logs.openstack.org/73/259273/6/check/gate-python-swiftclient-python34/65efc2a/ : SUCCESS in 3m 19s\n- gate-python-swiftclient-pypy http://logs.openstack.org/73/259273/6/check/gate-python-swiftclient-pypy/5dc1dee/ : SUCCESS in 1m 17s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-swiftclient http://logs.openstack.org/73/259273/6/check/gate-tempest-dsvm-neutron-src-python-swiftclient/0928244/ : SUCCESS in 45m 52s\n- gate-swift-dsvm-functional http://logs.openstack.org/73/259273/6/check/gate-swift-dsvm-functional/140d7dd/ : SUCCESS in 23m 30s\n- gate-swiftclient-dsvm-functional http://logs.openstack.org/73/259273/6/check/gate-swiftclient-dsvm-functional/f0fb355/ : SUCCESS in 14m 37s","accounts_in_message":[],"_revision_number":6},{"id":"f08bfd3ae832e8e2abd3ce696b20ad70547c7ee1","author":{"_account_id":9216,"name":"Joel Wright","email":"joel.wright@gmail.com","username":"jjw-sohonet"},"date":"2016-02-19 15:02:30.000000000","message":"Patch Set 6:\n\nI have attempted to combine both approaches to bug #1516692 in a new patch here: https://review.openstack.org/#/c/282363","accounts_in_message":[],"_revision_number":6},{"id":"e3e107f1f1367ccbe29f836a9fa2160284b024ca","author":{"_account_id":11373,"name":"Bing Hu","email":"hubingsh@cn.ibm.com","username":"hubingsh"},"date":"2016-02-19 15:26:12.000000000","message":"Patch Set 6:\n\n\u003e I have attempted to combine both approaches to bug #1516692 in a\n \u003e new patch here: https://review.openstack.org/#/c/282363\n\n@Joel, okay, thanks.\nI just graduate from school, don\u0027t have so much experience on python\nand swift. And this launchpad account is my friend\u0027s. :)\nSorry for leaving this bug unresolved such a long time.\n\nI am trying to learn more about python and swift,\nso that I can fix bugs easier. :)\n\nIs there any thing should I do on this patch? close it?","accounts_in_message":[],"_revision_number":6},{"id":"e85a5ec168e40caea2367ca6482802f98a920f50","author":{"_account_id":9216,"name":"Joel Wright","email":"joel.wright@gmail.com","username":"jjw-sohonet"},"date":"2016-02-19 17:26:31.000000000","message":"Patch Set 6:\n\nThanks for the patch, contributions are always welcome! A large part of the one I created was taken from your patch, but we are under some time pressure to release a new version of the swiftclient and we had 2 competing patches to solve this bug, so I thought it would be quickest to create a new one.\n\nPlease will you review https://review.openstack.org/#/c/282363 and leave comments.","accounts_in_message":[],"_revision_number":6},{"id":"d299dd845fe99c516207e68c148ddbe5fc2ba8ff","author":{"_account_id":9216,"name":"Joel Wright","email":"joel.wright@gmail.com","username":"jjw-sohonet"},"date":"2016-02-19 23:31:54.000000000","message":"Patch Set 6:\n\nPlease can I have the real name/contact details of this patch author so that I can properly attribute co-authorship on the new patch.","accounts_in_message":[],"_revision_number":6},{"id":"017ef164939ea6d65eee7367dd65c12e0800ca97","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-02-25 01:54:22.000000000","message":"Patch Set 6: Verified-1\n\nMerge Failed.\n\nThis change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.","accounts_in_message":[],"_revision_number":6},{"id":"44e37bf21ac6126dbf19b759a63af39f8c3784d6","author":{"_account_id":11373,"name":"Bing Hu","email":"hubingsh@cn.ibm.com","username":"hubingsh"},"date":"2016-02-26 17:11:50.000000000","message":"Abandoned\n\nthis bug has been fixed in https://review.openstack.org/#/c/282363","accounts_in_message":[],"_revision_number":6}],"current_revision_number":6,"current_revision":"0c0a1a9afa7350de0c4b77c7515a526d1088c477","revisions":{"9b9a8341b515a925152d32440fecd765fcd40c79":{"kind":"REWORK","_number":1,"created":"2015-12-18 04:17:04.000000000","uploader":{"_account_id":11373,"name":"Bing Hu","email":"hubingsh@cn.ibm.com","username":"hubingsh"},"ref":"refs/changes/73/259273/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-swiftclient","ref":"refs/changes/73/259273/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/73/259273/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/73/259273/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/73/259273/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-swiftclient refs/changes/73/259273/1"}}},"commit":{"parents":[{"commit":"3f1c304e3b4b38ed9525e88c193ed84305247780","subject":"Merge \"Test \u0027string\u0027 behaviour of get_object\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/3f1c304e3b4b38ed9525e88c193ed84305247780"}]}],"author":{"name":"Hu Bing","email":"hubingsh@cn.ibm.com","date":"2015-12-18 03:24:31.000000000","tz":480},"committer":{"name":"Hu Bing","email":"hubingsh@cn.ibm.com","date":"2015-12-18 04:16:02.000000000","tz":480},"subject":"ecnode auth token in swiftclient log message Closes-bug:#1516692","message":"ecnode auth token in swiftclient log message\nCloses-bug:#1516692\n\nChange-Id: Ifaa468e489a31b3ede5fa8ad30c7b0717345e11b\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/9b9a8341b515a925152d32440fecd765fcd40c79"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/9b9a8341b515a925152d32440fecd765fcd40c79"}]},"branch":"refs/heads/master"},"56828b4737f25074520821d247ce1f46fb006896":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2016-01-16 01:48:58.000000000","uploader":{"_account_id":11373,"name":"Bing Hu","email":"hubingsh@cn.ibm.com","username":"hubingsh"},"ref":"refs/changes/73/259273/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-swiftclient","ref":"refs/changes/73/259273/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/73/259273/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/73/259273/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/73/259273/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-swiftclient refs/changes/73/259273/2"}}},"commit":{"parents":[{"commit":"64c2c2eaaae630da67653aaf18ad9ea319af1baa","subject":"Merge \"Fix the http request headers being overwritten in logging\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/64c2c2eaaae630da67653aaf18ad9ea319af1baa"}]}],"author":{"name":"Hu Bing","email":"hubingsh@cn.ibm.com","date":"2015-12-18 03:24:31.000000000","tz":480},"committer":{"name":"Hu Bing","email":"hubingsh@cn.ibm.com","date":"2016-01-16 01:48:17.000000000","tz":480},"subject":"ecnode auth token in swiftclient log message Closes-bug:#1516692","message":"ecnode auth token in swiftclient log message\nCloses-bug:#1516692\n\nChange-Id: Ifaa468e489a31b3ede5fa8ad30c7b0717345e11b\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/56828b4737f25074520821d247ce1f46fb006896"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/56828b4737f25074520821d247ce1f46fb006896"}]},"branch":"refs/heads/master"},"eb9eb6db803911e544d80975511d993746d7fcfb":{"kind":"NO_CODE_CHANGE","_number":3,"created":"2016-01-30 04:47:26.000000000","uploader":{"_account_id":11373,"name":"Bing Hu","email":"hubingsh@cn.ibm.com","username":"hubingsh"},"ref":"refs/changes/73/259273/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-swiftclient","ref":"refs/changes/73/259273/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/73/259273/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/73/259273/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/73/259273/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-swiftclient refs/changes/73/259273/3"}}},"commit":{"parents":[{"commit":"64c2c2eaaae630da67653aaf18ad9ea319af1baa","subject":"Merge \"Fix the http request headers being overwritten in logging\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/64c2c2eaaae630da67653aaf18ad9ea319af1baa"}]}],"author":{"name":"Hu Bing","email":"hubingsh@cn.ibm.com","date":"2015-12-18 03:24:31.000000000","tz":480},"committer":{"name":"Hu Bing","email":"hubingsh@cn.ibm.com","date":"2016-01-30 04:44:59.000000000","tz":480},"subject":"ecnode auth token in swiftclient log message","message":"ecnode auth token in swiftclient log message\n\nswiftclient logs sensitive info in headers when logging http requests in debug mode.\nthis patch is to hash sensitive info in headers such as \u0027X-Auth-Token\u0027\n\nCloses-bug:#1516692\n\nChange-Id: Ifaa468e489a31b3ede5fa8ad30c7b0717345e11b\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/eb9eb6db803911e544d80975511d993746d7fcfb"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/eb9eb6db803911e544d80975511d993746d7fcfb"}]},"branch":"refs/heads/master"},"9cb74fdc775ed9e70a989e594b37bda183f2a986":{"kind":"REWORK","_number":4,"created":"2016-02-19 05:02:00.000000000","uploader":{"_account_id":11373,"name":"Bing Hu","email":"hubingsh@cn.ibm.com","username":"hubingsh"},"ref":"refs/changes/73/259273/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-swiftclient","ref":"refs/changes/73/259273/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/73/259273/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/73/259273/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/73/259273/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-swiftclient refs/changes/73/259273/4"}}},"commit":{"parents":[{"commit":"64c2c2eaaae630da67653aaf18ad9ea319af1baa","subject":"Merge \"Fix the http request headers being overwritten in logging\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/64c2c2eaaae630da67653aaf18ad9ea319af1baa"}]}],"author":{"name":"Hu Bing","email":"hubingsh@cn.ibm.com","date":"2015-12-18 03:24:31.000000000","tz":480},"committer":{"name":"Hu Bing","email":"hubingsh@cn.ibm.com","date":"2016-02-19 05:01:21.000000000","tz":480},"subject":"ecnode auth token in swiftclient log message","message":"ecnode auth token in swiftclient log message\n\nswiftclient logs sensitive info in headers when logging http requests in debug mode.\nthis patch is to hash sensitive info in headers such as \u0027X-Auth-Token\u0027\n\nCloses-bug:#1516692\n\nChange-Id: Ifaa468e489a31b3ede5fa8ad30c7b0717345e11b\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/9cb74fdc775ed9e70a989e594b37bda183f2a986"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/9cb74fdc775ed9e70a989e594b37bda183f2a986"}]},"branch":"refs/heads/master"},"a2dc993fede1bb9e905a8b368404fa79f54c7fc7":{"kind":"NO_CODE_CHANGE","_number":5,"created":"2016-02-19 05:12:25.000000000","uploader":{"_account_id":11373,"name":"Bing Hu","email":"hubingsh@cn.ibm.com","username":"hubingsh"},"ref":"refs/changes/73/259273/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-swiftclient","ref":"refs/changes/73/259273/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/73/259273/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/73/259273/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/73/259273/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-swiftclient refs/changes/73/259273/5"}}},"commit":{"parents":[{"commit":"64c2c2eaaae630da67653aaf18ad9ea319af1baa","subject":"Merge \"Fix the http request headers being overwritten in logging\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/64c2c2eaaae630da67653aaf18ad9ea319af1baa"}]}],"author":{"name":"Hu Bing","email":"hubingsh@cn.ibm.com","date":"2015-12-18 03:24:31.000000000","tz":480},"committer":{"name":"Hu Bing","email":"hubingsh@cn.ibm.com","date":"2016-02-19 05:06:37.000000000","tz":480},"subject":"ecnode auth token in swiftclient log message","message":"ecnode auth token in swiftclient log message\n\nswiftclient logs sensitive info in headers when logging http requests\nin debug mode.\nthis patch is to hide sensitive info in headers such as \u0027X-Auth-Token\u0027\n\nwith this patch, debug info likes lines follow (replace some chars with\nstar char *)\n\nDEBUG:swiftclient:RESP HEADERS:\n[(\u0027Content-Length\u0027, \u00270\u0027),\n(\u0027X-Trans-Id\u0027, \u0027tx3cb474794ed84c65a1907-0056c6a2ad\u0027),\n(\u0027X-Auth-Token-Expires\u0027, \u002777809\u0027),\n(\u0027X-Auth-Token\u0027, \u0027AUTH_tkee9*****************************\u0027),\n(\u0027X-Storage-Token\u0027, \u0027AUTH_tkee9*****************************\u0027),\n(\u0027Date\u0027, \u0027Fri, 19 Feb 2016 05:05:49 GMT\u0027),\n(\u0027X-Storage-Url\u0027, \u0027http://127.0.0.1:8080/v1/AUTH_admin\u0027),\n(\u0027Content-Type\u0027, \u0027text/html; charset\u003dUTF-8\u0027)]\n\nCloses-bug:#1516692\n\nChange-Id: Ifaa468e489a31b3ede5fa8ad30c7b0717345e11b\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/a2dc993fede1bb9e905a8b368404fa79f54c7fc7"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/a2dc993fede1bb9e905a8b368404fa79f54c7fc7"}]},"branch":"refs/heads/master"},"0c0a1a9afa7350de0c4b77c7515a526d1088c477":{"kind":"NO_CODE_CHANGE","_number":6,"created":"2016-02-19 05:16:37.000000000","uploader":{"_account_id":11373,"name":"Bing Hu","email":"hubingsh@cn.ibm.com","username":"hubingsh"},"ref":"refs/changes/73/259273/6","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-swiftclient","ref":"refs/changes/73/259273/6","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/73/259273/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/73/259273/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/73/259273/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-swiftclient refs/changes/73/259273/6"}}},"commit":{"parents":[{"commit":"64c2c2eaaae630da67653aaf18ad9ea319af1baa","subject":"Merge \"Fix the http request headers being overwritten in logging\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/64c2c2eaaae630da67653aaf18ad9ea319af1baa"}]}],"author":{"name":"Hu Bing","email":"hubingsh@cn.ibm.com","date":"2015-12-18 03:24:31.000000000","tz":480},"committer":{"name":"Hu Bing","email":"hubingsh@cn.ibm.com","date":"2016-02-19 05:14:14.000000000","tz":480},"subject":"encode auth token in swiftclient log message","message":"encode auth token in swiftclient log message\n\nswiftclient logs sensitive info in headers when logging http requests\nin debug mode.\nthis patch is to hide sensitive info in headers such as \u0027X-Auth-Token\u0027\n\nwith this patch, debug info likes lines follow (replace some chars with\nstar char *)\n\nDEBUG:swiftclient:RESP HEADERS:\n[(\u0027Content-Length\u0027, \u00270\u0027),\n(\u0027X-Trans-Id\u0027, \u0027tx3cb474794ed84c65a1907-0056c6a2ad\u0027),\n(\u0027X-Auth-Token-Expires\u0027, \u002777809\u0027),\n(\u0027X-Auth-Token\u0027, \u0027AUTH_tkee9*****************************\u0027),\n(\u0027X-Storage-Token\u0027, \u0027AUTH_tkee9*****************************\u0027),\n(\u0027Date\u0027, \u0027Fri, 19 Feb 2016 05:05:49 GMT\u0027),\n(\u0027X-Storage-Url\u0027, \u0027http://127.0.0.1:8080/v1/AUTH_admin\u0027),\n(\u0027Content-Type\u0027, \u0027text/html; charset\u003dUTF-8\u0027)]\n\nCloses-bug:#1516692\n\nChange-Id: Ifaa468e489a31b3ede5fa8ad30c7b0717345e11b\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/0c0a1a9afa7350de0c4b77c7515a526d1088c477"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/0c0a1a9afa7350de0c4b77c7515a526d1088c477"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}