)]}'
{"swiftclient/service.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"8a532adc0099f809ade413287ae4d7a7d50c8eb4","unresolved":false,"context_lines":[{"line_number":1909,"context_line":"                    res[\u0027manifest_response_dict\u0027] \u003d mr"},{"line_number":1910,"context_line":"                else:"},{"line_number":1911,"context_line":"                    new_object_manifest \u003d \u0027%s/%s/%s/%s/%s/\u0027 % ("},{"line_number":1912,"context_line":"                        quote(seg_container.encode(\u0027utf8\u0027)), quote(obj),"},{"line_number":1913,"context_line":"                        put_headers[\u0027x-object-meta-mtime\u0027], full_size,"},{"line_number":1914,"context_line":"                        options[\u0027segment_size\u0027])"},{"line_number":1915,"context_line":"                    if old_manifest and old_manifest.rstrip(\u0027/\u0027) \u003d\u003d \\"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa69d971_b7ef2fb0","line":1912,"range":{"start_line":1912,"start_character":67,"end_line":1912,"end_character":70},"updated":"2016-01-09 19:46:22.000000000","message":"obj needs to be encode()ed, too, right?","commit_id":"bb4ef74cf15dad0b1f882a1c0a4d21793d4fbfa6"}],"tests/unit/test_service.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"f2ec59eebd1c60e391ba41d2218bce24b5b86a33","unresolved":false,"context_lines":[{"line_number":884,"context_line":"            }"},{"line_number":885,"context_line":""},{"line_number":886,"context_line":"            s \u003d SwiftService()"},{"line_number":887,"context_line":"            r \u003d s._upload_segment_job(conn\u003dmock_conn,"},{"line_number":888,"context_line":"                                      path\u003d(f.name).encode(\u0027utf8\u0027),"},{"line_number":889,"context_line":"                                      container\u003d\u0027test_c\u0027,"},{"line_number":890,"context_line":"                                      segment_name\u003d\u0027test_s_1\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"da6ed579_e83cebc9","line":887,"range":{"start_line":887,"start_character":18,"end_line":887,"end_character":37},"updated":"2016-01-13 22:48:55.000000000","message":"From the Traceback in the linked bug, I think we may want to test _upload_object_job, rather than _upload_segment_job.\n\nThat may explain why the test still passes if I undo your change in service.py.","commit_id":"445fae6981e1b49572b2766b2371add0c1da28ce"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"e2890c699f0f3f65a99e263fdd388304fb1b4195","unresolved":false,"context_lines":[{"line_number":889,"context_line":"                                              \u0027skip_identical\u0027: False,"},{"line_number":890,"context_line":"                                              \u0027leave_segments\u0027: True,"},{"line_number":891,"context_line":"                                              \u0027header\u0027: \u0027\u0027,"},{"line_number":892,"context_line":"                                              \u0027segment_size\u0027: 0,"},{"line_number":893,"context_line":"                                              \u0027checksum\u0027: True})"},{"line_number":894,"context_line":""},{"line_number":895,"context_line":"            mtime \u003d float(r[\u0027headers\u0027][\u0027x-object-meta-mtime\u0027])"}],"source_content_type":"text/x-python","patch_set":5,"id":"da6ed579_01e00295","line":892,"range":{"start_line":892,"start_character":46,"end_line":892,"end_character":64},"updated":"2016-01-14 19:42:29.000000000","message":"With a segment_size of zero, we won\u0027t try to upload a large object, so we still aren\u0027t testing the code path we want.\n\nSomething like http://paste.openstack.org/show/483920/ would test what we want (and fail without your change to service.py), but we might want to make some assertions about the calls to the mocked-out _upload_segment_job.","commit_id":"b1f2086b7bdc1f3f643515f6804cecabce452acb"}]}