)]}'
{"id":"openstack%2Fpython-swiftclient~266906","triplet_id":"openstack%2Fpython-swiftclient~master~I90812828c5d9db0bc72c2f660e238ec1cd430a9e","project":"openstack/python-swiftclient","branch":"master","hashtags":[],"change_id":"I90812828c5d9db0bc72c2f660e238ec1cd430a9e","subject":"Replace assertEqual(*, None) with assertIsNone in tests.","status":"NEW","created":"2016-01-13 13:19:54.000000000","updated":"2017-12-18 04:32:52.000000000","submit_type":"MERGE_IF_NECESSARY","mergeable":false,"submittable":false,"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"c9f9b2b77001b5e0bb6972e349a47e50b077bdbb","_number":266906,"virtual_id_number":266906,"owner":{"_account_id":11689,"name":"Vishal kumar mahajan","email":"mahajan.vishal.mca@gmail.com","username":"vishal"},"actions":{},"labels":{"Verified":{"all":[{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"date":"2016-01-13 13:21:13.000000000","_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-01-13 13:21:13.000000000","updated_by":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"reviewer":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"state":"REVIEWER"}],"messages":[{"id":"796d2f26c1554528c375d1bc45a329f5acb99893","author":{"_account_id":11689,"name":"Vishal kumar mahajan","email":"mahajan.vishal.mca@gmail.com","username":"vishal"},"date":"2016-01-13 13:19:54.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"4732ad63bf615b9ab7ad5a05e8be77e2a0f0fdbe","author":{"_account_id":14867,"name":"Jaivish Kothari(janonymous)","email":"janonymous.codevulture@gmail.com","username":"Janonymous"},"date":"2016-01-13 13:38:53.000000000","message":"Patch Set 1: Code-Review+1\n\nLGTM","accounts_in_message":[],"_revision_number":1},{"id":"2a670e2a80b389ae24fda970441c251d3884e760","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-01-13 14:23:38.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-swiftclient-pep8 http://logs.openstack.org/06/266906/1/check/gate-python-swiftclient-pep8/24afd77/ : SUCCESS in 1m 01s\n- gate-python-swiftclient-docs http://docs-draft.openstack.org/06/266906/1/check/gate-python-swiftclient-docs/d36d098//doc/build/html/ : SUCCESS in 47s\n- gate-python-swiftclient-python27 http://logs.openstack.org/06/266906/1/check/gate-python-swiftclient-python27/087ff57/ : SUCCESS in 1m 16s\n- gate-python-swiftclient-python34 http://logs.openstack.org/06/266906/1/check/gate-python-swiftclient-python34/963fffd/ : SUCCESS in 1m 56s\n- gate-python-swiftclient-pypy http://logs.openstack.org/06/266906/1/check/gate-python-swiftclient-pypy/33906e7/ : SUCCESS in 1m 08s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-swiftclient http://logs.openstack.org/06/266906/1/check/gate-tempest-dsvm-neutron-src-python-swiftclient/438146b/ : SUCCESS in 57m 45s\n- gate-swift-dsvm-functional http://logs.openstack.org/06/266906/1/check/gate-swift-dsvm-functional/3f390bf/ : SUCCESS in 29m 07s\n- gate-swiftclient-dsvm-functional http://logs.openstack.org/06/266906/1/check/gate-swiftclient-dsvm-functional/97ea308/ : SUCCESS in 22m 08s","accounts_in_message":[],"_revision_number":1},{"id":"f09e89c7e41ab7f9983f9217b9cd90e0e84e3978","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2016-02-08 18:07:18.000000000","message":"Patch Set 1: Code-Review-1\n\nI\u0027m of two minds here. On the one hand, this feels like busywork. I don\u0027t especially care which of these are displayed; they\u0027re all clear:\n\n  AssertionError: None !\u003d \u0027foo\u0027\n  AssertionError: None is not \u0027foo\u0027\n  AssertionError: \u0027foo\u0027 is not None\n\nOn the other hand, I\u0027m in favor of consistency and only having one way to do things. However, without a hacking check to enforce this convention, we\u0027re going to have a long tail of follow-up patches (I saw Nova had four patches related to this \"bug\"!), which is decidedly worse than not doing anything. IF we want to do this, we\u0027ll need to:\n\n* Add a Depends-On: Iad65cb6399f4f933cbd9f503c88ce144387d39b5 line to the commit message.\n\n* Find a way to turn on the new (off-by-default) check without turning on all of hacking, and without turning off any of the existing checks.\n\n* Fix the two instances of self.assertNotEqual(..., None) that it picks up.","accounts_in_message":[],"_revision_number":1},{"id":"e94302550639a08fdd18c8a059e350754980bd74","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-07-27 14:08:01.000000000","message":"Patch Set 1: Verified-1\n\nMerge Failed.\n\nThis change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.","accounts_in_message":[],"_revision_number":1},{"id":"f4c7b4333016e0f5a48df1d5ffe36500d7a82d57","author":{"_account_id":14867,"name":"Jaivish Kothari(janonymous)","email":"janonymous.codevulture@gmail.com","username":"Janonymous"},"date":"2016-12-28 01:49:44.000000000","message":"Patch Set 1: -Code-Review","accounts_in_message":[],"_revision_number":1},{"id":"be62125450d9f658bd761d21052fe4d00127645c","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2017-02-20 06:44:21.000000000","message":"Removed the following votes:\n\n* Code-Review-1 by Tim Burke \u003ctim@swiftstack.com\u003e\n","accounts_in_message":[],"_revision_number":1},{"id":"c9f9b2b77001b5e0bb6972e349a47e50b077bdbb","author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"date":"2017-12-18 04:32:52.000000000","message":"Removed reviewer Jenkins with the following votes:\n\n* Verified-1 by Jenkins (3)\n","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"3bb3275fe2e712b5e89ac50366039804e37583e0","revisions":{"3bb3275fe2e712b5e89ac50366039804e37583e0":{"kind":"REWORK","_number":1,"created":"2016-01-13 13:19:54.000000000","uploader":{"_account_id":11689,"name":"Vishal kumar mahajan","email":"mahajan.vishal.mca@gmail.com","username":"vishal"},"ref":"refs/changes/06/266906/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-swiftclient","ref":"refs/changes/06/266906/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/06/266906/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/06/266906/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/06/266906/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-swiftclient refs/changes/06/266906/1"}}},"commit":{"parents":[{"commit":"6ed6c3343f73e170b259c1dc1956017da2c17620","subject":"Merge \"Retry file uploads via SwiftService\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/6ed6c3343f73e170b259c1dc1956017da2c17620"}]}],"author":{"name":"vishal mahajan","email":"vishal.mahajan@nectechnologies.in","date":"2016-01-13 13:16:55.000000000","tz":330},"committer":{"name":"vishal mahajan","email":"vishal.mahajan@nectechnologies.in","date":"2016-01-13 13:19:53.000000000","tz":330},"subject":"Replace assertEqual(*, None) with assertIsNone in tests.","message":"Replace assertEqual(*, None) with assertIsNone in tests.\n\nFor more clear messages in case of failure.\nCloses-bug: #1280522\n\nChange-Id: I90812828c5d9db0bc72c2f660e238ec1cd430a9e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/3bb3275fe2e712b5e89ac50366039804e37583e0"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/3bb3275fe2e712b5e89ac50366039804e37583e0"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"OK","labels":[{"label":"Verified","status":"MAY"},{"label":"Code-Review","status":"MAY"},{"label":"Workflow","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{"label:Verified\u003dMAX":"","label:Verified\u003dMIN":""}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","label:Code-Review\u003dMIN"],"atom_explanations":{"label:Code-Review\u003dMAX":"","label:Code-Review\u003dMIN":""}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Workflow\u003dMAX","label:Workflow\u003dMIN"],"atom_explanations":{"label:Workflow\u003dMAX":"","label:Workflow\u003dMIN":""}}}]}