)]}'
{"id":"openstack%2Fpython-swiftclient~273801","triplet_id":"openstack%2Fpython-swiftclient~master~Ib2eeb13cd07febcb7c8b4e1435b885c4339093e4","project":"openstack/python-swiftclient","branch":"master","hashtags":[],"change_id":"Ib2eeb13cd07febcb7c8b4e1435b885c4339093e4","subject":"mock time in unit test","status":"MERGED","created":"2016-01-28 22:39:15.000000000","updated":"2016-01-29 07:56:45.000000000","submitted":"2016-01-29 07:56:45.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"b00349c2baa0584eeba5ef0a72959c3e692c3b95","_number":273801,"virtual_id_number":273801,"owner":{"_account_id":16896,"name":"Ondřej Nový","email":"novy@ondrej.org","username":"onovy"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2016-01-29 07:56:45.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"value":0,"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2016-01-29 03:05:54.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"value":2,"date":"2016-01-28 23:24:26.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2016-01-29 03:05:54.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"value":0,"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-01-28 23:24:26.000000000","updated_by":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"reviewer":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"state":"REVIEWER"},{"updated":"2016-01-29 03:05:54.000000000","updated_by":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"reviewer":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"state":"REVIEWER"},{"updated":"2016-01-29 07:56:45.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"8dfd100628dc3556a494f45c341d99f44ae3ede7","author":{"_account_id":16896,"name":"Ondřej Nový","email":"novy@ondrej.org","username":"onovy"},"date":"2016-01-28 22:39:15.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"cccbb23e145b17a80852a523d5a5ae08ed5c316c","author":{"_account_id":16896,"name":"Ondřej Nový","email":"novy@ondrej.org","username":"onovy"},"date":"2016-01-28 23:19:17.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"ea6d2b1ddf96a35128680e85841ec388f3bbd7cf","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2016-01-28 23:24:26.000000000","message":"Patch Set 2: Code-Review+2\n\nSeems reasonable. I might vote for including a fraction of a second in the return_value (just to verify the rounding), but this should fix the flakey test.","accounts_in_message":[],"_revision_number":2},{"id":"41feeac771dc1033d75052de375c82d81dcfdf11","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-01-29 00:24:40.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-swiftclient-pep8 http://logs.openstack.org/01/273801/2/check/gate-python-swiftclient-pep8/ea93ba9/ : SUCCESS in 47s\n- gate-python-swiftclient-docs http://docs-draft.openstack.org/01/273801/2/check/gate-python-swiftclient-docs/f500b37//doc/build/html/ : SUCCESS in 48s\n- gate-python-swiftclient-python27 http://logs.openstack.org/01/273801/2/check/gate-python-swiftclient-python27/969f2f0/ : SUCCESS in 59s\n- gate-python-swiftclient-python34 http://logs.openstack.org/01/273801/2/check/gate-python-swiftclient-python34/11c7c91/ : SUCCESS in 1m 44s\n- gate-python-swiftclient-pypy http://logs.openstack.org/01/273801/2/check/gate-python-swiftclient-pypy/92575b7/ : SUCCESS in 1m 21s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-swiftclient http://logs.openstack.org/01/273801/2/check/gate-tempest-dsvm-neutron-src-python-swiftclient/01c601b/ : SUCCESS in 1h 01m 58s\n- gate-swift-dsvm-functional http://logs.openstack.org/01/273801/2/check/gate-swift-dsvm-functional/511d1e7/ : SUCCESS in 25m 01s\n- gate-swiftclient-dsvm-functional http://logs.openstack.org/01/273801/2/check/gate-swiftclient-dsvm-functional/21b9272/ : SUCCESS in 23m 48s","accounts_in_message":[],"_revision_number":2},{"id":"1d25408cf6a1a9b74112d820040cd4148920ba20","author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"date":"2016-01-29 01:25:05.000000000","message":"Patch Set 2: Code-Review+1\n\nThat test would make a lot more sense to me if it used a StringIO object (obviously has no mtime) instead of a tempfile whos mtime is just being ignored because we\u0027re passing it in as an open handle (I\u0027m assuming it\u0027s sane to not peek at fileobject.filename in this case to get the *real* mtime of the file).\n\nDoes this also mean that we can cleanup the rest of the Almost equal tests that are poking at tempfiles mtimes?  They *are* exactly equal right?  No one is modifying the file - we\u0027re using mtime not time for files right?  RIGHT?\n\nThe traceback in the commit message doesn\u0027t line up with the lines changed in the test - would it be possible to find an example of a failure of the test being changed?","accounts_in_message":[],"_revision_number":2},{"id":"293a6e2fb336416541b19255c0cc23726262e7e0","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2016-01-29 02:06:26.000000000","message":"Patch Set 2:\n\nClay,\n\nStringIO\u0027s a good idea. I kinda hate how much the tests hit the disk currently. (And don\u0027t even clean up after themselves! See https://review.openstack.org/#/c/269891/)\n\nThe other AlmostEquals are right, though; the mtime reported will be sub-second, while swiftclient rounds for the header. We could *also* round in the tests, but that seems less explicit.\n\nThat *is* the test from the traceback; the lines don\u0027t match because it was from 2.6.0 and we\u0027ve been adding more tests. See https://github.com/openstack/python-swiftclient/blob/2.6.0/tests/unit/test_service.py#L1085","accounts_in_message":[],"_revision_number":2},{"id":"f4170de236cef3e8168ffdcba9586ccf94b58dd0","author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"date":"2016-01-29 03:05:54.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1\n\nah, ok good wfm then [1]\n\n1. https://review.openstack.org/273854","accounts_in_message":[],"_revision_number":2},{"id":"c7b146182b49d89af5cbf05e64c4aa882c1ac4a4","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-01-29 03:06:00.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"16f3565eb89e3a6055c06f942c2e3eaa75c185d8","date":"2016-01-29 07:56:45.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":2},{"id":"b00349c2baa0584eeba5ef0a72959c3e692c3b95","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-01-29 07:56:45.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-swiftclient-docs http://docs-draft.openstack.org/01/273801/2/gate/gate-python-swiftclient-docs/0665722//doc/build/html/ : SUCCESS in 51s\n- gate-python-swiftclient-pep8 http://logs.openstack.org/01/273801/2/gate/gate-python-swiftclient-pep8/a678c18/ : SUCCESS in 50s\n- gate-python-swiftclient-python27 http://logs.openstack.org/01/273801/2/gate/gate-python-swiftclient-python27/8e7e726/ : SUCCESS in 1m 07s\n- gate-python-swiftclient-python34 http://logs.openstack.org/01/273801/2/gate/gate-python-swiftclient-python34/8d2e205/ : SUCCESS in 1m 49s\n- gate-tempest-dsvm-neutron-src-python-swiftclient http://logs.openstack.org/01/273801/2/gate/gate-tempest-dsvm-neutron-src-python-swiftclient/c52c4a5/ : SUCCESS in 59m 59s\n- gate-swift-dsvm-functional http://logs.openstack.org/01/273801/2/gate/gate-swift-dsvm-functional/ff49f6b/ : SUCCESS in 31m 24s\n- gate-swiftclient-dsvm-functional http://logs.openstack.org/01/273801/2/gate/gate-swiftclient-dsvm-functional/0dc01c3/ : SUCCESS in 24m 38s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"0fe02eb1c006d7d70f638f8012aa370fdf4b6096","revisions":{"c71cfa6bf0077f2c66c457eb681699d2b8647122":{"kind":"REWORK","_number":1,"created":"2016-01-28 22:39:15.000000000","uploader":{"_account_id":16896,"name":"Ondřej Nový","email":"novy@ondrej.org","username":"onovy"},"ref":"refs/changes/01/273801/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-swiftclient","ref":"refs/changes/01/273801/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/01/273801/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/01/273801/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/01/273801/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-swiftclient refs/changes/01/273801/1"}}},"commit":{"parents":[{"commit":"6d52264c30178ef393060d6f80f6189d9d0b44ed","subject":"Merge \"Error with uploading large object includes unicode path\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/6d52264c30178ef393060d6f80f6189d9d0b44ed"}]}],"author":{"name":"Ondřej Nový","email":"ondrej.novy@firma.seznam.cz","date":"2016-01-28 22:36:07.000000000","tz":60},"committer":{"name":"Ondřej Nový","email":"ondrej.novy@firma.seznam.cz","date":"2016-01-28 22:39:14.000000000","tz":60},"subject":"Allow higher delta in unit tests","message":"Allow higher delta in unit tests\n\nIt\u0027s crashing now (sometimes):\n\n_StringException: Traceback (most recent call last):\n  File \"/build/python-swiftclient-2.6.0/tests/unit/test_service.py\", line 1085, in test_upload_object_job_stream\n    self.assertAlmostEqual(mtime, expected_mtime, delta\u003d0.5)\n  File \"/usr/lib/python3/dist-packages/unittest2/case.py\", line 883, in assertAlmostEqual\n    raise self.failureException(msg)\nAssertionError: 1453224313.0 !\u003d 1453224312.4944572 within 0.5 delta\n\nChange-Id: Ib2eeb13cd07febcb7c8b4e1435b885c4339093e4\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/c71cfa6bf0077f2c66c457eb681699d2b8647122"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/c71cfa6bf0077f2c66c457eb681699d2b8647122"}]},"branch":"refs/heads/master"},"0fe02eb1c006d7d70f638f8012aa370fdf4b6096":{"kind":"REWORK","_number":2,"created":"2016-01-28 23:19:17.000000000","uploader":{"_account_id":16896,"name":"Ondřej Nový","email":"novy@ondrej.org","username":"onovy"},"ref":"refs/changes/01/273801/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-swiftclient","ref":"refs/changes/01/273801/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/01/273801/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/01/273801/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/01/273801/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-swiftclient refs/changes/01/273801/2"}}},"commit":{"parents":[{"commit":"6d52264c30178ef393060d6f80f6189d9d0b44ed","subject":"Merge \"Error with uploading large object includes unicode path\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/6d52264c30178ef393060d6f80f6189d9d0b44ed"}]}],"author":{"name":"Ondřej Nový","email":"ondrej.novy@firma.seznam.cz","date":"2016-01-28 22:36:07.000000000","tz":60},"committer":{"name":"Ondřej Nový","email":"ondrej.novy@firma.seznam.cz","date":"2016-01-28 23:18:28.000000000","tz":60},"subject":"mock time in unit test","message":"mock time in unit test\n\nIt\u0027s crashing now (sometimes):\n\n_StringException: Traceback (most recent call last):\n  File \"/build/python-swiftclient-2.6.0/tests/unit/test_service.py\", line 1085, in test_upload_object_job_stream\n    self.assertAlmostEqual(mtime, expected_mtime, delta\u003d0.5)\n  File \"/usr/lib/python3/dist-packages/unittest2/case.py\", line 883, in assertAlmostEqual\n    raise self.failureException(msg)\nAssertionError: 1453224313.0 !\u003d 1453224312.4944572 within 0.5 delta\n\nChange-Id: Ib2eeb13cd07febcb7c8b4e1435b885c4339093e4\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/0fe02eb1c006d7d70f638f8012aa370fdf4b6096"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/0fe02eb1c006d7d70f638f8012aa370fdf4b6096"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}