)]}'
{"swiftclient/client.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"a4834f614c1a5e92a11a5df846c1fb2d61168db2","unresolved":false,"context_lines":[{"line_number":469,"context_line":"            debug\u003ddebug,"},{"line_number":470,"context_line":"            cacert\u003dkwargs.get(\u0027cacert\u0027),"},{"line_number":471,"context_line":"            auth_url\u003dauth_url, insecure\u003dinsecure, timeout\u003dtimeout,"},{"line_number":472,"context_line":"            identity_api_version\u003dos_options.get(\u0027identity_api_version\u0027))"},{"line_number":473,"context_line":"    except exceptions.Unauthorized:"},{"line_number":474,"context_line":"        msg \u003d \u0027Unauthorized. Check username, password and tenant name/id.\u0027"},{"line_number":475,"context_line":"        if auth_version in AUTH_VERSIONS_V3:"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a5ae5dd_3a97fb91","line":472,"updated":"2016-02-03 18:28:40.000000000","message":"Is this part actually necessary? I thought _import_keystone_client handled version selection.\n\nWill keystoneclient.v2_0.client.Client accept an identity_api_version kwarg other than \"2.0\"? Will keystoneclient.v3.client.Client accept an identity_api_version kwarg other than \"3\"?","commit_id":"720c6037accd3d69bd8eb4ad70d7e39a961d839d"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"6c5abc856ba3103bee7cee2e1c182e9402e962c6","unresolved":false,"context_lines":[{"line_number":469,"context_line":"            debug\u003ddebug,"},{"line_number":470,"context_line":"            cacert\u003dkwargs.get(\u0027cacert\u0027),"},{"line_number":471,"context_line":"            auth_url\u003dauth_url, insecure\u003dinsecure, timeout\u003dtimeout,"},{"line_number":472,"context_line":"            identity_api_version\u003dos_options.get(\u0027identity_api_version\u0027))"},{"line_number":473,"context_line":"    except exceptions.Unauthorized:"},{"line_number":474,"context_line":"        msg \u003d \u0027Unauthorized. Check username, password and tenant name/id.\u0027"},{"line_number":475,"context_line":"        if auth_version in AUTH_VERSIONS_V3:"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a5ae5dd_fd771d00","line":472,"in_reply_to":"5a5ae5dd_3a97fb91","updated":"2016-02-03 18:54:04.000000000","message":"No, what was I thinking? The kwarg is harmless but not expected because we have already selected a version specific client class.","commit_id":"720c6037accd3d69bd8eb4ad70d7e39a961d839d"}],"swiftclient/shell.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"a4834f614c1a5e92a11a5df846c1fb2d61168db2","unresolved":false,"context_lines":[{"line_number":1029,"context_line":"            print(\u0027export ST_KEY\u003d%s\u0027 % sh_quote(options.key))"},{"line_number":1030,"context_line":"        else:"},{"line_number":1031,"context_line":"            print(\u0027export OS_IDENTITY_API_VERSION\u003d%s\u0027 % sh_quote("},{"line_number":1032,"context_line":"                options.auth_version))"},{"line_number":1033,"context_line":"            print(\u0027export OS_AUTH_VERSION\u003d%s\u0027 % sh_quote(options.auth_version))"},{"line_number":1034,"context_line":"            print(\u0027export OS_AUTH_URL\u003d%s\u0027 % sh_quote(options.auth))"},{"line_number":1035,"context_line":"            for k, v in sorted(_opts.items()):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a5ae5dd_f7aade18","line":1032,"updated":"2016-02-03 18:28:40.000000000","message":"Either\n\n* this should use options.os_identity_api_version, and \u0027os_identity_api_version\u0027 should be added to the exclusions below, or\n* we should just drop this entirely and let the for-loop handle it.","commit_id":"720c6037accd3d69bd8eb4ad70d7e39a961d839d"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"6c5abc856ba3103bee7cee2e1c182e9402e962c6","unresolved":false,"context_lines":[{"line_number":1029,"context_line":"            print(\u0027export ST_KEY\u003d%s\u0027 % sh_quote(options.key))"},{"line_number":1030,"context_line":"        else:"},{"line_number":1031,"context_line":"            print(\u0027export OS_IDENTITY_API_VERSION\u003d%s\u0027 % sh_quote("},{"line_number":1032,"context_line":"                options.auth_version))"},{"line_number":1033,"context_line":"            print(\u0027export OS_AUTH_VERSION\u003d%s\u0027 % sh_quote(options.auth_version))"},{"line_number":1034,"context_line":"            print(\u0027export OS_AUTH_URL\u003d%s\u0027 % sh_quote(options.auth))"},{"line_number":1035,"context_line":"            for k, v in sorted(_opts.items()):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a5ae5dd_bd04457e","line":1032,"in_reply_to":"5a5ae5dd_f7aade18","updated":"2016-02-03 18:54:04.000000000","message":"yes, i completely missed the duplication here. thanks","commit_id":"720c6037accd3d69bd8eb4ad70d7e39a961d839d"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"a4834f614c1a5e92a11a5df846c1fb2d61168db2","unresolved":false,"context_lines":[{"line_number":1118,"context_line":"        options.auth_version \u003d options.os_identity_api_version"},{"line_number":1119,"context_line":""},{"line_number":1120,"context_line":"    if options.auth_version \u003d\u003d \u00273.0\u0027:"},{"line_number":1121,"context_line":"        # tolerate sloppy auth_version"},{"line_number":1122,"context_line":"        options.auth_version \u003d \u00273\u0027"},{"line_number":1123,"context_line":""},{"line_number":1124,"context_line":"    if (not (options.auth and options.user and options.key)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a5ae5dd_ba88cb23","line":1121,"updated":"2016-02-03 18:28:40.000000000","message":"Should we also clean up os_identity_api_version, if present? What does keystoneclient expect?","commit_id":"720c6037accd3d69bd8eb4ad70d7e39a961d839d"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"6c5abc856ba3103bee7cee2e1c182e9402e962c6","unresolved":false,"context_lines":[{"line_number":1118,"context_line":"        options.auth_version \u003d options.os_identity_api_version"},{"line_number":1119,"context_line":""},{"line_number":1120,"context_line":"    if options.auth_version \u003d\u003d \u00273.0\u0027:"},{"line_number":1121,"context_line":"        # tolerate sloppy auth_version"},{"line_number":1122,"context_line":"        options.auth_version \u003d \u00273\u0027"},{"line_number":1123,"context_line":""},{"line_number":1124,"context_line":"    if (not (options.auth and options.user and options.key)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a5ae5dd_7d356d44","line":1121,"in_reply_to":"5a5ae5dd_ba88cb23","updated":"2016-02-03 18:54:04.000000000","message":"probably. But based on your comment in client.py I need to re-consider how far os-identity-api-version gets propagated","commit_id":"720c6037accd3d69bd8eb4ad70d7e39a961d839d"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"6a1f3e3be5d9acf1afae38bdc9c0fb2aee223cf7","unresolved":false,"context_lines":[{"line_number":1283,"context_line":"                                                   \u00271.0\u0027)))),"},{"line_number":1284,"context_line":"                      type\u003dstr,"},{"line_number":1285,"context_line":"                      help\u003d\u0027Specify a version for authentication. \u0027"},{"line_number":1286,"context_line":"                           \u0027Defaults to env[OS_AUTH_VERSION] or \u0027"},{"line_number":1287,"context_line":"                           \u0027os[OS_IDENTITY_API_VERSION] or 1.0.\u0027)"},{"line_number":1288,"context_line":"    parser.add_option(\u0027-U\u0027, \u0027--user\u0027, dest\u003d\u0027user\u0027,"},{"line_number":1289,"context_line":"                      default\u003denviron.get(\u0027ST_USER\u0027),"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a5ae5dd_136aea1a","line":1286,"updated":"2016-02-04 19:54:03.000000000","message":"Should this mention ST_AUTH_VERSION? I think I prefer it as it is (it\u0027s already kinda wordy), but wanted to point out that it\u0027s technically missing.","commit_id":"4041d7037f75ba8f41cd852781a919b670f88590"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"8179b0e43add21d26c345742a2273e888e1d0dcb","unresolved":false,"context_lines":[{"line_number":1283,"context_line":"                                                   \u00271.0\u0027)))),"},{"line_number":1284,"context_line":"                      type\u003dstr,"},{"line_number":1285,"context_line":"                      help\u003d\u0027Specify a version for authentication. \u0027"},{"line_number":1286,"context_line":"                           \u0027Defaults to env[OS_AUTH_VERSION] or \u0027"},{"line_number":1287,"context_line":"                           \u0027os[OS_IDENTITY_API_VERSION] or 1.0.\u0027)"},{"line_number":1288,"context_line":"    parser.add_option(\u0027-U\u0027, \u0027--user\u0027, dest\u003d\u0027user\u0027,"},{"line_number":1289,"context_line":"                      default\u003denviron.get(\u0027ST_USER\u0027),"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a5ae5dd_ac65951e","line":1286,"in_reply_to":"5a5ae5dd_136aea1a","updated":"2016-02-05 11:12:48.000000000","message":"It should, and as much as I agree with you about the verbosity, we should include it for the sake of the user. Auth options are confusing enough without the usage message being incomplete.","commit_id":"4041d7037f75ba8f41cd852781a919b670f88590"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"8179b0e43add21d26c345742a2273e888e1d0dcb","unresolved":false,"context_lines":[{"line_number":1284,"context_line":"                      type\u003dstr,"},{"line_number":1285,"context_line":"                      help\u003d\u0027Specify a version for authentication. \u0027"},{"line_number":1286,"context_line":"                           \u0027Defaults to env[OS_AUTH_VERSION] or \u0027"},{"line_number":1287,"context_line":"                           \u0027os[OS_IDENTITY_API_VERSION] or 1.0.\u0027)"},{"line_number":1288,"context_line":"    parser.add_option(\u0027-U\u0027, \u0027--user\u0027, dest\u003d\u0027user\u0027,"},{"line_number":1289,"context_line":"                      default\u003denviron.get(\u0027ST_USER\u0027),"},{"line_number":1290,"context_line":"                      help\u003d\u0027User name for obtaining an auth token.\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a5ae5dd_2c7a05be","line":1287,"updated":"2016-02-05 11:12:48.000000000","message":"Argh s/os/env/","commit_id":"4041d7037f75ba8f41cd852781a919b670f88590"}],"tests/unit/test_shell.py":[{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"8179b0e43add21d26c345742a2273e888e1d0dcb","unresolved":false,"context_lines":[{"line_number":1424,"context_line":"        opts \u003d {\"auth_version\": \"2.0\"}"},{"line_number":1425,"context_line":"        os_opts \u003d {\"password\": \"secret\","},{"line_number":1426,"context_line":"                   \"username\": \"user\","},{"line_number":1427,"context_line":"                   \"auth_url\": \"http://example.com:5000/v3\"}"},{"line_number":1428,"context_line":"        args \u003d _make_args(\"stat\", opts, os_opts, \u0027_\u0027)"},{"line_number":1429,"context_line":"        result \u003d [None, None]"},{"line_number":1430,"context_line":"        fake_command \u003d self._make_fake_command(result)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a5ae5dd_3713325d","line":1427,"updated":"2016-02-05 11:12:48.000000000","message":"there is no os-identity-api-version option specified for the test, so auth-version has nothing to override","commit_id":"4041d7037f75ba8f41cd852781a919b670f88590"}]}