)]}'
{"id":"openstack%2Fpython-swiftclient~282363","triplet_id":"openstack%2Fpython-swiftclient~master~I43dd7254f7281d4db59b286aa2145643c64e1705","project":"openstack/python-swiftclient","branch":"master","topic":"bug/1516692","hashtags":[],"change_id":"I43dd7254f7281d4db59b286aa2145643c64e1705","subject":"Do not reveal auth token in swiftclient log messages by default","status":"MERGED","created":"2016-02-19 14:54:35.000000000","updated":"2016-02-25 01:49:07.000000000","submitted":"2016-02-25 01:49:06.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":13,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"f5ae2042c76c27ec0e542e2ade5cf1c9fbe76078","_number":282363,"virtual_id_number":282363,"owner":{"_account_id":9216,"name":"Joel Wright","email":"joel.wright@gmail.com","username":"jjw-sohonet"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":9216,"name":"Joel Wright","email":"joel.wright@gmail.com","username":"jjw-sohonet"},{"value":2,"date":"2016-02-25 01:49:06.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},{"value":0,"_account_id":330,"name":"John Dickinson","email":"me@not.mn","username":"notmyname"},{"value":0,"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"value":0,"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":330,"name":"John Dickinson","email":"me@not.mn","username":"notmyname"},"all":[{"value":0,"_account_id":9216,"name":"Joel Wright","email":"joel.wright@gmail.com","username":"jjw-sohonet"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},{"value":2,"date":"2016-02-25 00:26:33.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":330,"name":"John Dickinson","email":"me@not.mn","username":"notmyname"},{"value":0,"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"value":2,"date":"2016-02-25 00:36:40.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"all":[{"value":0,"_account_id":9216,"name":"Joel Wright","email":"joel.wright@gmail.com","username":"jjw-sohonet"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},{"value":0,"_account_id":330,"name":"John Dickinson","email":"me@not.mn","username":"notmyname"},{"value":0,"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"value":1,"date":"2016-02-25 00:36:40.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":330,"name":"John Dickinson","email":"me@not.mn","username":"notmyname"},{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},{"_account_id":9216,"name":"Joel Wright","email":"joel.wright@gmail.com","username":"jjw-sohonet"},{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-02-19 15:23:00.000000000","updated_by":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"reviewer":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"state":"REVIEWER"},{"updated":"2016-02-19 18:11:14.000000000","updated_by":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"reviewer":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"state":"REVIEWER"},{"updated":"2016-02-25 00:26:33.000000000","updated_by":{"_account_id":330,"name":"John Dickinson","email":"me@not.mn","username":"notmyname"},"reviewer":{"_account_id":330,"name":"John Dickinson","email":"me@not.mn","username":"notmyname"},"state":"REVIEWER"},{"updated":"2016-02-25 00:36:40.000000000","updated_by":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"reviewer":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"state":"REVIEWER"},{"updated":"2016-02-25 01:49:06.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"1e2bd517dc2651ee22cc0a20754b2b033f4bd1a4","author":{"_account_id":9216,"name":"Joel Wright","email":"joel.wright@gmail.com","username":"jjw-sohonet"},"date":"2016-02-19 14:54:35.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"d9170051b3eca01c8de49525687a93dae3aca4bf","author":{"_account_id":9216,"name":"Joel Wright","email":"joel.wright@gmail.com","username":"jjw-sohonet"},"date":"2016-02-19 14:59:30.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"09e2fcce40ab389019c79844cb991f773dbf849e","author":{"_account_id":9216,"name":"Joel Wright","email":"joel.wright@gmail.com","username":"jjw-sohonet"},"date":"2016-02-19 15:05:28.000000000","message":"Patch Set 2:\n\nThis is a combination of patches 194884 and 259273, with the additional feature of allowing the truncation of tokens to be configured. By default programmatic use of the swiftclient.client and swiftclient.service code should no longer log sensitive information, but CLI use of --debug will still print complete and usable curl commands to the console.","accounts_in_message":[],"_revision_number":2},{"id":"d3d6708b1e54cdefccf38b2a391f5e7db8187058","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-02-19 16:01:39.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-swiftclient-pep8 http://logs.openstack.org/63/282363/2/check/gate-python-swiftclient-pep8/37ffe4b/ : SUCCESS in 47s\n- gate-python-swiftclient-docs http://docs-draft.openstack.org/63/282363/2/check/gate-python-swiftclient-docs/727d8a8//doc/build/html/ : SUCCESS in 1m 03s\n- gate-python-swiftclient-python27 http://logs.openstack.org/63/282363/2/check/gate-python-swiftclient-python27/050b9d2/ : SUCCESS in 1m 00s\n- gate-python-swiftclient-python34 http://logs.openstack.org/63/282363/2/check/gate-python-swiftclient-python34/8e8b590/ : FAILURE in 40m 07s\n- gate-python-swiftclient-pypy http://logs.openstack.org/63/282363/2/check/gate-python-swiftclient-pypy/78ad193/ : SUCCESS in 1m 35s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-swiftclient http://logs.openstack.org/63/282363/2/check/gate-tempest-dsvm-neutron-src-python-swiftclient/5710ef1/ : SUCCESS in 1h 02m 00s\n- gate-swift-dsvm-functional http://logs.openstack.org/63/282363/2/check/gate-swift-dsvm-functional/c989b40/ : SUCCESS in 20m 45s\n- gate-swiftclient-dsvm-functional http://logs.openstack.org/63/282363/2/check/gate-swiftclient-dsvm-functional/88f89c5/ : SUCCESS in 16m 47s","accounts_in_message":[],"_revision_number":2},{"id":"7b30ea4c02efe8ebdab40663236b3b8be300b743","author":{"_account_id":9216,"name":"Joel Wright","email":"joel.wright@gmail.com","username":"jjw-sohonet"},"date":"2016-02-19 16:56:16.000000000","message":"Patch Set 2:\n\nrecheck","accounts_in_message":[],"_revision_number":2},{"id":"33cc72a0d879a6a1fdec7b2fbbebe5957302a200","author":{"_account_id":9216,"name":"Joel Wright","email":"joel.wright@gmail.com","username":"jjw-sohonet"},"date":"2016-02-19 17:01:03.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"052a82b9b19e3a7fa21a825675044380ff2d0591","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-02-19 18:05:19.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-swiftclient-pep8 http://logs.openstack.org/63/282363/3/check/gate-python-swiftclient-pep8/f9867a1/ : SUCCESS in 48s\n- gate-python-swiftclient-docs http://docs-draft.openstack.org/63/282363/3/check/gate-python-swiftclient-docs/bbf6ea1//doc/build/html/ : SUCCESS in 45s\n- gate-python-swiftclient-python27 http://logs.openstack.org/63/282363/3/check/gate-python-swiftclient-python27/1321dd7/ : SUCCESS in 56s\n- gate-python-swiftclient-python34 http://logs.openstack.org/63/282363/3/check/gate-python-swiftclient-python34/fc81e69/ : SUCCESS in 1m 58s\n- gate-python-swiftclient-pypy http://logs.openstack.org/63/282363/3/check/gate-python-swiftclient-pypy/247d62a/ : SUCCESS in 1m 37s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-swiftclient http://logs.openstack.org/63/282363/3/check/gate-tempest-dsvm-neutron-src-python-swiftclient/22dfd41/ : SUCCESS in 1h 03m 58s\n- gate-swift-dsvm-functional http://logs.openstack.org/63/282363/3/check/gate-swift-dsvm-functional/5309378/ : SUCCESS in 29m 11s\n- gate-swiftclient-dsvm-functional http://logs.openstack.org/63/282363/3/check/gate-swiftclient-dsvm-functional/b1528f8/ : SUCCESS in 24m 20s","accounts_in_message":[],"_revision_number":3},{"id":"35035ae763a45844281616e5ca03e928cee9c52f","author":{"_account_id":330,"name":"John Dickinson","email":"me@not.mn","username":"notmyname"},"date":"2016-02-19 22:43:39.000000000","message":"Patch Set 3: Code-Review-1\n\n(2 comments)\n\na couple of inline comments.\n\nalso, where should docs for this be? (I\u0027d not block this patch for that, but it needs to be thought about, especially going into the hackathon)","accounts_in_message":[],"_revision_number":3},{"id":"a658aede376db72035c418eb6e75b1d607acd2d9","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2016-02-19 23:21:53.000000000","message":"Patch Set 3: Code-Review-1\n\n(4 comments)\n\nThanks for picking this up; I really like where it\u0027s gone.","accounts_in_message":[],"_revision_number":3},{"id":"0132031a02e8140cb495d2e89716364d577efd70","author":{"_account_id":9216,"name":"Joel Wright","email":"joel.wright@gmail.com","username":"jjw-sohonet"},"date":"2016-02-19 23:29:01.000000000","message":"Patch Set 3:\n\n(4 comments)\n\nThanks for the reviews, I\u0027ll address them all first thing tomorrow morning.","accounts_in_message":[],"_revision_number":3},{"id":"3d195fbc4b2f5bd512dfe92632d056514d687df2","author":{"_account_id":9216,"name":"Joel Wright","email":"joel.wright@gmail.com","username":"jjw-sohonet"},"date":"2016-02-20 17:46:32.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"004bddfab07da950eae5e0ebbaf02f9740c18d87","author":{"_account_id":9216,"name":"Joel Wright","email":"joel.wright@gmail.com","username":"jjw-sohonet"},"date":"2016-02-20 17:53:12.000000000","message":"Patch Set 4:\n\nI\u0027ve tried to address all the comments in the latest patch.\n\nThought I\u0027d run a different approach past you - rather than truncating at a specified length, remove a specified number of characters from the end of a logged token. The case of negative values is now handled explicitly by setting to the default value if we find \u003c 0.\n\nI added the extra tokens, and put in the tempurl-keys as a further suggestion. If we decide we want to keep those we\u0027ll need to modify the key name check to be \u0027startswith\u0027, but I thought it was worth starting the discussion before implementing that.\n\nLet me know what you think about the altered approach to redaction and whether we want to avoid logging the tempurl keys and I\u0027ll push up a (hopefully) finalised version asap.\n\nAs for docs, this will have to be documented in the both the swiftclient.client docs, and swiftclient.service docs somewhere I would imagine.","accounts_in_message":[],"_revision_number":4},{"id":"6844381aedd136bb2428b6f59647df8f72049636","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-02-20 18:37:23.000000000","message":"Patch Set 4: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-swiftclient-pep8 http://logs.openstack.org/63/282363/4/check/gate-python-swiftclient-pep8/eb46769/ : SUCCESS in 45s\n- gate-python-swiftclient-docs http://docs-draft.openstack.org/63/282363/4/check/gate-python-swiftclient-docs/e3d1d49//doc/build/html/ : SUCCESS in 42s\n- gate-python-swiftclient-python27 http://logs.openstack.org/63/282363/4/check/gate-python-swiftclient-python27/6f6ce33/ : SUCCESS in 58s\n- gate-python-swiftclient-python34 http://logs.openstack.org/63/282363/4/check/gate-python-swiftclient-python34/8abbdd5/ : SUCCESS in 2m 03s\n- gate-python-swiftclient-pypy http://logs.openstack.org/63/282363/4/check/gate-python-swiftclient-pypy/b8164b4/ : SUCCESS in 1m 58s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-swiftclient http://logs.openstack.org/63/282363/4/check/gate-tempest-dsvm-neutron-src-python-swiftclient/8265db0/ : SUCCESS in 50m 44s\n- gate-swift-dsvm-functional http://logs.openstack.org/63/282363/4/check/gate-swift-dsvm-functional/d942cab/ : SUCCESS in 17m 28s\n- gate-swiftclient-dsvm-functional http://logs.openstack.org/63/282363/4/check/gate-swiftclient-dsvm-functional/4df9ef2/ : SUCCESS in 15m 32s","accounts_in_message":[],"_revision_number":4},{"id":"a4734876899afdbf166473dd541de9a7dbb9fb87","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2016-02-20 21:39:52.000000000","message":"Patch Set 4:\n\n(2 comments)\n\n\u003e rather than truncating at a specified length, remove a specified number of characters from the end of a logged token.\n\nI\u0027m not sure I like that, at least in the case of Set-Cookie. The particular auth middleware that made me suggest it only sets one cookie, but hypothetically some other auth middleware may try to set several secrets in the same header, in which case only the last one would be truncated. Even without that, cookie attributes may cause us to reveal more of the secret than was intended.\n\nI think I see why you wanted to do that, though -- to make sure we don\u0027t reveal short passwords, right? (And at 16 chars, I\u0027d expect *most* passwords to be considered \"short\".) What about truncating to min(reveal_sensitive_prefix, len(value) / 2) or something like that?\n\n\u003e and put in the tempurl-keys as a further suggestion.\n\nGood call! Love it. Since we\u0027ve only got the two sets of keys each, it might makes sense to just list them instead of moving to startswith, though. Up to you.","accounts_in_message":[],"_revision_number":4},{"id":"9af1c5bff3177b1cb50fdaeee329d9e60ee346ea","author":{"_account_id":9216,"name":"Joel Wright","email":"joel.wright@gmail.com","username":"jjw-sohonet"},"date":"2016-02-20 21:53:13.000000000","message":"Patch Set 4:\n\n(1 comment)\n\nYeah, I wasn\u0027t sure about removing a specified number of characters either, but you spotted why was doing it too :) I like your solution so I\u0027ll revert to prefix and add the min calculation.\n\nI\u0027ll also add the other tempurl keys explicitly and pop up another patch covering any other comments received by Monday morning (UK time).","accounts_in_message":[],"_revision_number":4},{"id":"512604714cc5d6ed3d89184b3972dcca0b019544","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2016-02-21 06:32:31.000000000","message":"Patch Set 4:\n\nMaybe better idea?\n\n min(len(value) / 2, len(value)**2 / 32, 16)\n\n* As a ratio of the total secret, more is removed from shorter content (5 character secrets are completely redacted).\n\n* We still never reveal more than half the secret (starting at 16 characters).\n\n* We\u0027ll still honor swift\u0027s default reveal_sensative_prefix param, eventually (starting at 32 characters).\n\nWith either min calculation, though, we should consider changing our config option to just be an on/off toggle; I feel like it\u0027ll be weird for a developer to bump up the prefix length and not see any change because all of the secrets were too short anyway.\n\nOh, and the header value should already be unicode, right? We don\u0027t have to worry about splitting up multi-byte codepoints?","accounts_in_message":[],"_revision_number":4},{"id":"586441dcb37b0be86521e0a020aaae681dee6c05","author":{"_account_id":9216,"name":"Joel Wright","email":"joel.wright@gmail.com","username":"jjw-sohonet"},"date":"2016-02-22 17:46:50.000000000","message":"Uploaded patch set 5.","accounts_in_message":[],"_revision_number":5},{"id":"569a9b5aef07caa1d5a810d01ddfe58e6c0524db","author":{"_account_id":9216,"name":"Joel Wright","email":"joel.wright@gmail.com","username":"jjw-sohonet"},"date":"2016-02-22 17:56:00.000000000","message":"Uploaded patch set 6.","accounts_in_message":[],"_revision_number":6},{"id":"f55672be41639d1ac99b41c1ce2875e83bdd220b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-02-22 18:53:15.000000000","message":"Patch Set 6: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-swiftclient-pep8 http://logs.openstack.org/63/282363/6/check/gate-python-swiftclient-pep8/9f0dd2c/ : SUCCESS in 1m 23s\n- gate-python-swiftclient-docs http://docs-draft.openstack.org/63/282363/6/check/gate-python-swiftclient-docs/7905041//doc/build/html/ : SUCCESS in 49s\n- gate-python-swiftclient-python27 http://logs.openstack.org/63/282363/6/check/gate-python-swiftclient-python27/668b7e4/ : SUCCESS in 42s\n- gate-python-swiftclient-python34 http://logs.openstack.org/63/282363/6/check/gate-python-swiftclient-python34/0efd1ff/ : SUCCESS in 1m 43s\n- gate-python-swiftclient-pypy http://logs.openstack.org/63/282363/6/check/gate-python-swiftclient-pypy/24628d4/ : SUCCESS in 1m 28s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-swiftclient http://logs.openstack.org/63/282363/6/check/gate-tempest-dsvm-neutron-src-python-swiftclient/e0eefea/ : SUCCESS in 56m 22s\n- gate-swift-dsvm-functional http://logs.openstack.org/63/282363/6/check/gate-swift-dsvm-functional/5712ed5/ : SUCCESS in 20m 00s\n- gate-swiftclient-dsvm-functional http://logs.openstack.org/63/282363/6/check/gate-swiftclient-dsvm-functional/dca1aa6/ : SUCCESS in 15m 16s","accounts_in_message":[],"_revision_number":6},{"id":"36a634c01a66848cfe547d431a2e93b5231b63a5","author":{"_account_id":330,"name":"John Dickinson","email":"me@not.mn","username":"notmyname"},"date":"2016-02-25 00:26:33.000000000","message":"Patch Set 6: Code-Review+2","accounts_in_message":[],"_revision_number":6},{"id":"4d1c388f02ee61deaa723eb0482f3d28b02cb746","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2016-02-25 00:36:40.000000000","message":"Patch Set 6: Code-Review+2 Workflow+1\n\nI\u0027ll probably have a minor docfix in a bit, but this looks great! Thanks again, Joel! (And Li Cheng and Zack!)","accounts_in_message":[],"_revision_number":6},{"id":"93fa051a3ebaa3ec9473d62dfe513dd6ddbaa97e","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-02-25 00:36:46.000000000","message":"Patch Set 6: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":6},{"id":"4217a53a52e544025ee5b3387da864d5f06f6042","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-02-25 01:49:06.000000000","message":"Patch Set 6: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-swiftclient-docs http://docs-draft.openstack.org/63/282363/6/gate/gate-python-swiftclient-docs/c989ceb//doc/build/html/ : SUCCESS in 1m 19s\n- gate-python-swiftclient-pep8 http://logs.openstack.org/63/282363/6/gate/gate-python-swiftclient-pep8/52c2d7d/ : SUCCESS in 32s\n- gate-python-swiftclient-python27 http://logs.openstack.org/63/282363/6/gate/gate-python-swiftclient-python27/8cdf93b/ : SUCCESS in 48s\n- gate-python-swiftclient-python34 http://logs.openstack.org/63/282363/6/gate/gate-python-swiftclient-python34/9d3cace/ : SUCCESS in 1m 44s\n- gate-tempest-dsvm-neutron-src-python-swiftclient http://logs.openstack.org/63/282363/6/gate/gate-tempest-dsvm-neutron-src-python-swiftclient/b67fe23/ : SUCCESS in 1h 11m 36s\n- gate-swift-dsvm-functional http://logs.openstack.org/63/282363/6/gate/gate-swift-dsvm-functional/aebf766/ : SUCCESS in 25m 10s\n- gate-swiftclient-dsvm-functional http://logs.openstack.org/63/282363/6/gate/gate-swiftclient-dsvm-functional/db5f849/ : SUCCESS in 16m 18s","accounts_in_message":[],"_revision_number":6},{"id":"128faff725ccec2713d97d0d21834a4230ccec14","date":"2016-02-25 01:49:07.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":6}],"current_revision_number":6,"current_revision":"4d44dcf36086add13d3353915c014f095ab99c6d","revisions":{"9810882caa706916dd0d9eb63df58dee72a8166d":{"kind":"REWORK","_number":1,"created":"2016-02-19 14:54:35.000000000","uploader":{"_account_id":9216,"name":"Joel Wright","email":"joel.wright@gmail.com","username":"jjw-sohonet"},"ref":"refs/changes/63/282363/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-swiftclient","ref":"refs/changes/63/282363/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/63/282363/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/63/282363/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/63/282363/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-swiftclient refs/changes/63/282363/1"}}},"commit":{"parents":[{"commit":"da0aa24f28da8508283da85b6a45e29912a927cf","subject":"Merge \"_RetryBody doesn\u0027t need to take explicit etag/content-length\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/da0aa24f28da8508283da85b6a45e29912a927cf"}]}],"author":{"name":"Joel Wright","email":"joel.wright@sohonet.com","date":"2016-02-19 13:18:15.000000000","tz":0},"committer":{"name":"Joel Wright","email":"joel.wright@sohonet.com","date":"2016-02-19 14:54:32.000000000","tz":0},"subject":"Do not reveal auth token in swiftclient log messages by default","message":"Do not reveal auth token in swiftclient log messages by default\n\nCurrently the swiftclient logs sensitive info in headers when logging\nHTTP requests. This patch hides sensitive info in headers such as\n\u0027X-Auth-Token\u0027 in a similar way to swift itself (we add a\n\u0027reveal_sensitive_prefix\u0027 configuration to the client).\n\nWith this patch, tokens are truncated at the configured length and\n\u0027...\u0027 is appended to the logged token to indicate that it has been\nredacted.\n\nChange-Id: I43dd7254f7281d4db59b286aa2145643c64e1705\nCloses-bug: #1516692\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/9810882caa706916dd0d9eb63df58dee72a8166d"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/9810882caa706916dd0d9eb63df58dee72a8166d"}]},"branch":"refs/heads/master"},"8f04513bb70705040d5e8b40c4f6160c901d7feb":{"kind":"REWORK","_number":2,"created":"2016-02-19 14:59:30.000000000","uploader":{"_account_id":9216,"name":"Joel Wright","email":"joel.wright@gmail.com","username":"jjw-sohonet"},"ref":"refs/changes/63/282363/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-swiftclient","ref":"refs/changes/63/282363/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/63/282363/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/63/282363/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/63/282363/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-swiftclient refs/changes/63/282363/2"}}},"commit":{"parents":[{"commit":"da0aa24f28da8508283da85b6a45e29912a927cf","subject":"Merge \"_RetryBody doesn\u0027t need to take explicit etag/content-length\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/da0aa24f28da8508283da85b6a45e29912a927cf"}]}],"author":{"name":"Joel Wright","email":"joel.wright@sohonet.com","date":"2016-02-19 13:18:15.000000000","tz":0},"committer":{"name":"Joel Wright","email":"joel.wright@sohonet.com","date":"2016-02-19 14:59:15.000000000","tz":0},"subject":"Do not reveal auth token in swiftclient log messages by default","message":"Do not reveal auth token in swiftclient log messages by default\n\nCurrently the swiftclient logs sensitive info in headers when logging\nHTTP requests. This patch hides sensitive info in headers such as\n\u0027X-Auth-Token\u0027 in a similar way to swift itself (we add a\n\u0027reveal_sensitive_prefix\u0027 configuration to the client).\n\nWith this patch, tokens are truncated at the configured length and\n\u0027...\u0027 is appended to the logged token to indicate that it has been\nredacted.\n\nChange-Id: I43dd7254f7281d4db59b286aa2145643c64e1705\nCloses-bug: #1516692\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/8f04513bb70705040d5e8b40c4f6160c901d7feb"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/8f04513bb70705040d5e8b40c4f6160c901d7feb"}]},"branch":"refs/heads/master"},"85552915308b6795171e72b35618a86d35038a7f":{"kind":"REWORK","_number":3,"created":"2016-02-19 17:01:03.000000000","uploader":{"_account_id":9216,"name":"Joel Wright","email":"joel.wright@gmail.com","username":"jjw-sohonet"},"ref":"refs/changes/63/282363/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-swiftclient","ref":"refs/changes/63/282363/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/63/282363/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/63/282363/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/63/282363/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-swiftclient refs/changes/63/282363/3"}}},"commit":{"parents":[{"commit":"da0aa24f28da8508283da85b6a45e29912a927cf","subject":"Merge \"_RetryBody doesn\u0027t need to take explicit etag/content-length\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/da0aa24f28da8508283da85b6a45e29912a927cf"}]}],"author":{"name":"Joel Wright","email":"joel.wright@sohonet.com","date":"2016-02-19 13:18:15.000000000","tz":0},"committer":{"name":"Joel Wright","email":"joel.wright@sohonet.com","date":"2016-02-19 17:00:53.000000000","tz":0},"subject":"Do not reveal auth token in swiftclient log messages by default","message":"Do not reveal auth token in swiftclient log messages by default\n\nCurrently the swiftclient logs sensitive info in headers when logging\nHTTP requests. This patch hides sensitive info in headers such as\n\u0027X-Auth-Token\u0027 in a similar way to swift itself (we add a\n\u0027reveal_sensitive_prefix\u0027 configuration to the client).\n\nWith this patch, tokens are truncated at the configured length and\n\u0027...\u0027 is appended to the logged token to indicate that it has been\nredacted.\n\nChange-Id: I43dd7254f7281d4db59b286aa2145643c64e1705\nCloses-bug: #1516692\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/85552915308b6795171e72b35618a86d35038a7f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/85552915308b6795171e72b35618a86d35038a7f"}]},"branch":"refs/heads/master"},"ecb59e9b647713d93dbae822c21be0b2d7d3cc82":{"kind":"REWORK","_number":4,"created":"2016-02-20 17:46:32.000000000","uploader":{"_account_id":9216,"name":"Joel Wright","email":"joel.wright@gmail.com","username":"jjw-sohonet"},"ref":"refs/changes/63/282363/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-swiftclient","ref":"refs/changes/63/282363/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/63/282363/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/63/282363/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/63/282363/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-swiftclient refs/changes/63/282363/4"}}},"commit":{"parents":[{"commit":"da0aa24f28da8508283da85b6a45e29912a927cf","subject":"Merge \"_RetryBody doesn\u0027t need to take explicit etag/content-length\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/da0aa24f28da8508283da85b6a45e29912a927cf"}]}],"author":{"name":"Joel Wright","email":"joel.wright@sohonet.com","date":"2016-02-19 13:18:15.000000000","tz":0},"committer":{"name":"Joel Wright","email":"joel.wright@sohonet.com","date":"2016-02-20 17:45:24.000000000","tz":0},"subject":"Do not reveal auth token in swiftclient log messages by default","message":"Do not reveal auth token in swiftclient log messages by default\n\nCurrently the swiftclient logs sensitive info in headers when logging\nHTTP requests. This patch hides sensitive info in headers such as\n\u0027X-Auth-Token\u0027 in a similar way to swift itself (we add a\n\u0027reveal_sensitive_prefix\u0027 configuration to the client).\n\nWith this patch, tokens are truncated by removing the specified number\nof characters, after which \u0027...\u0027 is appended to the logged token to\nindicate that it has been redacted.\n\nCo-Authored-By: Li Cheng \u003cshcli@cn.ibm.com\u003e\nCo-Authored-By: Zack M. Davis \u003czdavis@swiftstack.com\u003e\nChange-Id: I43dd7254f7281d4db59b286aa2145643c64e1705\nCloses-bug: #1516692\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/ecb59e9b647713d93dbae822c21be0b2d7d3cc82"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/ecb59e9b647713d93dbae822c21be0b2d7d3cc82"}]},"branch":"refs/heads/master"},"288618d4ad60c9ef216f38277692dc4bfdeed6b5":{"kind":"REWORK","_number":5,"created":"2016-02-22 17:46:50.000000000","uploader":{"_account_id":9216,"name":"Joel Wright","email":"joel.wright@gmail.com","username":"jjw-sohonet"},"ref":"refs/changes/63/282363/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-swiftclient","ref":"refs/changes/63/282363/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/63/282363/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/63/282363/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/63/282363/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-swiftclient refs/changes/63/282363/5"}}},"commit":{"parents":[{"commit":"da0aa24f28da8508283da85b6a45e29912a927cf","subject":"Merge \"_RetryBody doesn\u0027t need to take explicit etag/content-length\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/da0aa24f28da8508283da85b6a45e29912a927cf"}]}],"author":{"name":"Joel Wright","email":"joel.wright@sohonet.com","date":"2016-02-19 13:18:15.000000000","tz":0},"committer":{"name":"Joel Wright","email":"joel.wright@sohonet.com","date":"2016-02-22 17:46:33.000000000","tz":0},"subject":"Do not reveal auth token in swiftclient log messages by default","message":"Do not reveal auth token in swiftclient log messages by default\n\nCurrently the swiftclient logs sensitive info in headers when logging\nHTTP requests. This patch hides sensitive info in headers such as\n\u0027X-Auth-Token\u0027 in a similar way to swift itself (we add a\n\u0027reveal_sensitive_prefix\u0027 configuration to the client).\n\nWith this patch, tokens are truncated by removing the specified number\nof characters, after which \u0027...\u0027 is appended to the logged token to\nindicate that it has been redacted.\n\nCo-Authored-By: Li Cheng \u003cshcli@cn.ibm.com\u003e\nCo-Authored-By: Zack M. Davis \u003czdavis@swiftstack.com\u003e\nChange-Id: I43dd7254f7281d4db59b286aa2145643c64e1705\nCloses-bug: #1516692\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/288618d4ad60c9ef216f38277692dc4bfdeed6b5"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/288618d4ad60c9ef216f38277692dc4bfdeed6b5"}]},"branch":"refs/heads/master"},"4d44dcf36086add13d3353915c014f095ab99c6d":{"kind":"REWORK","_number":6,"created":"2016-02-22 17:56:00.000000000","uploader":{"_account_id":9216,"name":"Joel Wright","email":"joel.wright@gmail.com","username":"jjw-sohonet"},"ref":"refs/changes/63/282363/6","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-swiftclient","ref":"refs/changes/63/282363/6","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/63/282363/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/63/282363/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/63/282363/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-swiftclient refs/changes/63/282363/6"}}},"commit":{"parents":[{"commit":"da0aa24f28da8508283da85b6a45e29912a927cf","subject":"Merge \"_RetryBody doesn\u0027t need to take explicit etag/content-length\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/da0aa24f28da8508283da85b6a45e29912a927cf"}]}],"author":{"name":"Joel Wright","email":"joel.wright@sohonet.com","date":"2016-02-19 13:18:15.000000000","tz":0},"committer":{"name":"Joel Wright","email":"joel.wright@sohonet.com","date":"2016-02-22 17:55:51.000000000","tz":0},"subject":"Do not reveal auth token in swiftclient log messages by default","message":"Do not reveal auth token in swiftclient log messages by default\n\nCurrently the swiftclient logs sensitive info in headers when logging\nHTTP requests. This patch hides sensitive info in headers such as\n\u0027X-Auth-Token\u0027 in a similar way to swift itself (we add a\n\u0027reveal_sensitive_prefix\u0027 configuration to the client).\n\nWith this patch, tokens are truncated by removing the specified number\nof characters, after which \u0027...\u0027 is appended to the logged token to\nindicate that it has been redacted.\n\nCo-Authored-By: Li Cheng \u003cshcli@cn.ibm.com\u003e\nCo-Authored-By: Zack M. Davis \u003czdavis@swiftstack.com\u003e\nChange-Id: I43dd7254f7281d4db59b286aa2145643c64e1705\nCloses-bug: #1516692\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/4d44dcf36086add13d3353915c014f095ab99c6d"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/4d44dcf36086add13d3353915c014f095ab99c6d"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}