)]}'
{"id":"openstack%2Fpython-swiftclient~284822","triplet_id":"openstack%2Fpython-swiftclient~master~Id0def0b3af7a364f1257cc22f67b71c0cc5d8479","project":"openstack/python-swiftclient","branch":"master","topic":"fix-safe-logging-tests","hashtags":[],"change_id":"Id0def0b3af7a364f1257cc22f67b71c0cc5d8479","subject":"Fix test for redacting sensitive data in client.http_log()","status":"MERGED","created":"2016-02-25 17:15:44.000000000","updated":"2016-02-26 20:07:55.000000000","submitted":"2016-02-26 20:07:55.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":3,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"6269ac412291bf40b725fffa985a04f474946a46","_number":284822,"virtual_id_number":284822,"owner":{"_account_id":9216,"name":"Joel Wright","email":"joel.wright@gmail.com","username":"jjw-sohonet"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":9216,"name":"Joel Wright","email":"joel.wright@gmail.com","username":"jjw-sohonet"},{"value":2,"date":"2016-02-26 20:07:55.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},{"value":0,"_account_id":330,"name":"John Dickinson","email":"me@not.mn","username":"notmyname"},{"value":0,"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"all":[{"value":0,"_account_id":9216,"name":"Joel Wright","email":"joel.wright@gmail.com","username":"jjw-sohonet"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2016-02-26 14:05:21.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},{"value":0,"_account_id":330,"name":"John Dickinson","email":"me@not.mn","username":"notmyname"},{"value":2,"date":"2016-02-26 17:37:35.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"all":[{"value":0,"_account_id":9216,"name":"Joel Wright","email":"joel.wright@gmail.com","username":"jjw-sohonet"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},{"value":0,"_account_id":330,"name":"John Dickinson","email":"me@not.mn","username":"notmyname"},{"value":1,"date":"2016-02-26 17:36:53.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":330,"name":"John Dickinson","email":"me@not.mn","username":"notmyname"},{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},{"_account_id":9216,"name":"Joel Wright","email":"joel.wright@gmail.com","username":"jjw-sohonet"},{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-02-25 17:16:46.000000000","updated_by":{"_account_id":330,"name":"John Dickinson","email":"me@not.mn","username":"notmyname"},"reviewer":{"_account_id":330,"name":"John Dickinson","email":"me@not.mn","username":"notmyname"},"state":"REVIEWER"},{"updated":"2016-02-26 14:05:21.000000000","updated_by":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"reviewer":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"state":"REVIEWER"},{"updated":"2016-02-26 17:36:53.000000000","updated_by":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"reviewer":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"state":"REVIEWER"},{"updated":"2016-02-26 20:07:55.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"f7f3804721eb9e0573797f336a6d1e80b89ae3e4","author":{"_account_id":9216,"name":"Joel Wright","email":"joel.wright@gmail.com","username":"jjw-sohonet"},"date":"2016-02-25 17:15:44.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"25fc9e684e6b3d87fb48116e2d811731cb86e9da","author":{"_account_id":9216,"name":"Joel Wright","email":"joel.wright@gmail.com","username":"jjw-sohonet"},"date":"2016-02-25 19:10:59.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"0efad865fceaabb4c294b86a44ec08f4c8bbebc3","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2016-02-25 19:59:42.000000000","message":"Patch Set 2: Code-Review+2\n\n(2 comments)","accounts_in_message":[],"_revision_number":2},{"id":"26d3f1adacfa540d8517f0dae53481812fc6b86a","author":{"_account_id":9216,"name":"Joel Wright","email":"joel.wright@gmail.com","username":"jjw-sohonet"},"date":"2016-02-25 22:09:27.000000000","message":"Patch Set 2:\n\n(1 comment)\n\nThanks for the quick review - pretty sure it\u0027s utf8 or nothing for the metadata.\n\nquote from the swift api docs:\n\n\"The metadata values in Object Storage do not follow HTTP/1.1 rules for character encodings. You must use a UTF-8 encoding to get a byte array for any string that contains characters that are not in the 7-bit ASCII 0-127 range. Otherwise, Object Storage returns the 404 response code for ISO-8859-1 characters in the 128-255 range, which is a direct violation of the HTTP/1.1 basic rules.\"","accounts_in_message":[],"_revision_number":2},{"id":"b7401b95a82688bb456c1105a0eab072f6b06d5f","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-02-25 23:30:18.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-swiftclient-pep8 http://logs.openstack.org/22/284822/2/check/gate-python-swiftclient-pep8/f78b003/ : SUCCESS in 34s\n- gate-python-swiftclient-docs http://docs-draft.openstack.org/22/284822/2/check/gate-python-swiftclient-docs/e4447fa//doc/build/html/ : SUCCESS in 42s\n- gate-python-swiftclient-python27 http://logs.openstack.org/22/284822/2/check/gate-python-swiftclient-python27/16eb34d/ : SUCCESS in 43s\n- gate-python-swiftclient-python34 http://logs.openstack.org/22/284822/2/check/gate-python-swiftclient-python34/f5056da/ : SUCCESS in 1m 52s\n- gate-python-swiftclient-pypy http://logs.openstack.org/22/284822/2/check/gate-python-swiftclient-pypy/c4d8367/ : SUCCESS in 1m 06s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-swiftclient http://logs.openstack.org/22/284822/2/check/gate-tempest-dsvm-neutron-src-python-swiftclient/e0171b9/ : SUCCESS in 1h 11m 02s\n- gate-swift-dsvm-functional http://logs.openstack.org/22/284822/2/check/gate-swift-dsvm-functional/030d10c/ : SUCCESS in 19m 18s\n- gate-swiftclient-dsvm-functional http://logs.openstack.org/22/284822/2/check/gate-swiftclient-dsvm-functional/cce76e4/ : SUCCESS in 15m 07s","accounts_in_message":[],"_revision_number":2},{"id":"1201d566cd11c564dc0105c52787115620f81657","author":{"_account_id":9216,"name":"Joel Wright","email":"joel.wright@gmail.com","username":"jjw-sohonet"},"date":"2016-02-26 11:38:34.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"9782f3928e46838574cb12a23b060ace56d3fa60","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-02-26 13:07:14.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-swiftclient-pep8 http://logs.openstack.org/22/284822/3/check/gate-python-swiftclient-pep8/febc1ad/ : SUCCESS in 49s\n- gate-python-swiftclient-docs http://docs-draft.openstack.org/22/284822/3/check/gate-python-swiftclient-docs/45da058//doc/build/html/ : SUCCESS in 39s\n- gate-python-swiftclient-python27 http://logs.openstack.org/22/284822/3/check/gate-python-swiftclient-python27/0354ad9/ : SUCCESS in 58s\n- gate-python-swiftclient-python34 http://logs.openstack.org/22/284822/3/check/gate-python-swiftclient-python34/9e1e35a/ : SUCCESS in 1m 56s\n- gate-python-swiftclient-pypy http://logs.openstack.org/22/284822/3/check/gate-python-swiftclient-pypy/99c6204/ : SUCCESS in 4m 41s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-swiftclient http://logs.openstack.org/22/284822/3/check/gate-tempest-dsvm-neutron-src-python-swiftclient/8918773/ : SUCCESS in 1h 18m 33s\n- gate-swift-dsvm-functional http://logs.openstack.org/22/284822/3/check/gate-swift-dsvm-functional/8c40277/ : SUCCESS in 21m 03s\n- gate-swiftclient-dsvm-functional http://logs.openstack.org/22/284822/3/check/gate-swiftclient-dsvm-functional/7aacbd2/ : SUCCESS in 22m 04s","accounts_in_message":[],"_revision_number":3},{"id":"18e005ccf62a5971c437059af6ac09ecca4fca90","author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"date":"2016-02-26 14:05:21.000000000","message":"Patch Set 3: Code-Review+2\n\nThanks Joel\n\nI guess with py3 the response headers are expected to be unicode, at least that\u0027s what the comment in parse_header_string suggests, but the test as it is now at least verifies that parse_header_string will morph all values to unicode whether py3 or py2.","accounts_in_message":[],"_revision_number":3},{"id":"4cf7c5591a9a793f33904b22bd6df62937be4a8d","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2016-02-26 17:36:53.000000000","message":"Patch Set 3: Workflow+1","accounts_in_message":[],"_revision_number":3},{"id":"f8eae4a9759efc3b1d853a80bd21ec84ec5bb0ac","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-02-26 17:37:15.000000000","message":"Patch Set 3: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":3},{"id":"c1dd80a29b34ade8eb1d92be24593ae465ce2df4","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2016-02-26 17:37:35.000000000","message":"Patch Set 3: Code-Review+2\n\nHuh. That Workflow+1 button really *only* does the workflow bit.","accounts_in_message":[],"_revision_number":3},{"id":"f82d58c3edf88355890478787a1c5d39e696566c","date":"2016-02-26 20:07:55.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":3},{"id":"451f1ddd7ef548e3797d6263cc94f0cecb7ae882","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-02-26 20:07:55.000000000","message":"Patch Set 3: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-swiftclient-docs http://docs-draft.openstack.org/22/284822/3/gate/gate-python-swiftclient-docs/6d2cbf3//doc/build/html/ : SUCCESS in 4m 21s\n- gate-python-swiftclient-pep8 http://logs.openstack.org/22/284822/3/gate/gate-python-swiftclient-pep8/ba1c3e7/ : SUCCESS in 54s\n- gate-python-swiftclient-python27 http://logs.openstack.org/22/284822/3/gate/gate-python-swiftclient-python27/8e523f8/ : SUCCESS in 1m 00s\n- gate-python-swiftclient-python34 http://logs.openstack.org/22/284822/3/gate/gate-python-swiftclient-python34/c501927/ : SUCCESS in 2m 47s\n- gate-tempest-dsvm-neutron-src-python-swiftclient http://logs.openstack.org/22/284822/3/gate/gate-tempest-dsvm-neutron-src-python-swiftclient/7610388/ : SUCCESS in 1h 42m 45s\n- gate-swift-dsvm-functional http://logs.openstack.org/22/284822/3/gate/gate-swift-dsvm-functional/28b8e67/ : SUCCESS in 25m 19s\n- gate-swiftclient-dsvm-functional http://logs.openstack.org/22/284822/3/gate/gate-swiftclient-dsvm-functional/0c15a7f/ : SUCCESS in 15m 15s","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"46d817828082105a69d4da53fef2f2fbefc54809","revisions":{"4ab0741be2bc3da6f03fe7b7b3b21dd41e64f59f":{"kind":"REWORK","_number":1,"created":"2016-02-25 17:15:44.000000000","uploader":{"_account_id":9216,"name":"Joel Wright","email":"joel.wright@gmail.com","username":"jjw-sohonet"},"ref":"refs/changes/22/284822/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-swiftclient","ref":"refs/changes/22/284822/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/22/284822/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/22/284822/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/22/284822/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-swiftclient refs/changes/22/284822/1"}}},"commit":{"parents":[{"commit":"0f60cf05f439521dd3098b0c83c6830537a74ba4","subject":"Merge \"Do not reveal auth token in swiftclient log messages by default\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/0f60cf05f439521dd3098b0c83c6830537a74ba4"}]}],"author":{"name":"Joel Wright","email":"joel.wright@sohonet.com","date":"2016-02-25 17:13:35.000000000","tz":0},"committer":{"name":"Joel Wright","email":"joel.wright@sohonet.com","date":"2016-02-25 17:13:35.000000000","tz":0},"subject":"Fix test for redacting sensitive data in client.http_log()","message":"Fix test for redacting sensitive data in client.http_log()\n\nThe test should have included utf8 encoded unicode data to\ntest that encoded unicode data stored in headers was parsed\ncorrectly.\n\nChange-Id: Id0def0b3af7a364f1257cc22f67b71c0cc5d8479\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/4ab0741be2bc3da6f03fe7b7b3b21dd41e64f59f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/4ab0741be2bc3da6f03fe7b7b3b21dd41e64f59f"}]},"branch":"refs/heads/master"},"332398dd12fb30eaebbdda1d26a18714fb7740ec":{"kind":"REWORK","_number":2,"created":"2016-02-25 19:10:59.000000000","uploader":{"_account_id":9216,"name":"Joel Wright","email":"joel.wright@gmail.com","username":"jjw-sohonet"},"ref":"refs/changes/22/284822/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-swiftclient","ref":"refs/changes/22/284822/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/22/284822/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/22/284822/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/22/284822/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-swiftclient refs/changes/22/284822/2"}}},"commit":{"parents":[{"commit":"0f60cf05f439521dd3098b0c83c6830537a74ba4","subject":"Merge \"Do not reveal auth token in swiftclient log messages by default\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/0f60cf05f439521dd3098b0c83c6830537a74ba4"}]}],"author":{"name":"Joel Wright","email":"joel.wright@sohonet.com","date":"2016-02-25 17:13:35.000000000","tz":0},"committer":{"name":"Joel Wright","email":"joel.wright@sohonet.com","date":"2016-02-25 19:10:48.000000000","tz":0},"subject":"Fix test for redacting sensitive data in client.http_log()","message":"Fix test for redacting sensitive data in client.http_log()\n\nThe test should have included utf8 encoded unicode data to\ntest that encoded unicode data stored in headers was parsed\ncorrectly.\n\nAlso fixes the docstring for swiftclient.safe_value()\n\nChange-Id: Id0def0b3af7a364f1257cc22f67b71c0cc5d8479\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/332398dd12fb30eaebbdda1d26a18714fb7740ec"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/332398dd12fb30eaebbdda1d26a18714fb7740ec"}]},"branch":"refs/heads/master"},"46d817828082105a69d4da53fef2f2fbefc54809":{"kind":"REWORK","_number":3,"created":"2016-02-26 11:38:34.000000000","uploader":{"_account_id":9216,"name":"Joel Wright","email":"joel.wright@gmail.com","username":"jjw-sohonet"},"ref":"refs/changes/22/284822/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-swiftclient","ref":"refs/changes/22/284822/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/22/284822/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/22/284822/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/22/284822/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-swiftclient refs/changes/22/284822/3"}}},"commit":{"parents":[{"commit":"ee905477ac6fad7c43e875d7e52b22a494ef3d6f","subject":"Merge \"Follow-up to patch 282363\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/ee905477ac6fad7c43e875d7e52b22a494ef3d6f"}]}],"author":{"name":"Joel Wright","email":"joel.wright@sohonet.com","date":"2016-02-25 17:13:35.000000000","tz":0},"committer":{"name":"Joel Wright","email":"joel.wright@sohonet.com","date":"2016-02-26 11:36:45.000000000","tz":0},"subject":"Fix test for redacting sensitive data in client.http_log()","message":"Fix test for redacting sensitive data in client.http_log()\n\nThe test should have included utf8 encoded unicode data to\ntest that encoded unicode data stored in headers was parsed\ncorrectly.\n\nAlso fixes the docstring for swiftclient.safe_value()\n\nChange-Id: Id0def0b3af7a364f1257cc22f67b71c0cc5d8479\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/46d817828082105a69d4da53fef2f2fbefc54809"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/46d817828082105a69d4da53fef2f2fbefc54809"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}