)]}'
{"id":"openstack%2Fpython-swiftclient~284851","triplet_id":"openstack%2Fpython-swiftclient~master~I61fc04f32b861106ae5e08aa719d092773e71398","project":"openstack/python-swiftclient","branch":"master","topic":"bug/1544952","hashtags":[],"change_id":"I61fc04f32b861106ae5e08aa719d092773e71398","subject":"make download --prefix working correct","status":"NEW","created":"2016-02-25 18:10:39.000000000","updated":"2016-08-16 22:05:41.000000000","submit_type":"MERGE_IF_NECESSARY","mergeable":false,"submittable":false,"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"2eec2189b8acb8874216ece79936f218607ca7e1","_number":284851,"virtual_id_number":284851,"owner":{"_account_id":11373,"name":"Bing Hu","email":"hubingsh@cn.ibm.com","username":"hubingsh"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"_account_id":9216,"name":"Joel Wright","email":"joel.wright@gmail.com","username":"jjw-sohonet"},{"_account_id":20403,"name":"Cheng Li","email":"shcli@cn.ibm.com","username":"Cheng"},{"value":1,"date":"2016-02-26 20:58:47.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"date":"2016-03-03 12:47:14.000000000","_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},{"date":"2016-03-05 02:45:14.000000000","_account_id":11373,"name":"Bing Hu","email":"hubingsh@cn.ibm.com","username":"hubingsh"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"rejected":{"_account_id":9216,"name":"Joel Wright","email":"joel.wright@gmail.com","username":"jjw-sohonet"},"recommended":{"_account_id":20403,"name":"Cheng Li","email":"shcli@cn.ibm.com","username":"Cheng"},"all":[{"value":-2,"date":"2016-08-16 22:05:41.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":9216,"name":"Joel Wright","email":"joel.wright@gmail.com","username":"jjw-sohonet"},{"value":1,"date":"2016-03-27 09:36:55.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":20403,"name":"Cheng Li","email":"shcli@cn.ibm.com","username":"Cheng"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":11373,"name":"Bing Hu","email":"hubingsh@cn.ibm.com","username":"hubingsh"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":9216,"name":"Joel Wright","email":"joel.wright@gmail.com","username":"jjw-sohonet"},{"_account_id":20403,"name":"Cheng Li","email":"shcli@cn.ibm.com","username":"Cheng"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":11373,"name":"Bing Hu","email":"hubingsh@cn.ibm.com","username":"hubingsh"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},{"_account_id":9216,"name":"Joel Wright","email":"joel.wright@gmail.com","username":"jjw-sohonet"},{"_account_id":11373,"name":"Bing Hu","email":"hubingsh@cn.ibm.com","username":"hubingsh"},{"_account_id":20403,"name":"Cheng Li","email":"shcli@cn.ibm.com","username":"Cheng"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-02-26 20:58:47.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2016-03-03 12:47:14.000000000","updated_by":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"reviewer":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"state":"REVIEWER"},{"updated":"2016-03-27 09:36:55.000000000","updated_by":{"_account_id":20403,"name":"Cheng Li","email":"shcli@cn.ibm.com","username":"Cheng"},"reviewer":{"_account_id":20403,"name":"Cheng Li","email":"shcli@cn.ibm.com","username":"Cheng"},"state":"REVIEWER"},{"updated":"2016-08-16 22:05:41.000000000","updated_by":{"_account_id":9216,"name":"Joel Wright","email":"joel.wright@gmail.com","username":"jjw-sohonet"},"reviewer":{"_account_id":9216,"name":"Joel Wright","email":"joel.wright@gmail.com","username":"jjw-sohonet"},"state":"REVIEWER"}],"messages":[{"id":"785d210845e4aa1f69ed0dbd8ca57923c551ddb2","author":{"_account_id":11373,"name":"Bing Hu","email":"hubingsh@cn.ibm.com","username":"hubingsh"},"date":"2016-02-25 18:10:39.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"61b05e81ce34fa0a7297c53e7ca1b721e869c2f7","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-02-25 22:19:32.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-swiftclient-pep8 http://logs.openstack.org/51/284851/1/check/gate-python-swiftclient-pep8/5c49c47/ : SUCCESS in 40s\n- gate-python-swiftclient-docs http://docs-draft.openstack.org/51/284851/1/check/gate-python-swiftclient-docs/350437b//doc/build/html/ : SUCCESS in 48s\n- gate-python-swiftclient-python27 http://logs.openstack.org/51/284851/1/check/gate-python-swiftclient-python27/a00f3e4/ : FAILURE in 54s\n- gate-python-swiftclient-python34 http://logs.openstack.org/51/284851/1/check/gate-python-swiftclient-python34/0196011/ : FAILURE in 1m 42s\n- gate-python-swiftclient-pypy http://logs.openstack.org/51/284851/1/check/gate-python-swiftclient-pypy/e828599/ : FAILURE in 1m 33s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-swiftclient http://logs.openstack.org/51/284851/1/check/gate-tempest-dsvm-neutron-src-python-swiftclient/b36e03c/ : SUCCESS in 49m 41s\n- gate-swift-dsvm-functional http://logs.openstack.org/51/284851/1/check/gate-swift-dsvm-functional/7c377de/ : SUCCESS in 28m 14s\n- gate-swiftclient-dsvm-functional http://logs.openstack.org/51/284851/1/check/gate-swiftclient-dsvm-functional/775fd9d/ : SUCCESS in 18m 37s","accounts_in_message":[],"_revision_number":1},{"id":"7d72c3f0cd4d797eb5ec6d8de9e3734d6de12d71","author":{"_account_id":11373,"name":"Bing Hu","email":"hubingsh@cn.ibm.com","username":"hubingsh"},"date":"2016-02-26 17:03:56.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"9cbdc3c138d035d0f09270783645bd5679e23ad3","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-02-26 20:58:47.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-swiftclient-pep8 http://logs.openstack.org/51/284851/2/check/gate-python-swiftclient-pep8/15d7ad8/ : SUCCESS in 40s\n- gate-python-swiftclient-docs http://docs-draft.openstack.org/51/284851/2/check/gate-python-swiftclient-docs/78f412c//doc/build/html/ : SUCCESS in 37s\n- gate-python-swiftclient-python27 http://logs.openstack.org/51/284851/2/check/gate-python-swiftclient-python27/36e172e/ : SUCCESS in 42s\n- gate-python-swiftclient-python34 http://logs.openstack.org/51/284851/2/check/gate-python-swiftclient-python34/3e97d05/ : SUCCESS in 1m 59s\n- gate-python-swiftclient-pypy http://logs.openstack.org/51/284851/2/check/gate-python-swiftclient-pypy/3dac379/ : SUCCESS in 1m 24s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-swiftclient http://logs.openstack.org/51/284851/2/check/gate-tempest-dsvm-neutron-src-python-swiftclient/f31fc8d/ : SUCCESS in 1h 03m 37s\n- gate-swift-dsvm-functional http://logs.openstack.org/51/284851/2/check/gate-swift-dsvm-functional/7b2096f/ : SUCCESS in 18m 59s\n- gate-swiftclient-dsvm-functional http://logs.openstack.org/51/284851/2/check/gate-swiftclient-dsvm-functional/8cf1d1b/ : SUCCESS in 16m 11s","accounts_in_message":[],"_revision_number":2},{"id":"34a3b04435559643e8899298ccadb40fc1d3f080","author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"date":"2016-03-03 12:47:14.000000000","message":"Patch Set 2:\n\nThis sort of feature violates the KISS principle, IMHO. I would prefer that CLI threw a Usage message if -p is set together with explicit list. But I don\u0027t prefer it enough to put -1 or -2 on this. I\u0027m going to leave this in Tim\u0027s lap.","accounts_in_message":[],"_revision_number":2},{"id":"dd20ac0c0b00b71ba89a93a607c4d9146b0d9262","author":{"_account_id":11373,"name":"Bing Hu","email":"hubingsh@cn.ibm.com","username":"hubingsh"},"date":"2016-03-05 02:45:14.000000000","message":"Patch Set 2:\n\n\u003e This sort of feature violates the KISS principle, IMHO. I would\n \u003e prefer that CLI threw a Usage message if -p is set together with\n \u003e explicit list. But I don\u0027t prefer it enough to put -1 or -2 on\n \u003e this. I\u0027m going to leave this in Tim\u0027s lap.\n\n@Pete, thanks for your review.\n\nabout the KISS principle, you mean the code is complicated,\nor the idea that make --prefix working with objects?\n\nCould you please provide more details? Thanks.","accounts_in_message":[],"_revision_number":2},{"id":"dda59257ee73f30a4e992e702157fa1a4d2d0b93","author":{"_account_id":20403,"name":"Cheng Li","email":"shcli@cn.ibm.com","username":"Cheng"},"date":"2016-03-27 09:36:55.000000000","message":"Patch Set 2: Code-Review+1\n\nmake sense to me","accounts_in_message":[],"_revision_number":2},{"id":"d929b0091e1395a3a4319a446dc17f26175ad7e4","author":{"_account_id":9216,"name":"Joel Wright","email":"joel.wright@gmail.com","username":"jjw-sohonet"},"date":"2016-08-16 22:05:41.000000000","message":"Patch Set 2: Code-Review-2\n\nI don\u0027t think I like this approach - I would much rather see an error message if these options are specified together rather than filtering the given list of objects. If the input list needs to be filtered I think it really should be a separate operation rather than a function of the client.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"f3ec1cd79c09e6c736bcfca77be5197380fa008f","revisions":{"79638c95c52144fa6884f76972499b37d80cc43d":{"kind":"REWORK","_number":1,"created":"2016-02-25 18:10:39.000000000","uploader":{"_account_id":11373,"name":"Bing Hu","email":"hubingsh@cn.ibm.com","username":"hubingsh"},"ref":"refs/changes/51/284851/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-swiftclient","ref":"refs/changes/51/284851/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/51/284851/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/51/284851/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/51/284851/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-swiftclient refs/changes/51/284851/1"}}},"commit":{"parents":[{"commit":"0f60cf05f439521dd3098b0c83c6830537a74ba4","subject":"Merge \"Do not reveal auth token in swiftclient log messages by default\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/0f60cf05f439521dd3098b0c83c6830537a74ba4"}]}],"author":{"name":"Hu Bing","email":"hubingsh@cn.ibm.com","date":"2016-02-25 17:44:12.000000000","tz":480},"committer":{"name":"Hu Bing","email":"hubingsh@cn.ibm.com","date":"2016-02-25 17:44:12.000000000","tz":480},"subject":"make download --prefix working","message":"make download --prefix working\n\nin swift download command,\n--prefix argument can only work when \u003cobjects\u003e is not specified\nwhen \u003cobjects\u003e is specified, --prefix argument is ignored\n\nli@swift:~/workdir$ swift download cont1 --prefix x file1\nfile1 [auth 0.090s, headers 0.166s, total 0.167s, 0.001 MB/s]\nli@swift:~/workdir$\n\nthis patch is to make --prefix working when \u003cobjects\u003e is specified.\n\nwith this patch,\nswift@swift:~/workdir$ swift list cont1\nadminrc\nhello\nswift@swift:~/workdir$ swift download cont1 --prefix x hello\nswift@swift:~/workdir$\n\nand one useful case,\nli@swift:~/workdir$ cat filelist.txt\nfile1 file2 xfile1\nli@swift:~/workdir$ swift list cont1\nfile1\nfile2\nxfile1\nli@swift:~/workdir$ cat filelist.txt |xargs swift download cont1 --prefix fi\nfile2 [auth 0.065s, headers 0.097s, total 0.098s, 0.003 MB/s]\nfile1 [auth 0.084s, headers 0.110s, total 0.110s, 0.004 MB/s]\nli@swift:~/workdir$\n\nChange-Id: I61fc04f32b861106ae5e08aa719d092773e71398\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/79638c95c52144fa6884f76972499b37d80cc43d"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/79638c95c52144fa6884f76972499b37d80cc43d"}]},"branch":"refs/heads/master"},"f3ec1cd79c09e6c736bcfca77be5197380fa008f":{"kind":"REWORK","_number":2,"created":"2016-02-26 17:03:56.000000000","uploader":{"_account_id":11373,"name":"Bing Hu","email":"hubingsh@cn.ibm.com","username":"hubingsh"},"ref":"refs/changes/51/284851/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-swiftclient","ref":"refs/changes/51/284851/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/51/284851/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/51/284851/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/51/284851/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-swiftclient refs/changes/51/284851/2"}}},"commit":{"parents":[{"commit":"0f60cf05f439521dd3098b0c83c6830537a74ba4","subject":"Merge \"Do not reveal auth token in swiftclient log messages by default\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/0f60cf05f439521dd3098b0c83c6830537a74ba4"}]}],"author":{"name":"Hu Bing","email":"hubingsh@cn.ibm.com","date":"2016-02-25 17:44:12.000000000","tz":480},"committer":{"name":"Hu Bing","email":"hubingsh@cn.ibm.com","date":"2016-02-26 16:44:48.000000000","tz":480},"subject":"make download --prefix working correct","message":"make download --prefix working correct\n\nin swift download command,\n--prefix argument can only work when \u003cobjects\u003e is not specified\nwhen \u003cobjects\u003e is specified, --prefix argument is ignored\n\nli@swift:~/workdir$ swift download cont1 --prefix x file1\nfile1 [auth 0.090s, headers 0.166s, total 0.167s, 0.001 MB/s]\nli@swift:~/workdir$\n\nthis patch is to make --prefix working when \u003cobjects\u003e is specified.\n\nwith this patch,\nswift@swift:~/workdir$ swift list cont1\nadminrc\nhello\nswift@swift:~/workdir$ swift download cont1 --prefix x hello\nswift@swift:~/workdir$\n\nand one useful case is to filter some objects from a list of objects\nli@swift:~/workdir$ cat filelist.txt\nfile1 file2 xfile1\nli@swift:~/workdir$ swift list cont1\nfile1\nfile2\nxfile1\nli@swift:~/workdir$ cat filelist.txt |xargs swift download cont1 --prefix fi\nfile2 [auth 0.065s, headers 0.097s, total 0.098s, 0.003 MB/s]\nfile1 [auth 0.084s, headers 0.110s, total 0.110s, 0.004 MB/s]\nli@swift:~/workdir$\n\nCloses-bug: #1544952\n\nChange-Id: I61fc04f32b861106ae5e08aa719d092773e71398\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/f3ec1cd79c09e6c736bcfca77be5197380fa008f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/f3ec1cd79c09e6c736bcfca77be5197380fa008f"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"OK","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":9216,"name":"Joel Wright","email":"joel.wright@gmail.com","username":"jjw-sohonet"}},{"label":"Workflow","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{"label:Verified\u003dMAX":"","label:Verified\u003dMIN":""}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":["label:Code-Review\u003dMIN"],"failing_atoms":["label:Code-Review\u003dMAX"],"atom_explanations":{"label:Code-Review\u003dMAX":"","label:Code-Review\u003dMIN":""}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Workflow\u003dMAX","label:Workflow\u003dMIN"],"atom_explanations":{"label:Workflow\u003dMAX":"","label:Workflow\u003dMIN":""}}}]}