)]}'
{"swiftclient/service.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"eb4f0ee81dca279dffea5a1e0011f6947742a6d8","unresolved":false,"context_lines":[{"line_number":1847,"context_line":"                    try:"},{"line_number":1848,"context_line":"                        account_info \u003d self.capabilities()"},{"line_number":1849,"context_line":"                    except Exception:"},{"line_number":1850,"context_line":"                        logger.warning(\"get account information failed\")"},{"line_number":1851,"context_line":"                    else:"},{"line_number":1852,"context_line":"                        seg_wars \u003d []"},{"line_number":1853,"context_line":"                        if \u0027slo\u0027 not in account_info[\u0027capabilities\u0027].keys():"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba0121b8_094b9988","line":1850,"range":{"start_line":1850,"start_character":44,"end_line":1850,"end_character":51},"updated":"2016-07-22 19:41:38.000000000","message":"It\u0027s not really the *account* information; it affects all accounts. Maybe \"get cluster information failed\"?","commit_id":"4f31028c10f621fc2b0751b8972b1da3bf0833c8"},{"author":{"_account_id":20403,"name":"Cheng Li","email":"shcli@cn.ibm.com","username":"Cheng"},"change_message_id":"288917918813e7a188e7af7973638c67b84aeaa3","unresolved":false,"context_lines":[{"line_number":1847,"context_line":"                    try:"},{"line_number":1848,"context_line":"                        account_info \u003d self.capabilities()"},{"line_number":1849,"context_line":"                    except Exception:"},{"line_number":1850,"context_line":"                        logger.warning(\"get account information failed\")"},{"line_number":1851,"context_line":"                    else:"},{"line_number":1852,"context_line":"                        seg_wars \u003d []"},{"line_number":1853,"context_line":"                        if \u0027slo\u0027 not in account_info[\u0027capabilities\u0027].keys():"}],"source_content_type":"text/x-python","patch_set":1,"id":"dada55a8_3f06a820","line":1850,"range":{"start_line":1850,"start_character":44,"end_line":1850,"end_character":51},"in_reply_to":"ba0121b8_094b9988","updated":"2016-07-23 13:19:46.000000000","message":"You are right, we don\u0027t need to catch exception here.\neven if exception happens, outside upload method will catch it.","commit_id":"4f31028c10f621fc2b0751b8972b1da3bf0833c8"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"eb4f0ee81dca279dffea5a1e0011f6947742a6d8","unresolved":false,"context_lines":[{"line_number":1850,"context_line":"                        logger.warning(\"get account information failed\")"},{"line_number":1851,"context_line":"                    else:"},{"line_number":1852,"context_line":"                        seg_wars \u003d []"},{"line_number":1853,"context_line":"                        if \u0027slo\u0027 not in account_info[\u0027capabilities\u0027].keys():"},{"line_number":1854,"context_line":"                            seg_wars.append(\u0027Warn: slo middleware is \u0027"},{"line_number":1855,"context_line":"                                            \u0027not enabled\u0027)"},{"line_number":1856,"context_line":"                        else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba0121b8_b45e4010","line":1853,"range":{"start_line":1853,"start_character":69,"end_line":1853,"end_character":73},"updated":"2016-07-22 19:41:38.000000000","message":"nit: the keys will automatically be used if you say\n\n if \u0027slo\u0027 not in account_info[\u0027capabilities\u0027]:","commit_id":"4f31028c10f621fc2b0751b8972b1da3bf0833c8"},{"author":{"_account_id":20403,"name":"Cheng Li","email":"shcli@cn.ibm.com","username":"Cheng"},"change_message_id":"288917918813e7a188e7af7973638c67b84aeaa3","unresolved":false,"context_lines":[{"line_number":1850,"context_line":"                        logger.warning(\"get account information failed\")"},{"line_number":1851,"context_line":"                    else:"},{"line_number":1852,"context_line":"                        seg_wars \u003d []"},{"line_number":1853,"context_line":"                        if \u0027slo\u0027 not in account_info[\u0027capabilities\u0027].keys():"},{"line_number":1854,"context_line":"                            seg_wars.append(\u0027Warn: slo middleware is \u0027"},{"line_number":1855,"context_line":"                                            \u0027not enabled\u0027)"},{"line_number":1856,"context_line":"                        else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"dada55a8_d20f832c","line":1853,"range":{"start_line":1853,"start_character":69,"end_line":1853,"end_character":73},"in_reply_to":"ba0121b8_b45e4010","updated":"2016-07-23 13:19:46.000000000","message":"cool","commit_id":"4f31028c10f621fc2b0751b8972b1da3bf0833c8"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"eb4f0ee81dca279dffea5a1e0011f6947742a6d8","unresolved":false,"context_lines":[{"line_number":1851,"context_line":"                    else:"},{"line_number":1852,"context_line":"                        seg_wars \u003d []"},{"line_number":1853,"context_line":"                        if \u0027slo\u0027 not in account_info[\u0027capabilities\u0027].keys():"},{"line_number":1854,"context_line":"                            seg_wars.append(\u0027Warn: slo middleware is \u0027"},{"line_number":1855,"context_line":"                                            \u0027not enabled\u0027)"},{"line_number":1856,"context_line":"                        else:"},{"line_number":1857,"context_line":"                            slo_info \u003d account_info[\u0027capabilities\u0027][\u0027slo\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba0121b8_a94a6daa","line":1854,"range":{"start_line":1854,"start_character":45,"end_line":1854,"end_character":49},"updated":"2016-07-22 19:41:38.000000000","message":"If we\u0027re going to immediately exit without attempting an upload, this feels more like an error than a warning.","commit_id":"4f31028c10f621fc2b0751b8972b1da3bf0833c8"},{"author":{"_account_id":20403,"name":"Cheng Li","email":"shcli@cn.ibm.com","username":"Cheng"},"change_message_id":"288917918813e7a188e7af7973638c67b84aeaa3","unresolved":false,"context_lines":[{"line_number":1851,"context_line":"                    else:"},{"line_number":1852,"context_line":"                        seg_wars \u003d []"},{"line_number":1853,"context_line":"                        if \u0027slo\u0027 not in account_info[\u0027capabilities\u0027].keys():"},{"line_number":1854,"context_line":"                            seg_wars.append(\u0027Warn: slo middleware is \u0027"},{"line_number":1855,"context_line":"                                            \u0027not enabled\u0027)"},{"line_number":1856,"context_line":"                        else:"},{"line_number":1857,"context_line":"                            slo_info \u003d account_info[\u0027capabilities\u0027][\u0027slo\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"dada55a8_729a17c7","line":1854,"range":{"start_line":1854,"start_character":45,"end_line":1854,"end_character":49},"in_reply_to":"ba0121b8_a94a6daa","updated":"2016-07-23 13:19:46.000000000","message":"Done","commit_id":"4f31028c10f621fc2b0751b8972b1da3bf0833c8"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"eb4f0ee81dca279dffea5a1e0011f6947742a6d8","unresolved":false,"context_lines":[{"line_number":1862,"context_line":"                                                \u0027ecified a larger segment_size\u0027"},{"line_number":1863,"context_line":"                                                % slo_info"},{"line_number":1864,"context_line":"                                                [\u0027max_manifest_segments\u0027])"},{"line_number":1865,"context_line":"                            if slo_info[\u0027min_segment_size\u0027] \u003e segment_size:"},{"line_number":1866,"context_line":"                                seg_wars.append(\u0027Warn: specified segment_size\u0027"},{"line_number":1867,"context_line":"                                                \u0027 %s is less than min allowed\u0027"},{"line_number":1868,"context_line":"                                                \u0027 segment_size %s\u0027 %"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba0121b8_94e85ce4","line":1865,"updated":"2016-07-22 19:41:38.000000000","message":"I feel like we can do better here. What do you think about just bumping up segment_size to match min_segment_size, logging a warning to say that we did that, and moving forward?\n\nWe\u0027d want to update options while we\u0027re at it, to avoid logging the warning on *every* large object. And swap positions with the max_manifest_segments check.\n\nMight be better as a follow-on patch, though. What you\u0027ve got is certainly better than the existing behavior.","commit_id":"4f31028c10f621fc2b0751b8972b1da3bf0833c8"},{"author":{"_account_id":20403,"name":"Cheng Li","email":"shcli@cn.ibm.com","username":"Cheng"},"change_message_id":"288917918813e7a188e7af7973638c67b84aeaa3","unresolved":false,"context_lines":[{"line_number":1862,"context_line":"                                                \u0027ecified a larger segment_size\u0027"},{"line_number":1863,"context_line":"                                                % slo_info"},{"line_number":1864,"context_line":"                                                [\u0027max_manifest_segments\u0027])"},{"line_number":1865,"context_line":"                            if slo_info[\u0027min_segment_size\u0027] \u003e segment_size:"},{"line_number":1866,"context_line":"                                seg_wars.append(\u0027Warn: specified segment_size\u0027"},{"line_number":1867,"context_line":"                                                \u0027 %s is less than min allowed\u0027"},{"line_number":1868,"context_line":"                                                \u0027 segment_size %s\u0027 %"}],"source_content_type":"text/x-python","patch_set":1,"id":"dada55a8_125f5b0f","line":1865,"in_reply_to":"ba0121b8_94e85ce4","updated":"2016-07-23 13:19:46.000000000","message":"Done","commit_id":"4f31028c10f621fc2b0751b8972b1da3bf0833c8"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"eb4f0ee81dca279dffea5a1e0011f6947742a6d8","unresolved":false,"context_lines":[{"line_number":1871,"context_line":"                        if seg_wars:"},{"line_number":1872,"context_line":"                            logger.error(seg_wars)"},{"line_number":1873,"context_line":"                            res.update({\u0027success\u0027: False,"},{"line_number":1874,"context_line":"                                        \u0027error\u0027: \"\\n\".join(seg_wars),"},{"line_number":1875,"context_line":"                                        }"},{"line_number":1876,"context_line":"                                       )"},{"line_number":1877,"context_line":"                            return res"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba0121b8_e9b905cd","line":1874,"range":{"start_line":1874,"start_character":49,"end_line":1874,"end_character":68},"updated":"2016-07-22 19:41:38.000000000","message":"We typically expect res[\u0027error\u0027] to be an exception, rather than a string. We probably want to wrap this in a ClientException, similar to what\u0027s done down around line 1921.","commit_id":"4f31028c10f621fc2b0751b8972b1da3bf0833c8"},{"author":{"_account_id":20403,"name":"Cheng Li","email":"shcli@cn.ibm.com","username":"Cheng"},"change_message_id":"288917918813e7a188e7af7973638c67b84aeaa3","unresolved":false,"context_lines":[{"line_number":1871,"context_line":"                        if seg_wars:"},{"line_number":1872,"context_line":"                            logger.error(seg_wars)"},{"line_number":1873,"context_line":"                            res.update({\u0027success\u0027: False,"},{"line_number":1874,"context_line":"                                        \u0027error\u0027: \"\\n\".join(seg_wars),"},{"line_number":1875,"context_line":"                                        }"},{"line_number":1876,"context_line":"                                       )"},{"line_number":1877,"context_line":"                            return res"}],"source_content_type":"text/x-python","patch_set":1,"id":"dada55a8_32625fd9","line":1874,"range":{"start_line":1874,"start_character":49,"end_line":1874,"end_character":68},"in_reply_to":"ba0121b8_e9b905cd","updated":"2016-07-23 13:19:46.000000000","message":"Done","commit_id":"4f31028c10f621fc2b0751b8972b1da3bf0833c8"}]}