)]}'
{"id":"openstack%2Fpython-swiftclient~30198","triplet_id":"openstack%2Fpython-swiftclient~master~I62729364b9bd279498909dc5cd0d2a1ec5fcd70d","project":"openstack/python-swiftclient","branch":"master","topic":"fix_get_auth_logging","hashtags":[],"change_id":"I62729364b9bd279498909dc5cd0d2a1ec5fcd70d","subject":"log get_auth request url instead of x-storage-url","status":"MERGED","created":"2013-05-23 01:18:46.000000000","updated":"2013-05-24 22:38:36.000000000","submitted":"2013-05-24 22:38:35.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"40e41034f3768ad755c8f635ba1d4ad6451fffa2","_number":30198,"virtual_id_number":30198,"owner":{"_account_id":7008,"name":"Leah Klearman","email":"lklrmn@gmail.com","username":"klrmn"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":7008,"name":"Leah Klearman","email":"lklrmn@gmail.com","username":"klrmn"},{"value":2,"date":"2013-05-24 22:38:35.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":917,"name":"Chuck Thier","email":"cthier@gmail.com","username":"cthier"},{"value":0,"_account_id":2696,"name":"Darrell Bishop","email":"dbishop@nvidia.com","username":"darrellb"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":917,"name":"Chuck Thier","email":"cthier@gmail.com","username":"cthier"},"all":[{"value":0,"date":"2013-05-23 04:44:28.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":7008,"name":"Leah Klearman","email":"lklrmn@gmail.com","username":"klrmn"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2013-05-24 22:37:45.000000000","_account_id":917,"name":"Chuck Thier","email":"cthier@gmail.com","username":"cthier"},{"value":2,"date":"2013-05-23 15:45:56.000000000","_account_id":2696,"name":"Darrell Bishop","email":"dbishop@nvidia.com","username":"darrellb"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":917,"name":"Chuck Thier","email":"cthier@gmail.com","username":"cthier"},"all":[{"value":0,"_account_id":7008,"name":"Leah Klearman","email":"lklrmn@gmail.com","username":"klrmn"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2013-05-24 22:37:45.000000000","_account_id":917,"name":"Chuck Thier","email":"cthier@gmail.com","username":"cthier"},{"value":0,"date":"2013-05-23 01:27:57.000000000","_account_id":2696,"name":"Darrell Bishop","email":"dbishop@nvidia.com","username":"darrellb"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":917,"name":"Chuck Thier","email":"cthier@gmail.com","username":"cthier"},{"_account_id":2696,"name":"Darrell Bishop","email":"dbishop@nvidia.com","username":"darrellb"},{"_account_id":7008,"name":"Leah Klearman","email":"lklrmn@gmail.com","username":"klrmn"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2013-05-23 01:27:57.000000000","updated_by":{"_account_id":2696,"name":"Darrell Bishop","email":"dbishop@nvidia.com","username":"darrellb"},"reviewer":{"_account_id":2696,"name":"Darrell Bishop","email":"dbishop@nvidia.com","username":"darrellb"},"state":"REVIEWER"},{"updated":"2013-05-24 22:37:45.000000000","updated_by":{"_account_id":917,"name":"Chuck Thier","email":"cthier@gmail.com","username":"cthier"},"reviewer":{"_account_id":917,"name":"Chuck Thier","email":"cthier@gmail.com","username":"cthier"},"state":"REVIEWER"},{"updated":"2013-05-24 22:38:35.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"9215ce4644a3878d4f2ec8f7f10f48ba112d9a3d","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-05-23 01:19:36.000000000","message":"Patch Set 1: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/30198/1/check/gate-python-swiftclient-pep8/293 : SUCCESS in 30s\n- http://docs-draft.openstack.org/30198/1/check/gate-python-swiftclient-docs/243/doc/build/html/ : SUCCESS in 35s\n- http://logs.openstack.org/30198/1/check/gate-python-swiftclient-python26/291 : SUCCESS in 41s\n- http://logs.openstack.org/30198/1/check/gate-python-swiftclient-python27/291 : SUCCESS in 35s\n","accounts_in_message":[],"_revision_number":1},{"id":"aa994f1b0dac853f61c7152be6b34606331db19d","author":{"_account_id":2696,"name":"Darrell Bishop","email":"dbishop@nvidia.com","username":"darrellb"},"date":"2013-05-23 01:27:57.000000000","message":"Patch Set 1:\n\nI\u0027d prefer logging both?  Then you\u0027d have the auth URL and either the storage URL returned or knowledge of the fact that no storage URl was returned.\n\nDoes that make sense?","accounts_in_message":[],"_revision_number":1},{"id":"0a663b8355267eb5b9b107f02e2a300efde65df4","author":{"_account_id":7008,"name":"Leah Klearman","email":"lklrmn@gmail.com","username":"klrmn"},"date":"2013-05-23 04:44:28.000000000","message":"Patch Set 1:\n\nWould you prefer the \u0027increase the entire library\u0027s logging by 33% by always printing response headers (for requests that succeed), (since headers seem to be kinda important to swift\u0027s operation as a whole)\u0027 option or the \u0027add odd-ball logging to get_auth()\u0027 option?\n\nA single call to Connection:head_account() (without a pre-existing token) currently has output that looks like this (if the logger\u0027s level is set to DEBUG):\n\n(succeeding)\n\nswiftclient: DEBUG: REQ: curl -i http://192.168.22.50/v1/AUTH_1369246720897245 -X GET\n\nswiftclient: DEBUG: RESP STATUS: 200\n\nswiftclient: DEBUG: REQ: curl -i http://192.168.22.50/v1/AUTH_1369246720897245 -I -H \"X-Auth-Token: AUTH_tk8831caaec8b44a0784160821dc389453\"\n\nswiftclient: DEBUG: RESP STATUS: 204\n\n\n(or failing)\n\nswiftclient: DEBUG: REQ: curl -i None -X GET\n\nswiftclient: DEBUG: RESP STATUS: 401\n\nswiftclient: DEBUG: RESP BODY: \u003chtml\u003e\u003ch1\u003eUnauthorized\u003c/h1\u003e\u003cp\u003eThis server could not verify that you are authorized to access the document you requested.\u003c/p\u003e\u003c/html\u003e\n\nswiftclient: DEBUG: REQ: curl -i None -X GET\n\nswiftclient: DEBUG: RESP STATUS: 401\n\nswiftclient: DEBUG: RESP BODY: \u003chtml\u003e\u003ch1\u003eUnauthorized\u003c/h1\u003e\u003cp\u003eThis server could not verify that you are authorized to access the document you requested.\u003c/p\u003e\u003c/html\u003e","accounts_in_message":[],"_revision_number":1},{"id":"a3b8bd6e5492e87135e2e592f5f14045b78d6f30","author":{"_account_id":2696,"name":"Darrell Bishop","email":"dbishop@nvidia.com","username":"darrellb"},"date":"2013-05-23 15:45:56.000000000","message":"Patch Set 1: Looks good to me (core reviewer)\n\nNever mind, I looked more closely and actually ran the relevant code and you\u0027re change is great as is.","accounts_in_message":[],"_revision_number":1},{"id":"377e74b2b19de7e30f389236583a337693edda00","author":{"_account_id":917,"name":"Chuck Thier","email":"cthier@gmail.com","username":"cthier"},"date":"2013-05-24 22:37:45.000000000","message":"Patch Set 1: Looks good to me (core reviewer); Approved\n\nLooks good, thanks Leah!","accounts_in_message":[],"_revision_number":1},{"id":"07c88ccadabfc96d66b5ac57538228b28b0dc280","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-05-24 22:37:47.000000000","message":"Patch Set 1: No score\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"9f3bdeda07acc9d4e54a9d58d66dd2bf1f05c371","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-05-24 22:38:35.000000000","message":"Patch Set 1: Verified\n\nBuild succeeded.\n\n- http://docs-draft.openstack.org/30198/1/gate/gate-python-swiftclient-docs/248/doc/build/html/ : SUCCESS in 35s\n- http://logs.openstack.org/30198/1/gate/gate-python-swiftclient-pep8/298 : SUCCESS in 33s\n- http://logs.openstack.org/30198/1/gate/gate-python-swiftclient-python26/296 : SUCCESS in 41s\n- http://logs.openstack.org/30198/1/gate/gate-python-swiftclient-python27/296 : SUCCESS in 36s\n","accounts_in_message":[],"_revision_number":1},{"id":"7ca00aa84af633a0b9835468b59d78f74b393e53","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-05-24 22:38:36.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"7e84b69291efbc07be6ced17b24ffa42efdc67c0","revisions":{"7e84b69291efbc07be6ced17b24ffa42efdc67c0":{"kind":"REWORK","_number":1,"created":"2013-05-23 01:18:46.000000000","uploader":{"_account_id":7008,"name":"Leah Klearman","email":"lklrmn@gmail.com","username":"klrmn"},"ref":"refs/changes/98/30198/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-swiftclient","ref":"refs/changes/98/30198/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/98/30198/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/98/30198/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/98/30198/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-swiftclient refs/changes/98/30198/1"}}},"commit":{"parents":[{"commit":"07311a0639ba06d2b2ed190dc49095df95ae669b","subject":"Update the man page","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/07311a0639ba06d2b2ed190dc49095df95ae669b"}]}],"author":{"name":"Leah Klearman","email":"lklrmn@gmail.com","date":"2013-05-23 01:17:59.000000000","tz":-420},"committer":{"name":"Leah Klearman","email":"lklrmn@gmail.com","date":"2013-05-23 01:17:59.000000000","tz":-420},"subject":"log get_auth request url instead of x-storage-url","message":"log get_auth request url instead of x-storage-url\n\nbecause if the request gets a 4xx error, then the url will be None, and that\u0027s just confusing.\n\nChange-Id: I62729364b9bd279498909dc5cd0d2a1ec5fcd70d\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/7e84b69291efbc07be6ced17b24ffa42efdc67c0"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/7e84b69291efbc07be6ced17b24ffa42efdc67c0"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
