)]}'
{"id":"openstack%2Fpython-swiftclient~30203","triplet_id":"openstack%2Fpython-swiftclient~master~Ifb988f7c74a27283cf3d2210c7644f04d03bd94c","project":"openstack/python-swiftclient","branch":"master","topic":"fix-keystoneclient-dep","hashtags":[],"change_id":"Ifb988f7c74a27283cf3d2210c7644f04d03bd94c","subject":"Require keystoneclient in pip-requires.","status":"ABANDONED","created":"2013-05-23 01:58:35.000000000","updated":"2013-06-01 06:03:02.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"7a5ea8549207bf17c164f840e22796d9ca29a523","_number":30203,"virtual_id_number":30203,"owner":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},{"value":1,"date":"2013-05-23 01:59:28.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":917,"name":"Chuck Thier","email":"cthier@gmail.com","username":"cthier"},{"_account_id":6039,"name":"Joni Harker","email":"code@gentlydownthe.net","username":"jesusaurus"},{"_account_id":2696,"name":"Darrell Bishop","email":"dbishop@nvidia.com","username":"darrellb"},{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"recommended":{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},"disliked":{"_account_id":917,"name":"Chuck Thier","email":"cthier@gmail.com","username":"cthier"},"all":[{"value":0,"date":"2013-05-23 18:07:30.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},{"value":0,"date":"2013-05-23 12:42:30.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":-1,"date":"2013-05-24 22:43:36.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":917,"name":"Chuck Thier","email":"cthier@gmail.com","username":"cthier"},{"value":1,"date":"2013-05-23 02:00:45.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":6039,"name":"Joni Harker","email":"code@gentlydownthe.net","username":"jesusaurus"},{"value":1,"date":"2013-05-23 21:18:08.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":2696,"name":"Darrell Bishop","email":"dbishop@nvidia.com","username":"darrellb"},{"value":1,"date":"2013-05-23 19:26:27.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},{"date":"2013-05-23 12:42:30.000000000","_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"date":"2013-05-24 22:43:36.000000000","_account_id":917,"name":"Chuck Thier","email":"cthier@gmail.com","username":"cthier"},{"_account_id":6039,"name":"Joni Harker","email":"code@gentlydownthe.net","username":"jesusaurus"},{"date":"2013-05-23 21:18:08.000000000","_account_id":2696,"name":"Darrell Bishop","email":"dbishop@nvidia.com","username":"darrellb"},{"date":"2013-05-23 19:26:27.000000000","_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},{"_account_id":917,"name":"Chuck Thier","email":"cthier@gmail.com","username":"cthier"},{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},{"_account_id":2696,"name":"Darrell Bishop","email":"dbishop@nvidia.com","username":"darrellb"},{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},{"_account_id":6039,"name":"Joni Harker","email":"code@gentlydownthe.net","username":"jesusaurus"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2013-05-23 01:59:28.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2013-05-23 02:00:45.000000000","updated_by":{"_account_id":6039,"name":"Joni Harker","email":"code@gentlydownthe.net","username":"jesusaurus"},"reviewer":{"_account_id":6039,"name":"Joni Harker","email":"code@gentlydownthe.net","username":"jesusaurus"},"state":"REVIEWER"},{"updated":"2013-05-23 12:42:30.000000000","updated_by":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"reviewer":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"state":"REVIEWER"},{"updated":"2013-05-23 19:26:27.000000000","updated_by":{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},"reviewer":{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},"state":"REVIEWER"},{"updated":"2013-05-23 21:18:08.000000000","updated_by":{"_account_id":2696,"name":"Darrell Bishop","email":"dbishop@nvidia.com","username":"darrellb"},"reviewer":{"_account_id":2696,"name":"Darrell Bishop","email":"dbishop@nvidia.com","username":"darrellb"},"state":"REVIEWER"},{"updated":"2013-05-24 22:43:36.000000000","updated_by":{"_account_id":917,"name":"Chuck Thier","email":"cthier@gmail.com","username":"cthier"},"reviewer":{"_account_id":917,"name":"Chuck Thier","email":"cthier@gmail.com","username":"cthier"},"state":"REVIEWER"}],"messages":[{"id":"6e5c498ef877a39babe355371a1ad451474a9d0d","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-05-23 01:59:28.000000000","message":"Patch Set 1: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/30203/1/check/gate-python-swiftclient-requirements/15 : SUCCESS in 4s\n- http://logs.openstack.org/30203/1/check/gate-python-swiftclient-pep8/294 : SUCCESS in 35s\n- http://docs-draft.openstack.org/30203/1/check/gate-python-swiftclient-docs/244/doc/build/html/ : SUCCESS in 38s\n- http://logs.openstack.org/30203/1/check/gate-python-swiftclient-python26/292 : SUCCESS in 42s\n- http://logs.openstack.org/30203/1/check/gate-python-swiftclient-python27/292 : SUCCESS in 37s\n","accounts_in_message":[],"_revision_number":1},{"id":"aef4ba7ae8445a373952204a178a649c91c5f3d6","author":{"_account_id":6039,"name":"Joni Harker","email":"code@gentlydownthe.net","username":"jesusaurus"},"date":"2013-05-23 02:00:45.000000000","message":"Patch Set 1: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":1},{"id":"62524a3e9fffbb99669c091a50db1b227e7818d9","author":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"date":"2013-05-23 12:42:30.000000000","message":"Patch Set 1:\n\nwe wanted to make the v2 keystone auth optionals, for what purpose do you need absolutely to have it in pip-requires?","accounts_in_message":[],"_revision_number":1},{"id":"453f4b647ccdba579e4c3854fba0f29a87b73149","author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"date":"2013-05-23 18:07:30.000000000","message":"Patch Set 1:\n\nSo that it works as expected when installed via pip regardless of keystone auth version.","accounts_in_message":[],"_revision_number":1},{"id":"f03fb19cf968c8313288c9535444a55d06fd6867","author":{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},"date":"2013-05-23 19:26:27.000000000","message":"Patch Set 1: Looks good to me, but someone else must approve\n\nI like it, but then I really don\u0027t like optional dependencies. Others do, though, so I\u0027ll leave my opinion at +1 for a while to give them a chance to chime in.","accounts_in_message":[],"_revision_number":1},{"id":"d39c522737b4f92162fb4f292ef9c096c119692b","author":{"_account_id":2696,"name":"Darrell Bishop","email":"dbishop@nvidia.com","username":"darrellb"},"date":"2013-05-23 21:18:08.000000000","message":"Patch Set 1: Looks good to me, but someone else must approve\n\nI don\u0027t mind optional dependencies, but in this case we have to package all the keystone stuff anyway, so I don\u0027t care, here.","accounts_in_message":[],"_revision_number":1},{"id":"4170a485ce45651416edc3a1af8523a988d88289","author":{"_account_id":917,"name":"Chuck Thier","email":"cthier@gmail.com","username":"cthier"},"date":"2013-05-24 22:43:36.000000000","message":"Patch Set 1: I would prefer that you didn\u0027t merge this\n\nThe problem with making keystoneclient a hard dependency, is that not everyone who uses swift, is using keystone.  This would require everyone who is running swift without keystone to at least install, and likely build keystoneclient packages.  I\u0027ve worked with a lot of grumpy engineers that really don\u0027t like installing packages that aren\u0027t used.","accounts_in_message":[],"_revision_number":1},{"id":"3fcbcfe8cb478a7ec1e594e57c7057ae578a12f8","author":{"_account_id":9,"name":"LaunchpadSync","username":"launchpadsync"},"date":"2013-06-01 06:03:02.000000000","message":"Patch Set 1: Abandoned\n\ncode review expired after 1 week of no activity after a negative review, it can be restored using the `Restore Change` button under the Patch Set on the web interface","accounts_in_message":[],"_revision_number":1},{"id":"4bb0d380bd41b4f2136cc4af7b2e989c4de81d24","author":{"_account_id":9,"name":"LaunchpadSync","username":"launchpadsync"},"date":"2013-06-01 06:03:02.000000000","message":"Patch Set 1:\n\ncode review expired after 1 week of no activity after a negative review, it can be restored using the `Restore Change` button under the Patch Set on the web interface","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"15ef3506a56ae67eb91a5c6d51c5839722d4627b","revisions":{"15ef3506a56ae67eb91a5c6d51c5839722d4627b":{"kind":"REWORK","_number":1,"created":"2013-05-23 01:58:35.000000000","uploader":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"ref":"refs/changes/03/30203/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-swiftclient","ref":"refs/changes/03/30203/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/03/30203/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/03/30203/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/03/30203/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-swiftclient refs/changes/03/30203/1"}}},"commit":{"parents":[{"commit":"07311a0639ba06d2b2ed190dc49095df95ae669b","subject":"Update the man page","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/07311a0639ba06d2b2ed190dc49095df95ae669b"}]}],"author":{"name":"Clark Boylan","email":"clark.boylan@gmail.com","date":"2013-05-23 01:57:11.000000000","tz":-420},"committer":{"name":"Clark Boylan","email":"clark.boylan@gmail.com","date":"2013-05-23 01:58:31.000000000","tz":-420},"subject":"Require keystoneclient in pip-requires.","message":"Require keystoneclient in pip-requires.\n\npython-keystoneclient was in test-requires. Move it to pip-requires as\nkeystone auth v2 requires keystoneclient.\n\nChange-Id: Ifb988f7c74a27283cf3d2210c7644f04d03bd94c\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/15ef3506a56ae67eb91a5c6d51c5839722d4627b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/15ef3506a56ae67eb91a5c6d51c5839722d4627b"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}