)]}'
{"swiftclient/service.py":[{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"f235f20a21b462c3ab5a8e14d1e23dd8df5f0d2e","unresolved":false,"context_lines":[{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    if options.get(\u0027auth_version\u0027) not in (\u00272.0\u0027, \u00273\u0027) and not all("},{"line_number":96,"context_line":"            options.get(key) for key in (\u0027auth\u0027, \u0027user\u0027, \u0027key\u0027)):"},{"line_number":97,"context_line":"        # Use keystone auth if any of the new-style args are present"},{"line_number":98,"context_line":"        if any(options.get(k) for k in ("},{"line_number":99,"context_line":"                \u0027os_user_domain_id\u0027,"},{"line_number":100,"context_line":"                \u0027os_user_domain_name\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a122d0e_b07385b3","line":97,"updated":"2016-05-05 17:30:17.000000000","message":"nit: comment was more accurate before the change - in case of v2.0 there is no check here that any new style args are present, just that old-style are not present.","commit_id":"67f629cdeb4e4c9fcb858167091f1c00c69c87f4"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"dc0550d49e0b520857aed0e11b24495356e50b2f","unresolved":false,"context_lines":[{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    if options.get(\u0027auth_version\u0027) not in (\u00272.0\u0027, \u00273\u0027) and not all("},{"line_number":96,"context_line":"            options.get(key) for key in (\u0027auth\u0027, \u0027user\u0027, \u0027key\u0027)):"},{"line_number":97,"context_line":"        # Use keystone auth if any of the new-style args are present"},{"line_number":98,"context_line":"        if any(options.get(k) for k in ("},{"line_number":99,"context_line":"                \u0027os_user_domain_id\u0027,"},{"line_number":100,"context_line":"                \u0027os_user_domain_name\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a122d0e_229562e3","line":97,"in_reply_to":"1a122d0e_b07385b3","updated":"2016-05-05 18:40:04.000000000","message":"Yeah, I think I\u0027d actually done that in another revision, but backed it out to simplify this patch. Take a look at https://review.openstack.org/#/c/310596/1/swiftclient/shell.py@1207 - I should probably propose that as a follow-up.","commit_id":"67f629cdeb4e4c9fcb858167091f1c00c69c87f4"}],"swiftclient/shell.py":[{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"f235f20a21b462c3ab5a8e14d1e23dd8df5f0d2e","unresolved":false,"context_lines":[{"line_number":1198,"context_line":""},{"line_number":1199,"context_line":"    if (options[\u0027os_options\u0027][\u0027object_storage_url\u0027] and"},{"line_number":1200,"context_line":"            options[\u0027os_options\u0027][\u0027auth_token\u0027] and"},{"line_number":1201,"context_line":"            options[\u0027auth_version\u0027] in (\u00272.0\u0027, \u00273\u0027)):"},{"line_number":1202,"context_line":"        return options, args"},{"line_number":1203,"context_line":""},{"line_number":1204,"context_line":"    if enforce_requires:"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a122d0e_19889d21","side":"PARENT","line":1201,"updated":"2016-05-05 17:30:17.000000000","message":"ok. this avoid enforce_requires when we have a token and url. If I use all of A/K/U options than enforce requires will pass ok anyway, and if I don\u0027t then the auth_version has already defaulted to 2.0 in process_options, so this condition is pointless.","commit_id":"c3766319b93d60e30f55747f6cfc9ca915ff603c"}],"tests/unit/test_shell.py":[{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"f235f20a21b462c3ab5a8e14d1e23dd8df5f0d2e","unresolved":false,"context_lines":[{"line_number":1971,"context_line":"        self._test_options(opts, os_opts, flags\u003dself.flags)"},{"line_number":1972,"context_line":""},{"line_number":1973,"context_line":"        opts \u003d {}"},{"line_number":1974,"context_line":"        self.defaults[\u0027auth-version\u0027] \u003d \u00273\u0027"},{"line_number":1975,"context_line":"        self._test_options(opts, os_opts, flags\u003dself.flags)"},{"line_number":1976,"context_line":""},{"line_number":1977,"context_line":"        for o in (\u0027user-domain-name\u0027, \u0027user-domain-id\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a122d0e_7c3edfb8","line":1974,"updated":"2016-05-05 17:30:17.000000000","message":"nice","commit_id":"67f629cdeb4e4c9fcb858167091f1c00c69c87f4"}]}
